[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506523#comment-16506523
]
ASF subversion and git services commented on SOLR-11982:
Commit 4dacf9081240076dd421bdd9819c2f13aec19b8c in lucene-solr's branch
refs/heads/master from [~ctargett]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4dacf90 ]
SOLR-11982: Ref Guide: remove deprecated content; break up long paragraphs
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Assignee: Tomás Fernández Löbbe
>Priority: Minor
> Labels: patch-available, patch-with-test
> Fix For: 7.4, master (8.0)
>
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506527#comment-16506527
]
ASF subversion and git services commented on SOLR-11982:
Commit b3ec7510735e5f4a34e63a4977cdd5139d7135f8 in lucene-solr's branch
refs/heads/branch_7_4 from [~ctargett]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b3ec751 ]
SOLR-11982: Ref Guide: remove deprecated content; break up long paragraphs
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Assignee: Tomás Fernández Löbbe
>Priority: Minor
> Labels: patch-available, patch-with-test
> Fix For: 7.4, master (8.0)
>
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506526#comment-16506526
]
ASF subversion and git services commented on SOLR-11982:
Commit a05234f77739878215109e4959fb435486a85fb9 in lucene-solr's branch
refs/heads/branch_7x from [~ctargett]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a05234f ]
SOLR-11982: Ref Guide: remove deprecated content; break up long paragraphs
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Assignee: Tomás Fernández Löbbe
>Priority: Minor
> Labels: patch-available, patch-with-test
> Fix For: 7.4, master (8.0)
>
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502197#comment-16502197
]
Tomás Fernández Löbbe commented on SOLR-11982:
--
+1
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Assignee: Tomás Fernández Löbbe
>Priority: Minor
> Labels: patch-available, patch-with-test
> Fix For: 7.4, master (8.0)
>
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501390#comment-16501390
]
Ere Maijala commented on SOLR-11982:
I think it would be good to open a new issue for e.g the isLeader option and
any further discussion on how the different cases should work.
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Assignee: Tomás Fernández Löbbe
>Priority: Minor
> Labels: patch-available, patch-with-test
> Fix For: 7.4, master (8.0)
>
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500920#comment-16500920
]
Tomás Fernández Löbbe commented on SOLR-11982:
--
bq. unusual or impossible preferences should just fall back to random when they
cannot be achieved, it shouldn't stop Solr operation
This is the way it will work right now. The value of the {{shards.preference}}
is used to sort the (previously shuffled) list of replicas that can respond to
a query, but it doesn't remove any replica from that list. If, for example, you
say: {{shards.preference=PULL}}, and there are no {{PULL}} replicas in the
shard, any non pull replica will be queried. The work for filtering replicas
will be done in SOLR-10880 (in my TODOs list)
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Assignee: Tomás Fernández Löbbe
>Priority: Minor
> Labels: patch-available, patch-with-test
> Fix For: 7.4, master (8.0)
>
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500566#comment-16500566
]
Shawn Heisey commented on SOLR-11982:
-
[~emaijala], that's why I had the question, because the type does remain TLOG
even when it's leader. But the way the replica works does change, so that
effectively it works exactly the same as an NRT replica would in a leader role.
It would make sense to me if this feature were to treat a TLOG leader as if it
were NRT. But some minority of users might not actually want that behavior.
The solution suggested by [~tomasflobbe] would allow whatever combination the
user wants.
I think that there are a couple of preference combinations that warrant some
special action. If somebody sets a preference for leaders and also sets a
preference for PULL replicas, that should create an ERROR log entry, because it
is not possible for a PULL replica to be leader. A preference for leaders with
TLOG replicas should produce a WARN log entry. Because unusual or impossible
preferences should just fall back to random when they cannot be achieved, it
shouldn't stop Solr operation.
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Assignee: Tomás Fernández Löbbe
>Priority: Minor
> Labels: patch-available, patch-with-test
> Fix For: 7.4, master (8.0)
>
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500426#comment-16500426
]
Tomás Fernández Löbbe commented on SOLR-11982:
--
I think this is expected, at least with the current state of things. A TLOG
replica that is leader doesn't stop being a TLOG replica (the replica type is
recorded on the cluster state and doesn't change). IMO, what we want is a rule
that one can use to prefer leader (or not leader, which would be more common).
Something like {{shards.prefernce=isLeader:false replicaType:TLOG}}
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Assignee: Tomás Fernández Löbbe
>Priority: Minor
> Labels: patch-available, patch-with-test
> Fix For: 7.4, master (8.0)
>
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500222#comment-16500222
]
Ere Maijala commented on SOLR-11982:
That's an issue if its type is still TLOG while it's serving as the leader. I'm
under the impression that this should be a temporary situation, however, so it
might very well be justified e.g. if the replica is on hardware that has the
best capacity for handling queries. That's a hairy situation, though, since
it's difficult to say what's the best thing to do. The logic could probably be
extended with an option to prefer non-leaders.
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Assignee: Tomás Fernández Löbbe
>Priority: Minor
> Labels: patch-available, patch-with-test
> Fix For: 7.4, master (8.0)
>
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500203#comment-16500203
]
Shawn Heisey commented on SOLR-11982:
-
I've got a question about this, sorry I didn't think of it while the issue was
open.
If a preference is configured for TLOG replicas, what happens if a TLOG replica
is elected leader? I would think that most people would NOT want requests to
go to that replica, because its operation while leader is the same as NRT.
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Assignee: Tomás Fernández Löbbe
>Priority: Minor
> Labels: patch-available, patch-with-test
> Fix For: 7.4, master (8.0)
>
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435995#comment-16435995
]
Tomás Fernández Löbbe commented on SOLR-11982:
--
Created SOLR-12217 for the single shard case
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Assignee: Tomás Fernández Löbbe
>Priority: Minor
> Labels: patch-available, patch-with-test
> Fix For: 7.4, master (8.0)
>
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435255#comment-16435255
]
Lucene/Solr QA commented on SOLR-11982:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color}
| {color:red} SOLR-11982 does not apply to master. Rebase required? Wrong
Branch? See
https://wiki.apache.org/solr/HowToContribute#Creating_the_patch_file for help.
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-11982 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12918487/SOLR-11982.patch |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/50/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Assignee: Tomás Fernández Löbbe
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434704#comment-16434704
]
ASF subversion and git services commented on SOLR-11982:
Commit ba26bf7c6f8dd28ef0438e719d9b0bb45a60dd58 in lucene-solr's branch
refs/heads/branch_7x from [~tomasflobbe]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ba26bf7 ]
SOLR-11982: Add support for indicating preferred replica types for queries
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Assignee: Tomás Fernández Löbbe
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434703#comment-16434703
]
ASF subversion and git services commented on SOLR-11982:
Commit 8927d469cb05c27db6864076010de039302c7e25 in lucene-solr's branch
refs/heads/master from [~tomasflobbe]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8927d46 ]
SOLR-11982: Add support for indicating preferred replica types for queries
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Assignee: Tomás Fernández Löbbe
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433224#comment-16433224
]
Tomás Fernández Löbbe commented on SOLR-11982:
--
Uploaded patch with rename to {{shards.preference}} and minor changes to the
docs (the examples). I'll commit tomorrow if there are no more concerns
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Assignee: Tomás Fernández Löbbe
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431861#comment-16431861
]
Ere Maijala commented on SOLR-11982:
While I like shards.routing, to me (a non-native English speaker) it sounds
stronger to me than shards.preference. That would speak for using
shards.preference since it really just sets the preferred order and doesn't
exclude others. Either way is fine with me though, I'd just like to use this
with one name or another.
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Assignee: Tomás Fernández Löbbe
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427511#comment-16427511
]
Houston Putman commented on SOLR-11982:
---
[~anshumg], what do you see this option being extended to in the future beyond
request routing? I agree keeping it generic would be good if the scope were to
expand in the future, I just can't think of any other feature that it would
make sense for this option to govern.
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Assignee: Tomás Fernández Löbbe
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427448#comment-16427448
]
Anshum Gupta commented on SOLR-11982:
-
Not trying to convert this to a bikeshed but I much prefer the
{{shards.preference}} parameter.
This is inline with everything else and is much more open to being extended in
the future.
Also, thanks for not going with the {{|}} as that to me would mean an {{OR}}
and not a preferred order.
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Assignee: Tomás Fernández Löbbe
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426529#comment-16426529
]
Ere Maijala commented on SOLR-11982:
Thanks! I like shards.routing too.
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Assignee: Tomás Fernández Löbbe
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426135#comment-16426135
]
Tomás Fernández Löbbe commented on SOLR-11982:
--
[~emaijala] Patch looks really good (it seems to have an unwanted change in
{{TimeOut.java}}, I'll just skip that). I'll run some tests locally but I think
it's ready to commit regardless of the final naming decision. I can just change
the param name to whatever we agree on.
Thanks for your input [~houstonputman], I like {{shards.routing}}. I'll rename
to that if nobody disagrees.
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425820#comment-16425820
]
Houston Putman commented on SOLR-11982:
---
Just my two cents, but I think that {{shards.preference}} is a lot clearer than
{{shards.sort}} for this kind of option. {{sort}} is a defined parameter in
Solr and I think using it in this context would muddy the term else where in
Solr as well as add confusion here. This is a new type of behavior for Solr and
therefore requires a new parameter name. I think {{shards.preference}} would
work well in differentiating it as a new feature.
{{shards.routing}} or {{shards.route}} may be even clearer names as they
explicitly show that they are options for routing a request. The words
{{preference}} and {{sort}} don't inherently relate to routing, though
{{preference}} does come closer.
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425148#comment-16425148
]
Ere Maijala commented on SOLR-11982:
[~tomasflobbe], did you have a chance to take a look yet?
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415955#comment-16415955
]
Tomás Fernández Löbbe commented on SOLR-11982:
--
Thanks [~emaijala]. I've been traveling for the last couple of weeks. I'll take
a look later this week
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415402#comment-16415402
]
Ere Maijala commented on SOLR-11982:
The QA is now passing for all the relevant parts, I believe. The failures are
from untouched parts of the ref guide and a replica recovery test.
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414898#comment-16414898
]
Lucene/Solr QA commented on SOLR-11982:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
38s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 15s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} Validate ref guide {color} | {color:red}
1m 15s{color} | {color:red} Validate ref guide bare-bones-html-validation
failed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 48m 54s{color}
| {color:red} core in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 5m
4s{color} | {color:green} solrj in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 60m 13s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.cloud.TestTlogReplica |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-11982 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12916188/SOLR-11982.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns validaterefguide |
| uname | Linux lucene1-us-west 3.13.0-88-generic #135-Ubuntu SMP Wed Jun 8
21:10:42 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 3adacbc |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on April 8 2014 |
| Default Java | 1.8.0_144 |
| Validate ref guide |
https://builds.apache.org/job/PreCommit-SOLR-Build/19/artifact/out/patch-bare-bones-html-validation-solr_solr-ref-guide.txt
|
| unit |
https://builds.apache.org/job/PreCommit-SOLR-Build/19/artifact/out/patch-unit-solr_core.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/19/testReport/ |
| modules | C: solr solr/core solr/solrj solr/solr-ref-guide U: solr |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/19/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412473#comment-16412473
]
Lucene/Solr QA commented on SOLR-11982:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
47s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 1m
16s{color} | {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 16s{color}
| {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} Release audit (RAT) {color} | {color:red}
1m 16s{color} | {color:red} core in the patch failed. {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 0m 15s{color} | {color:green} Release audit (RAT) rat-sources
passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 0m 5s{color} | {color:green} Release audit (RAT) rat-sources
passed {color} |
| {color:red}-1{color} | {color:red} Check forbidden APIs {color} | {color:red}
1m 16s{color} | {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} Validate source patterns {color} |
{color:red} 1m 16s{color} | {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} Validate ref guide {color} | {color:red}
1m 16s{color} | {color:red} core in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 24s{color}
| {color:red} core in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
39s{color} | {color:green} solrj in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 7m 43s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-11982 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12914028/SOLR-11982.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns validaterefguide |
| uname | Linux lucene1-us-west 3.13.0-88-generic #135-Ubuntu SMP Wed Jun 8
21:10:42 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / ea50409 |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on April 8 2014 |
| Default Java | 1.8.0_144 |
| compile |
https://builds.apache.org/job/PreCommit-SOLR-Build/15/artifact/out/patch-compile-solr_core.txt
|
| javac |
https://builds.apache.org/job/PreCommit-SOLR-Build/15/artifact/out/patch-compile-solr_core.txt
|
| Release audit (RAT) |
https://builds.apache.org/job/PreCommit-SOLR-Build/15/artifact/out/patch-compile-solr_core.txt
|
| Check forbidden APIs |
https://builds.apache.org/job/PreCommit-SOLR-Build/15/artifact/out/patch-compile-solr_core.txt
|
| Validate source patterns |
https://builds.apache.org/job/PreCommit-SOLR-Build/15/artifact/out/patch-compile-solr_core.txt
|
| Validate ref guide |
https://builds.apache.org/job/PreCommit-SOLR-Build/15/artifact/out/patch-compile-solr_core.txt
|
| unit |
https://builds.apache.org/job/PreCommit-SOLR-Build/15/artifact/out/patch-unit-solr_core.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/15/testReport/ |
| modules | C: solr solr/core solr/solrj solr/solr-ref-guide U: solr |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/15/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
>
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395136#comment-16395136
]
Ere Maijala commented on SOLR-11982:
I moved the CHANGES.txt entry to version 7.4.
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.4, master (8.0)
>Reporter: Ere Maijala
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395076#comment-16395076
]
Ere Maijala commented on SOLR-11982:
Added a new patch that should address the latest review comments. I also put
all the strings to ShardParams and renamed replicaType to replica.type and
replicaLocation to replica.location.
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.3, master (8.0)
>Reporter: Ere Maijala
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982-preferReplicaTypes.patch,
> SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393271#comment-16393271
]
Tomás Fernández Löbbe commented on SOLR-11982:
--
I think it should be a single parameter that can address the different types of
preference, not different parameters one for each type. In general I like the
syntax discussed here so far (I have that concern of the pipe I mentioned
before). I also feel it falls into the "shards" family of parameters.
{{shards}} determines the replicas to which the distributed query should be
sent, {{shards.info}} tells users which replicas responded a distributed query,
etc. as I said before, I think it is close to what's discussed in SOLR-10880
and naming should be consistent. I'm ok with changing the word "sort" if you
think that can confuse users. Do you think something like {{shards.preference}}
would be better [~elyograg]?
{quote} I don't think it needs to since the client, whatever it is, has full
control over where to send the query.
{quote}
Unless they are using CloudSolrClient... but yes, in that case users can choose
not to use it. In any case, I think that can be left to another Jira. We should
include a big note in the docs though.
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.3, master (8.0)
>Reporter: Ere Maijala
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for indicating preferred replica types for queries
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392931#comment-16392931
]
Shawn Heisey commented on SOLR-11982:
-
bq. I think shards.sort is pretty consistent with the rest of the Solr
parameters. facet.sort sorts facets, group.sort sorts groups
Those sort parameters affect the order of information in search results. The
one discussed here is unlikely in most situations to have any effect at all on
the order of results.
If you're determined to use a sort parameter, I won't stand in your way. I've
said why I don't like it, and you're free to say that my worries are unfounded.
You might want to consider replica.sort instead of shards.sort, since it's
actually replicas that are being sorted.
One more thing, I should create a new issue for this: We have a lot of
inconsistency on multi-word parameter names. Some of them have the parts
separated by periods, some of them use camelCase. We really should standardize
on one style, and remove old parameters in 8.0. I'm leaning towards the period
separator, simply because if we can make parameter names case-insensitive,
users are less likely to type parameters incorrectly.
> Add support for indicating preferred replica types for queries
> --
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.3, master (8.0)
>Reporter: Ere Maijala
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
