[jira] [Commented] (SOLR-11982) Add support for shards.sort parameter
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392615#comment-16392615
]
Ere Maijala commented on SOLR-11982:
I attached SOLR-11982-preferReplicaTypes.patch, which is a refined version of
the original patch to add preferReplicaTypes parameter. This is a smaller
change to the current functionality and does not require deprecating
preferLocalShards, but then it doesn't allow as much flexibility as the
shards.sort version. Both version fulfill my needs, but I'd really appreciate a
clear decision which way is to be preferred.
[~tomasflobbe], I'll wait for the decision before addressing the latest review.
You're right in that this doesn't work for single-shard collections but I don't
think it needs to since the client, whatever it is, has full control over where
to send the query.
> Add support for shards.sort parameter
> -
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.3, master (8.0)
>Reporter: Ere Maijala
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982-preferReplicaTypes.patch, SOLR-11982.patch,
> SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for shards.sort parameter
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392528#comment-16392528
]
Ere Maijala commented on SOLR-11982:
I don't feel strongly about either naming convention, but how do we proceed
from here to agree on something?
> Add support for shards.sort parameter
> -
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.3, master (8.0)
>Reporter: Ere Maijala
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with \{{shards.sort=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for shards.sort parameter
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392370#comment-16392370
]
Tomás Fernández Löbbe commented on SOLR-11982:
--
[~emaijala], I'm thinking also that this feature won't work (as it is now) on
single shard collections... We may need to add a similar logic to SolrJ
(CloudSolrClient I guess).
> Add support for shards.sort parameter
> -
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.3, master (8.0)
>Reporter: Ere Maijala
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with {{shards.sor=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for shards.sort parameter
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392229#comment-16392229
]
Tomás Fernández Löbbe commented on SOLR-11982:
--
I disagree on the parameter name. I think {{shards.sort}} is pretty consistent
with the rest of the Solr parameters. {{facet.sort}} sorts facets,
{{group.sort}} sorts groups, {{shards.sort}} sorts the "shards" (taken, there
is a misname in "shards" here, but it's how the parameter is called right now).
Using this parameter is extensible to add more types of sorting (i.e. prefer
replicas by tag, prefer non-leader replicas, preference by location like Ere
implemented, all those a very valid use cases) and I think it's better for
someone to go to the docs to understand how {{shards.sort}} works vs having a
bunch of one-off parameters that users won't even know that exist. In general I
think we need to reduce the amount of one-off parameters in Solr.
> Add support for shards.sort parameter
> -
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.3, master (8.0)
>Reporter: Ere Maijala
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with {{shards.sor=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for shards.sort parameter
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392197#comment-16392197
]
Shawn Heisey commented on SOLR-11982:
-
When I saw the review request on the mailing list for this issue, my thought
was "shards.sort? what does sorting shards mean?" This is the precise
reaction that the average user is going to have when they see the parameter
name.
I would very much prefer to have preferReplicaTypes and preferLocalShards.
These parameter names are straightforward and describe exactly what they do in
a very compact way. Regarding what to do when both are present: I think
preferReplicaTypes should take priority. Look for the preferred replica type
(like TLOG) and if it is found, then decide whether there are any appropriate
replicas of that type locally. Perhaps the preferLocalShards parameter could
accept true, false, and always as values -- with the always value overriding
that behavior.
Using a weird parameter name can be justified in cases where the concepts
related to that parameter are complex. It should make perfect sense to an
average user once they have become familiar with the concepts, though.
Preferring certain replica types is not a difficult concept, so the parameter
name(s) should definitely be straightforward and nearly self-documenting.
> Add support for shards.sort parameter
> -
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.3, master (8.0)
>Reporter: Ere Maijala
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with {{shards.sor=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for shards.sort parameter
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391900#comment-16391900
]
Tomás Fernández Löbbe commented on SOLR-11982:
--
Thanks [~emaijala]. Code looks really good. I uploaded the latest patch and
left some minor comments there. One thing I'm not 100% yet is the pipe in the
syntax. To me, pipe usually means "OR", but in this case, that is not the case,
the order of the elements in does affect the output. Your code can also handle
the comma separated clauses, so it seems like:
{code:java}shards.sort=replicaType:PULL|TLOG{code}
Is actually the same as
{code:java}shards.sort=replicaType:PULL,replicaType:TLOG{code}
What is the intention of including the pipe then?
> Add support for shards.sort parameter
> -
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.3, master (8.0)
>Reporter: Ere Maijala
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with {{shards.sor=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for shards.sort parameter
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391134#comment-16391134
]
Ere Maijala commented on SOLR-11982:
(somehow failed to send this comment yesterday)
Thanks for the review. I believe I've addressed the review comments, but please
let me know if there are any remaining issues.
> Add support for shards.sort parameter
> -
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 7.3, master (8.0)
>Reporter: Ere Maijala
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch,
> SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with {{shards.sor=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for shards.sort parameter
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388907#comment-16388907
]
Tomás Fernández Löbbe commented on SOLR-11982:
--
I created a review request with your latest patch. I'll add some comments
there: https://reviews.apache.org/r/65942/
> Add support for shards.sort parameter
> -
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: master (8.0), 7.3
>Reporter: Ere Maijala
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with {{shards.sor=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11982) Add support for shards.sort parameter
[
https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387131#comment-16387131
]
Tomás Fernández Löbbe commented on SOLR-11982:
--
Thanks Ere, I'll take a look at your patch as soon as I can
> Add support for shards.sort parameter
> -
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: master (8.0), 7.3
>Reporter: Ere Maijala
>Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the
> preferred order e.g. by replica type. The attached patch adds support for
> {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas
> first with {{shards.sor=replicaType:PULL|TLOG }}(which would mean that NRT
> replicas wouldn't be hit with queries unless they're the only ones available)
> and/or to sort by replica location (like preferLocalShards=true but more
> versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
