[jira] [Commented] (SOLR-12110) Replica which failed to register in Zk can become leader

2018-03-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-12110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407447#comment-16407447
 ] 

ASF subversion and git services commented on SOLR-12110:


Commit a1692f950797abe9b4faeb3154f50b3bce25ec52 in lucene-solr's branch 
refs/heads/branch_7_3 from [~caomanhdat]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a1692f9 ]

SOLR-12110: Remove debug log for test


> Replica which failed to register in Zk can become leader
> 
>
> Key: SOLR-12110
> URL: https://issues.apache.org/jira/browse/SOLR-12110
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Affects Versions: 7.3
>Reporter: Cao Manh Dat
>Assignee: Cao Manh Dat
>Priority: Blocker
> Fix For: 7.3
>
> Attachments: SOLR-12110.patch, SOLR-12110.patch
>
>
> In case of when an exception is thrown in ZkController.register() a replica 
> can still be able to joinElection and become leader after that. This will 
> cause many problems, one of the problems can happen (the patch including a 
> test which lead to this failure) is
> A replica with DOWN state can become a leader and the shard will be stuck in 
> this state forever until the replica is removed or the node contains the 
> replica is restarted.
> This won't be a problem in Solr 7.2.1 because a replica with last published 
> state = DOWN can't become a leader, only since SOLR-7034 get resolved (by 
> SOLR-12011)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-12110) Replica which failed to register in Zk can become leader

2018-03-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-12110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407446#comment-16407446
 ] 

ASF subversion and git services commented on SOLR-12110:


Commit 32c8540d56add6fbf1906225f58afb78b7f9983c in lucene-solr's branch 
refs/heads/branch_7x from [~caomanhdat]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=32c8540 ]

SOLR-12110: Remove debug log for test


> Replica which failed to register in Zk can become leader
> 
>
> Key: SOLR-12110
> URL: https://issues.apache.org/jira/browse/SOLR-12110
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Affects Versions: 7.3
>Reporter: Cao Manh Dat
>Assignee: Cao Manh Dat
>Priority: Blocker
> Fix For: 7.3
>
> Attachments: SOLR-12110.patch, SOLR-12110.patch
>
>
> In case of when an exception is thrown in ZkController.register() a replica 
> can still be able to joinElection and become leader after that. This will 
> cause many problems, one of the problems can happen (the patch including a 
> test which lead to this failure) is
> A replica with DOWN state can become a leader and the shard will be stuck in 
> this state forever until the replica is removed or the node contains the 
> replica is restarted.
> This won't be a problem in Solr 7.2.1 because a replica with last published 
> state = DOWN can't become a leader, only since SOLR-7034 get resolved (by 
> SOLR-12011)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-12110) Replica which failed to register in Zk can become leader

2018-03-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-12110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407445#comment-16407445
 ] 

ASF subversion and git services commented on SOLR-12110:


Commit d2ef38d7845d967e259483bbf4a22cf8abec1309 in lucene-solr's branch 
refs/heads/master from [~caomanhdat]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d2ef38d ]

SOLR-12110: Remove debug log for test


> Replica which failed to register in Zk can become leader
> 
>
> Key: SOLR-12110
> URL: https://issues.apache.org/jira/browse/SOLR-12110
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Affects Versions: 7.3
>Reporter: Cao Manh Dat
>Assignee: Cao Manh Dat
>Priority: Blocker
> Fix For: 7.3
>
> Attachments: SOLR-12110.patch, SOLR-12110.patch
>
>
> In case of when an exception is thrown in ZkController.register() a replica 
> can still be able to joinElection and become leader after that. This will 
> cause many problems, one of the problems can happen (the patch including a 
> test which lead to this failure) is
> A replica with DOWN state can become a leader and the shard will be stuck in 
> this state forever until the replica is removed or the node contains the 
> replica is restarted.
> This won't be a problem in Solr 7.2.1 because a replica with last published 
> state = DOWN can't become a leader, only since SOLR-7034 get resolved (by 
> SOLR-12011)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-12110) Replica which failed to register in Zk can become leader

2018-03-16 Thread Cao Manh Dat (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-12110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403138#comment-16403138
 ] 

Cao Manh Dat commented on SOLR-12110:
-

Thanks [~shalinmangar]

> Replica which failed to register in Zk can become leader
> 
>
> Key: SOLR-12110
> URL: https://issues.apache.org/jira/browse/SOLR-12110
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Affects Versions: 7.3
>Reporter: Cao Manh Dat
>Assignee: Cao Manh Dat
>Priority: Blocker
> Fix For: 7.3
>
> Attachments: SOLR-12110.patch, SOLR-12110.patch
>
>
> In case of when an exception is thrown in ZkController.register() a replica 
> can still be able to joinElection and become leader after that. This will 
> cause many problems, one of the problems can happen (the patch including a 
> test which lead to this failure) is
> A replica with DOWN state can become a leader and the shard will be stuck in 
> this state forever until the replica is removed or the node contains the 
> replica is restarted.
> This won't be a problem in Solr 7.2.1 because a replica with last published 
> state = DOWN can't become a leader, only since SOLR-7034 get resolved (by 
> SOLR-12011)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-12110) Replica which failed to register in Zk can become leader

2018-03-16 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-12110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403137#comment-16403137
 ] 

ASF subversion and git services commented on SOLR-12110:


Commit 8a3742d2ee342ee60a6ed822e36fbdf66e0b5b97 in lucene-solr's branch 
refs/heads/branch_7_3 from [~caomanhdat]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8a3742d ]

SOLR-12110: Replica which failed to register in Zk can become leader


> Replica which failed to register in Zk can become leader
> 
>
> Key: SOLR-12110
> URL: https://issues.apache.org/jira/browse/SOLR-12110
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Affects Versions: 7.3
>Reporter: Cao Manh Dat
>Assignee: Cao Manh Dat
>Priority: Blocker
> Fix For: 7.3
>
> Attachments: SOLR-12110.patch, SOLR-12110.patch
>
>
> In case of when an exception is thrown in ZkController.register() a replica 
> can still be able to joinElection and become leader after that. This will 
> cause many problems, one of the problems can happen (the patch including a 
> test which lead to this failure) is
> A replica with DOWN state can become a leader and the shard will be stuck in 
> this state forever until the replica is removed or the node contains the 
> replica is restarted.
> This won't be a problem in Solr 7.2.1 because a replica with last published 
> state = DOWN can't become a leader, only since SOLR-7034 get resolved (by 
> SOLR-12011)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-12110) Replica which failed to register in Zk can become leader

2018-03-16 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-12110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403135#comment-16403135
 ] 

ASF subversion and git services commented on SOLR-12110:


Commit 911fda2efd4d71a604c1815e7e0545bc66986eee in lucene-solr's branch 
refs/heads/branch_7x from [~caomanhdat]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=911fda2 ]

SOLR-12110: Replica which failed to register in Zk can become leader


> Replica which failed to register in Zk can become leader
> 
>
> Key: SOLR-12110
> URL: https://issues.apache.org/jira/browse/SOLR-12110
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Affects Versions: 7.3
>Reporter: Cao Manh Dat
>Assignee: Cao Manh Dat
>Priority: Blocker
> Attachments: SOLR-12110.patch, SOLR-12110.patch
>
>
> In case of when an exception is thrown in ZkController.register() a replica 
> can still be able to joinElection and become leader after that. This will 
> cause many problems, one of the problems can happen (the patch including a 
> test which lead to this failure) is
> A replica with DOWN state can become a leader and the shard will be stuck in 
> this state forever until the replica is removed or the node contains the 
> replica is restarted.
> This won't be a problem in Solr 7.2.1 because a replica with last published 
> state = DOWN can't become a leader, only since SOLR-7034 get resolved (by 
> SOLR-12011)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-12110) Replica which failed to register in Zk can become leader

2018-03-16 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-12110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403134#comment-16403134
 ] 

ASF subversion and git services commented on SOLR-12110:


Commit be8dca3c7bc064bc42662cb3fa6eb7439ffc7fdb in lucene-solr's branch 
refs/heads/master from [~caomanhdat]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=be8dca3 ]

SOLR-12110: Replica which failed to register in Zk can become leader


> Replica which failed to register in Zk can become leader
> 
>
> Key: SOLR-12110
> URL: https://issues.apache.org/jira/browse/SOLR-12110
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Affects Versions: 7.3
>Reporter: Cao Manh Dat
>Assignee: Cao Manh Dat
>Priority: Blocker
> Attachments: SOLR-12110.patch, SOLR-12110.patch
>
>
> In case of when an exception is thrown in ZkController.register() a replica 
> can still be able to joinElection and become leader after that. This will 
> cause many problems, one of the problems can happen (the patch including a 
> test which lead to this failure) is
> A replica with DOWN state can become a leader and the shard will be stuck in 
> this state forever until the replica is removed or the node contains the 
> replica is restarted.
> This won't be a problem in Solr 7.2.1 because a replica with last published 
> state = DOWN can't become a leader, only since SOLR-7034 get resolved (by 
> SOLR-12011)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-12110) Replica which failed to register in Zk can become leader

2018-03-16 Thread Cao Manh Dat (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-12110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402059#comment-16402059
 ] 

Cao Manh Dat commented on SOLR-12110:
-

Updated patch with reliable test ( beasted 100 times )

> Replica which failed to register in Zk can become leader
> 
>
> Key: SOLR-12110
> URL: https://issues.apache.org/jira/browse/SOLR-12110
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Affects Versions: 7.3
>Reporter: Cao Manh Dat
>Assignee: Cao Manh Dat
>Priority: Blocker
> Attachments: SOLR-12110.patch, SOLR-12110.patch
>
>
> In case of when an exception is thrown in ZkController.register() a replica 
> can still be able to joinElection and become leader after that. This will 
> cause many problems, one of the problems can happen (the patch including a 
> test which lead to this failure) is
> A replica with DOWN state can become a leader and the shard will be stuck in 
> this state forever until the replica is removed or the node contains the 
> replica is restarted.
> This won't be a problem in Solr 7.2.1 because a replica with last published 
> state = DOWN can't become a leader, only since SOLR-7034 get resolved (by 
> SOLR-12011)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-12110) Replica which failed to register in Zk can become leader

2018-03-16 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-12110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401736#comment-16401736
 ] 

Shalin Shekhar Mangar commented on SOLR-12110:
--

+1 LGTM

> Replica which failed to register in Zk can become leader
> 
>
> Key: SOLR-12110
> URL: https://issues.apache.org/jira/browse/SOLR-12110
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Affects Versions: 7.3
>Reporter: Cao Manh Dat
>Assignee: Cao Manh Dat
>Priority: Blocker
> Attachments: SOLR-12110.patch
>
>
> In case of when an exception is thrown in ZkController.register() a replica 
> can still be able to joinElection and become leader after that. This will 
> cause many problems, one of the problems can happen (the patch including a 
> test which lead to this failure) is
> A replica with DOWN state can become a leader and the shard will be stuck in 
> this state forever until the replica is removed or the node contains the 
> replica is restarted.
> This won't be a problem in Solr 7.2.1 because a replica with last published 
> state = DOWN can't become a leader, only since SOLR-7034 get resolved (by 
> SOLR-12011)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-12110) Replica which failed to register in Zk can become leader

2018-03-15 Thread Cao Manh Dat (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-12110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401377#comment-16401377
 ] 

Cao Manh Dat commented on SOLR-12110:
-

The idea of the patch is calling ZkController.unregister when an exception is 
thrown by ZkController.register

> Replica which failed to register in Zk can become leader
> 
>
> Key: SOLR-12110
> URL: https://issues.apache.org/jira/browse/SOLR-12110
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Affects Versions: 7.3
>Reporter: Cao Manh Dat
>Assignee: Cao Manh Dat
>Priority: Blocker
> Attachments: SOLR-12110.patch
>
>
> In case of when an exception is thrown in ZkController.register() a replica 
> can still be able to joinElection and become leader after that. This will 
> cause many problems, one of the problems can happen (the patch including a 
> test which lead to this failure) is
> A replica with DOWN state can become a leader and the shard will be stuck in 
> this state forever until the replica is removed or the node contains the 
> replica is restarted.
> This won't be a problem in Solr 7.2.1 because a replica with last published 
> state = DOWN can't become a leader, only since SOLR-7034 get resolved (by 
> SOLR-12011)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org