[jira] [Commented] (SOLR-12533) Collection creation fails if metrics are called during core creation
[ https://issues.apache.org/jira/browse/SOLR-12533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532183#comment-16532183 ] ASF subversion and git services commented on SOLR-12533: Commit 2e22a12f0e28add0335ea3c56c5236175a76604c in lucene-solr's branch refs/heads/branch_7x from [~yo...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2e22a12 ] SOLR-12533: getting index size shouldn't create directory (metrics race) > Collection creation fails if metrics are called during core creation > > > Key: SOLR-12533 > URL: https://issues.apache.org/jira/browse/SOLR-12533 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Affects Versions: 7.0 >Reporter: Peter Cseh >Priority: Major > Fix For: 7.5 > > Time Spent: 10m > Remaining Estimate: 0h > > There is a race condition in SorlCore's constructor: > - the metrics.indexSize call implicitly creates a data/index folder for that > core > - if the data/index folder exists, no segments file will be created > - the searcher won't start up if there are no segments file in the data/index > folder > This is probably the root cause for SOLR-2130 and SOLR-2801 as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12533) Collection creation fails if metrics are called during core creation
[ https://issues.apache.org/jira/browse/SOLR-12533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532182#comment-16532182 ] ASF subversion and git services commented on SOLR-12533: Commit b7b6f242e8db06ef5a1ff441dfc8123fc811c121 in lucene-solr's branch refs/heads/master from [~yo...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b7b6f24 ] SOLR-12533: getting index size shouldn't create directory (metrics race) > Collection creation fails if metrics are called during core creation > > > Key: SOLR-12533 > URL: https://issues.apache.org/jira/browse/SOLR-12533 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Affects Versions: 7.0 >Reporter: Peter Cseh >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > There is a race condition in SorlCore's constructor: > - the metrics.indexSize call implicitly creates a data/index folder for that > core > - if the data/index folder exists, no segments file will be created > - the searcher won't start up if there are no segments file in the data/index > folder > This is probably the root cause for SOLR-2130 and SOLR-2801 as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12533) Collection creation fails if metrics are called during core creation
[ https://issues.apache.org/jira/browse/SOLR-12533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530356#comment-16530356 ] Yonik Seeley commented on SOLR-12533: - These changes look good to me. I plan on committing after unit tests finish running. > Collection creation fails if metrics are called during core creation > > > Key: SOLR-12533 > URL: https://issues.apache.org/jira/browse/SOLR-12533 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Affects Versions: 7.0 >Reporter: Peter Cseh >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > There is a race condition in SorlCore's constructor: > - the metrics.indexSize call implicitly creates a data/index folder for that > core > - if the data/index folder exists, no segments file will be created > - the searcher won't start up if there are no segments file in the data/index > folder > This is probably the root cause for SOLR-2130 and SOLR-2801 as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12533) Collection creation fails if metrics are called during core creation
[ https://issues.apache.org/jira/browse/SOLR-12533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530351#comment-16530351 ] Peter Cseh commented on SOLR-12533: --- I think the root cause is that the index core.getIndexSize() creates the data/index folder if it does no exists. This is a side effect which the getIndexSize() should no have. I've refreshed the pull request with the new fix > Collection creation fails if metrics are called during core creation > > > Key: SOLR-12533 > URL: https://issues.apache.org/jira/browse/SOLR-12533 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Affects Versions: 7.0 >Reporter: Peter Cseh >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > There is a race condition in SorlCore's constructor: > - the metrics.indexSize call implicitly creates a data/index folder for that > core > - if the data/index folder exists, no segments file will be created > - the searcher won't start up if there are no segments file in the data/index > folder > This is probably the root cause for SOLR-2130 and SOLR-2801 as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
