[jira] [Commented] (SOLR-12574) SignificantTermsQParserPlugin should output its keys in a combined bucket
[ https://issues.apache.org/jira/browse/SOLR-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567669#comment-16567669 ] ASF subversion and git services commented on SOLR-12574: Commit 2b121e7f2267d185455b4f6bf4aa9fa6bf9266f9 in lucene-solr's branch refs/heads/branch_7x from [~arafalov] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2b121e7 ] SOLR-12574: Fix the SignificantTermStream to use the new bucket format > SignificantTermsQParserPlugin should output its keys in a combined bucket > - > > Key: SOLR-12574 > URL: https://issues.apache.org/jira/browse/SOLR-12574 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: query parsers >Affects Versions: 7.4 >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > Fix For: 7.5 > > Attachments: SOLR-12574.patch > > > SignificantTermsQParserPlugin is not yet visible to the users (was not > documented or spelt correctly in 7.4), so there is still a chance to fix its > output before people start using it. > Currently, it injects 6 different keys into the document, on the same level > as responseHeader and response. This feels like polluting top-level space. It > may be better to put all those keys under one bucket (e.g. significantTerms). > Additionally, resultCount is always the same as response.numFound (documents > found), so does not seem to be needed. > Current output: > {code:java} > { > "responseHeader": { > "status": 0, > "QTime": 1, > "params": { > "q": "directed_by_str:\"Steven Soderbergh\"", > "fq": "{!significantTerms field=genre numTerms=2}", > "rows": "1", > "wt": "json" > } > }, > "numDocs": 1100, > "resultCount": 5, > "sterms": [ > "biographical", > "romance" > ], > "scores": [ > 2.5552773475646973, > 2.6387078762054443 > ], > "docFreq": [ > 74, > 270 > ], > "queryDocFreq": [ > 2, > 3 > ], > "response": { > "numFound": 5, > "start": 0, > "docs": [ > { > "id": "/en/bubble", > "directed_by": [ > "Steven Soderbergh" > ], > "initial_release_date": "2005-09-03T00:00:00Z", > "name": "Bubble", > "genre": [ > "Crime Fiction", > "Mystery", > "Indie film", > "Thriller", > "Drama" > ], > "_version_": 1606610059993808899 > } > ] > } > }{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12574) SignificantTermsQParserPlugin should output its keys in a combined bucket
[ https://issues.apache.org/jira/browse/SOLR-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564950#comment-16564950 ] ASF subversion and git services commented on SOLR-12574: Commit fd2cc195f7a0dbbc3a3603b056a393f02864dfbb in lucene-solr's branch refs/heads/branch_7x from [~shalinmangar] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fd2cc19 ] SOLR-12574: Annotating testSignificantTermsStream with AwaitsFix > SignificantTermsQParserPlugin should output its keys in a combined bucket > - > > Key: SOLR-12574 > URL: https://issues.apache.org/jira/browse/SOLR-12574 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: query parsers >Affects Versions: 7.4 >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > Fix For: 7.5 > > Attachments: SOLR-12574.patch > > > SignificantTermsQParserPlugin is not yet visible to the users (was not > documented or spelt correctly in 7.4), so there is still a chance to fix its > output before people start using it. > Currently, it injects 6 different keys into the document, on the same level > as responseHeader and response. This feels like polluting top-level space. It > may be better to put all those keys under one bucket (e.g. significantTerms). > Additionally, resultCount is always the same as response.numFound (documents > found), so does not seem to be needed. > Current output: > {code:java} > { > "responseHeader": { > "status": 0, > "QTime": 1, > "params": { > "q": "directed_by_str:\"Steven Soderbergh\"", > "fq": "{!significantTerms field=genre numTerms=2}", > "rows": "1", > "wt": "json" > } > }, > "numDocs": 1100, > "resultCount": 5, > "sterms": [ > "biographical", > "romance" > ], > "scores": [ > 2.5552773475646973, > 2.6387078762054443 > ], > "docFreq": [ > 74, > 270 > ], > "queryDocFreq": [ > 2, > 3 > ], > "response": { > "numFound": 5, > "start": 0, > "docs": [ > { > "id": "/en/bubble", > "directed_by": [ > "Steven Soderbergh" > ], > "initial_release_date": "2005-09-03T00:00:00Z", > "name": "Bubble", > "genre": [ > "Crime Fiction", > "Mystery", > "Indie film", > "Thriller", > "Drama" > ], > "_version_": 1606610059993808899 > } > ] > } > }{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12574) SignificantTermsQParserPlugin should output its keys in a combined bucket
[ https://issues.apache.org/jira/browse/SOLR-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564904#comment-16564904 ] Shalin Shekhar Mangar commented on SOLR-12574: -- [~arafalov] -- this needs backporting to 7x too. > SignificantTermsQParserPlugin should output its keys in a combined bucket > - > > Key: SOLR-12574 > URL: https://issues.apache.org/jira/browse/SOLR-12574 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: query parsers >Affects Versions: 7.4 >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > Fix For: 7.5 > > Attachments: SOLR-12574.patch > > > SignificantTermsQParserPlugin is not yet visible to the users (was not > documented or spelt correctly in 7.4), so there is still a chance to fix its > output before people start using it. > Currently, it injects 6 different keys into the document, on the same level > as responseHeader and response. This feels like polluting top-level space. It > may be better to put all those keys under one bucket (e.g. significantTerms). > Additionally, resultCount is always the same as response.numFound (documents > found), so does not seem to be needed. > Current output: > {code:java} > { > "responseHeader": { > "status": 0, > "QTime": 1, > "params": { > "q": "directed_by_str:\"Steven Soderbergh\"", > "fq": "{!significantTerms field=genre numTerms=2}", > "rows": "1", > "wt": "json" > } > }, > "numDocs": 1100, > "resultCount": 5, > "sterms": [ > "biographical", > "romance" > ], > "scores": [ > 2.5552773475646973, > 2.6387078762054443 > ], > "docFreq": [ > 74, > 270 > ], > "queryDocFreq": [ > 2, > 3 > ], > "response": { > "numFound": 5, > "start": 0, > "docs": [ > { > "id": "/en/bubble", > "directed_by": [ > "Steven Soderbergh" > ], > "initial_release_date": "2005-09-03T00:00:00Z", > "name": "Bubble", > "genre": [ > "Crime Fiction", > "Mystery", > "Indie film", > "Thriller", > "Drama" > ], > "_version_": 1606610059993808899 > } > ] > } > }{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12574) SignificantTermsQParserPlugin should output its keys in a combined bucket
[ https://issues.apache.org/jira/browse/SOLR-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563564#comment-16563564 ] ASF subversion and git services commented on SOLR-12574: Commit abd6b07ea98eaf24577ad8c347bb39f491276fa0 in lucene-solr's branch refs/heads/master from [~arafalov] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=abd6b07 ] SOLR-12574: Fix the SignificantTermStream to use the new bucket format > SignificantTermsQParserPlugin should output its keys in a combined bucket > - > > Key: SOLR-12574 > URL: https://issues.apache.org/jira/browse/SOLR-12574 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: query parsers >Affects Versions: 7.4 >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > Fix For: 7.5 > > Attachments: SOLR-12574.patch > > > SignificantTermsQParserPlugin is not yet visible to the users (was not > documented or spelt correctly in 7.4), so there is still a chance to fix its > output before people start using it. > Currently, it injects 6 different keys into the document, on the same level > as responseHeader and response. This feels like polluting top-level space. It > may be better to put all those keys under one bucket (e.g. significantTerms). > Additionally, resultCount is always the same as response.numFound (documents > found), so does not seem to be needed. > Current output: > {code:java} > { > "responseHeader": { > "status": 0, > "QTime": 1, > "params": { > "q": "directed_by_str:\"Steven Soderbergh\"", > "fq": "{!significantTerms field=genre numTerms=2}", > "rows": "1", > "wt": "json" > } > }, > "numDocs": 1100, > "resultCount": 5, > "sterms": [ > "biographical", > "romance" > ], > "scores": [ > 2.5552773475646973, > 2.6387078762054443 > ], > "docFreq": [ > 74, > 270 > ], > "queryDocFreq": [ > 2, > 3 > ], > "response": { > "numFound": 5, > "start": 0, > "docs": [ > { > "id": "/en/bubble", > "directed_by": [ > "Steven Soderbergh" > ], > "initial_release_date": "2005-09-03T00:00:00Z", > "name": "Bubble", > "genre": [ > "Crime Fiction", > "Mystery", > "Indie film", > "Thriller", > "Drama" > ], > "_version_": 1606610059993808899 > } > ] > } > }{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12574) SignificantTermsQParserPlugin should output its keys in a combined bucket
[ https://issues.apache.org/jira/browse/SOLR-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563038#comment-16563038 ] ASF subversion and git services commented on SOLR-12574: Commit e264d0392081ab1880ccf3c9895fa0e7e9c17d29 in lucene-solr's branch refs/heads/jira/http2 from [~arafalov] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e264d03 ] SOLR-12574: Use a common bucket for all significantTerms outputs > SignificantTermsQParserPlugin should output its keys in a combined bucket > - > > Key: SOLR-12574 > URL: https://issues.apache.org/jira/browse/SOLR-12574 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: query parsers >Affects Versions: 7.4 >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > Fix For: 7.5 > > Attachments: SOLR-12574.patch > > > SignificantTermsQParserPlugin is not yet visible to the users (was not > documented or spelt correctly in 7.4), so there is still a chance to fix its > output before people start using it. > Currently, it injects 6 different keys into the document, on the same level > as responseHeader and response. This feels like polluting top-level space. It > may be better to put all those keys under one bucket (e.g. significantTerms). > Additionally, resultCount is always the same as response.numFound (documents > found), so does not seem to be needed. > Current output: > {code:java} > { > "responseHeader": { > "status": 0, > "QTime": 1, > "params": { > "q": "directed_by_str:\"Steven Soderbergh\"", > "fq": "{!significantTerms field=genre numTerms=2}", > "rows": "1", > "wt": "json" > } > }, > "numDocs": 1100, > "resultCount": 5, > "sterms": [ > "biographical", > "romance" > ], > "scores": [ > 2.5552773475646973, > 2.6387078762054443 > ], > "docFreq": [ > 74, > 270 > ], > "queryDocFreq": [ > 2, > 3 > ], > "response": { > "numFound": 5, > "start": 0, > "docs": [ > { > "id": "/en/bubble", > "directed_by": [ > "Steven Soderbergh" > ], > "initial_release_date": "2005-09-03T00:00:00Z", > "name": "Bubble", > "genre": [ > "Crime Fiction", > "Mystery", > "Indie film", > "Thriller", > "Drama" > ], > "_version_": 1606610059993808899 > } > ] > } > }{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12574) SignificantTermsQParserPlugin should output its keys in a combined bucket
[ https://issues.apache.org/jira/browse/SOLR-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561991#comment-16561991 ] Alexandre Rafalovitch commented on SOLR-12574: -- Thanks for the catch. The StreamExpression was using Query Parser under the covers and I missed one link. I'll fix it tonight. > SignificantTermsQParserPlugin should output its keys in a combined bucket > - > > Key: SOLR-12574 > URL: https://issues.apache.org/jira/browse/SOLR-12574 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: query parsers >Affects Versions: 7.4 >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > Fix For: 7.5 > > Attachments: SOLR-12574.patch > > > SignificantTermsQParserPlugin is not yet visible to the users (was not > documented or spelt correctly in 7.4), so there is still a chance to fix its > output before people start using it. > Currently, it injects 6 different keys into the document, on the same level > as responseHeader and response. This feels like polluting top-level space. It > may be better to put all those keys under one bucket (e.g. significantTerms). > Additionally, resultCount is always the same as response.numFound (documents > found), so does not seem to be needed. > Current output: > {code:java} > { > "responseHeader": { > "status": 0, > "QTime": 1, > "params": { > "q": "directed_by_str:\"Steven Soderbergh\"", > "fq": "{!significantTerms field=genre numTerms=2}", > "rows": "1", > "wt": "json" > } > }, > "numDocs": 1100, > "resultCount": 5, > "sterms": [ > "biographical", > "romance" > ], > "scores": [ > 2.5552773475646973, > 2.6387078762054443 > ], > "docFreq": [ > 74, > 270 > ], > "queryDocFreq": [ > 2, > 3 > ], > "response": { > "numFound": 5, > "start": 0, > "docs": [ > { > "id": "/en/bubble", > "directed_by": [ > "Steven Soderbergh" > ], > "initial_release_date": "2005-09-03T00:00:00Z", > "name": "Bubble", > "genre": [ > "Crime Fiction", > "Mystery", > "Indie film", > "Thriller", > "Drama" > ], > "_version_": 1606610059993808899 > } > ] > } > }{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12574) SignificantTermsQParserPlugin should output its keys in a combined bucket
[ https://issues.apache.org/jira/browse/SOLR-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561971#comment-16561971 ] Adrien Grand commented on SOLR-12574: - [~arafalov] This seems to cause failures in StreamExpressionTest. See eg. https://builds.apache.org/job/Lucene-Solr-NightlyTests-master/1598/. > SignificantTermsQParserPlugin should output its keys in a combined bucket > - > > Key: SOLR-12574 > URL: https://issues.apache.org/jira/browse/SOLR-12574 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: query parsers >Affects Versions: 7.4 >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > Fix For: 7.5 > > Attachments: SOLR-12574.patch > > > SignificantTermsQParserPlugin is not yet visible to the users (was not > documented or spelt correctly in 7.4), so there is still a chance to fix its > output before people start using it. > Currently, it injects 6 different keys into the document, on the same level > as responseHeader and response. This feels like polluting top-level space. It > may be better to put all those keys under one bucket (e.g. significantTerms). > Additionally, resultCount is always the same as response.numFound (documents > found), so does not seem to be needed. > Current output: > {code:java} > { > "responseHeader": { > "status": 0, > "QTime": 1, > "params": { > "q": "directed_by_str:\"Steven Soderbergh\"", > "fq": "{!significantTerms field=genre numTerms=2}", > "rows": "1", > "wt": "json" > } > }, > "numDocs": 1100, > "resultCount": 5, > "sterms": [ > "biographical", > "romance" > ], > "scores": [ > 2.5552773475646973, > 2.6387078762054443 > ], > "docFreq": [ > 74, > 270 > ], > "queryDocFreq": [ > 2, > 3 > ], > "response": { > "numFound": 5, > "start": 0, > "docs": [ > { > "id": "/en/bubble", > "directed_by": [ > "Steven Soderbergh" > ], > "initial_release_date": "2005-09-03T00:00:00Z", > "name": "Bubble", > "genre": [ > "Crime Fiction", > "Mystery", > "Indie film", > "Thriller", > "Drama" > ], > "_version_": 1606610059993808899 > } > ] > } > }{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12574) SignificantTermsQParserPlugin should output its keys in a combined bucket
[ https://issues.apache.org/jira/browse/SOLR-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561150#comment-16561150 ] ASF subversion and git services commented on SOLR-12574: Commit c0b78f74e5cabb2a1aee2012aa55229a9780b86d in lucene-solr's branch refs/heads/branch_7x from [~arafalov] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c0b78f7 ] SOLR-12574: Use a common bucket for all significantTerms outputs > SignificantTermsQParserPlugin should output its keys in a combined bucket > - > > Key: SOLR-12574 > URL: https://issues.apache.org/jira/browse/SOLR-12574 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: query parsers >Affects Versions: 7.4 >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > Attachments: SOLR-12574.patch > > > SignificantTermsQParserPlugin is not yet visible to the users (was not > documented or spelt correctly in 7.4), so there is still a chance to fix its > output before people start using it. > Currently, it injects 6 different keys into the document, on the same level > as responseHeader and response. This feels like polluting top-level space. It > may be better to put all those keys under one bucket (e.g. significantTerms). > Additionally, resultCount is always the same as response.numFound (documents > found), so does not seem to be needed. > Current output: > {code:java} > { > "responseHeader": { > "status": 0, > "QTime": 1, > "params": { > "q": "directed_by_str:\"Steven Soderbergh\"", > "fq": "{!significantTerms field=genre numTerms=2}", > "rows": "1", > "wt": "json" > } > }, > "numDocs": 1100, > "resultCount": 5, > "sterms": [ > "biographical", > "romance" > ], > "scores": [ > 2.5552773475646973, > 2.6387078762054443 > ], > "docFreq": [ > 74, > 270 > ], > "queryDocFreq": [ > 2, > 3 > ], > "response": { > "numFound": 5, > "start": 0, > "docs": [ > { > "id": "/en/bubble", > "directed_by": [ > "Steven Soderbergh" > ], > "initial_release_date": "2005-09-03T00:00:00Z", > "name": "Bubble", > "genre": [ > "Crime Fiction", > "Mystery", > "Indie film", > "Thriller", > "Drama" > ], > "_version_": 1606610059993808899 > } > ] > } > }{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12574) SignificantTermsQParserPlugin should output its keys in a combined bucket
[ https://issues.apache.org/jira/browse/SOLR-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561148#comment-16561148 ] ASF subversion and git services commented on SOLR-12574: Commit e264d0392081ab1880ccf3c9895fa0e7e9c17d29 in lucene-solr's branch refs/heads/master from [~arafalov] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e264d03 ] SOLR-12574: Use a common bucket for all significantTerms outputs > SignificantTermsQParserPlugin should output its keys in a combined bucket > - > > Key: SOLR-12574 > URL: https://issues.apache.org/jira/browse/SOLR-12574 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: query parsers >Affects Versions: 7.4 >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > Attachments: SOLR-12574.patch > > > SignificantTermsQParserPlugin is not yet visible to the users (was not > documented or spelt correctly in 7.4), so there is still a chance to fix its > output before people start using it. > Currently, it injects 6 different keys into the document, on the same level > as responseHeader and response. This feels like polluting top-level space. It > may be better to put all those keys under one bucket (e.g. significantTerms). > Additionally, resultCount is always the same as response.numFound (documents > found), so does not seem to be needed. > Current output: > {code:java} > { > "responseHeader": { > "status": 0, > "QTime": 1, > "params": { > "q": "directed_by_str:\"Steven Soderbergh\"", > "fq": "{!significantTerms field=genre numTerms=2}", > "rows": "1", > "wt": "json" > } > }, > "numDocs": 1100, > "resultCount": 5, > "sterms": [ > "biographical", > "romance" > ], > "scores": [ > 2.5552773475646973, > 2.6387078762054443 > ], > "docFreq": [ > 74, > 270 > ], > "queryDocFreq": [ > 2, > 3 > ], > "response": { > "numFound": 5, > "start": 0, > "docs": [ > { > "id": "/en/bubble", > "directed_by": [ > "Steven Soderbergh" > ], > "initial_release_date": "2005-09-03T00:00:00Z", > "name": "Bubble", > "genre": [ > "Crime Fiction", > "Mystery", > "Indie film", > "Thriller", > "Drama" > ], > "_version_": 1606610059993808899 > } > ] > } > }{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org