[jira] [Commented] (SOLR-13143) Output from ExplainAugmenterFactory and DebugQuery for rerank queries is not same
[
https://issues.apache.org/jira/browse/SOLR-13143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859653#comment-16859653
]
Lucene/Solr QA commented on SOLR-13143:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
1s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 53s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 49m
9s{color} | {color:green} core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 55m 50s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13143 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12956438/539.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon
Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / fe58b6f |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | LTS |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/424/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/424/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Output from ExplainAugmenterFactory and DebugQuery for rerank queries is not
> same
> -
>
> Key: SOLR-13143
> URL: https://issues.apache.org/jira/browse/SOLR-13143
> Project: Solr
> Issue Type: Bug
> Components: search
>Affects Versions: 7.5
>Reporter: Sambhav Kothari
>Priority: Minor
> Attachments: 539.patch, bug.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently, if we use the ExplainAugmenterFactory with LtR, instead of using
> the
> model/re-rankers explain method, it uses the default query explain (tf-idf
> explanation). This happens because the BasicResultContext doesn't wrap the
>
> query([https://github.com/apache/lucene-solr/blob/1d85cd783863f75cea133fb9c452302]
>
> 214165a4d/solr/core/src/java/org/apache/solr/response/BasicResultContext.java#L6
> 7) with the RankQuery when its set to context's query, which is then used by
> the ExplainAugmenterFactory.
>
> ([https://github.com/apache/lucene-solr/blob/1d85cd783863f75cea133fb9c45230221416]
>
> 5a4d/solr/core/src/java/org/apache/solr/response/transform/ExplainAugmenterFacto
> ry.java#L111).
> As a result there are discrepancies between queries like -
> [http://localhost:8983/solr/collection1/select?q=*:*&collection=collectionName&wt]
> =json&fl=[explain style=nl],score&rq=\{!ltr model=linear-model}
> [http://localhost:8983/solr/collection1/select?q=*:*&collection=collectionName&wt]
> =json&fl=score&rq=\{!ltr model=linear-model}&debugQuery=true
> the former outputs the explain from the SimilarityScorer's explain while the
> latter uses the correct LtR ModelScorer's explain.
> There are a few other problems with the explain augmenter - for eg. it
> doesn't
> work with grouping (although the other doc transformers like LtR's
> LTRFeatureLoggerTransformerFactory work with grouping)
> Mailing List -
>
> http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201901.mbox/%3C5C3879D702C30144003902B0_0_18802%40msllnjpmsgsv06%3E
--
This message was sent
[jira] [Commented] (SOLR-13143) Output from ExplainAugmenterFactory and DebugQuery for rerank queries is not same
[
https://issues.apache.org/jira/browse/SOLR-13143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753447#comment-16753447
]
Lucene/Solr QA commented on SOLR-13143:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
45s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 36s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 40m 49s{color}
| {color:red} core in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 46m 55s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.search.TestRecovery |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13143 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12956438/539.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon
Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 250d21d |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | 1.8.0_191 |
| unit |
https://builds.apache.org/job/PreCommit-SOLR-Build/270/artifact/out/patch-unit-solr_core.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/270/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/270/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Output from ExplainAugmenterFactory and DebugQuery for rerank queries is not
> same
> -
>
> Key: SOLR-13143
> URL: https://issues.apache.org/jira/browse/SOLR-13143
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: search
>Affects Versions: 7.5
>Reporter: Sambhav Kothari
>Priority: Minor
> Attachments: 539.patch, bug.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, if we use the ExplainAugmenterFactory with LtR, instead of using
> the
> model/re-rankers explain method, it uses the default query explain (tf-idf
> explanation). This happens because the BasicResultContext doesn't wrap the
>
> query([https://github.com/apache/lucene-solr/blob/1d85cd783863f75cea133fb9c452302]
>
> 214165a4d/solr/core/src/java/org/apache/solr/response/BasicResultContext.java#L6
> 7) with the RankQuery when its set to context's query, which is then used by
> the ExplainAugmenterFactory.
>
> ([https://github.com/apache/lucene-solr/blob/1d85cd783863f75cea133fb9c45230221416]
>
> 5a4d/solr/core/src/java/org/apache/solr/response/transform/ExplainAugmenterFacto
> ry.java#L111).
> As a result there are discrepancies between queries like -
> [http://localhost:8983/solr/collection1/select?q=*:*&collection=collectionName&wt]
> =json&fl=[explain style=nl],score&rq=\{!ltr model=linear-model}
> [http://localhost:8983/solr/collection1/select?q=*:*&collection=collectionName&wt]
> =json&fl=score&rq=\{!ltr model=linear-model}&debugQuery=true
> the former outputs the explain from the SimilarityScorer's explain while the
> latter uses the correct LtR ModelScorer's explain.
> There are a few other problems with the explain augmenter - for eg. it
> doesn't
> work with grouping (although the other doc transfo
[jira] [Commented] (SOLR-13143) Output from ExplainAugmenterFactory and DebugQuery for rerank queries is not same
[
https://issues.apache.org/jira/browse/SOLR-13143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748650#comment-16748650
]
Lucene/Solr QA commented on SOLR-13143:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
33s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 4m 26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 4m 26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 4m 27s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 81m 7s{color}
| {color:red} core in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 92m 58s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.cloud.CollectionsAPISolrJTest |
| | solr.cloud.autoscaling.sim.TestSimExtremeIndexing |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13143 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12955690/SOLR-13143.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 2aa2c16 |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | 1.8.0_191 |
| unit |
https://builds.apache.org/job/PreCommit-SOLR-Build/265/artifact/out/patch-unit-solr_core.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/265/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/265/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Output from ExplainAugmenterFactory and DebugQuery for rerank queries is not
> same
> -
>
> Key: SOLR-13143
> URL: https://issues.apache.org/jira/browse/SOLR-13143
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: search
>Affects Versions: 7.5
>Reporter: Sambhav Kothari
>Priority: Minor
> Attachments: SOLR-13143.patch, bug.patch
>
>
> Currently, if we use the ExplainAugmenterFactory with LtR, instead of using
> the
> model/re-rankers explain method, it uses the default query explain (tf-idf
> explanation). This happens because the BasicResultContext doesn't wrap the
>
> query([https://github.com/apache/lucene-solr/blob/1d85cd783863f75cea133fb9c452302]
>
> 214165a4d/solr/core/src/java/org/apache/solr/response/BasicResultContext.java#L6
> 7) with the RankQuery when its set to context's query, which is then used by
> the ExplainAugmenterFactory.
>
> ([https://github.com/apache/lucene-solr/blob/1d85cd783863f75cea133fb9c45230221416]
>
> 5a4d/solr/core/src/java/org/apache/solr/response/transform/ExplainAugmenterFacto
> ry.java#L111).
> As a result there are discrepancies between queries like -
> [http://localhost:8983/solr/collection1/select?q=*:*&collection=collectionName&wt]
> =json&fl=[explain style=nl],score&rq=\{!ltr model=linear-model}
> [http://localhost:8983/solr/collection1/select?q=*:*&collection=collectionName&wt]
> =json&fl=score&rq=\{!ltr model=linear-model}&debugQuery=true
> the former outputs the explain from the SimilarityScorer's explain while the
> latter uses the correct LtR ModelScorer's explain.
> There are a few other problems with the explain augmenter - for eg. it
> doesn't
> work with grouping
[jira] [Commented] (SOLR-13143) Output from ExplainAugmenterFactory and DebugQuery for rerank queries is not same
[
https://issues.apache.org/jira/browse/SOLR-13143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748188#comment-16748188
]
Sambhav Kothari commented on SOLR-13143:
The above was for my new unit test which confirms the bug. Attaching the fix -
[^SOLR-13143.patch]
> Output from ExplainAugmenterFactory and DebugQuery for rerank queries is not
> same
> -
>
> Key: SOLR-13143
> URL: https://issues.apache.org/jira/browse/SOLR-13143
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: search
>Affects Versions: 7.5
>Reporter: Sambhav Kothari
>Priority: Minor
> Attachments: SOLR-13143.patch, bug.patch
>
>
> Currently, if we use the ExplainAugmenterFactory with LtR, instead of using
> the
> model/re-rankers explain method, it uses the default query explain (tf-idf
> explanation). This happens because the BasicResultContext doesn't wrap the
>
> query([https://github.com/apache/lucene-solr/blob/1d85cd783863f75cea133fb9c452302]
>
> 214165a4d/solr/core/src/java/org/apache/solr/response/BasicResultContext.java#L6
> 7) with the RankQuery when its set to context's query, which is then used by
> the ExplainAugmenterFactory.
>
> ([https://github.com/apache/lucene-solr/blob/1d85cd783863f75cea133fb9c45230221416]
>
> 5a4d/solr/core/src/java/org/apache/solr/response/transform/ExplainAugmenterFacto
> ry.java#L111).
> As a result there are discrepancies between queries like -
> [http://localhost:8983/solr/collection1/select?q=*:*&collection=collectionName&wt]
> =json&fl=[explain style=nl],score&rq=\{!ltr model=linear-model}
> [http://localhost:8983/solr/collection1/select?q=*:*&collection=collectionName&wt]
> =json&fl=score&rq=\{!ltr model=linear-model}&debugQuery=true
> the former outputs the explain from the SimilarityScorer's explain while the
> latter uses the correct LtR ModelScorer's explain.
> There are a few other problems with the explain augmenter - for eg. it
> doesn't
> work with grouping (although the other doc transformers like LtR's
> LTRFeatureLoggerTransformerFactory work with grouping)
> Mailing List -
>
> http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201901.mbox/%3C5C3879D702C30144003902B0_0_18802%40msllnjpmsgsv06%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13143) Output from ExplainAugmenterFactory and DebugQuery for rerank queries is not same
[
https://issues.apache.org/jira/browse/SOLR-13143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16746478#comment-16746478
]
Lucene/Solr QA commented on SOLR-13143:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
49s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 50s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 40m 8s{color}
| {color:red} core in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 46m 31s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.search.TestReRankQParserPlugin |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13143 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12955252/bug.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon
Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 6326800 |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | 1.8.0_191 |
| unit |
https://builds.apache.org/job/PreCommit-SOLR-Build/264/artifact/out/patch-unit-solr_core.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/264/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/264/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Output from ExplainAugmenterFactory and DebugQuery for rerank queries is not
> same
> -
>
> Key: SOLR-13143
> URL: https://issues.apache.org/jira/browse/SOLR-13143
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: search
>Affects Versions: 7.5
>Reporter: Sambhav Kothari
>Priority: Minor
> Attachments: bug.patch
>
>
> Currently, if we use the ExplainAugmenterFactory with LtR, instead of using
> the
> model/re-rankers explain method, it uses the default query explain (tf-idf
> explanation). This happens because the BasicResultContext doesn't wrap the
>
> query([https://github.com/apache/lucene-solr/blob/1d85cd783863f75cea133fb9c452302]
>
> 214165a4d/solr/core/src/java/org/apache/solr/response/BasicResultContext.java#L6
> 7) with the RankQuery when its set to context's query, which is then used by
> the ExplainAugmenterFactory.
>
> ([https://github.com/apache/lucene-solr/blob/1d85cd783863f75cea133fb9c45230221416]
>
> 5a4d/solr/core/src/java/org/apache/solr/response/transform/ExplainAugmenterFacto
> ry.java#L111).
> As a result there are discrepancies between queries like -
> [http://localhost:8983/solr/collection1/select?q=*:*&collection=collectionName&wt]
> =json&fl=[explain style=nl],score&rq=\{!ltr model=linear-model}
> [http://localhost:8983/solr/collection1/select?q=*:*&collection=collectionName&wt]
> =json&fl=score&rq=\{!ltr model=linear-model}&debugQuery=true
> the former outputs the explain from the SimilarityScorer's explain while the
> latter uses the correct LtR ModelScorer's explain.
> There are a few other problems with the explain augmenter - for eg. it
> doesn't
> work with grouping (although the other doc transformers like LtR's
> LTRFeatureLoggerTransformerFacto
[jira] [Commented] (SOLR-13143) Output from ExplainAugmenterFactory and DebugQuery for rerank queries is not same
[
https://issues.apache.org/jira/browse/SOLR-13143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745425#comment-16745425
]
Sambhav Kothari commented on SOLR-13143:
They are in the same ballpark, but different issues IMHO. The scores are
correct for re-ranking. It was only the explain doc transformer that was giving
the wrong output.
> Output from ExplainAugmenterFactory and DebugQuery for rerank queries is not
> same
> -
>
> Key: SOLR-13143
> URL: https://issues.apache.org/jira/browse/SOLR-13143
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: search
>Affects Versions: 7.5
>Reporter: Sambhav Kothari
>Priority: Minor
> Attachments: bug.patch
>
>
> Currently, if we use the ExplainAugmenterFactory with LtR, instead of using
> the
> model/re-rankers explain method, it uses the default query explain (tf-idf
> explanation). This happens because the BasicResultContext doesn't wrap the
>
> query([https://github.com/apache/lucene-solr/blob/1d85cd783863f75cea133fb9c452302]
>
> 214165a4d/solr/core/src/java/org/apache/solr/response/BasicResultContext.java#L6
> 7) with the RankQuery when its set to context's query, which is then used by
> the ExplainAugmenterFactory.
>
> ([https://github.com/apache/lucene-solr/blob/1d85cd783863f75cea133fb9c45230221416]
>
> 5a4d/solr/core/src/java/org/apache/solr/response/transform/ExplainAugmenterFacto
> ry.java#L111).
> As a result there are discrepancies between queries like -
> [http://localhost:8983/solr/collection1/select?q=*:*&collection=collectionName&wt]
> =json&fl=[explain style=nl],score&rq=\{!ltr model=linear-model}
> [http://localhost:8983/solr/collection1/select?q=*:*&collection=collectionName&wt]
> =json&fl=score&rq=\{!ltr model=linear-model}&debugQuery=true
> the former outputs the explain from the SimilarityScorer's explain while the
> latter uses the correct LtR ModelScorer's explain.
> There are a few other problems with the explain augmenter - for eg. it
> doesn't
> work with grouping (although the other doc transformers like LtR's
> LTRFeatureLoggerTransformerFactory work with grouping)
> Mailing List -
>
> http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201901.mbox/%3C5C3879D702C30144003902B0_0_18802%40msllnjpmsgsv06%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13143) Output from ExplainAugmenterFactory and DebugQuery for rerank queries is not same
[
https://issues.apache.org/jira/browse/SOLR-13143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745387#comment-16745387
]
Erick Erickson commented on SOLR-13143:
---
Is this the same as SOLR-13126?
> Output from ExplainAugmenterFactory and DebugQuery for rerank queries is not
> same
> -
>
> Key: SOLR-13143
> URL: https://issues.apache.org/jira/browse/SOLR-13143
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: search
>Affects Versions: 7.5
>Reporter: Sambhav Kothari
>Priority: Minor
> Attachments: bug.patch
>
>
> Currently, if we use the ExplainAugmenterFactory with LtR, instead of using
> the
> model/re-rankers explain method, it uses the default query explain (tf-idf
> explanation). This happens because the BasicResultContext doesn't wrap the
>
> query([https://github.com/apache/lucene-solr/blob/1d85cd783863f75cea133fb9c452302]
>
> 214165a4d/solr/core/src/java/org/apache/solr/response/BasicResultContext.java#L6
> 7) with the RankQuery when its set to context's query, which is then used by
> the ExplainAugmenterFactory.
>
> ([https://github.com/apache/lucene-solr/blob/1d85cd783863f75cea133fb9c45230221416]
>
> 5a4d/solr/core/src/java/org/apache/solr/response/transform/ExplainAugmenterFacto
> ry.java#L111).
> As a result there are discrepancies between queries like -
> [http://localhost:8983/solr/collection1/select?q=*:*&collection=collectionName&wt]
> =json&fl=[explain style=nl],score&rq=\{!ltr model=linear-model}
> [http://localhost:8983/solr/collection1/select?q=*:*&collection=collectionName&wt]
> =json&fl=score&rq=\{!ltr model=linear-model}&debugQuery=true
> the former outputs the explain from the SimilarityScorer's explain while the
> latter uses the correct LtR ModelScorer's explain.
> There are a few other problems with the explain augmenter - for eg. it
> doesn't
> work with grouping (although the other doc transformers like LtR's
> LTRFeatureLoggerTransformerFactory work with grouping)
> Mailing List -
>
> http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201901.mbox/%3C5C3879D702C30144003902B0_0_18802%40msllnjpmsgsv06%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13143) Output from ExplainAugmenterFactory and DebugQuery for rerank queries is not same
[
https://issues.apache.org/jira/browse/SOLR-13143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745388#comment-16745388
]
Erick Erickson commented on SOLR-13143:
---
These are at least in the same ballpark.
> Output from ExplainAugmenterFactory and DebugQuery for rerank queries is not
> same
> -
>
> Key: SOLR-13143
> URL: https://issues.apache.org/jira/browse/SOLR-13143
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: search
>Affects Versions: 7.5
>Reporter: Sambhav Kothari
>Priority: Minor
> Attachments: bug.patch
>
>
> Currently, if we use the ExplainAugmenterFactory with LtR, instead of using
> the
> model/re-rankers explain method, it uses the default query explain (tf-idf
> explanation). This happens because the BasicResultContext doesn't wrap the
>
> query([https://github.com/apache/lucene-solr/blob/1d85cd783863f75cea133fb9c452302]
>
> 214165a4d/solr/core/src/java/org/apache/solr/response/BasicResultContext.java#L6
> 7) with the RankQuery when its set to context's query, which is then used by
> the ExplainAugmenterFactory.
>
> ([https://github.com/apache/lucene-solr/blob/1d85cd783863f75cea133fb9c45230221416]
>
> 5a4d/solr/core/src/java/org/apache/solr/response/transform/ExplainAugmenterFacto
> ry.java#L111).
> As a result there are discrepancies between queries like -
> [http://localhost:8983/solr/collection1/select?q=*:*&collection=collectionName&wt]
> =json&fl=[explain style=nl],score&rq=\{!ltr model=linear-model}
> [http://localhost:8983/solr/collection1/select?q=*:*&collection=collectionName&wt]
> =json&fl=score&rq=\{!ltr model=linear-model}&debugQuery=true
> the former outputs the explain from the SimilarityScorer's explain while the
> latter uses the correct LtR ModelScorer's explain.
> There are a few other problems with the explain augmenter - for eg. it
> doesn't
> work with grouping (although the other doc transformers like LtR's
> LTRFeatureLoggerTransformerFactory work with grouping)
> Mailing List -
>
> http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201901.mbox/%3C5C3879D702C30144003902B0_0_18802%40msllnjpmsgsv06%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13143) Output from ExplainAugmenterFactory and DebugQuery for rerank queries is not same
[
https://issues.apache.org/jira/browse/SOLR-13143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745178#comment-16745178
]
Sambhav Kothari commented on SOLR-13143:
https://github.com/apache/lucene-solr/pull/539
> Output from ExplainAugmenterFactory and DebugQuery for rerank queries is not
> same
> -
>
> Key: SOLR-13143
> URL: https://issues.apache.org/jira/browse/SOLR-13143
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: search
>Affects Versions: 7.5
>Reporter: Sambhav Kothari
>Priority: Minor
> Attachments: bug.patch
>
>
> Currently, if we use the ExplainAugmenterFactory with LtR, instead of using
> the
> model/re-rankers explain method, it uses the default query explain (tf-idf
> explanation). This happens because the BasicResultContext doesn't wrap the
>
> query([https://github.com/apache/lucene-solr/blob/1d85cd783863f75cea133fb9c452302]
>
> 214165a4d/solr/core/src/java/org/apache/solr/response/BasicResultContext.java#L6
> 7) with the RankQuery when its set to context's query, which is then used by
> the ExplainAugmenterFactory.
>
> ([https://github.com/apache/lucene-solr/blob/1d85cd783863f75cea133fb9c45230221416]
>
> 5a4d/solr/core/src/java/org/apache/solr/response/transform/ExplainAugmenterFacto
> ry.java#L111).
> As a result there are discrepancies between queries like -
> [http://localhost:8983/solr/collection1/select?q=*:*&collection=collectionName&wt]
> =json&fl=[explain style=nl],score&rq=\{!ltr model=linear-model}
> [http://localhost:8983/solr/collection1/select?q=*:*&collection=collectionName&wt]
> =json&fl=score&rq=\{!ltr model=linear-model}&debugQuery=true
> the former outputs the explain from the SimilarityScorer's explain while the
> latter uses the correct LtR ModelScorer's explain.
> There are a few other problems with the explain augmenter - for eg. it
> doesn't
> work with grouping (although the other doc transformers like LtR's
> LTRFeatureLoggerTransformerFactory work with grouping)
> Mailing List -
>
> http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201901.mbox/%3C5C3879D702C30144003902B0_0_18802%40msllnjpmsgsv06%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13143) Output from ExplainAugmenterFactory and DebugQuery for rerank queries is not same
[
https://issues.apache.org/jira/browse/SOLR-13143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745004#comment-16745004
]
Sambhav Kothari commented on SOLR-13143:
Attaching the failing test as a patch.
> Output from ExplainAugmenterFactory and DebugQuery for rerank queries is not
> same
> -
>
> Key: SOLR-13143
> URL: https://issues.apache.org/jira/browse/SOLR-13143
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: search
>Affects Versions: 7.5
>Reporter: Sambhav Kothari
>Priority: Minor
> Labels: patch
> Attachments: bug.patch
>
>
> Currently, if we use the ExplainAugmenterFactory with LtR, instead of using
> the
> model/re-rankers explain method, it uses the default query explain (tf-idf
> explanation). This happens because the BasicResultContext doesn't wrap the
> query(https://github.com/apache/lucene-solr/blob/1d85cd783863f75cea133fb9c452302
> 214165a4d/solr/core/src/java/org/apache/solr/response/BasicResultContext.java#L6
> 7) with the RankQuery when its set to context's query, which is then used by
> the ExplainAugmenterFactory.
> (https://github.com/apache/lucene-solr/blob/1d85cd783863f75cea133fb9c45230221416
> 5a4d/solr/core/src/java/org/apache/solr/response/transform/ExplainAugmenterFacto
> ry.java#L111).
> As a result there are discrepancies between queries like -
> http://localhost:8983/solr/collection1/select?q=*:*&collection=collectionName&wt
> =json&fl=[explain style=nl],score&rq=\{!ltr model=linear-model}
> http://localhost:8983/solr/collection1/select?q=*:*&collection=collectionName&wt
> =json&fl=score&rq=\{!ltr model=linear-model}&debugQuery=true
> the former outputs the explain from the SimilarityScorer's explain while the
> latter uses the correct LtR ModelScorer's explain.
> There are a few other problems with the explain augmenter - for eg. it
> doesn't
> work with grouping (although the other doc transformers like LtR's
> LTRFeatureLoggerTransformerFactory work with grouping)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
