[jira] [Commented] (SOLR-13643) ResponseBuilder should provide accessors/setters for analytics response handling
[
https://issues.apache.org/jira/browse/SOLR-13643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894931#comment-16894931
]
Munendra S N commented on SOLR-13643:
-
{quote}I'm planning make these member variable private in master(9.0){quote}
This is not done. Probably, I will handle it in different jira
> ResponseBuilder should provide accessors/setters for analytics response
> handling
>
>
> Key: SOLR-13643
> URL: https://issues.apache.org/jira/browse/SOLR-13643
> Project: Solr
> Issue Type: Task
> Components: Response Writers
>Affects Versions: 8.1.1
>Reporter: Neal Sidhwaney
>Assignee: Munendra S N
>Priority: Trivial
> Fix For: 8.3
>
> Attachments:
> SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch,
> SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch, SOLR-13643.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Right now inside o.a.s.h.c.AnalyticsComponent.java, fields inside
> ResponseBuilder are accessed directly. Since they're in the same package,
> this is OK at compile tie. But when the Solr core and Analytics jars are
> loaded at runtime by Solr, they are done by different classloaders, which
> causes an IllegalAccessError during request handling. There must be soething
> different about y setup which is why I am running into this, but it seems
> like a good idea to abstract away the fields behinds setters/getters anyway.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13643) ResponseBuilder should provide accessors/setters for analytics response handling
[ https://issues.apache.org/jira/browse/SOLR-13643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894926#comment-16894926 ] ASF subversion and git services commented on SOLR-13643: Commit 64357bc913f6dfe2475294accced833a83b44340 in lucene-solr's branch refs/heads/branch_8x from Munendra S N [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=64357bc ] SOLR-13643:add Getter/Setter in ResponseBuilder to handle analytic res > ResponseBuilder should provide accessors/setters for analytics response > handling > > > Key: SOLR-13643 > URL: https://issues.apache.org/jira/browse/SOLR-13643 > Project: Solr > Issue Type: Task > Components: Response Writers >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Assignee: Munendra S N >Priority: Trivial > Attachments: > SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch, > SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch, SOLR-13643.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Right now inside o.a.s.h.c.AnalyticsComponent.java, fields inside > ResponseBuilder are accessed directly. Since they're in the same package, > this is OK at compile tie. But when the Solr core and Analytics jars are > loaded at runtime by Solr, they are done by different classloaders, which > causes an IllegalAccessError during request handling. There must be soething > different about y setup which is why I am running into this, but it seems > like a good idea to abstract away the fields behinds setters/getters anyway. > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13643) ResponseBuilder should provide accessors/setters for analytics response handling
[ https://issues.apache.org/jira/browse/SOLR-13643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894920#comment-16894920 ] ASF subversion and git services commented on SOLR-13643: Commit 9f74cb10d3f7e7a5b03d474a20152b88899aa6e9 in lucene-solr's branch refs/heads/master from Munendra S N [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=9f74cb1 ] SOLR-13643:add Getter/Setter in ResponseBuilder to handle analytic res > ResponseBuilder should provide accessors/setters for analytics response > handling > > > Key: SOLR-13643 > URL: https://issues.apache.org/jira/browse/SOLR-13643 > Project: Solr > Issue Type: Task > Components: Response Writers >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Assignee: Munendra S N >Priority: Trivial > Attachments: > SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch, > SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch, SOLR-13643.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Right now inside o.a.s.h.c.AnalyticsComponent.java, fields inside > ResponseBuilder are accessed directly. Since they're in the same package, > this is OK at compile tie. But when the Solr core and Analytics jars are > loaded at runtime by Solr, they are done by different classloaders, which > causes an IllegalAccessError during request handling. There must be soething > different about y setup which is why I am running into this, but it seems > like a good idea to abstract away the fields behinds setters/getters anyway. > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13643) ResponseBuilder should provide accessors/setters for analytics response handling
[
https://issues.apache.org/jira/browse/SOLR-13643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894532#comment-16894532
]
Lucene/Solr QA commented on SOLR-13643:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
34s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 35s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
3s{color} | {color:green} analytics in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 32m
42s{color} | {color:green} core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 42m 58s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13643 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12976037/SOLR-13643.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 4050ddc59b |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/510/testReport/ |
| modules | C: solr solr/contrib/analytics solr/core U: solr |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/510/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> ResponseBuilder should provide accessors/setters for analytics response
> handling
>
>
> Key: SOLR-13643
> URL: https://issues.apache.org/jira/browse/SOLR-13643
> Project: Solr
> Issue Type: Task
> Components: Response Writers
>Affects Versions: 8.1.1
>Reporter: Neal Sidhwaney
>Assignee: Munendra S N
>Priority: Trivial
> Attachments:
> SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch,
> SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch, SOLR-13643.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Right now inside o.a.s.h.c.AnalyticsComponent.java, fields inside
> ResponseBuilder are accessed directly. Since they're in the same package,
> this is OK at compile tie. But when the Solr core and Analytics jars are
> loaded at runtime by Solr, they are done by different classloaders, which
> causes an IllegalAccessError during request handling. There must be soething
> different about y setup which is why I am running into this, but it seems
> like a good idea to abstract away the fields behinds setters/getters anyway.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13643) ResponseBuilder should provide accessors/setters for analytics response handling
[ https://issues.apache.org/jira/browse/SOLR-13643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894318#comment-16894318 ] Neal Sidhwaney commented on SOLR-13643: --- The new names and making them private sounds good to me. Re: the type of _analyticsRequestManager. I'll admit I didn't have time to look back at the entire history of the code, but my best guess was that the methods in AnalyticsRequestComponent can't store state im AnalyticsRequestComponent to be referred to between calls to init/process, which is why they store it in ResponseBuilder. It may be somethin to abstrct away through an object that is passed to each call to init/prepare in the future) . But if ResponseBuilder knew about the types inside the analytics component, it would create a dependency from the core package on contrib. Thank you Munendra. Neal > ResponseBuilder should provide accessors/setters for analytics response > handling > > > Key: SOLR-13643 > URL: https://issues.apache.org/jira/browse/SOLR-13643 > Project: Solr > Issue Type: Task > Components: Response Writers >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Assignee: Munendra S N >Priority: Trivial > Attachments: > SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch, > SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch, SOLR-13643.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Right now inside o.a.s.h.c.AnalyticsComponent.java, fields inside > ResponseBuilder are accessed directly. Since they're in the same package, > this is OK at compile tie. But when the Solr core and Analytics jars are > loaded at runtime by Solr, they are done by different classloaders, which > causes an IllegalAccessError during request handling. There must be soething > different about y setup which is why I am running into this, but it seems > like a good idea to abstract away the fields behinds setters/getters anyway. > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13643) ResponseBuilder should provide accessors/setters for analytics response handling
[
https://issues.apache.org/jira/browse/SOLR-13643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894308#comment-16894308
]
Munendra S N commented on SOLR-13643:
-
[^SOLR-13643.patch]
[~nealsidhwaney]
Thanks for the patch.
Attaching a new patch with modified method names and changes entry.
Also, I'm planning make these member variable private in master(9.0). I'm also
not sure why {{_analyticsRequestManager}} is of type Object? when it is always
used analytics component.
Let me know if there are any suggestions.
> ResponseBuilder should provide accessors/setters for analytics response
> handling
>
>
> Key: SOLR-13643
> URL: https://issues.apache.org/jira/browse/SOLR-13643
> Project: Solr
> Issue Type: Task
> Components: Response Writers
>Affects Versions: 8.1.1
>Reporter: Neal Sidhwaney
>Priority: Trivial
> Attachments:
> SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch,
> SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch, SOLR-13643.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Right now inside o.a.s.h.c.AnalyticsComponent.java, fields inside
> ResponseBuilder are accessed directly. Since they're in the same package,
> this is OK at compile tie. But when the Solr core and Analytics jars are
> loaded at runtime by Solr, they are done by different classloaders, which
> causes an IllegalAccessError during request handling. There must be soething
> different about y setup which is why I am running into this, but it seems
> like a good idea to abstract away the fields behinds setters/getters anyway.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13643) ResponseBuilder should provide accessors/setters for analytics response handling
[
https://issues.apache.org/jira/browse/SOLR-13643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894241#comment-16894241
]
Lucene/Solr QA commented on SOLR-13643:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
36s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 34s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
57s{color} | {color:green} analytics in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 33m
19s{color} | {color:green} core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 43m 26s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13643 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12975999/SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch
|
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 4050ddc59b |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/507/testReport/ |
| modules | C: solr/contrib/analytics solr/core U: solr |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/507/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> ResponseBuilder should provide accessors/setters for analytics response
> handling
>
>
> Key: SOLR-13643
> URL: https://issues.apache.org/jira/browse/SOLR-13643
> Project: Solr
> Issue Type: Task
> Components: Response Writers
>Affects Versions: 8.1.1
>Reporter: Neal Sidhwaney
>Priority: Trivial
> Attachments:
> SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch,
> SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Right now inside o.a.s.h.c.AnalyticsComponent.java, fields inside
> ResponseBuilder are accessed directly. Since they're in the same package,
> this is OK at compile tie. But when the Solr core and Analytics jars are
> loaded at runtime by Solr, they are done by different classloaders, which
> causes an IllegalAccessError during request handling. There must be soething
> different about y setup which is why I am running into this, but it seems
> like a good idea to abstract away the fields behinds setters/getters anyway.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13643) ResponseBuilder should provide accessors/setters for analytics response handling
[ https://issues.apache.org/jira/browse/SOLR-13643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894070#comment-16894070 ] Neal Sidhwaney commented on SOLR-13643: --- FYI, no action necessary, but I updated the patch to apply against HEAD. Thanks, Neal > ResponseBuilder should provide accessors/setters for analytics response > handling > > > Key: SOLR-13643 > URL: https://issues.apache.org/jira/browse/SOLR-13643 > Project: Solr > Issue Type: Task > Components: Response Writers >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Trivial > Attachments: > SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch, > SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Right now inside o.a.s.h.c.AnalyticsComponent.java, fields inside > ResponseBuilder are accessed directly. Since they're in the same package, > this is OK at compile tie. But when the Solr core and Analytics jars are > loaded at runtime by Solr, they are done by different classloaders, which > causes an IllegalAccessError during request handling. There must be soething > different about y setup which is why I am running into this, but it seems > like a good idea to abstract away the fields behinds setters/getters anyway. > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13643) ResponseBuilder should provide accessors/setters for analytics response handling
[ https://issues.apache.org/jira/browse/SOLR-13643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891428#comment-16891428 ] Neal Sidhwaney commented on SOLR-13643: --- Hello - any chance of this being pusehd? Let me know if I can do anything else, thanks. > ResponseBuilder should provide accessors/setters for analytics response > handling > > > Key: SOLR-13643 > URL: https://issues.apache.org/jira/browse/SOLR-13643 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Response Writers >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Trivial > Attachments: > SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Right now inside o.a.s.h.c.AnalyticsComponent.java, fields inside > ResponseBuilder are accessed directly. Since they're in the same package, > this is OK at compile tie. But when the Solr core and Analytics jars are > loaded at runtime by Solr, they are done by different classloaders, which > causes an IllegalAccessError during request handling. There must be soething > different about y setup which is why I am running into this, but it seems > like a good idea to abstract away the fields behinds setters/getters anyway. > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13643) ResponseBuilder should provide accessors/setters for analytics response handling
[
https://issues.apache.org/jira/browse/SOLR-13643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889542#comment-16889542
]
Lucene/Solr QA commented on SOLR-13643:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
23s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 33s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
18s{color} | {color:green} analytics in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 32m
12s{color} | {color:green} core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 42m 22s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13643 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12975310/SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch
|
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / ebeae0c889 |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/504/testReport/ |
| modules | C: solr/contrib/analytics solr/core U: solr |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/504/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> ResponseBuilder should provide accessors/setters for analytics response
> handling
>
>
> Key: SOLR-13643
> URL: https://issues.apache.org/jira/browse/SOLR-13643
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Response Writers
>Affects Versions: 8.1.1
>Reporter: Neal Sidhwaney
>Priority: Trivial
> Attachments:
> SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Right now inside o.a.s.h.c.AnalyticsComponent.java, fields inside
> ResponseBuilder are accessed directly. Since they're in the same package,
> this is OK at compile tie. But when the Solr core and Analytics jars are
> loaded at runtime by Solr, they are done by different classloaders, which
> causes an IllegalAccessError during request handling. There must be soething
> different about y setup which is why I am running into this, but it seems
> like a good idea to abstract away the fields behinds setters/getters anyway.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
