[jira] [Commented] (SOLR-13693) Use strongly-typed setters for cache parameters
[ https://issues.apache.org/jira/browse/SOLR-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907311#comment-16907311 ] ASF subversion and git services commented on SOLR-13693: Commit c48a3cd9dcc20a124cb5eab2e3c17703c0c9e352 in lucene-solr's branch refs/heads/branch_8x from Andrzej Bialecki [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=c48a3cd ] SOLR-13693: Use strongly-typed setters for cache parameters. > Use strongly-typed setters for cache parameters > --- > > Key: SOLR-13693 > URL: https://issues.apache.org/jira/browse/SOLR-13693 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 8.3 >Reporter: Andrzej Bialecki >Assignee: Andrzej Bialecki >Priority: Major > Fix For: 8.3 > > Attachments: SOLR-13693.patch > > > SOLR-13558 added ability to modify cache parameters on the fly. It uses an > API similar to the originally proposed API in SOLR-13579. After several > iterations of that patch it became clear that the originally proposed > weakly-typed API should be replaced with a strongly-typed one. > Since it's a new API in 8.3 there are no back-compat considerations. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13693) Use strongly-typed setters for cache parameters
[ https://issues.apache.org/jira/browse/SOLR-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907286#comment-16907286 ] ASF subversion and git services commented on SOLR-13693: Commit a4ff429ab0b770e9dd3bcc275257f0478b6a1b35 in lucene-solr's branch refs/heads/master from Andrzej Bialecki [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=a4ff429 ] SOLR-13693: Use strongly-typed setters for cache parameters. > Use strongly-typed setters for cache parameters > --- > > Key: SOLR-13693 > URL: https://issues.apache.org/jira/browse/SOLR-13693 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 8.3 >Reporter: Andrzej Bialecki >Assignee: Andrzej Bialecki >Priority: Major > Fix For: 8.3 > > Attachments: SOLR-13693.patch > > > SOLR-13558 added ability to modify cache parameters on the fly. It uses an > API similar to the originally proposed API in SOLR-13579. After several > iterations of that patch it became clear that the originally proposed > weakly-typed API should be replaced with a strongly-typed one. > Since it's a new API in 8.3 there are no back-compat considerations. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13693) Use strongly-typed setters for cache parameters
[
https://issues.apache.org/jira/browse/SOLR-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907238#comment-16907238
]
Lucene/Solr QA commented on SOLR-13693:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
9s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 2m 0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 2m 0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 2m 0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 31m
29s{color} | {color:green} core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 38m 48s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13693 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12977595/SOLR-13693.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / cdeb294236 |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/530/testReport/ |
| modules | C: solr solr/core U: solr |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/530/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Use strongly-typed setters for cache parameters
> ---
>
> Key: SOLR-13693
> URL: https://issues.apache.org/jira/browse/SOLR-13693
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 8.3
>Reporter: Andrzej Bialecki
>Assignee: Andrzej Bialecki
>Priority: Major
> Fix For: 8.3
>
> Attachments: SOLR-13693.patch
>
>
> SOLR-13558 added ability to modify cache parameters on the fly. It uses an
> API similar to the originally proposed API in SOLR-13579. After several
> iterations of that patch it became clear that the originally proposed
> weakly-typed API should be replaced with a strongly-typed one.
> Since it's a new API in 8.3 there are no back-compat considerations.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13693) Use strongly-typed setters for cache parameters
[
https://issues.apache.org/jira/browse/SOLR-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906573#comment-16906573
]
Lucene/Solr QA commented on SOLR-13693:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
50s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 3m 36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 3m 36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 3m 36s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 51m
37s{color} | {color:green} core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 60m 26s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13693 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12977509/SOLR-13693.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 9e60473 |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | LTS |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/528/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/528/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Use strongly-typed setters for cache parameters
> ---
>
> Key: SOLR-13693
> URL: https://issues.apache.org/jira/browse/SOLR-13693
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 8.3
>Reporter: Andrzej Bialecki
>Assignee: Andrzej Bialecki
>Priority: Major
> Fix For: 8.3
>
> Attachments: SOLR-13693.patch
>
>
> SOLR-13558 added ability to modify cache parameters on the fly. It uses an
> API similar to the originally proposed API in SOLR-13579. After several
> iterations of that patch it became clear that the originally proposed
> weakly-typed API should be replaced with a strongly-typed one.
> Since it's a new API in 8.3 there are no back-compat considerations.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
