[jira] [Commented] (SOLR-2436) move uimaConfig to under the uima's update processor in solrconfig.xml
[
https://issues.apache.org/jira/browse/SOLR-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030256#comment-13030256
]
Koji Sekiguchi commented on SOLR-2436:
--
While I was reviewing my requirement:
http://www.lucidimagination.com/search/document/983a059d6d370ce/uima_fieldmappings_and_solr_dynamicfield
I found a bug that's been introduced in this ticket. I'd mentioned it at above
in this thread, but not corrected at the time.
Because a type can have multiple features, the mapping definition:
{code}
org.apache.uima.SentenceAnnotation
coveredText
sentence
{code}
should be:
{code}
org.apache.uima.SentenceAnnotation
coveredText
sentence
{code}
> move uimaConfig to under the uima's update processor in solrconfig.xml
> --
>
> Key: SOLR-2436
> URL: https://issues.apache.org/jira/browse/SOLR-2436
> Project: Solr
> Issue Type: Improvement
>Affects Versions: 3.1
>Reporter: Koji Sekiguchi
>Assignee: Koji Sekiguchi
>Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: SOLR-2436-3.patch, SOLR-2436.patch, SOLR-2436.patch,
> SOLR-2436.patch, SOLR-2436.patch, SOLR-2436_2.patch
>
>
> Solr contrib UIMA has its config just beneath . I think it should
> move to uima's update processor tag.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2436) move uimaConfig to under the uima's update processor in solrconfig.xml
[ https://issues.apache.org/jira/browse/SOLR-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024668#comment-13024668 ] Tommaso Teofili commented on SOLR-2436: --- Thanks Joji :) > move uimaConfig to under the uima's update processor in solrconfig.xml > -- > > Key: SOLR-2436 > URL: https://issues.apache.org/jira/browse/SOLR-2436 > Project: Solr > Issue Type: Improvement >Affects Versions: 3.1 >Reporter: Koji Sekiguchi >Assignee: Koji Sekiguchi >Priority: Minor > Fix For: 3.2, 4.0 > > Attachments: SOLR-2436-3.patch, SOLR-2436.patch, SOLR-2436.patch, > SOLR-2436.patch, SOLR-2436.patch, SOLR-2436_2.patch > > > Solr contrib UIMA has its config just beneath . I think it should > move to uima's update processor tag. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2436) move uimaConfig to under the uima's update processor in solrconfig.xml
[ https://issues.apache.org/jira/browse/SOLR-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023478#comment-13023478 ] Koji Sekiguchi commented on SOLR-2436: -- And now I realized there are files (aggregate-uima-config.xml and uima-fields.xml) under src/main/resources/solr/conf. Those seems to be sample config for alchemy api. Patch should include aggregate-uima-config.xml modified if we keep them. > move uimaConfig to under the uima's update processor in solrconfig.xml > -- > > Key: SOLR-2436 > URL: https://issues.apache.org/jira/browse/SOLR-2436 > Project: Solr > Issue Type: Improvement >Affects Versions: 3.1 >Reporter: Koji Sekiguchi >Priority: Minor > Attachments: SOLR-2436-3.patch, SOLR-2436.patch, SOLR-2436.patch, > SOLR-2436.patch, SOLR-2436_2.patch > > > Solr contrib UIMA has its config just beneath . I think it should > move to uima's update processor tag. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2436) move uimaConfig to under the uima's update processor in solrconfig.xml
[ https://issues.apache.org/jira/browse/SOLR-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019715#comment-13019715 ] Uwe Schindler commented on SOLR-2436: - bq. When I did it, I missed something. Thank you for the alarm. The code in DataImporter.java and DataImportHandler.java is a very bad example because it also supports loading from StringReaders and such stuff solely for testing puposes. Because of this the code is very complicated and parts of it are in both files. The examples in Solr core are much better. > move uimaConfig to under the uima's update processor in solrconfig.xml > -- > > Key: SOLR-2436 > URL: https://issues.apache.org/jira/browse/SOLR-2436 > Project: Solr > Issue Type: Improvement >Affects Versions: 3.1 >Reporter: Koji Sekiguchi >Priority: Minor > Attachments: SOLR-2436-3.patch, SOLR-2436.patch, SOLR-2436.patch, > SOLR-2436.patch, SOLR-2436_2.patch > > > Solr contrib UIMA has its config just beneath . I think it should > move to uima's update processor tag. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2436) move uimaConfig to under the uima's update processor in solrconfig.xml
[ https://issues.apache.org/jira/browse/SOLR-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019713#comment-13019713 ] Tommaso Teofili commented on SOLR-2436: --- Thanks Uwe for the useful clarification regarding XML resources loading. I agree having such information on the wiki would be good. bq. If it is going to commit, it breaks back-compat. I think we need a note for users in CHANGES.txt. Yes, and we need to align the README and wiki too. > move uimaConfig to under the uima's update processor in solrconfig.xml > -- > > Key: SOLR-2436 > URL: https://issues.apache.org/jira/browse/SOLR-2436 > Project: Solr > Issue Type: Improvement >Affects Versions: 3.1 >Reporter: Koji Sekiguchi >Priority: Minor > Attachments: SOLR-2436-3.patch, SOLR-2436.patch, SOLR-2436.patch, > SOLR-2436.patch, SOLR-2436_2.patch > > > Solr contrib UIMA has its config just beneath . I think it should > move to uima's update processor tag. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2436) move uimaConfig to under the uima's update processor in solrconfig.xml
[ https://issues.apache.org/jira/browse/SOLR-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019652#comment-13019652 ] Koji Sekiguchi commented on SOLR-2436: -- The patch looks good, Tommaso! If it is going to commit, it breaks back-compat. I think we need a note for users in CHANGES.txt. > move uimaConfig to under the uima's update processor in solrconfig.xml > -- > > Key: SOLR-2436 > URL: https://issues.apache.org/jira/browse/SOLR-2436 > Project: Solr > Issue Type: Improvement >Affects Versions: 3.1 >Reporter: Koji Sekiguchi >Priority: Minor > Attachments: SOLR-2436-3.patch, SOLR-2436.patch, SOLR-2436.patch, > SOLR-2436.patch, SOLR-2436_2.patch > > > Solr contrib UIMA has its config just beneath . I think it should > move to uima's update processor tag. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2436) move uimaConfig to under the uima's update processor in solrconfig.xml
[ https://issues.apache.org/jira/browse/SOLR-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019649#comment-13019649 ] Koji Sekiguchi commented on SOLR-2436: -- Hi Uwe, The problematic snippet regarding XInclude handling has been first introduced in my patch that I borrowed from DIH. When I did it, I missed something. Thank you for the alarm. Now we are trying to embed the config in update processor instead of loading it from out of solrconfig.xml, the problematic snippet are gone. > move uimaConfig to under the uima's update processor in solrconfig.xml > -- > > Key: SOLR-2436 > URL: https://issues.apache.org/jira/browse/SOLR-2436 > Project: Solr > Issue Type: Improvement >Affects Versions: 3.1 >Reporter: Koji Sekiguchi >Priority: Minor > Attachments: SOLR-2436-3.patch, SOLR-2436.patch, SOLR-2436.patch, > SOLR-2436.patch, SOLR-2436_2.patch > > > Solr contrib UIMA has its config just beneath . I think it should > move to uima's update processor tag. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2436) move uimaConfig to under the uima's update processor in solrconfig.xml
[ https://issues.apache.org/jira/browse/SOLR-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019492#comment-13019492 ] Uwe Schindler commented on SOLR-2436: - bq. Or perhaps we need a utility method and pointer to that? That's a little bit out of scope. I was thinking about that, too, but there are too many different ways to parse XML (Stax, DocumentBuilder), so I did not do this. The new Resolver and Logging classes already handle those interface implementations for all types of parsing, just initializing the parsers should be in the caller's responsibility. Also XSL is different, so all of them use ResourceLoader, but their code is different. It is just important that you just *not* use the standard copy-paste from XML howtos. A similar code example like above can be shown for Stax and Transformers/Templates. I see no need to make helper classes. I will add to wiki later. > move uimaConfig to under the uima's update processor in solrconfig.xml > -- > > Key: SOLR-2436 > URL: https://issues.apache.org/jira/browse/SOLR-2436 > Project: Solr > Issue Type: Improvement >Affects Versions: 3.1 >Reporter: Koji Sekiguchi >Priority: Minor > Attachments: SOLR-2436-3.patch, SOLR-2436.patch, SOLR-2436.patch, > SOLR-2436.patch, SOLR-2436_2.patch > > > Solr contrib UIMA has its config just beneath . I think it should > move to uima's update processor tag. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2436) move uimaConfig to under the uima's update processor in solrconfig.xml
[ https://issues.apache.org/jira/browse/SOLR-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019476#comment-13019476 ] Mark Miller commented on SOLR-2436: --- Or perhaps we need a utility method and pointer to that? > move uimaConfig to under the uima's update processor in solrconfig.xml > -- > > Key: SOLR-2436 > URL: https://issues.apache.org/jira/browse/SOLR-2436 > Project: Solr > Issue Type: Improvement >Affects Versions: 3.1 >Reporter: Koji Sekiguchi >Priority: Minor > Attachments: SOLR-2436-3.patch, SOLR-2436.patch, SOLR-2436.patch, > SOLR-2436.patch, SOLR-2436_2.patch > > > Solr contrib UIMA has its config just beneath . I think it should > move to uima's update processor tag. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2436) move uimaConfig to under the uima's update processor in solrconfig.xml
[ https://issues.apache.org/jira/browse/SOLR-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019474#comment-13019474 ] Mark Miller commented on SOLR-2436: --- bq. Maybe we should add my last comment into the Wiki: +1 > move uimaConfig to under the uima's update processor in solrconfig.xml > -- > > Key: SOLR-2436 > URL: https://issues.apache.org/jira/browse/SOLR-2436 > Project: Solr > Issue Type: Improvement >Affects Versions: 3.1 >Reporter: Koji Sekiguchi >Priority: Minor > Attachments: SOLR-2436-3.patch, SOLR-2436.patch, SOLR-2436.patch, > SOLR-2436.patch, SOLR-2436_2.patch > > > Solr contrib UIMA has its config just beneath . I think it should > move to uima's update processor tag. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2436) move uimaConfig to under the uima's update processor in solrconfig.xml
[ https://issues.apache.org/jira/browse/SOLR-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019473#comment-13019473 ] Uwe Schindler commented on SOLR-2436: - Maybe we should add my last comment into the Wiki: "Howto load XML from Solr's config resources", to prevent broken code again from appearing (if this no issue here anymore this is fine, I was just alarmed). I had a hard time to fix all XML handling in Solr (DIH is still broken with charsets), but XInclude now works as expected everywhere. > move uimaConfig to under the uima's update processor in solrconfig.xml > -- > > Key: SOLR-2436 > URL: https://issues.apache.org/jira/browse/SOLR-2436 > Project: Solr > Issue Type: Improvement >Affects Versions: 3.1 >Reporter: Koji Sekiguchi >Priority: Minor > Attachments: SOLR-2436-3.patch, SOLR-2436.patch, SOLR-2436.patch, > SOLR-2436.patch, SOLR-2436_2.patch > > > Solr contrib UIMA has its config just beneath . I think it should > move to uima's update processor tag. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2436) move uimaConfig to under the uima's update processor in solrconfig.xml
[
https://issues.apache.org/jira/browse/SOLR-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019470#comment-13019470
]
Uwe Schindler commented on SOLR-2436:
-
Here is the new way to load XML from ResourceLoaders in Solr (taken from
Config). This code also intercepts errors and warnings and logs them correctly
(parsers tend to write them to System.err):
{code:java}
is = new InputSource(loader.openConfig(name));
is.setSystemId(SystemIdResolver.createSystemIdFromResourceName(name));
// only enable xinclude, if a SystemId is available
if (is.getSystemId() != null) {
try {
dbf.setXIncludeAware(true);
dbf.setNamespaceAware(true);
} catch(UnsupportedOperationException e) {
log.warn(name + " XML parser doesn't support XInclude option");
}
}
final DocumentBuilder db = dbf.newDocumentBuilder();
db.setEntityResolver(new SystemIdResolver(loader));
db.setErrorHandler(xmllog);
try {
doc = db.parse(is);
} finally {
// some XML parsers are broken and don't close the byte stream (but
they should according to spec)
IOUtils.closeQuietly(is.getByteStream());
}
{code}
> move uimaConfig to under the uima's update processor in solrconfig.xml
> --
>
> Key: SOLR-2436
> URL: https://issues.apache.org/jira/browse/SOLR-2436
> Project: Solr
> Issue Type: Improvement
>Affects Versions: 3.1
>Reporter: Koji Sekiguchi
>Priority: Minor
> Attachments: SOLR-2436-3.patch, SOLR-2436.patch, SOLR-2436.patch,
> SOLR-2436.patch, SOLR-2436_2.patch
>
>
> Solr contrib UIMA has its config just beneath . I think it should
> move to uima's update processor tag.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2436) move uimaConfig to under the uima's update processor in solrconfig.xml
[
https://issues.apache.org/jira/browse/SOLR-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019465#comment-13019465
]
Uwe Schindler commented on SOLR-2436:
-
I just looked at the patch, is the SOLR-2436_2.patch still active or replaced
by Kojis?
I ask because:
{noformat}
+try{
+ final InputSource is = new
InputSource(loader.openConfig(uimaConfigFile));
+ DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance();
+ // only enable xinclude, if SystemId is present (makes no sense
otherwise)
+ if (is.getSystemId() != null) {
+try {
+ dbf.setXIncludeAware(true);
+ dbf.setNamespaceAware(true);
+} catch( UnsupportedOperationException e ) {
+ LOG.warn( "XML parser doesn't support XInclude option" );
+}
+ }
{noformat}
This XInclude Handling is broken (the if-clause never gets executed). We have a
new framework that makes XML-Loading from ResourceLoaders working correct, even
with relative pathes! Just look at the example committed during the cleanup
issue (look at other places in solr where DocumentBuilders or XMLStreamReaders
are instantiated. The new Solr way to load such files is a special URI scheme
that is internally used to resolve ResourceLoader resources correctly (see
SOLR-1656).
The latest patch looks fine, it embeds the config directly, which seems much
more consistent.
> move uimaConfig to under the uima's update processor in solrconfig.xml
> --
>
> Key: SOLR-2436
> URL: https://issues.apache.org/jira/browse/SOLR-2436
> Project: Solr
> Issue Type: Improvement
>Affects Versions: 3.1
>Reporter: Koji Sekiguchi
>Priority: Minor
> Attachments: SOLR-2436-3.patch, SOLR-2436.patch, SOLR-2436.patch,
> SOLR-2436.patch, SOLR-2436_2.patch
>
>
> Solr contrib UIMA has its config just beneath . I think it should
> move to uima's update processor tag.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2436) move uimaConfig to under the uima's update processor in solrconfig.xml
[ https://issues.apache.org/jira/browse/SOLR-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019377#comment-13019377 ] Tommaso Teofili commented on SOLR-2436: --- Hello Koji, your patch seems fine to me from the functional point of view. Just, I don't think the SolrUIMAConfigurationReader should be emptied, I wouldn't remove it preferring to assign to it the simple responsibility of reading args without the previous explicit Node traversing but, as you did, using the "Solr way". I also made some fixes to remove warning while getting objects from the NamedList. > move uimaConfig to under the uima's update processor in solrconfig.xml > -- > > Key: SOLR-2436 > URL: https://issues.apache.org/jira/browse/SOLR-2436 > Project: Solr > Issue Type: Improvement >Affects Versions: 3.1 >Reporter: Koji Sekiguchi >Priority: Minor > Attachments: SOLR-2436-3.patch, SOLR-2436.patch, SOLR-2436.patch, > SOLR-2436.patch, SOLR-2436_2.patch > > > Solr contrib UIMA has its config just beneath . I think it should > move to uima's update processor tag. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2436) move uimaConfig to under the uima's update processor in solrconfig.xml
[ https://issues.apache.org/jira/browse/SOLR-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008793#comment-13008793 ] Tommaso Teofili commented on SOLR-2436: --- Thanks Koji, this was on my TODO list just after 3.1 (together with tests' enhance). I'll have a look at your patch and share my comments here. > move uimaConfig to under the uima's update processor in solrconfig.xml > -- > > Key: SOLR-2436 > URL: https://issues.apache.org/jira/browse/SOLR-2436 > Project: Solr > Issue Type: Improvement >Affects Versions: 3.1 >Reporter: Koji Sekiguchi >Priority: Minor > Attachments: SOLR-2436.patch > > > Solr contrib UIMA has its config just beneath . I think it should > move to uima's update processor tag. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2436) move uimaConfig to under the uima's update processor in solrconfig.xml
[ https://issues.apache.org/jira/browse/SOLR-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008735#comment-13008735 ] Koji Sekiguchi commented on SOLR-2436: -- And if I want to use a form of "/config/updateRequestProcessorChain[@name='uima']/processor/uimaConfig/...", UpdateRequestProcessorFactory need to get the name of the processor chain. This needs API change. > move uimaConfig to under the uima's update processor in solrconfig.xml > -- > > Key: SOLR-2436 > URL: https://issues.apache.org/jira/browse/SOLR-2436 > Project: Solr > Issue Type: Improvement >Affects Versions: 3.1 >Reporter: Koji Sekiguchi >Priority: Minor > Attachments: SOLR-2436.patch > > > Solr contrib UIMA has its config just beneath . I think it should > move to uima's update processor tag. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
