[jira] [Commented] (SOLR-2466) CommonsHttpSolrServer will retry a query even if _maxRetries is 0
[ https://issues.apache.org/jira/browse/SOLR-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019021#comment-13019021 ] Yonik Seeley commented on SOLR-2466: Hmmm, that's interesting. Does anyone know why we (CommonsHttpSolrServer) do retries when HttpClient already does them? Is there an advantage to doing it ourselves? CommonsHttpSolrServer will retry a query even if _maxRetries is 0 - Key: SOLR-2466 URL: https://issues.apache.org/jira/browse/SOLR-2466 Project: Solr Issue Type: Bug Components: clients - java Affects Versions: 1.4.1, 3.1, 4.0 Reporter: Tomás Fernández Löbbe The HttpClient library used by CommonsHttpSolrServer will retry by default 3 times a request that failed on the server side, even if the _maxRetries field of CommonsHttpSolrServer is set to 0. The retry count should be managed in just one place and CommonsHttpSolrServer seems to be the right one. CommonsHttpSolrServer should override that HttpClient default to 0 retries, and manage the retry count with the value of the field _maxRetries. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2466) CommonsHttpSolrServer will retry a query even if _maxRetries is 0
[ https://issues.apache.org/jira/browse/SOLR-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019028#comment-13019028 ] Tomás Fernández Löbbe commented on SOLR-2466: - Not sure why Solr does it on CommonsHttpSolrServer. I do think is important to be able to specify the exact number of retries. CommonsHttpSolrServer will retry a query even if _maxRetries is 0 - Key: SOLR-2466 URL: https://issues.apache.org/jira/browse/SOLR-2466 Project: Solr Issue Type: Bug Components: clients - java Affects Versions: 1.4.1, 3.1, 4.0 Reporter: Tomás Fernández Löbbe The HttpClient library used by CommonsHttpSolrServer will retry by default 3 times a request that failed on the server side, even if the _maxRetries field of CommonsHttpSolrServer is set to 0. The retry count should be managed in just one place and CommonsHttpSolrServer seems to be the right one. CommonsHttpSolrServer should override that HttpClient default to 0 retries, and manage the retry count with the value of the field _maxRetries. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2466) CommonsHttpSolrServer will retry a query even if _maxRetries is 0
[ https://issues.apache.org/jira/browse/SOLR-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019030#comment-13019030 ] Hoss Man commented on SOLR-2466: I haven't checked hte code but if i remember correctly (from another project) HttpClient and it's RetryHandler hook are only used when dealing with *network* failures -- ie: connection refused, connection timeout, connection aborted. If a request is a success at the TCP layer, but a failure at the HTTP layer (ie: 500) then you need your own retry logic external to the HttpClient that may be what SolrJ is doing, to account for transient errors (ie: trying to add during a blocking commit or something like that) CommonsHttpSolrServer will retry a query even if _maxRetries is 0 - Key: SOLR-2466 URL: https://issues.apache.org/jira/browse/SOLR-2466 Project: Solr Issue Type: Bug Components: clients - java Affects Versions: 1.4.1, 3.1, 4.0 Reporter: Tomás Fernández Löbbe The HttpClient library used by CommonsHttpSolrServer will retry by default 3 times a request that failed on the server side, even if the _maxRetries field of CommonsHttpSolrServer is set to 0. The retry count should be managed in just one place and CommonsHttpSolrServer seems to be the right one. CommonsHttpSolrServer should override that HttpClient default to 0 retries, and manage the retry count with the value of the field _maxRetries. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
