[jira] [Commented] (SOLR-3039) ExtendedDismaxQParser should allow for extension of parsing-related behavior
[ https://issues.apache.org/jira/browse/SOLR-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554274#comment-13554274 ] Danny Dvinov commented on SOLR-3039: Thank you, [~otis] and [~tomasflobbe], looked at Tomas' patch, and looks like it pretty much covers everything I was suggesting (and further improves the refactoring!). The only thing we won't be able to do out of the box is decide on whether or not a particular clause should be included/excluded while in splitIntoClauses (includeClause method from this suggested patch), but I suppose this is minor, and we could either override entire splitIntoClauses or just apply a minor patch to accomplish this. Thank you for looking into this! > ExtendedDismaxQParser should allow for extension of parsing-related behavior > > > Key: SOLR-3039 > URL: https://issues.apache.org/jira/browse/SOLR-3039 > Project: Solr > Issue Type: Improvement > Components: query parsers >Affects Versions: 5.0 >Reporter: Danny Dvinov >Priority: Minor > Labels: edismax, parser, parsing > Fix For: 5.0 > > Attachments: SOLR-3039.patch, SOLR-3039.patch, SOLR-3039.patch, > SOLR-3039.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > ExtendedDismaxQParser.parse does not currently allow for things like query > pre-processing prior to its parsing, specifying the parser to be used, and > whether particular clause should be included in the query being parsed. > Furthermore, ExtendedDismaxQParser and inner ExtendedSolrQueryParser cannot > be subclassed. By resolving this issue, we'll provide a way for Solr > implementations to extend the parser and parsing related behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3039) ExtendedDismaxQParser should allow for extension of parsing-related behavior
[ https://issues.apache.org/jira/browse/SOLR-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553967#comment-13553967 ] Otis Gospodnetic commented on SOLR-3039: [~ddvinov] maybe you can close after you've confirmed? > ExtendedDismaxQParser should allow for extension of parsing-related behavior > > > Key: SOLR-3039 > URL: https://issues.apache.org/jira/browse/SOLR-3039 > Project: Solr > Issue Type: Improvement > Components: query parsers >Affects Versions: 5.0 >Reporter: Danny Dvinov >Priority: Minor > Labels: edismax, parser, parsing > Fix For: 5.0 > > Attachments: SOLR-3039.patch, SOLR-3039.patch, SOLR-3039.patch, > SOLR-3039.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > ExtendedDismaxQParser.parse does not currently allow for things like query > pre-processing prior to its parsing, specifying the parser to be used, and > whether particular clause should be included in the query being parsed. > Furthermore, ExtendedDismaxQParser and inner ExtendedSolrQueryParser cannot > be subclassed. By resolving this issue, we'll provide a way for Solr > implementations to extend the parser and parsing related behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3039) ExtendedDismaxQParser should allow for extension of parsing-related behavior
[ https://issues.apache.org/jira/browse/SOLR-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553622#comment-13553622 ] Tomás Fernández Löbbe commented on SOLR-3039: - Yes, it looks like this patch is based on an older revision, prior to SOLR-4208. Most of the things that are suggested here were implemented and committed. I didn't add a "preProecessUserQuery(...)", I thought about this, but I think now it is something easier to extend now (either wrapping the parse method, overriding the "getString()" method, when parsing the configuration, when getting the different clauses, depending on the needs). I didn't thought it was necessary to add an empty hook for this. > ExtendedDismaxQParser should allow for extension of parsing-related behavior > > > Key: SOLR-3039 > URL: https://issues.apache.org/jira/browse/SOLR-3039 > Project: Solr > Issue Type: Improvement > Components: query parsers >Affects Versions: 5.0 >Reporter: Danny Dvinov >Priority: Minor > Labels: edismax, parser, parsing > Fix For: 5.0 > > Attachments: SOLR-3039.patch, SOLR-3039.patch, SOLR-3039.patch, > SOLR-3039.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > ExtendedDismaxQParser.parse does not currently allow for things like query > pre-processing prior to its parsing, specifying the parser to be used, and > whether particular clause should be included in the query being parsed. > Furthermore, ExtendedDismaxQParser and inner ExtendedSolrQueryParser cannot > be subclassed. By resolving this issue, we'll provide a way for Solr > implementations to extend the parser and parsing related behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3039) ExtendedDismaxQParser should allow for extension of parsing-related behavior
[ https://issues.apache.org/jira/browse/SOLR-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553455#comment-13553455 ] Otis Gospodnetic commented on SOLR-3039: Haven't looked at the patch but I suspect it might be in conflict with [~tomasflobbe]'s SOLR-4208. Oh, maybe not, SOLR-4208 was committed... assuming Danny based his latest patch on the more recent trunk revision? I'm eyeing this with LUCENE-4499 in mind. > ExtendedDismaxQParser should allow for extension of parsing-related behavior > > > Key: SOLR-3039 > URL: https://issues.apache.org/jira/browse/SOLR-3039 > Project: Solr > Issue Type: Improvement > Components: query parsers >Affects Versions: 5.0 >Reporter: Danny Dvinov >Priority: Minor > Labels: edismax, parser, parsing > Fix For: 5.0 > > Attachments: SOLR-3039.patch, SOLR-3039.patch, SOLR-3039.patch, > SOLR-3039.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > ExtendedDismaxQParser.parse does not currently allow for things like query > pre-processing prior to its parsing, specifying the parser to be used, and > whether particular clause should be included in the query being parsed. > Furthermore, ExtendedDismaxQParser and inner ExtendedSolrQueryParser cannot > be subclassed. By resolving this issue, we'll provide a way for Solr > implementations to extend the parser and parsing related behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3039) ExtendedDismaxQParser should allow for extension of parsing-related behavior
[ https://issues.apache.org/jira/browse/SOLR-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553382#comment-13553382 ] Danny Dvinov commented on SOLR-3039: Please feel free to make comments/suggestions! > ExtendedDismaxQParser should allow for extension of parsing-related behavior > > > Key: SOLR-3039 > URL: https://issues.apache.org/jira/browse/SOLR-3039 > Project: Solr > Issue Type: Improvement > Components: query parsers >Affects Versions: 5.0 >Reporter: Danny Dvinov >Priority: Minor > Labels: edismax, parser, parsing > Fix For: 5.0 > > Attachments: SOLR-3039.patch, SOLR-3039.patch, SOLR-3039.patch, > SOLR-3039.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > ExtendedDismaxQParser.parse does not currently allow for things like query > pre-processing prior to its parsing, specifying the parser to be used, and > whether particular clause should be included in the query being parsed. > Furthermore, ExtendedDismaxQParser and inner ExtendedSolrQueryParser cannot > be subclassed. By resolving this issue, we'll provide a way for Solr > implementations to extend the parser and parsing related behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3039) ExtendedDismaxQParser should allow for extension of parsing-related behavior
[ https://issues.apache.org/jira/browse/SOLR-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483476#comment-13483476 ] Danny Dvinov commented on SOLR-3039: All comments are more than welcome btw! > ExtendedDismaxQParser should allow for extension of parsing-related behavior > > > Key: SOLR-3039 > URL: https://issues.apache.org/jira/browse/SOLR-3039 > Project: Solr > Issue Type: Improvement > Components: query parsers >Affects Versions: 5.0 >Reporter: Danny Dvinov >Priority: Minor > Labels: edismax, parser, parsing > Fix For: 5.0 > > Attachments: SOLR-3039.patch, SOLR-3039.patch, SOLR-3039.patch, > SOLR-3039.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > ExtendedDismaxQParser.parse does not currently allow for things like query > pre-processing prior to its parsing, specifying the parser to be used, and > whether particular clause should be included in the query being parsed. > Furthermore, ExtendedDismaxQParser and inner ExtendedSolrQueryParser cannot > be subclassed. By resolving this issue, we'll provide a way for Solr > implementations to extend the parser and parsing related behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
