[jira] [Commented] (SOLR-3093) Remove unused features boolTofilterOptimizer and HashDocSet
[ https://issues.apache.org/jira/browse/SOLR-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13218240#comment-13218240 ] Jan Høydahl commented on SOLR-3093: --- Mark, can you comment on the boolToFilterOptimizer code you commented out? I plan to include this issue in SOLR-1052 since it's all about cleaning up config parsing. Remove unused features boolTofilterOptimizer and HashDocSet --- Key: SOLR-3093 URL: https://issues.apache.org/jira/browse/SOLR-3093 Project: Solr Issue Type: Improvement Reporter: Jan Høydahl Assignee: Jan Høydahl Fix For: 3.6, 4.0 SolrConfig.java still tries to parse boolTofilterOptimizer But the only user of this param was SolrIndexSearcher.java line 366-381 which is commented out. Probably the whole logic should be ripped out, and we fail hard if we find this config option in solrconfig.xml Also, the HashDocSet config option is old and no longer used or needed? There is some code which tries to use it but I believe that since 1.4 there are more efficient ways to do the same. Should we also fail-fast if found in config or only print a warning? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3093) Remove unused features boolTofilterOptimizer and HashDocSet
[ https://issues.apache.org/jira/browse/SOLR-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13199768#comment-13199768 ] Yonik Seeley commented on SOLR-3093: bq. and we fail hard if we find this config option in solrconfig.xml It's just an optimization, so no need to fail. Just remove all traces completely IMO. Remove unused features boolTofilterOptimizer and HashDocSet --- Key: SOLR-3093 URL: https://issues.apache.org/jira/browse/SOLR-3093 Project: Solr Issue Type: Improvement Reporter: Jan Høydahl Fix For: 3.6, 4.0 SolrConfig.java still tries to parse boolTofilterOptimizer But the only user of this param was SolrIndexSearcher.java line 366-381 which is commented out. Probably the whole logic should be ripped out, and we fail hard if we find this config option in solrconfig.xml Also, the HashDocSet config option is old and no longer used or needed? There is some code which tries to use it but I believe that since 1.4 there are more efficient ways to do the same. Should we also fail-fast if found in config or only print a warning? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3093) Remove unused features boolTofilterOptimizer and HashDocSet
[ https://issues.apache.org/jira/browse/SOLR-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13199784#comment-13199784 ] Tommaso Teofili commented on SOLR-3093: --- bq. There is some code which tries to use it but I believe that since 1.4 there are more efficient ways to do the same. Should we also fail-fast if found in config or only print a warning? IMHO we should print a warning for 3.x and fail fast from 4 on. Remove unused features boolTofilterOptimizer and HashDocSet --- Key: SOLR-3093 URL: https://issues.apache.org/jira/browse/SOLR-3093 Project: Solr Issue Type: Improvement Reporter: Jan Høydahl Fix For: 3.6, 4.0 SolrConfig.java still tries to parse boolTofilterOptimizer But the only user of this param was SolrIndexSearcher.java line 366-381 which is commented out. Probably the whole logic should be ripped out, and we fail hard if we find this config option in solrconfig.xml Also, the HashDocSet config option is old and no longer used or needed? There is some code which tries to use it but I believe that since 1.4 there are more efficient ways to do the same. Should we also fail-fast if found in config or only print a warning? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3093) Remove unused features boolTofilterOptimizer and HashDocSet
[ https://issues.apache.org/jira/browse/SOLR-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13199789#comment-13199789 ] Jan Høydahl commented on SOLR-3093: --- Is there any use at all in the HashDocSet config any more? Should code related to this also be removed? I agree with Tommaso that fail fast is better, not to fool =1.3 users who modify their old schema to believe that these settings have any effect at all, see discussion in SOLR-1052. Remove unused features boolTofilterOptimizer and HashDocSet --- Key: SOLR-3093 URL: https://issues.apache.org/jira/browse/SOLR-3093 Project: Solr Issue Type: Improvement Reporter: Jan Høydahl Fix For: 3.6, 4.0 SolrConfig.java still tries to parse boolTofilterOptimizer But the only user of this param was SolrIndexSearcher.java line 366-381 which is commented out. Probably the whole logic should be ripped out, and we fail hard if we find this config option in solrconfig.xml Also, the HashDocSet config option is old and no longer used or needed? There is some code which tries to use it but I believe that since 1.4 there are more efficient ways to do the same. Should we also fail-fast if found in config or only print a warning? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3093) Remove unused features boolTofilterOptimizer and HashDocSet
[ https://issues.apache.org/jira/browse/SOLR-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13199930#comment-13199930 ] Hoss Man commented on SOLR-3093: I think yonik's point is that unlike things in SOLR-1052 where existing users would have a reasonable expectation that the syntax would definitively do something (ie: use specific classes/settings), the config in this issue was _always_ just an optimization hint, and the system ultimately works fine even if/when it is ignored. Personally i think that in these cases, it would be sufficient to WARN that these optimization hints are no longer used and being ignored so people can clean up if/when they want, but since they don't *have* to change anything to have a working solr instance (that still externally behaves the way it would in older versions of solr) there's no reason to FAIL and annoy them. Remove unused features boolTofilterOptimizer and HashDocSet --- Key: SOLR-3093 URL: https://issues.apache.org/jira/browse/SOLR-3093 Project: Solr Issue Type: Improvement Reporter: Jan Høydahl Fix For: 3.6, 4.0 SolrConfig.java still tries to parse boolTofilterOptimizer But the only user of this param was SolrIndexSearcher.java line 366-381 which is commented out. Probably the whole logic should be ripped out, and we fail hard if we find this config option in solrconfig.xml Also, the HashDocSet config option is old and no longer used or needed? There is some code which tries to use it but I believe that since 1.4 there are more efficient ways to do the same. Should we also fail-fast if found in config or only print a warning? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3093) Remove unused features boolTofilterOptimizer and HashDocSet
[ https://issues.apache.org/jira/browse/SOLR-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13199945#comment-13199945 ] Jan Høydahl commented on SOLR-3093: --- Yea, we'll go for a WARN for these ones. Besides, it *is* nice that it's possible to drop-in upgrade war without upgrading config. Then when/if proper xsd validation comes around (SOLR-1758), I guess we'll need to tackle this and other similar cases again. Remove unused features boolTofilterOptimizer and HashDocSet --- Key: SOLR-3093 URL: https://issues.apache.org/jira/browse/SOLR-3093 Project: Solr Issue Type: Improvement Reporter: Jan Høydahl Fix For: 3.6, 4.0 SolrConfig.java still tries to parse boolTofilterOptimizer But the only user of this param was SolrIndexSearcher.java line 366-381 which is commented out. Probably the whole logic should be ripped out, and we fail hard if we find this config option in solrconfig.xml Also, the HashDocSet config option is old and no longer used or needed? There is some code which tries to use it but I believe that since 1.4 there are more efficient ways to do the same. Should we also fail-fast if found in config or only print a warning? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3093) Remove unused features boolTofilterOptimizer and HashDocSet
[ https://issues.apache.org/jira/browse/SOLR-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13200177#comment-13200177 ] Jan Høydahl commented on SOLR-3093: --- @MarkMiller: Just to be suer... In [rev922957|http://svn.apache.org/viewvc?view=revisionrevision=922957] with commit message a hackey commit of stuff needed to get on lucene 3.0.1 :) you commented out the code in [SolrIndexSearcher|http://svn.apache.org/viewvc/lucene/solr/branches/solr/src/java/org/apache/solr/search/SolrIndexSearcher.java?r1=922957r2=922956pathrev=922957] related to LuceneQueryOptimizer to get it to compile. Was that intended as a permanent removal of the optimizer or did you plan to put it back? Do anyone *want* the optimizer back? Remove unused features boolTofilterOptimizer and HashDocSet --- Key: SOLR-3093 URL: https://issues.apache.org/jira/browse/SOLR-3093 Project: Solr Issue Type: Improvement Reporter: Jan Høydahl Fix For: 3.6, 4.0 SolrConfig.java still tries to parse boolTofilterOptimizer But the only user of this param was SolrIndexSearcher.java line 366-381 which is commented out. Probably the whole logic should be ripped out, and we fail hard if we find this config option in solrconfig.xml Also, the HashDocSet config option is old and no longer used or needed? There is some code which tries to use it but I believe that since 1.4 there are more efficient ways to do the same. Should we also fail-fast if found in config or only print a warning? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
