[jira] [Commented] (SOLR-4841) DetectedLanguage constructor should be public

2013-05-20 Thread Uwe Schindler (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-4841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13661991#comment-13661991
 ] 

Uwe Schindler commented on SOLR-4841:
-

protected should be enough!

 DetectedLanguage constructor should be public
 -

 Key: SOLR-4841
 URL: https://issues.apache.org/jira/browse/SOLR-4841
 Project: Solr
  Issue Type: Bug
Reporter: Maciej Lizewski

 org.apache.solr.update.processor.DetectedLanguage constructor should be 
 public. Without that it is impossible to create owne class extending 
 LanguageIdentifierUpdateProcessor.
 LanguageIdentifierUpdateProcessor base class needs detectLanguage(String 
 content) function to return listy of DetectedLanguage's but you cannot create 
 such objects because constructor is accessible only in same package 
 (org.apache.solr.update.processor).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-4841) DetectedLanguage constructor should be public

2013-05-20 Thread Maciej Lizewski (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-4841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13662013#comment-13662013
 ] 

Maciej Lizewski commented on SOLR-4841:
---

I am OK with that. My point was that it is impossible to extend 
LanguageIdentifierUpdateProcessor with own custom implementation, because 
constructor does not have any visibility modifier, so it is accessible only 
from same package.

 DetectedLanguage constructor should be public
 -

 Key: SOLR-4841
 URL: https://issues.apache.org/jira/browse/SOLR-4841
 Project: Solr
  Issue Type: Bug
Reporter: Maciej Lizewski

 org.apache.solr.update.processor.DetectedLanguage constructor should be 
 public. Without that it is impossible to create owne class extending 
 LanguageIdentifierUpdateProcessor.
 LanguageIdentifierUpdateProcessor base class needs detectLanguage(String 
 content) function to return listy of DetectedLanguage's but you cannot create 
 such objects because constructor is accessible only in same package 
 (org.apache.solr.update.processor).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org