[jira] [Commented] (SOLR-4842) Field faceting with local params affects successive field faceting parameters
[
https://issues.apache.org/jira/browse/SOLR-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663190#comment-13663190
]
Erik Hatcher commented on SOLR-4842:
Additional test case from Hoss picked up and committed. Committed to trunk
branch_4x, and lucene_solr_4_3
> Field faceting with local params affects successive field faceting parameters
> -
>
> Key: SOLR-4842
> URL: https://issues.apache.org/jira/browse/SOLR-4842
> Project: Solr
> Issue Type: Bug
> Components: search, SearchComponents - other
>Affects Versions: 4.3
>Reporter: Erik Hatcher
>Assignee: Erik Hatcher
>Priority: Critical
> Fix For: 5.0, 4.3.1
>
> Attachments: SOLR-4842__hoss_tests.patch, SOLR-4842.patch,
> SOLR-4842.patch, SOLR-4842.patch, SOLR-4842.patch
>
>
> SOLR-4717 introduced local param support for per-field faceting, allowing the
> same field to be faceted in various ways. There's a problem such that one
> fields local param setting will override the defaults of the next field. For
> example:
> {code}http://localhost:8983/solr/query?q=*:*&facet=true&rows=0&facet.field={!facet.prefix=a}name&facet.field=features{code}
> where the facet.prefix for name affects the features faceting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4842) Field faceting with local params affects successive field faceting parameters
[
https://issues.apache.org/jira/browse/SOLR-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663184#comment-13663184
]
Hoss Man commented on SOLR-4842:
bq. I was wondering if that change you made was needed at the time but no
tests were failing.
because there were no tests using range on the same field multiple ways mixed
with local params on only one of hte range facets. ie: same bug you found with
facet.prefix, but with any of hte facet.range.* params.
bq. I added your one-line tweak in there. If you added test cases in your patch
I didn't catch that yet.
yes, the patch had a additional tests demonstrating the reason why reseting
"required" was needed.
> Field faceting with local params affects successive field faceting parameters
> -
>
> Key: SOLR-4842
> URL: https://issues.apache.org/jira/browse/SOLR-4842
> Project: Solr
> Issue Type: Bug
> Components: search, SearchComponents - other
>Affects Versions: 4.3
>Reporter: Erik Hatcher
>Assignee: Erik Hatcher
>Priority: Critical
> Fix For: 5.0, 4.3.1
>
> Attachments: SOLR-4842__hoss_tests.patch, SOLR-4842.patch,
> SOLR-4842.patch, SOLR-4842.patch, SOLR-4842.patch
>
>
> SOLR-4717 introduced local param support for per-field faceting, allowing the
> same field to be faceted in various ways. There's a problem such that one
> fields local param setting will override the defaults of the next field. For
> example:
> {code}http://localhost:8983/solr/query?q=*:*&facet=true&rows=0&facet.field={!facet.prefix=a}name&facet.field=features{code}
> where the facet.prefix for name affects the features faceting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4842) Field faceting with local params affects successive field faceting parameters
[
https://issues.apache.org/jira/browse/SOLR-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663180#comment-13663180
]
Steve Rowe commented on SOLR-4842:
--
bq. I set the fix version ;) Erik, please do commit to the 43 branch.
:) - sorry guys, I misinterpreted the Erik's adding 5.0 as a fix version in
JIRA's All view, since it appears as if no fix version was previously set
(empty left-hand column), and both 4.3.1 and 5.0 are in the right-hand column.
> Field faceting with local params affects successive field faceting parameters
> -
>
> Key: SOLR-4842
> URL: https://issues.apache.org/jira/browse/SOLR-4842
> Project: Solr
> Issue Type: Bug
> Components: search, SearchComponents - other
>Affects Versions: 4.3
>Reporter: Erik Hatcher
>Assignee: Erik Hatcher
>Priority: Critical
> Fix For: 5.0, 4.3.1
>
> Attachments: SOLR-4842__hoss_tests.patch, SOLR-4842.patch,
> SOLR-4842.patch, SOLR-4842.patch, SOLR-4842.patch
>
>
> SOLR-4717 introduced local param support for per-field faceting, allowing the
> same field to be faceted in various ways. There's a problem such that one
> fields local param setting will override the defaults of the next field. For
> example:
> {code}http://localhost:8983/solr/query?q=*:*&facet=true&rows=0&facet.field={!facet.prefix=a}name&facet.field=features{code}
> where the facet.prefix for name affects the features faceting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4842) Field faceting with local params affects successive field faceting parameters
[
https://issues.apache.org/jira/browse/SOLR-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663169#comment-13663169
]
Yonik Seeley commented on SOLR-4842:
I set the fix version ;-) Erik, please do commit to the 43 branch.
> Field faceting with local params affects successive field faceting parameters
> -
>
> Key: SOLR-4842
> URL: https://issues.apache.org/jira/browse/SOLR-4842
> Project: Solr
> Issue Type: Bug
> Components: search, SearchComponents - other
>Affects Versions: 4.3
>Reporter: Erik Hatcher
>Assignee: Erik Hatcher
>Priority: Critical
> Fix For: 5.0, 4.3.1
>
> Attachments: SOLR-4842__hoss_tests.patch, SOLR-4842.patch,
> SOLR-4842.patch, SOLR-4842.patch, SOLR-4842.patch
>
>
> SOLR-4717 introduced local param support for per-field faceting, allowing the
> same field to be faceted in various ways. There's a problem such that one
> fields local param setting will override the defaults of the next field. For
> example:
> {code}http://localhost:8983/solr/query?q=*:*&facet=true&rows=0&facet.field={!facet.prefix=a}name&facet.field=features{code}
> where the facet.prefix for name affects the features faceting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4842) Field faceting with local params affects successive field faceting parameters
[
https://issues.apache.org/jira/browse/SOLR-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663168#comment-13663168
]
Steve Rowe commented on SOLR-4842:
--
bq. Committed to branch_4x and trunk. Is there any other branch where this
should go?
Erik, you set the fix version to 4.3.1, and in order for that to happen, this
has to be committed on the lucene_solr_4_3 branch, no?
> Field faceting with local params affects successive field faceting parameters
> -
>
> Key: SOLR-4842
> URL: https://issues.apache.org/jira/browse/SOLR-4842
> Project: Solr
> Issue Type: Bug
> Components: search, SearchComponents - other
>Affects Versions: 4.3
>Reporter: Erik Hatcher
>Assignee: Erik Hatcher
>Priority: Critical
> Fix For: 5.0, 4.3.1
>
> Attachments: SOLR-4842__hoss_tests.patch, SOLR-4842.patch,
> SOLR-4842.patch, SOLR-4842.patch, SOLR-4842.patch
>
>
> SOLR-4717 introduced local param support for per-field faceting, allowing the
> same field to be faceted in various ways. There's a problem such that one
> fields local param setting will override the defaults of the next field. For
> example:
> {code}http://localhost:8983/solr/query?q=*:*&facet=true&rows=0&facet.field={!facet.prefix=a}name&facet.field=features{code}
> where the facet.prefix for name affects the features faceting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4842) Field faceting with local params affects successive field faceting parameters
[
https://issues.apache.org/jira/browse/SOLR-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663162#comment-13663162
]
Erik Hatcher commented on SOLR-4842:
bq. Ugh ... i didn't realize how stateful param parsing had gotten i nthe
faceting code.
Yeah, icky it is.
bq. Erik's last patch had at least one bug remaining that affected range & date
faceting because of the need to reset the "required" params.
Hmmm... did you see a test failure? I was wondering if that change you made
was needed at the time but no tests were failing. I added your one-line tweak
in there. If you added test cases in your patch I didn't catch that yet.
Committed to branch_4x and trunk. Is there any other branch where this should
go?
> Field faceting with local params affects successive field faceting parameters
> -
>
> Key: SOLR-4842
> URL: https://issues.apache.org/jira/browse/SOLR-4842
> Project: Solr
> Issue Type: Bug
> Components: search, SearchComponents - other
>Affects Versions: 4.3
>Reporter: Erik Hatcher
>Assignee: Erik Hatcher
>Priority: Critical
> Fix For: 5.0, 4.3.1
>
> Attachments: SOLR-4842__hoss_tests.patch, SOLR-4842.patch,
> SOLR-4842.patch, SOLR-4842.patch, SOLR-4842.patch
>
>
> SOLR-4717 introduced local param support for per-field faceting, allowing the
> same field to be faceted in various ways. There's a problem such that one
> fields local param setting will override the defaults of the next field. For
> example:
> {code}http://localhost:8983/solr/query?q=*:*&facet=true&rows=0&facet.field={!facet.prefix=a}name&facet.field=features{code}
> where the facet.prefix for name affects the features faceting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4842) Field faceting with local params affects successive field faceting parameters
[
https://issues.apache.org/jira/browse/SOLR-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663117#comment-13663117
]
Yonik Seeley commented on SOLR-4842:
Patch looks good, commit it!
> Field faceting with local params affects successive field faceting parameters
> -
>
> Key: SOLR-4842
> URL: https://issues.apache.org/jira/browse/SOLR-4842
> Project: Solr
> Issue Type: Bug
> Components: search, SearchComponents - other
>Affects Versions: 4.3
>Reporter: Erik Hatcher
>Assignee: Erik Hatcher
>Priority: Critical
> Fix For: 5.0, 4.3.1
>
> Attachments: SOLR-4842__hoss_tests.patch, SOLR-4842.patch,
> SOLR-4842.patch, SOLR-4842.patch, SOLR-4842.patch
>
>
> SOLR-4717 introduced local param support for per-field faceting, allowing the
> same field to be faceted in various ways. There's a problem such that one
> fields local param setting will override the defaults of the next field. For
> example:
> {code}http://localhost:8983/solr/query?q=*:*&facet=true&rows=0&facet.field={!facet.prefix=a}name&facet.field=features{code}
> where the facet.prefix for name affects the features faceting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4842) Field faceting with local params affects successive field faceting parameters
[
https://issues.apache.org/jira/browse/SOLR-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663056#comment-13663056
]
Yonik Seeley commented on SOLR-4842:
Confirmed bug w/ simple test on example data:
{code}
http://localhost:8983/solr/query?q=*:*&facet=true&rows=0&facet.field={!facet.prefix=a}name&facet.field=features
{code}
The features constraints returned all start with "a" only.
> Field faceting with local params affects successive field faceting parameters
> -
>
> Key: SOLR-4842
> URL: https://issues.apache.org/jira/browse/SOLR-4842
> Project: Solr
> Issue Type: Bug
> Components: search, SearchComponents - other
>Affects Versions: 4.3
>Reporter: Erik Hatcher
>Assignee: Erik Hatcher
>Priority: Critical
> Attachments: SOLR-4842__hoss_tests.patch, SOLR-4842.patch,
> SOLR-4842.patch, SOLR-4842.patch
>
>
> SOLR-4717 introduced local param support for per-field faceting, allowing the
> same field to be faceted in various ways. There's a problem such that one
> fields local param setting will override the defaults of the next field. For
> example: {code}facet.field={!key=foo facet.mincount=1
> facet.missing=false}field&facet.field={!key=bar
> facet.missing=true}field{code} causes the "bar" faceting to use
> facet.mincount=1 when it should use the default of 0.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4842) Field faceting with local params affects successive field faceting parameters
[
https://issues.apache.org/jira/browse/SOLR-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663048#comment-13663048
]
Erik Hatcher commented on SOLR-4842:
bq. I'm running the full test suite now and will await Hoss' review (and maybe
Ryan's eyes too?) before committing.
Fresh branch_4x checkout with just this patch attached, "ant test" (from solr/
directory) gives me the following failures:
{code}
[junit4:junit4] Tests with failures:
[junit4:junit4] -
org.apache.solr.cloud.CollectionsAPIDistributedZkTest.testDistribSearch
[junit4:junit4] -
org.apache.solr.cloud.ZkCLITest.testUpConfigLinkConfigClearZk
{code}
I can only presume this is unrelated to this patch.
> Field faceting with local params affects successive field faceting parameters
> -
>
> Key: SOLR-4842
> URL: https://issues.apache.org/jira/browse/SOLR-4842
> Project: Solr
> Issue Type: Bug
> Components: search, SearchComponents - other
>Affects Versions: 4.3
>Reporter: Erik Hatcher
>Assignee: Erik Hatcher
>Priority: Critical
> Attachments: SOLR-4842__hoss_tests.patch, SOLR-4842.patch,
> SOLR-4842.patch, SOLR-4842.patch
>
>
> SOLR-4717 introduced local param support for per-field faceting, allowing the
> same field to be faceted in various ways. There's a problem such that one
> fields local param setting will override the defaults of the next field. For
> example: {code}facet.field={!key=foo facet.mincount=1
> facet.missing=false}field&facet.field={!key=bar
> facet.missing=true}field{code} causes the "bar" faceting to use
> facet.mincount=1 when it should use the default of 0.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4842) Field faceting with local params affects successive field faceting parameters
[
https://issues.apache.org/jira/browse/SOLR-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13662646#comment-13662646
]
Hoss Man commented on SOLR-4842:
Erik: ok, now looking at your test, i think it's just flawed.
Ignore for a minute the issue of faceting multiple ways, ignore the "foo" key
in the assertQ your patch modifies, ignore everything about it, delete it from
the test, and just consider a query using only the "bar" key like so...
{noformat}
assertQ("ignore foo, look at bar",
req("q", "id:[42 TO 47]"
,"facet", "true"
,"facet.zeros", "false"
,"fq", "id:[42 TO 45]"
,"facet.field", "{!key=bar " +
"facet.missing=true "+
"}"+fname
)
,"*[count(//doc)=4]"
,"*[count(//lst[@name='bar']/int)=5]"
,"//lst[@name='bar']/int[not(@name)][.='1']"
);
{noformat}
That test is still going to fail because facet.zeros=false but you are
asserting that there should be 5 terms for "bar". the only way there could be
5 terms is if you include the terms with a zero.
I don't think the docs have never really specified what happens if you mix and
match "facet.mincount" with the deprecated "facet.zeros" (ie:
"facet.mincount=1&facet.zeros=true&facet.field=XXX"), let alone in the case of
per-field overrides (ie:
"facet.mincount=1&f.XXX.facet.zeros=true&facet.field=XXX") -- i think it's fair
game to say all bets are off in the new situation of localparams. but in this
specific case, there's no way it makes sense to think that the "bar" key should
have a mincount of "0".
> Field faceting with local params affects successive field faceting parameters
> -
>
> Key: SOLR-4842
> URL: https://issues.apache.org/jira/browse/SOLR-4842
> Project: Solr
> Issue Type: Bug
> Components: search, SearchComponents - other
>Affects Versions: 4.3
>Reporter: Erik Hatcher
>Assignee: Erik Hatcher
>Priority: Critical
> Attachments: SOLR-4842__hoss_tests.patch, SOLR-4842.patch
>
>
> SOLR-4717 introduced local param support for per-field faceting, allowing the
> same field to be faceted in various ways. There's a problem such that one
> fields local param setting will override the defaults of the next field. For
> example: {code}facet.field={!key=foo facet.mincount=1
> facet.missing=false}field&facet.field={!key=bar
> facet.missing=true}field{code} causes the "bar" faceting to use
> facet.mincount=1 when it should use the default of 0.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4842) Field faceting with local params affects successive field faceting parameters
[
https://issues.apache.org/jira/browse/SOLR-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13662580#comment-13662580
]
Erik Hatcher commented on SOLR-4842:
I'm not sure my patch actually shows the problem clearly yet. facet.mincount
and deprecated facet.zeros support still in there confuse things a bit. I'm
still working through a test case showing the issue clearly.
> Field faceting with local params affects successive field faceting parameters
> -
>
> Key: SOLR-4842
> URL: https://issues.apache.org/jira/browse/SOLR-4842
> Project: Solr
> Issue Type: Bug
> Components: search, SearchComponents - other
>Affects Versions: 4.3
>Reporter: Erik Hatcher
>Assignee: Erik Hatcher
>Priority: Critical
> Attachments: SOLR-4842.patch
>
>
> SOLR-4717 introduced local param support for per-field faceting, allowing the
> same field to be faceted in various ways. There's a problem such that one
> fields local param setting will override the defaults of the next field. For
> example: {code}facet.field={!key=foo facet.mincount=1
> facet.missing=false}field&facet.field={!key=bar
> facet.missing=true}field{code} causes the "bar" faceting to use
> facet.mincount=1 when it should use the default of 0.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
