[jira] [Commented] (SOLR-4919) Allow setting ResponseParser and RequestWriter on LBHttpSolrServer
[
https://issues.apache.org/jira/browse/SOLR-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660692#comment-16660692
]
Jason Gerlowski commented on SOLR-4919:
---
Modern LBHttpSolrClient has a {{setParser}} and a {{setRequestWriter}} method
to achieve this, unless I miss the point of this JIRA. I imagine this can be
closed. Will close in a few days unless anyone corrects me.
> Allow setting ResponseParser and RequestWriter on LBHttpSolrServer
> --
>
> Key: SOLR-4919
> URL: https://issues.apache.org/jira/browse/SOLR-4919
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
>Affects Versions: 4.3
>Reporter: Shawn Heisey
>Assignee: Shawn Heisey
>Priority: Minor
> Fix For: 4.9, 6.0
>
> Attachments: SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch,
> SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch,
> SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch,
> SolrExampleJettyTest-testfail.txt,
> SolrExampleStreamingTest-failure-linux.txt,
> TestReplicationHandler-testfail.txt
>
>
> Patch to allow setting parser/writer on LBHttpSolrServer. Will only work if
> no server objects exist within. Part of larger issue SOLR-4715.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4919) Allow setting ResponseParser and RequestWriter on LBHttpSolrServer
[ https://issues.apache.org/jira/browse/SOLR-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117543#comment-14117543 ] Shawn Heisey commented on SOLR-4919: Looks like my patch was about constructors, not methods. I did think of something only related by a tangent, so it probably needs a new issue: Should setParser and setRequestWriter throw UnsupportedOperationException (or some other descendant of RunTimeException)) if the LB object already contains HttpSolrServer objects? > Allow setting ResponseParser and RequestWriter on LBHttpSolrServer > -- > > Key: SOLR-4919 > URL: https://issues.apache.org/jira/browse/SOLR-4919 > Project: Solr > Issue Type: Improvement > Components: clients - java >Affects Versions: 4.3 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 4.9, 5.0 > > Attachments: SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SolrExampleJettyTest-testfail.txt, > SolrExampleStreamingTest-failure-linux.txt, > TestReplicationHandler-testfail.txt > > > Patch to allow setting parser/writer on LBHttpSolrServer. Will only work if > no server objects exist within. Part of larger issue SOLR-4715. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4919) Allow setting ResponseParser and RequestWriter on LBHttpSolrServer
[ https://issues.apache.org/jira/browse/SOLR-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116807#comment-14116807 ] David Smiley commented on SOLR-4919: The parser & writer methods *are* there now. Apparently it got in as part of SOLR-3249 which landed in Solr 4.5. Time to close this issue? > Allow setting ResponseParser and RequestWriter on LBHttpSolrServer > -- > > Key: SOLR-4919 > URL: https://issues.apache.org/jira/browse/SOLR-4919 > Project: Solr > Issue Type: Improvement > Components: clients - java >Affects Versions: 4.3 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 4.9, 5.0 > > Attachments: SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SolrExampleJettyTest-testfail.txt, > SolrExampleStreamingTest-failure-linux.txt, > TestReplicationHandler-testfail.txt > > > Patch to allow setting parser/writer on LBHttpSolrServer. Will only work if > no server objects exist within. Part of larger issue SOLR-4715. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4919) Allow setting ResponseParser and RequestWriter on LBHttpSolrServer
[ https://issues.apache.org/jira/browse/SOLR-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702465#comment-13702465 ] Shawn Heisey commented on SOLR-4919: All standard solr tests passed on latest trunk. I've only run the tests once so far. I will run them again, then add nightly, then weekly. > Allow setting ResponseParser and RequestWriter on LBHttpSolrServer > -- > > Key: SOLR-4919 > URL: https://issues.apache.org/jira/browse/SOLR-4919 > Project: Solr > Issue Type: Improvement > Components: clients - java >Affects Versions: 4.3 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 5.0, 4.4 > > Attachments: SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SolrExampleJettyTest-testfail.txt, > SolrExampleStreamingTest-failure-linux.txt, > TestReplicationHandler-testfail.txt > > > Patch to allow setting parser/writer on LBHttpSolrServer. Will only work if > no server objects exist within. Part of larger issue SOLR-4715. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4919) Allow setting ResponseParser and RequestWriter on LBHttpSolrServer
[ https://issues.apache.org/jira/browse/SOLR-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682238#comment-13682238 ] Mark Miller commented on SOLR-4919: --- I'll take another pass over this today. > Allow setting ResponseParser and RequestWriter on LBHttpSolrServer > -- > > Key: SOLR-4919 > URL: https://issues.apache.org/jira/browse/SOLR-4919 > Project: Solr > Issue Type: Improvement > Components: clients - java >Affects Versions: 4.3 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 5.0, 4.4 > > Attachments: SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SOLR-4919.patch, SolrExampleJettyTest-testfail.txt, > SolrExampleStreamingTest-failure-linux.txt, > TestReplicationHandler-testfail.txt > > > Patch to allow setting parser/writer on LBHttpSolrServer. Will only work if > no server objects exist within. Part of larger issue SOLR-4715. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4919) Allow setting ResponseParser and RequestWriter on LBHttpSolrServer
[ https://issues.apache.org/jira/browse/SOLR-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681912#comment-13681912 ] Shawn Heisey commented on SOLR-4919: The email from Policeman Jenkins build #2885 that showed up earlier today looks very similar to two of the failures I've attached here, so perhaps those failures are not my patch after all. The ThreadLeakError in TestReplicationHandler is really mystifying. That one seems less likely to be connected to this patch. > Allow setting ResponseParser and RequestWriter on LBHttpSolrServer > -- > > Key: SOLR-4919 > URL: https://issues.apache.org/jira/browse/SOLR-4919 > Project: Solr > Issue Type: Improvement > Components: clients - java >Affects Versions: 4.3 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 5.0, 4.4 > > Attachments: SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SolrExampleJettyTest-testfail.txt, > SolrExampleStreamingTest-failure-linux.txt, > TestReplicationHandler-testfail.txt > > > Patch to allow setting parser/writer on LBHttpSolrServer. Will only work if > no server objects exist within. Part of larger issue SOLR-4715. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4919) Allow setting ResponseParser and RequestWriter on LBHttpSolrServer
[ https://issues.apache.org/jira/browse/SOLR-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681334#comment-13681334 ] Shawn Heisey commented on SOLR-4919: bq. What specific patch do I have to apply to get where you got these fails? The newest patch should do it. I am about to upload another patch, which if I did everything correctly last night, will only have some updates to javadocs. > Allow setting ResponseParser and RequestWriter on LBHttpSolrServer > -- > > Key: SOLR-4919 > URL: https://issues.apache.org/jira/browse/SOLR-4919 > Project: Solr > Issue Type: Improvement > Components: clients - java >Affects Versions: 4.3 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 5.0, 4.4 > > Attachments: SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SolrExampleJettyTest-testfail.txt, TestReplicationHandler-testfail.txt > > > Patch to allow setting parser/writer on LBHttpSolrServer. Will only work if > no server objects exist within. Part of larger issue SOLR-4715. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4919) Allow setting ResponseParser and RequestWriter on LBHttpSolrServer
[ https://issues.apache.org/jira/browse/SOLR-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681304#comment-13681304 ] Mark Miller commented on SOLR-4919: --- bq. If anyone has any insight into the attached failures, please let me know. What specific patch do I have to apply to get where you got these fails? > Allow setting ResponseParser and RequestWriter on LBHttpSolrServer > -- > > Key: SOLR-4919 > URL: https://issues.apache.org/jira/browse/SOLR-4919 > Project: Solr > Issue Type: Improvement > Components: clients - java >Affects Versions: 4.3 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 5.0, 4.4 > > Attachments: SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SolrExampleJettyTest-testfail.txt, TestReplicationHandler-testfail.txt > > > Patch to allow setting parser/writer on LBHttpSolrServer. Will only work if > no server objects exist within. Part of larger issue SOLR-4715. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4919) Allow setting ResponseParser and RequestWriter on LBHttpSolrServer
[ https://issues.apache.org/jira/browse/SOLR-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681300#comment-13681300 ] Mark Miller commented on SOLR-4919: --- bq. I would need to create a test to make sure. Yeah, thats the last issue I was going to bring up - we have no new tests yet that call these setters (at least that eclipse could find for me). bq. Right now I am hoping to get something in quickly I think we should try and get it right - if we just put this in to get something in, someone will start using these setters or something and then we will just pull them... Let's figure out what's going on with the test fails. > Allow setting ResponseParser and RequestWriter on LBHttpSolrServer > -- > > Key: SOLR-4919 > URL: https://issues.apache.org/jira/browse/SOLR-4919 > Project: Solr > Issue Type: Improvement > Components: clients - java >Affects Versions: 4.3 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 5.0, 4.4 > > Attachments: SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SolrExampleJettyTest-testfail.txt, TestReplicationHandler-testfail.txt > > > Patch to allow setting parser/writer on LBHttpSolrServer. Will only work if > no server objects exist within. Part of larger issue SOLR-4715. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4919) Allow setting ResponseParser and RequestWriter on LBHttpSolrServer
[ https://issues.apache.org/jira/browse/SOLR-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681296#comment-13681296 ] Shawn Heisey commented on SOLR-4919: I don't think there's anything wrong with changing both objects, except that it seems to cause the intermittent test failures. I can't tell whether my changes are the direct cause or whether they have revealed real bugs, but I do believe that my changes led to the failures. If anyone has any insight into the attached failures, please let me know. I took the setter approach initially because I was just trying to duplicate existing HttpSolrServer functionality. Now that I've been digging around for a while, I see why that approach wasn't taken from the beginning. Right now I am hoping to get something in quickly so [~joel.bernstein] can improve CloudSolrServer on SOLR-4816 without needing to internally extend LBHttpSolrServer. The setter approach seems to do that, although now that I think about it, I would need to create a test to make sure. > Allow setting ResponseParser and RequestWriter on LBHttpSolrServer > -- > > Key: SOLR-4919 > URL: https://issues.apache.org/jira/browse/SOLR-4919 > Project: Solr > Issue Type: Improvement > Components: clients - java >Affects Versions: 4.3 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 5.0, 4.4 > > Attachments: SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SolrExampleJettyTest-testfail.txt, TestReplicationHandler-testfail.txt > > > Patch to allow setting parser/writer on LBHttpSolrServer. Will only work if > no server objects exist within. Part of larger issue SOLR-4715. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4919) Allow setting ResponseParser and RequestWriter on LBHttpSolrServer
[ https://issues.apache.org/jira/browse/SOLR-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681219#comment-13681219 ] Mark Miller commented on SOLR-4919: --- bq. A constructor-based patch hits both LBHttpSolrServer and HttpSolrServer. What's wrong with that? Setters that can only be called in some situations without throwing an exception are pretty ugly little guys - this seems exactly what a construtor is for - what's the motivation for introducing these odd settlers? > Allow setting ResponseParser and RequestWriter on LBHttpSolrServer > -- > > Key: SOLR-4919 > URL: https://issues.apache.org/jira/browse/SOLR-4919 > Project: Solr > Issue Type: Improvement > Components: clients - java >Affects Versions: 4.3 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 5.0, 4.4 > > Attachments: SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SolrExampleJettyTest-testfail.txt, TestReplicationHandler-testfail.txt > > > Patch to allow setting parser/writer on LBHttpSolrServer. Will only work if > no server objects exist within. Part of larger issue SOLR-4715. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4919) Allow setting ResponseParser and RequestWriter on LBHttpSolrServer
[ https://issues.apache.org/jira/browse/SOLR-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13680920#comment-13680920 ] Shawn Heisey commented on SOLR-4919: I see what I did wrong with removeSolrServer. I was a little zealous. :) I will also incorporate the new constructors. My original goal with SOLR-4715 was to mirror (as much as possible) what can be done now with HttpSolrServer. In pursuit of that goal, I'm inclined to keep the setters, but I could be talked out of it if it's really considered a bad idea. > Allow setting ResponseParser and RequestWriter on LBHttpSolrServer > -- > > Key: SOLR-4919 > URL: https://issues.apache.org/jira/browse/SOLR-4919 > Project: Solr > Issue Type: Improvement > Components: clients - java >Affects Versions: 4.3 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 5.0, 4.4 > > Attachments: SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SOLR-4919.patch > > > Patch to allow setting parser/writer on LBHttpSolrServer. Will only work if > no server objects exist within. Part of larger issue SOLR-4715. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4919) Allow setting ResponseParser and RequestWriter on LBHttpSolrServer
[ https://issues.apache.org/jira/browse/SOLR-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13680912#comment-13680912 ] Shawn Heisey commented on SOLR-4919: Thanks for the review. I do have a patch that changes the constructors, I was just trying to get this in so the patch for SOLR-4816 could be simplified. > Allow setting ResponseParser and RequestWriter on LBHttpSolrServer > -- > > Key: SOLR-4919 > URL: https://issues.apache.org/jira/browse/SOLR-4919 > Project: Solr > Issue Type: Improvement > Components: clients - java >Affects Versions: 4.3 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 5.0, 4.4 > > Attachments: SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SOLR-4919.patch > > > Patch to allow setting parser/writer on LBHttpSolrServer. Will only work if > no server objects exist within. Part of larger issue SOLR-4715. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4919) Allow setting ResponseParser and RequestWriter on LBHttpSolrServer
[ https://issues.apache.org/jira/browse/SOLR-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13680907#comment-13680907 ] Mark Miller commented on SOLR-4919: --- Shouldn't we just require setting the parser/writer in the constructor? I'm not sure I like this setter methods that only work under certain conditions - it seems much cleaner to require those in the constructor. I think we should change that, but as it is, the access of aliveServers.size should really be wrapped in a synchronized(aliveServers) block. > Allow setting ResponseParser and RequestWriter on LBHttpSolrServer > -- > > Key: SOLR-4919 > URL: https://issues.apache.org/jira/browse/SOLR-4919 > Project: Solr > Issue Type: Improvement > Components: clients - java >Affects Versions: 4.3 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 5.0, 4.4 > > Attachments: SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SOLR-4919.patch > > > Patch to allow setting parser/writer on LBHttpSolrServer. Will only work if > no server objects exist within. Part of larger issue SOLR-4715. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4919) Allow setting ResponseParser and RequestWriter on LBHttpSolrServer
[ https://issues.apache.org/jira/browse/SOLR-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13680904#comment-13680904 ] Mark Miller commented on SOLR-4919: --- Doing a quick review of the latest patch... QQ: the CHANGES entry says "CloudSolrServer and LBHttpSolrServer methods no longer claim to throw MalformedURLException." But, that exception is removed from the sig of LBHttpSolrServer#addSolrServer but is also added to the sig of LBHttpSolrServer#removeSolrServer. Shouldn't we keep it or remove it from *all* methods? > Allow setting ResponseParser and RequestWriter on LBHttpSolrServer > -- > > Key: SOLR-4919 > URL: https://issues.apache.org/jira/browse/SOLR-4919 > Project: Solr > Issue Type: Improvement > Components: clients - java >Affects Versions: 4.3 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 5.0, 4.4 > > Attachments: SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, > SOLR-4919.patch > > > Patch to allow setting parser/writer on LBHttpSolrServer. Will only work if > no server objects exist within. Part of larger issue SOLR-4715. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4919) Allow setting ResponseParser and RequestWriter on LBHttpSolrServer
[ https://issues.apache.org/jira/browse/SOLR-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13680689#comment-13680689 ] Shawn Heisey commented on SOLR-4919: In a later issue I intend to deprecate the constructors on various SolrServer implementations that currently take a parser and replace them with constructors that take a parser and a writer, but that can be done after this issue goes in. > Allow setting ResponseParser and RequestWriter on LBHttpSolrServer > -- > > Key: SOLR-4919 > URL: https://issues.apache.org/jira/browse/SOLR-4919 > Project: Solr > Issue Type: Improvement > Components: clients - java >Affects Versions: 4.3 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 5.0, 4.4 > > Attachments: SOLR-4919.patch, SOLR-4919.patch > > > Patch to allow setting parser/writer on LBHttpSolrServer. Will only work if > no server objects exist within. Part of larger issue SOLR-4715. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4919) Allow setting ResponseParser and RequestWriter on LBHttpSolrServer
[ https://issues.apache.org/jira/browse/SOLR-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13680685#comment-13680685 ] Mark Miller commented on SOLR-4919: --- We tend to be a bit more lax with the java apis than the http apis for back compat - especially since a lot of the java apis could still use improvement. Consider the affect of the change, is it worth the small hassle, and document well in CHANGES.txt. > Allow setting ResponseParser and RequestWriter on LBHttpSolrServer > -- > > Key: SOLR-4919 > URL: https://issues.apache.org/jira/browse/SOLR-4919 > Project: Solr > Issue Type: Improvement > Components: clients - java >Affects Versions: 4.3 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 5.0, 4.4 > > Attachments: SOLR-4919.patch, SOLR-4919.patch > > > Patch to allow setting parser/writer on LBHttpSolrServer. Will only work if > no server objects exist within. Part of larger issue SOLR-4715. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
