[jira] [Commented] (SOLR-5401) In Solr's ResourceLoader, add a check for @Deprecated annotation in the plugin/analysis/... class loading code, so we print a warning in the log if a deprecated factory
[ https://issues.apache.org/jira/browse/SOLR-5401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13810107#comment-13810107 ] Dawid Weiss commented on SOLR-5401: --- It would be better to add some form of a callback listener instead of capturing the whole thing. Solr logs are *huge* so capturing in memory will very likely OOM on many machines... > In Solr's ResourceLoader, add a check for @Deprecated annotation in the > plugin/analysis/... class loading code, so we print a warning in the log if a > deprecated factory class is used > -- > > Key: SOLR-5401 > URL: https://issues.apache.org/jira/browse/SOLR-5401 > Project: Solr > Issue Type: Improvement > Components: Schema and Analysis >Affects Versions: 3.6, 4.5 >Reporter: Uwe Schindler >Assignee: Uwe Schindler > Fix For: 4.6, 5.0 > > Attachments: SOLR-5401.patch > > > While changing an antique 3.6 schema.xml to Solr 4.5, I noticed that some > factories were deprecated in 3.x and were no longer available in 4.x (e.g. > "solr._Language_PorterStemFilterFactory"). If the user would have got a > notice before, this could have been prevented and user would have upgraded > before. > In fact the factories were @Deprecated in 3.6, but the Solr loader does not > print any warning. My proposal is to add some simple code to > SolrResourceLoader that it prints a warning about the deprecated class, if > any configuartion setting loads a class with @Deprecated warning. So we can > prevent that problem in the future. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5401) In Solr's ResourceLoader, add a check for @Deprecated annotation in the plugin/analysis/... class loading code, so we print a warning in the log if a deprecated factory
[ https://issues.apache.org/jira/browse/SOLR-5401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13810086#comment-13810086 ] Uwe Schindler commented on SOLR-5401: - [~jkrupan]: I will open another issue to make something for capturing log output from tests available in the solr-testframework package. If this is done, we can add the check for this issue. For now, the whole thing works and already prints some warnings in the dfeault Solr config, which should be cleaned up to be deprecation free (see SOLR-5404). > In Solr's ResourceLoader, add a check for @Deprecated annotation in the > plugin/analysis/... class loading code, so we print a warning in the log if a > deprecated factory class is used > -- > > Key: SOLR-5401 > URL: https://issues.apache.org/jira/browse/SOLR-5401 > Project: Solr > Issue Type: Improvement > Components: Schema and Analysis >Affects Versions: 3.6, 4.5 >Reporter: Uwe Schindler >Assignee: Uwe Schindler > Fix For: 4.6, 5.0 > > Attachments: SOLR-5401.patch > > > While changing an antique 3.6 schema.xml to Solr 4.5, I noticed that some > factories were deprecated in 3.x and were no longer available in 4.x (e.g. > "solr._Language_PorterStemFilterFactory"). If the user would have got a > notice before, this could have been prevented and user would have upgraded > before. > In fact the factories were @Deprecated in 3.6, but the Solr loader does not > print any warning. My proposal is to add some simple code to > SolrResourceLoader that it prints a warning about the deprecated class, if > any configuartion setting loads a class with @Deprecated warning. So we can > prevent that problem in the future. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5401) In Solr's ResourceLoader, add a check for @Deprecated annotation in the plugin/analysis/... class loading code, so we print a warning in the log if a deprecated factory
[ https://issues.apache.org/jira/browse/SOLR-5401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809183#comment-13809183 ] ASF subversion and git services commented on SOLR-5401: --- Commit 1537122 from [~thetaphi] in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1537122 ] Merged revision(s) 1537119 from lucene/dev/trunk: SOLR-5401: SolrResourceLoader logs a warning if a deprecated (factory) class is used in schema or config > In Solr's ResourceLoader, add a check for @Deprecated annotation in the > plugin/analysis/... class loading code, so we print a warning in the log if a > deprecated factory class is used > -- > > Key: SOLR-5401 > URL: https://issues.apache.org/jira/browse/SOLR-5401 > Project: Solr > Issue Type: Improvement > Components: Schema and Analysis >Affects Versions: 3.6, 4.5 >Reporter: Uwe Schindler >Assignee: Uwe Schindler > Fix For: 4.6, 5.0 > > Attachments: SOLR-5401.patch > > > While changing an antique 3.6 schema.xml to Solr 4.5, I noticed that some > factories were deprecated in 3.x and were no longer available in 4.x (e.g. > "solr._Language_PorterStemFilterFactory"). If the user would have got a > notice before, this could have been prevented and user would have upgraded > before. > In fact the factories were @Deprecated in 3.6, but the Solr loader does not > print any warning. My proposal is to add some simple code to > SolrResourceLoader that it prints a warning about the deprecated class, if > any configuartion setting loads a class with @Deprecated warning. So we can > prevent that problem in the future. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5401) In Solr's ResourceLoader, add a check for @Deprecated annotation in the plugin/analysis/... class loading code, so we print a warning in the log if a deprecated factory
[ https://issues.apache.org/jira/browse/SOLR-5401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809177#comment-13809177 ] ASF subversion and git services commented on SOLR-5401: --- Commit 1537119 from [~thetaphi] in branch 'dev/trunk' [ https://svn.apache.org/r1537119 ] SOLR-5401: SolrResourceLoader logs a warning if a deprecated (factory) class is used in schema or config > In Solr's ResourceLoader, add a check for @Deprecated annotation in the > plugin/analysis/... class loading code, so we print a warning in the log if a > deprecated factory class is used > -- > > Key: SOLR-5401 > URL: https://issues.apache.org/jira/browse/SOLR-5401 > Project: Solr > Issue Type: Improvement > Components: Schema and Analysis >Affects Versions: 3.6, 4.5 >Reporter: Uwe Schindler >Assignee: Uwe Schindler > Fix For: 4.6, 5.0 > > Attachments: SOLR-5401.patch > > > While changing an antique 3.6 schema.xml to Solr 4.5, I noticed that some > factories were deprecated in 3.x and were no longer available in 4.x (e.g. > "solr._Language_PorterStemFilterFactory"). If the user would have got a > notice before, this could have been prevented and user would have upgraded > before. > In fact the factories were @Deprecated in 3.6, but the Solr loader does not > print any warning. My proposal is to add some simple code to > SolrResourceLoader that it prints a warning about the deprecated class, if > any configuartion setting loads a class with @Deprecated warning. So we can > prevent that problem in the future. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5401) In Solr's ResourceLoader, add a check for @Deprecated annotation in the plugin/analysis/... class loading code, so we print a warning in the log if a deprecated factory
[ https://issues.apache.org/jira/browse/SOLR-5401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808551#comment-13808551 ] Jack Krupansky commented on SOLR-5401: -- I suspect that all the needed logic is sprinkled throughout the Solr logging API. Yes, probably way too much effort for this one test, but it would be good to have lots of other Solr features fully test their error and warning handling, so eventually this piece of test infrastructure would be valuable. > In Solr's ResourceLoader, add a check for @Deprecated annotation in the > plugin/analysis/... class loading code, so we print a warning in the log if a > deprecated factory class is used > -- > > Key: SOLR-5401 > URL: https://issues.apache.org/jira/browse/SOLR-5401 > Project: Solr > Issue Type: Improvement > Components: Schema and Analysis >Affects Versions: 3.6, 4.5 >Reporter: Uwe Schindler >Assignee: Uwe Schindler > Fix For: 4.6, 5.0 > > Attachments: SOLR-5401.patch > > > While changing an antique 3.6 schema.xml to Solr 4.5, I noticed that some > factories were deprecated in 3.x and were no longer available in 4.x (e.g. > "solr._Language_PorterStemFilterFactory"). If the user would have got a > notice before, this could have been prevented and user would have upgraded > before. > In fact the factories were @Deprecated in 3.6, but the Solr loader does not > print any warning. My proposal is to add some simple code to > SolrResourceLoader that it prints a warning about the deprecated class, if > any configuartion setting loads a class with @Deprecated warning. So we can > prevent that problem in the future. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5401) In Solr's ResourceLoader, add a check for @Deprecated annotation in the plugin/analysis/... class loading code, so we print a warning in the log if a deprecated factory
[ https://issues.apache.org/jira/browse/SOLR-5401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808541#comment-13808541 ] Uwe Schindler commented on SOLR-5401: - I think it is too much work for such a stupid test. I think I keep everything as in the patch. The test verifies that just nothing breaks. Everything else would be more complicated than the functionality added. :-) > In Solr's ResourceLoader, add a check for @Deprecated annotation in the > plugin/analysis/... class loading code, so we print a warning in the log if a > deprecated factory class is used > -- > > Key: SOLR-5401 > URL: https://issues.apache.org/jira/browse/SOLR-5401 > Project: Solr > Issue Type: Improvement > Components: Schema and Analysis >Affects Versions: 3.6, 4.5 >Reporter: Uwe Schindler >Assignee: Uwe Schindler > Fix For: 4.6, 5.0 > > Attachments: SOLR-5401.patch > > > While changing an antique 3.6 schema.xml to Solr 4.5, I noticed that some > factories were deprecated in 3.x and were no longer available in 4.x (e.g. > "solr._Language_PorterStemFilterFactory"). If the user would have got a > notice before, this could have been prevented and user would have upgraded > before. > In fact the factories were @Deprecated in 3.6, but the Solr loader does not > print any warning. My proposal is to add some simple code to > SolrResourceLoader that it prints a warning about the deprecated class, if > any configuartion setting loads a class with @Deprecated warning. So we can > prevent that problem in the future. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5401) In Solr's ResourceLoader, add a check for @Deprecated annotation in the plugin/analysis/... class loading code, so we print a warning in the log if a deprecated factory
[ https://issues.apache.org/jira/browse/SOLR-5401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808297#comment-13808297 ] Uwe Schindler commented on SOLR-5401: - [~jkrupan]: This test has no Solr running at all, so no way to access this. I think Dawid's idea is a good one, because the testing in solr already uses log4j. > In Solr's ResourceLoader, add a check for @Deprecated annotation in the > plugin/analysis/... class loading code, so we print a warning in the log if a > deprecated factory class is used > -- > > Key: SOLR-5401 > URL: https://issues.apache.org/jira/browse/SOLR-5401 > Project: Solr > Issue Type: Improvement > Components: Schema and Analysis >Affects Versions: 3.6, 4.5 >Reporter: Uwe Schindler >Assignee: Uwe Schindler > Fix For: 4.6, 5.0 > > Attachments: SOLR-5401.patch > > > While changing an antique 3.6 schema.xml to Solr 4.5, I noticed that some > factories were deprecated in 3.x and were no longer available in 4.x (e.g. > "solr._Language_PorterStemFilterFactory"). If the user would have got a > notice before, this could have been prevented and user would have upgraded > before. > In fact the factories were @Deprecated in 3.6, but the Solr loader does not > print any warning. My proposal is to add some simple code to > SolrResourceLoader that it prints a warning about the deprecated class, if > any configuartion setting loads a class with @Deprecated warning. So we can > prevent that problem in the future. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5401) In Solr's ResourceLoader, add a check for @Deprecated annotation in the plugin/analysis/... class loading code, so we print a warning in the log if a deprecated factory
[
https://issues.apache.org/jira/browse/SOLR-5401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808292#comment-13808292
]
Jack Krupansky commented on SOLR-5401:
--
Solr has a logging admin API that will return recent log entries.
For example:
{code}
curl
"http://localhost:8983/solr/admin/logging?threshold=WARN&test&since=0&indent=true";
{code}
More examples and the API parameters are in the admin API section of my e-book
that is currently in progress, but that isn't out yet. The source code is
currently your best guide: org.apache.solr.handler.admin.LoggingHandler.
> In Solr's ResourceLoader, add a check for @Deprecated annotation in the
> plugin/analysis/... class loading code, so we print a warning in the log if a
> deprecated factory class is used
> --
>
> Key: SOLR-5401
> URL: https://issues.apache.org/jira/browse/SOLR-5401
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
>Affects Versions: 3.6, 4.5
>Reporter: Uwe Schindler
>Assignee: Uwe Schindler
> Fix For: 4.6, 5.0
>
> Attachments: SOLR-5401.patch
>
>
> While changing an antique 3.6 schema.xml to Solr 4.5, I noticed that some
> factories were deprecated in 3.x and were no longer available in 4.x (e.g.
> "solr._Language_PorterStemFilterFactory"). If the user would have got a
> notice before, this could have been prevented and user would have upgraded
> before.
> In fact the factories were @Deprecated in 3.6, but the Solr loader does not
> print any warning. My proposal is to add some simple code to
> SolrResourceLoader that it prints a warning about the deprecated class, if
> any configuartion setting loads a class with @Deprecated warning. So we can
> prevent that problem in the future.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5401) In Solr's ResourceLoader, add a check for @Deprecated annotation in the plugin/analysis/... class loading code, so we print a warning in the log if a deprecated factory
[ https://issues.apache.org/jira/browse/SOLR-5401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808288#comment-13808288 ] Dawid Weiss commented on SOLR-5401: --- Don't know about solr but for other logging frameworks you attach a listener to the root logger (or the one you're interested in), intercept any log messages, then detach the listener and analyze the forked log contents. Works like a charm for Log4j, don't know if other frameworks have this. > In Solr's ResourceLoader, add a check for @Deprecated annotation in the > plugin/analysis/... class loading code, so we print a warning in the log if a > deprecated factory class is used > -- > > Key: SOLR-5401 > URL: https://issues.apache.org/jira/browse/SOLR-5401 > Project: Solr > Issue Type: Improvement > Components: Schema and Analysis >Affects Versions: 3.6, 4.5 >Reporter: Uwe Schindler >Assignee: Uwe Schindler > Fix For: 4.6, 5.0 > > Attachments: SOLR-5401.patch > > > While changing an antique 3.6 schema.xml to Solr 4.5, I noticed that some > factories were deprecated in 3.x and were no longer available in 4.x (e.g. > "solr._Language_PorterStemFilterFactory"). If the user would have got a > notice before, this could have been prevented and user would have upgraded > before. > In fact the factories were @Deprecated in 3.6, but the Solr loader does not > print any warning. My proposal is to add some simple code to > SolrResourceLoader that it prints a warning about the deprecated class, if > any configuartion setting loads a class with @Deprecated warning. So we can > prevent that problem in the future. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
