[jira] [Commented] (SOLR-5654) Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API
[ https://issues.apache.org/jira/browse/SOLR-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961170#comment-13961170 ] ASF subversion and git services commented on SOLR-5654: --- Commit 1585147 from sar...@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1585147 ] SOLR-5654: Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API (merged trunk r1584211) Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API -- Key: SOLR-5654 URL: https://issues.apache.org/jira/browse/SOLR-5654 Project: Solr Issue Type: Sub-task Components: Schema and Analysis Reporter: Steve Rowe Attachments: SOLR-5654.patch, SOLR-5654.patch, SOLR-5654.patch, SOLR-5654.patch, SOLR-5654.patch A synonym filter factory could be (re)configurable via REST API by registering with the RESTManager described in SOLR-5653, and then responding to REST API calls to modify its init params and its synonyms resource file. Read-only (GET) REST API calls should also be provided, both for init params and the synonyms resource file. It should be possible to add/remove/modify one or more entries in the synonyms resource file. We should probably use JSON for the REST request body, as is done in the Schema REST API methods. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5654) Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API
[ https://issues.apache.org/jira/browse/SOLR-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961171#comment-13961171 ] ASF subversion and git services commented on SOLR-5654: --- Commit 1585148 from sar...@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1585148 ] SOLR-5654: Add CHANGES.txt entry Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API -- Key: SOLR-5654 URL: https://issues.apache.org/jira/browse/SOLR-5654 Project: Solr Issue Type: Sub-task Components: Schema and Analysis Reporter: Steve Rowe Attachments: SOLR-5654.patch, SOLR-5654.patch, SOLR-5654.patch, SOLR-5654.patch, SOLR-5654.patch A synonym filter factory could be (re)configurable via REST API by registering with the RESTManager described in SOLR-5653, and then responding to REST API calls to modify its init params and its synonyms resource file. Read-only (GET) REST API calls should also be provided, both for init params and the synonyms resource file. It should be possible to add/remove/modify one or more entries in the synonyms resource file. We should probably use JSON for the REST request body, as is done in the Schema REST API methods. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5654) Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API
[ https://issues.apache.org/jira/browse/SOLR-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13958312#comment-13958312 ] ASF subversion and git services commented on SOLR-5654: --- Commit 1584211 from [~steve_rowe] in branch 'dev/trunk' [ https://svn.apache.org/r1584211 ] SOLR-5654: Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API -- Key: SOLR-5654 URL: https://issues.apache.org/jira/browse/SOLR-5654 Project: Solr Issue Type: Sub-task Components: Schema and Analysis Reporter: Steve Rowe Attachments: SOLR-5654.patch, SOLR-5654.patch, SOLR-5654.patch, SOLR-5654.patch, SOLR-5654.patch A synonym filter factory could be (re)configurable via REST API by registering with the RESTManager described in SOLR-5653, and then responding to REST API calls to modify its init params and its synonyms resource file. Read-only (GET) REST API calls should also be provided, both for init params and the synonyms resource file. It should be possible to add/remove/modify one or more entries in the synonyms resource file. We should probably use JSON for the REST request body, as is done in the Schema REST API methods. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5654) Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API
[ https://issues.apache.org/jira/browse/SOLR-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13931253#comment-13931253 ] Timothy Potter commented on SOLR-5654: -- One other thing to notice is that I had to copy-and-paste re-use the getIgnoreCase methods from ManagedWordSetResource. Be better to make that static and re-use it in the synonym code? Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API -- Key: SOLR-5654 URL: https://issues.apache.org/jira/browse/SOLR-5654 Project: Solr Issue Type: Sub-task Components: Schema and Analysis Reporter: Steve Rowe Attachments: SOLR-5654.patch, SOLR-5654.patch, SOLR-5654.patch A synonym filter factory could be (re)configurable via REST API by registering with the RESTManager described in SOLR-5653, and then responding to REST API calls to modify its init params and its synonyms resource file. Read-only (GET) REST API calls should also be provided, both for init params and the synonyms resource file. It should be possible to add/remove/modify one or more entries in the synonyms resource file. We should probably use JSON for the REST request body, as is done in the Schema REST API methods. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5654) Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API
[ https://issues.apache.org/jira/browse/SOLR-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13900369#comment-13900369 ] Yonik Seeley commented on SOLR-5654: Cool stuff! Can you give some examples of the full URLs? Do they match the JSON storage format? Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API -- Key: SOLR-5654 URL: https://issues.apache.org/jira/browse/SOLR-5654 Project: Solr Issue Type: Sub-task Components: Schema and Analysis Reporter: Steve Rowe Attachments: SOLR-5654.patch A synonym filter factory could be (re)configurable via REST API by registering with the RESTManager described in SOLR-5653, and then responding to REST API calls to modify its init params and its synonyms resource file. Read-only (GET) REST API calls should also be provided, both for init params and the synonyms resource file. It should be possible to add/remove/modify one or more entries in the synonyms resource file. We should probably use JSON for the REST request body, as is done in the Schema REST API methods. -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5654) Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API
[
https://issues.apache.org/jira/browse/SOLR-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13900570#comment-13900570
]
Timothy Potter commented on SOLR-5654:
--
Thanks Yonik. Here are some examples:
In schema.xml, you'd activate this using something like:
fieldType name=managed_en class=solr.TextField
positionIncrementGap=100
analyzer
tokenizer class=solr.StandardTokenizerFactory/
filter
class=org.apache.solr.rest.schema.analysis.ManagedSynonymFilterFactory
managed=english /
/analyzer
/fieldType
GET a list of managed synonym mappings for managed handle english using:
curl -i -v
http://localhost:8984/solr/collection/schema/analysis/synonyms/english
This would return a JSON structure that looks like (which is pretty much the
same as the JSON backed storage structure):
{
initArgs: {
ignoreCase:true,
format:solr
},
managedMap: {
GB:[ GiB, Gigabyte],
TV:[Television],
happy:[ glad, joyful]
}
}
btw ... I'm not in love the with managedMap or managedList thing so am open to
suggestions. My thinking there was that the property name gave some hint as to
what the type of data structure the value is.
PUT: Add a mapping using PUT/POST
curl -v -X PUT \
-H 'Content-type:application/json' \
--data-binary '{sad:[unhappy]}' \
'http://localhost:8984/solr/collection/schema/analysis/synonyms/english'
There's some question in my mind if PUT should merge in new values to the
existing synonym mappings or replace them. I chose to merge in, which puts a
burden on the client to DELETE (not yet working) synonym mappings they don't
want to keep around. In other words, there's no way to wholesale replace the
existing mappings with another set, but that seems more like how users will use
the feature, ie. adding a synonym here and there as needs evolve.
You can also GET a specific mapping (or 404 if one doesn't exist) using:
curl -i -v
http://localhost:8984/solr/collection/schema/analysis/synonyms/english/happy
-- would return { happy:[glad], ... }
curl -i -v
http://localhost:8984/solr/collection/schema/analysis/synonyms/english/yappy
-- would return 404
Lastly, I'm planning to support a GET request to get all known handles:
curl -i -v http://localhost:8984/solr/collection/schema/analysis/synonyms
Currently would return a JSON list of known managed synonym mappings: [ {
english: { some stats / metadata here, such as whether it is 'dirty' } ]
Create a synonym filter factory that is (re)configurable, and capable of
reporting its configuration, via REST API
--
Key: SOLR-5654
URL: https://issues.apache.org/jira/browse/SOLR-5654
Project: Solr
Issue Type: Sub-task
Components: Schema and Analysis
Reporter: Steve Rowe
Attachments: SOLR-5654.patch
A synonym filter factory could be (re)configurable via REST API by
registering with the RESTManager described in SOLR-5653, and then responding
to REST API calls to modify its init params and its synonyms resource file.
Read-only (GET) REST API calls should also be provided, both for init params
and the synonyms resource file.
It should be possible to add/remove/modify one or more entries in the
synonyms resource file.
We should probably use JSON for the REST request body, as is done in the
Schema REST API methods.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5654) Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API
[ https://issues.apache.org/jira/browse/SOLR-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886574#comment-13886574 ] Jack Krupansky commented on SOLR-5654: -- Two reasonable and reliable use cases I have encountered: 1. Update or replace query-time synonyms - no risk for existing indexed data. 2. Add new index-time synonyms that will apply to new indexed documents - again, no expectation that they would apply to existing documents, but reindexing would of course apply them anyway. Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API -- Key: SOLR-5654 URL: https://issues.apache.org/jira/browse/SOLR-5654 Project: Solr Issue Type: Sub-task Components: Schema and Analysis Reporter: Steve Rowe A synonym filter factory could be (re)configurable via REST API by registering with the RESTManager described in SOLR-5653, and then responding to REST API calls to modify its init params and its synonyms resource file. Read-only (GET) REST API calls should also be provided, both for init params and the synonyms resource file. It should be possible to add/remove/modify one or more entries in the synonyms resource file. We should probably use JSON for the REST request body, as is done in the Schema REST API methods. -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5654) Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API
[ https://issues.apache.org/jira/browse/SOLR-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878957#comment-13878957 ] Robert Muir commented on SOLR-5654: --- Why do we need new factories for synonyms and stopwords? I dont understand this design at all, this seems like duplication of all the analysis factories! Instead, just pass a different resourceloader or something to the existing ones! Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API -- Key: SOLR-5654 URL: https://issues.apache.org/jira/browse/SOLR-5654 Project: Solr Issue Type: Sub-task Components: Schema and Analysis Reporter: Steve Rowe A synonym filter factory could be (re)configurable via REST API by registering with the RESTManager described in SOLR-5653, and then responding to REST API calls to modify its init params and its synonyms resource file. Read-only (GET) REST API calls should also be provided, both for init params and the synonyms resource file. It should be possible to add/remove/modify one or more entries in the synonyms resource file. We should probably use JSON for the REST request body, as is done in the Schema REST API methods. -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5654) Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API
[ https://issues.apache.org/jira/browse/SOLR-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878969#comment-13878969 ] Michael McCandless commented on SOLR-5654: -- In Lucene server (LUCENE-5376) I just created a custom ResourceLoader to pull stopwords that were specified (inlined) in the JSON when the field is registered. But separately I think it's ... dangerous to allow changing stopwords / syns on an already created field / running index? Ie, such changes won't fully take effect until you re-index all content ... I know it's convenient to be able to make such changes, but it's also trappy. Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API -- Key: SOLR-5654 URL: https://issues.apache.org/jira/browse/SOLR-5654 Project: Solr Issue Type: Sub-task Components: Schema and Analysis Reporter: Steve Rowe A synonym filter factory could be (re)configurable via REST API by registering with the RESTManager described in SOLR-5653, and then responding to REST API calls to modify its init params and its synonyms resource file. Read-only (GET) REST API calls should also be provided, both for init params and the synonyms resource file. It should be possible to add/remove/modify one or more entries in the synonyms resource file. We should probably use JSON for the REST request body, as is done in the Schema REST API methods. -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5654) Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API
[
https://issues.apache.org/jira/browse/SOLR-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879015#comment-13879015
]
Steve Rowe commented on SOLR-5654:
--
{quote}
Why do we need new factories for synonyms and stopwords? I dont understand this
design at all, this seems like duplication of all the analysis factories!
Instead, just pass a different resourceloader or something to the existing ones!
{quote}
The point of this issue is to provide REST API methods to interrogate and
modify/persist synonym config and mappings. A different resourceloader would
only allow for this info to be pulled from an alternate persistence store - it
wouldn't do anything for the REST API and persistence part.
{quote}
But separately I think it's ... dangerous to allow changing stopwords / syns on
an already created field / running index? Ie, such changes won't fully take
effect until you re-index all content ... I know it's convenient to be able to
make such changes, but it's also trappy.
{quote}
That's already true today for people who manually modify config and
restart/reload. I guess your point is that we shouldn't be making this easier.
I disagree: the point of the issue is to allow people more fine-grained
control over an already-existing freedom. I think documentation warning people
about the danger of modifying config with an existing index is sufficient to
help people who want this capability avoid creating indexes with mixed analysis
config.
Create a synonym filter factory that is (re)configurable, and capable of
reporting its configuration, via REST API
--
Key: SOLR-5654
URL: https://issues.apache.org/jira/browse/SOLR-5654
Project: Solr
Issue Type: Sub-task
Components: Schema and Analysis
Reporter: Steve Rowe
A synonym filter factory could be (re)configurable via REST API by
registering with the RESTManager described in SOLR-5653, and then responding
to REST API calls to modify its init params and its synonyms resource file.
Read-only (GET) REST API calls should also be provided, both for init params
and the synonyms resource file.
It should be possible to add/remove/modify one or more entries in the
synonyms resource file.
We should probably use JSON for the REST request body, as is done in the
Schema REST API methods.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5654) Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API
[
https://issues.apache.org/jira/browse/SOLR-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879204#comment-13879204
]
Robert Muir commented on SOLR-5654:
---
{quote}
The point of this issue is to provide REST API methods to interrogate and
modify/persist synonym config and mappings. A different resourceloader would
only allow for this info to be pulled from an alternate persistence store - it
wouldn't do anything for the REST API and persistence part.
{quote}
It wouldnt prevent it either.
Reworded: why is a custom factory necessary?
Create a synonym filter factory that is (re)configurable, and capable of
reporting its configuration, via REST API
--
Key: SOLR-5654
URL: https://issues.apache.org/jira/browse/SOLR-5654
Project: Solr
Issue Type: Sub-task
Components: Schema and Analysis
Reporter: Steve Rowe
A synonym filter factory could be (re)configurable via REST API by
registering with the RESTManager described in SOLR-5653, and then responding
to REST API calls to modify its init params and its synonyms resource file.
Read-only (GET) REST API calls should also be provided, both for init params
and the synonyms resource file.
It should be possible to add/remove/modify one or more entries in the
synonyms resource file.
We should probably use JSON for the REST request body, as is done in the
Schema REST API methods.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5654) Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API
[ https://issues.apache.org/jira/browse/SOLR-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879209#comment-13879209 ] Michael McCandless commented on SOLR-5654: -- bq. I guess your point is that we shouldn't be making this easier. Right. bq. I disagree: the point of the issue is to allow people more fine-grained control over an already-existing freedom. Just because there's already an existing (not necessarily good) freedom doesn't mean it must be made easier. Optimize is an existing freedom :) Does Solr at least record somewhere that full re-index required? So the user (if s/he knows to look in the right place on the admin UI) is informed that inconsistent results might be because they didn't fully re-index yet... Create a synonym filter factory that is (re)configurable, and capable of reporting its configuration, via REST API -- Key: SOLR-5654 URL: https://issues.apache.org/jira/browse/SOLR-5654 Project: Solr Issue Type: Sub-task Components: Schema and Analysis Reporter: Steve Rowe A synonym filter factory could be (re)configurable via REST API by registering with the RESTManager described in SOLR-5653, and then responding to REST API calls to modify its init params and its synonyms resource file. Read-only (GET) REST API calls should also be provided, both for init params and the synonyms resource file. It should be possible to add/remove/modify one or more entries in the synonyms resource file. We should probably use JSON for the REST request body, as is done in the Schema REST API methods. -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
