[jira] [Commented] (SOLR-5846) EnumField docValues funtionality
[ https://issues.apache.org/jira/browse/SOLR-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352409#comment-14352409 ] ASF subversion and git services commented on SOLR-5846: --- Commit 1665108 from sha...@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1665108 ] SOLR-5846: EnumField supports DocValues functionality EnumField docValues funtionality Key: SOLR-5846 URL: https://issues.apache.org/jira/browse/SOLR-5846 Project: Solr Issue Type: Improvement Reporter: Elran Dvir Assignee: Shalin Shekhar Mangar Fix For: Trunk, 5.1 Attachments: SOLR-5846.patch, SOLR-5846.patch, Solr-5846.patch, Solr-5846.patch I have added docValues functionality to EnumField. Please review the patch attached. If there is any problem with it, please let me know. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5846) EnumField docValues funtionality
[ https://issues.apache.org/jira/browse/SOLR-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352406#comment-14352406 ] ASF subversion and git services commented on SOLR-5846: --- Commit 1665107 from sha...@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1665107 ] SOLR-5846: EnumField supports DocValues functionality EnumField docValues funtionality Key: SOLR-5846 URL: https://issues.apache.org/jira/browse/SOLR-5846 Project: Solr Issue Type: Improvement Reporter: Elran Dvir Assignee: Shalin Shekhar Mangar Attachments: SOLR-5846.patch, SOLR-5846.patch, Solr-5846.patch, Solr-5846.patch I have added docValues functionality to EnumField. Please review the patch attached. If there is any problem with it, please let me know. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5846) EnumField docValues funtionality
[ https://issues.apache.org/jira/browse/SOLR-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14137042#comment-14137042 ] Elran Dvir commented on SOLR-5846: -- Thank you very much for your attention. Attaching new patch with test. I only added docValues=true in schema and rerun existing EnumFieldTest. All tests passed. Is it sufficient? Thanks. EnumField docValues funtionality Key: SOLR-5846 URL: https://issues.apache.org/jira/browse/SOLR-5846 Project: Solr Issue Type: Improvement Reporter: Elran Dvir Assignee: Shalin Shekhar Mangar Attachments: SOLR-5846.patch, Solr-5846.patch, Solr-5846.patch I have added docValues functionality to EnumField. Please review the patch attached. If there is any problem with it, please let me know. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5846) EnumField docValues funtionality
[ https://issues.apache.org/jira/browse/SOLR-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14133941#comment-14133941 ] Elran Dvir commented on SOLR-5846: -- Hi all, Did anyone have a chance to take a look at my code? Attached new patch with removal of checkSchemaField logic because since version 4.5 single-valued docvalues fields no longer require 'default' or 'required'. The patch is based on Solr 4.9 Thanks. EnumField docValues funtionality Key: SOLR-5846 URL: https://issues.apache.org/jira/browse/SOLR-5846 Project: Solr Issue Type: Improvement Reporter: Elran Dvir Attachments: SOLR-5846.patch, Solr-5846.patch I have added docValues functionality to EnumField. Please review the patch attached. If there is any problem with it, please let me know. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5846) EnumField docValues funtionality
[ https://issues.apache.org/jira/browse/SOLR-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14134043#comment-14134043 ] Shalin Shekhar Mangar commented on SOLR-5846: - Can you please add a test? EnumField docValues funtionality Key: SOLR-5846 URL: https://issues.apache.org/jira/browse/SOLR-5846 Project: Solr Issue Type: Improvement Reporter: Elran Dvir Attachments: SOLR-5846.patch, Solr-5846.patch I have added docValues functionality to EnumField. Please review the patch attached. If there is any problem with it, please let me know. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
