[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104193#comment-14104193 ] Hoss Man commented on SOLR-6178: removed deprecation and CHANGES.txt entry. updating linkage to make it clear we can't deprecate until we come up with a better default (SOLR-6185) > Deprecate Jaspell suggester > --- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless >Assignee: Uwe Schindler > Fix For: 5.0, 4.10 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104175#comment-14104175 ] ASF subversion and git services commented on SOLR-6178: --- Commit 1619173 from hoss...@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1619173 ] SOLR-6178: backout deprecation until we have a diff default (merge r1619172) > Deprecate Jaspell suggester > --- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless >Assignee: Uwe Schindler > Fix For: 5.0, 4.10 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104169#comment-14104169 ] ASF subversion and git services commented on SOLR-6178: --- Commit 1619172 from hoss...@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1619172 ] SOLR-6178: backout deprecation until we have a diff default > Deprecate Jaspell suggester > --- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless >Assignee: Uwe Schindler > Fix For: 5.0, 4.10 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102656#comment-14102656 ] Uwe Schindler commented on SOLR-6178: - I don't care. Maybe we should deprecate and change the default in Lucene 5. Changing defaults is a bad idea in stable branches, especially if they require stuff like reindexing. So maybe revert? > Deprecate Jaspell suggester > --- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless >Assignee: Uwe Schindler > Fix For: 5.0, 4.10 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102454#comment-14102454 ] Hoss Man commented on SOLR-6178: [~thetaphi]: can you please clarify the state of things with this issue? at a quick glance... * issues is currently unresolved, fixVersion=4.10 * issue is currently listed in CHANGES.txt as part of 4.10 * JaspellLookupFactory on branch 4x is currently marked deprecated * JaspellLookupFactory is still the default in Suggester.java ..should we rip out the deprecation & CHANGES.txt entry prior to 4.10 since this still appears to be an outstanding issue? > Deprecate Jaspell suggester > --- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless >Assignee: Uwe Schindler > Fix For: 5.0, 4.10 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14040505#comment-14040505 ] Uwe Schindler commented on SOLR-6178: - I reverted and reopened for more discussion. The Change of defaults was moved to separate issue: SOLR-6185 > Deprecate Jaspell suggester > --- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless >Assignee: Uwe Schindler > Fix For: 5.0, 4.10 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14040502#comment-14040502 ] ASF subversion and git services commented on SOLR-6178: --- Commit 1604711 from [~thetaphi] in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1604711 ] Merged revision(s) 1604710 from lucene/dev/trunk: Move changes of: SOLR-6178, LUCENE-5775: Deprecate JaspellLookupFactory > Deprecate Jaspell suggester > --- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless > Fix For: 4.9, 5.0 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14040500#comment-14040500 ] ASF subversion and git services commented on SOLR-6178: --- Commit 1604710 from [~thetaphi] in branch 'dev/trunk' [ https://svn.apache.org/r1604710 ] Move changes of: SOLR-6178, LUCENE-5775: Deprecate JaspellLookupFactory > Deprecate Jaspell suggester > --- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless > Fix For: 4.9, 5.0 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14040496#comment-14040496 ] ASF subversion and git services commented on SOLR-6178: --- Commit 1604707 from [~thetaphi] in branch 'dev/branches/lucene_solr_4_9' [ https://svn.apache.org/r1604707 ] Revert: Merged revision(s) 1604122 from lucene/dev/trunk: SOLR-6178, LUCENE-5775: Deprecate JaspellLookupFactory > Deprecate Jaspell suggester > --- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless > Fix For: 4.9, 5.0 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038739#comment-14038739 ] Robert Muir commented on SOLR-6178: --- Also, changing the default gets even more complex. its been jaspell for a long time: but changing the default could cause a ton of confusion (users think 4.9 cannot read their "index"), even though we know that suggester data is really not part of the index... the user just may not see it that way: to them its their data and the upgrade broke them. Such a change needs to be planned out from a docs and release notes perspective, not shoved in right at the last minute hastily. Its too risky. > Deprecate Jaspell suggester > --- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless > Fix For: 4.9, 5.0 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038732#comment-14038732 ] Robert Muir commented on SOLR-6178: --- Well, thats your opinion. There is absolutely no way I am going to let a lucene deprecation annotation have a destabilizing snowball effect on this release: first its a deprecation warning, then someone doesn't want the warning in the default configuration and wants a change of defaults, then the change of defaults breaks the example, then the change to the example breaks the documentation or tutorial, and on and on and on. There is just no reason for such risks. > Deprecate Jaspell suggester > --- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless > Fix For: 4.9, 5.0 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038726#comment-14038726 ] Uwe Schindler commented on SOLR-6178: - In my opinion, we should revert this one *and* the deprecation inside Lucene. To me it is also very controversal if Solr defaults to use something that is deprecated in Lucene because it uses too much memory! I agree to revert this issue if the deprecation in Lucene is also reverted. > Deprecate Jaspell suggester > --- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless > Fix For: 4.9, 5.0 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038669#comment-14038669 ] Robert Muir commented on SOLR-6178: --- Its last minute because it can be potentially controversial. Deprecating the lucene suggester has no impact to solr users. Putting a big warning in the default configuration is a different story. I didnt revert anything, your commit just didn't make it in time for the release candidate. I dont want such controversy: I care about keeping things stable and bad bugs. I can EASILY see such a warning turning into "we should change the solr default" and spinning totally out of control and somehow breaking the example. I waited extra time for SOLR-6182 because it looked like a really bad bug. And if a similar bug like that pops up I won't even have a second thought about respinning for it. But by no means is this a blocker. > Deprecate Jaspell suggester > --- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless > Fix For: 4.9, 5.0 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038664#comment-14038664 ] Michael McCandless commented on SOLR-6178: -- In hindsight I should have just backported the bug fix in LUCENE-5775 (stack overflow when calling .ramBytesUsed()), and not the deprecation, for 4.9 next time I'll make separate issues. Sorry for the hassle. > Deprecate Jaspell suggester > --- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless > Fix For: 4.9, 5.0 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038663#comment-14038663 ] Uwe Schindler commented on SOLR-6178: - This was not last minute. Mike just missed to add the deprecation also in Solr. If we go this way, please also revert Mike's commit. Sorry. > Deprecate Jaspell suggester > --- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless > Fix For: 4.9, 5.0 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038659#comment-14038659 ] Robert Muir commented on SOLR-6178: --- Well, you can vote however you like. I already spun the RC and its in progress. Its risky as shit to add such deprecations which will cause warning messages to solr users and create a controversy. There is no need to rush in such things at the last minute. > Deprecate Jaspell suggester > --- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless > Fix For: 4.9, 5.0 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038657#comment-14038657 ] Uwe Schindler commented on SOLR-6178: - Sorry, I don't see a release. > Deprecate Jaspell suggester > --- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless > Fix For: 4.9, 5.0 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester and change the default
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038654#comment-14038654 ] ASF subversion and git services commented on SOLR-6178: --- Commit 1604125 from [~thetaphi] in branch 'dev/branches/lucene_solr_4_9' [ https://svn.apache.org/r1604125 ] Merged revision(s) 1604122 from lucene/dev/trunk: SOLR-6178, LUCENE-5775: Deprecate JaspellLookupFactory > Deprecate Jaspell suggester and change the default > -- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless > Fix For: 4.9, 5.0 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038656#comment-14038656 ] Robert Muir commented on SOLR-6178: --- This didn't make 4.9 > Deprecate Jaspell suggester > --- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless > Fix For: 4.9, 5.0 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester and change the default
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038648#comment-14038648 ] ASF subversion and git services commented on SOLR-6178: --- Commit 1604122 from [~thetaphi] in branch 'dev/trunk' [ https://svn.apache.org/r1604122 ] SOLR-6178, LUCENE-5775: Deprecate JaspellLookupFactory > Deprecate Jaspell suggester and change the default > -- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless > Fix For: 4.9, 5.0 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester and change the default
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038652#comment-14038652 ] ASF subversion and git services commented on SOLR-6178: --- Commit 1604124 from [~thetaphi] in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1604124 ] Merged revision(s) 1604122 from lucene/dev/trunk: SOLR-6178, LUCENE-5775: Deprecate JaspellLookupFactory > Deprecate Jaspell suggester and change the default > -- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless > Fix For: 4.9, 5.0 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester and change the default
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038644#comment-14038644 ] Uwe Schindler commented on SOLR-6178: - Ok lets split this issue: We need in any case the deprecateion, not the change of defaults. > Deprecate Jaspell suggester and change the default > -- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless > Fix For: 4.9, 5.0 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester and change the default
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038627#comment-14038627 ] Robert Muir commented on SOLR-6178: --- This is *WAY* too risky to do right before a release. Please do not commit anything at all to the 4.9 branch. This can definitely be done in 4.10 > Deprecate Jaspell suggester and change the default > -- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless >Priority: Minor > Fix For: 4.9, 5.0 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester and change the default
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038625#comment-14038625 ] Robert Muir commented on SOLR-6178: --- Not a blocker. Sorry guys. Not even a bug! > Deprecate Jaspell suggester and change the default > -- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless >Priority: Minor > Fix For: 4.9, 5.0 > > Attachments: SOLR-6178.patch > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6178) Deprecate Jaspell suggester and change the default
[ https://issues.apache.org/jira/browse/SOLR-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038564#comment-14038564 ] Uwe Schindler commented on SOLR-6178: - I think for now, we should at least make the factory deprecated. As we deprecated Jaspell already in 4.9, this should be done before 4.9. > Deprecate Jaspell suggester and change the default > -- > > Key: SOLR-6178 > URL: https://issues.apache.org/jira/browse/SOLR-6178 > Project: Solr > Issue Type: Improvement > Components: spellchecker >Reporter: Michael McCandless > Fix For: 4.9, 5.0 > > > Right now Solr defaults to Jaspell, but we've deprecated it in LUCENE-5775 > ... and in trunk I'd like to remove it. But first we need to fix Solr to not > default to it. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
