[ https://issues.apache.org/jira/browse/SOLR-6195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14041412#comment-14041412 ]
Hoss Man commented on SOLR-6195: -------------------------------- suggestion for moving forward: * leave most of the code SOLR-6125 added alone, but mark it deprecated * add new logic for a {{indexConfig/closeWriterWaitsForMerges}} Boolean in SolrIndexConfig which defaults to null * add new logic in DirectUpdateHandler2 to check {{core.getSolrConfig().indexConfig.closeWriterWaitsForMerges}} first, and only if null does it look at {{updateHandlerInfo.indexWriterCloseWaitsForMerges;}} * add tests for both config options > replace updateHandler/indexWriter/closeWaitsForMerges with > indexConfig/closeWaitsForMerges > ------------------------------------------------------------------------------------------ > > Key: SOLR-6195 > URL: https://issues.apache.org/jira/browse/SOLR-6195 > Project: Solr > Issue Type: Improvement > Reporter: Hoss Man > > SOLR-6125 added a new "closeWaitsForMerges" config option, but in my opinion > this was done too hastily w/o enough consideration to how/shere the option is > configured. > * it's currently "updateHandler/indexWriter/closeWaitsForMerges" > ** there has never been an "updateHandler/indexWriter" section in > solrconfig.xml until now > ** this is the only setting that currently exists in this section > * this setting, although used by DirectUpdateHandler2, does not (from a user > perspective really fit with the other existing settings in {{<updateHandler>}} > ** i think from a user perspective, it would make much more sense in > {{<indexConfig>}} along side the other merge related settings. -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org