[jira] [Commented] (SOLR-6615) Refactor code to use String constants
[ https://issues.apache.org/jira/browse/SOLR-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937873#comment-15937873 ] ASF subversion and git services commented on SOLR-6615: --- Commit 121231b6ebd14e002439b8e0ca7a995ed5ad9e57 in lucene-solr's branch refs/heads/branch_6x from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=121231b ] SOLR-6615: use constants for 'sort', 'distrib' > Refactor code to use String constants > - > > Key: SOLR-6615 > URL: https://issues.apache.org/jira/browse/SOLR-6615 > Project: Solr > Issue Type: Task >Reporter: Noble Paul >Assignee: Noble Paul > > Solr codebase is full of string constants used in place and the same string > is declared in multiple places . We need to define the constants in a common > place and need to reuse them -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6615) Refactor code to use String constants
[ https://issues.apache.org/jira/browse/SOLR-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937872#comment-15937872 ] ASF subversion and git services commented on SOLR-6615: --- Commit 4edfc1a9c7b877a23cffbf5f73a2728173fa663d in lucene-solr's branch refs/heads/master from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4edfc1a ] SOLR-6615: use constants for 'sort', 'distrib' > Refactor code to use String constants > - > > Key: SOLR-6615 > URL: https://issues.apache.org/jira/browse/SOLR-6615 > Project: Solr > Issue Type: Task >Reporter: Noble Paul >Assignee: Noble Paul > > Solr codebase is full of string constants used in place and the same string > is declared in multiple places . We need to define the constants in a common > place and need to reuse them -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6615) Refactor code to use String constants
[ https://issues.apache.org/jira/browse/SOLR-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937569#comment-15937569 ] ASF subversion and git services commented on SOLR-6615: --- Commit 95be4eba246275a5d7fb29904ae30257bcda in lucene-solr's branch refs/heads/branch_6x from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=95be4eb ] SOLR-6615: use constants for 'id', '_route_', '_version_' > Refactor code to use String constants > - > > Key: SOLR-6615 > URL: https://issues.apache.org/jira/browse/SOLR-6615 > Project: Solr > Issue Type: Task >Reporter: Noble Paul >Assignee: Noble Paul > > Solr codebase is full of string constants used in place and the same string > is declared in multiple places . We need to define the constants in a common > place and need to reuse them -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6615) Refactor code to use String constants
[ https://issues.apache.org/jira/browse/SOLR-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937508#comment-15937508 ] ASF subversion and git services commented on SOLR-6615: --- Commit eb587772ddecaea371b20feb955a197e80699f22 in lucene-solr's branch refs/heads/master from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=eb58777 ] SOLR-6615: use constants for 'id', '_route_', '_version_' > Refactor code to use String constants > - > > Key: SOLR-6615 > URL: https://issues.apache.org/jira/browse/SOLR-6615 > Project: Solr > Issue Type: Task >Reporter: Noble Paul >Assignee: Noble Paul > > Solr codebase is full of string constants used in place and the same string > is declared in multiple places . We need to define the constants in a common > place and need to reuse them -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6615) Refactor code to use String constants
[ https://issues.apache.org/jira/browse/SOLR-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392157#comment-14392157 ] ASF subversion and git services commented on SOLR-6615: --- Commit 1670816 from [~noble.paul] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1670816 ] SOLR-6615: Refactor code to use String constants > Refactor code to use String constants > - > > Key: SOLR-6615 > URL: https://issues.apache.org/jira/browse/SOLR-6615 > Project: Solr > Issue Type: Task >Reporter: Noble Paul > > Solr codebase is full of string constants used in place and the same string > is declared in multiple places . We need to define the constants in a common > place and need to reuse them -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6615) Refactor code to use String constants
[ https://issues.apache.org/jira/browse/SOLR-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392098#comment-14392098 ] ASF subversion and git services commented on SOLR-6615: --- Commit 1670813 from [~noble.paul] in branch 'dev/trunk' [ https://svn.apache.org/r1670813 ] SOLR-6615: Refactor code to use String constants > Refactor code to use String constants > - > > Key: SOLR-6615 > URL: https://issues.apache.org/jira/browse/SOLR-6615 > Project: Solr > Issue Type: Task >Reporter: Noble Paul > > Solr codebase is full of string constants used in place and the same string > is declared in multiple places . We need to define the constants in a common > place and need to reuse them -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6615) Refactor code to use String constants
[ https://issues.apache.org/jira/browse/SOLR-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166243#comment-14166243 ] Yonik Seeley commented on SOLR-6615: +1, but not the test code please... IMO, If constants are used in test code, they should be different constants than those used in the normal code. Otherwise an accidental change of a string constant (either a typo, or someone making a deliberate change and not realizing the full scope of the change - like everywhere the constant is used) won't cause anything to fail. > Refactor code to use String constants > - > > Key: SOLR-6615 > URL: https://issues.apache.org/jira/browse/SOLR-6615 > Project: Solr > Issue Type: Task >Reporter: Noble Paul > > Solr codebase is full of string constants used in place and the same string > is declared in multiple places . We need to define the constants in a common > place and need to reuse them -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
