[jira] [Commented] (SOLR-6650) Add optional slow request logging at WARN level
[ https://issues.apache.org/jira/browse/SOLR-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14185519#comment-14185519 ] ASF subversion and git services commented on SOLR-6650: --- Commit 1634628 from [~thelabdude] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1634628 ] SOLR-6650: disabled by default > Add optional slow request logging at WARN level > --- > > Key: SOLR-6650 > URL: https://issues.apache.org/jira/browse/SOLR-6650 > Project: Solr > Issue Type: Improvement >Reporter: Jessica Cheng Mallet >Assignee: Timothy Potter > Labels: logging > Fix For: 5.0 > > > At super high request rates, logging all the requests can become a bottleneck > and therefore INFO logging is often turned off. However, it is still useful > to be able to set a latency threshold above which a request is considered > "slow" and log that request at WARN level so we can easily identify slow > queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6650) Add optional slow request logging at WARN level
[ https://issues.apache.org/jira/browse/SOLR-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14185501#comment-14185501 ] ASF subversion and git services commented on SOLR-6650: --- Commit 1634621 from [~thelabdude] in branch 'dev/trunk' [ https://svn.apache.org/r1634621 ] SOLR-6650: disabled by default > Add optional slow request logging at WARN level > --- > > Key: SOLR-6650 > URL: https://issues.apache.org/jira/browse/SOLR-6650 > Project: Solr > Issue Type: Improvement >Reporter: Jessica Cheng Mallet >Assignee: Timothy Potter > Labels: logging > Fix For: 5.0 > > > At super high request rates, logging all the requests can become a bottleneck > and therefore INFO logging is often turned off. However, it is still useful > to be able to set a latency threshold above which a request is considered > "slow" and log that request at WARN level so we can easily identify slow > queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6650) Add optional slow request logging at WARN level
[ https://issues.apache.org/jira/browse/SOLR-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14185384#comment-14185384 ] Timothy Potter commented on SOLR-6650: -- Yes, see that now ... the patch link doesn't have the latest (which I was I looked at earlier) https://github.com/apache/lucene-solr/pull/102.patch > Add optional slow request logging at WARN level > --- > > Key: SOLR-6650 > URL: https://issues.apache.org/jira/browse/SOLR-6650 > Project: Solr > Issue Type: Improvement >Reporter: Jessica Cheng Mallet >Assignee: Timothy Potter > Labels: logging > Fix For: 5.0 > > > At super high request rates, logging all the requests can become a bottleneck > and therefore INFO logging is often turned off. However, it is still useful > to be able to set a latency threshold above which a request is considered > "slow" and log that request at WARN level so we can easily identify slow > queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6650) Add optional slow request logging at WARN level
[ https://issues.apache.org/jira/browse/SOLR-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14185361#comment-14185361 ] Jessica Cheng Mallet commented on SOLR-6650: Hi Tim, It should be the latest. Do you see the default being changed for 1000 to -1 (https://github.com/apache/lucene-solr/pull/102/files)? > Add optional slow request logging at WARN level > --- > > Key: SOLR-6650 > URL: https://issues.apache.org/jira/browse/SOLR-6650 > Project: Solr > Issue Type: Improvement >Reporter: Jessica Cheng Mallet >Assignee: Timothy Potter > Labels: logging > Fix For: 5.0 > > > At super high request rates, logging all the requests can become a bottleneck > and therefore INFO logging is often turned off. However, it is still useful > to be able to set a latency threshold above which a request is considered > "slow" and log that request at WARN level so we can easily identify slow > queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6650) Add optional slow request logging at WARN level
[ https://issues.apache.org/jira/browse/SOLR-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14185201#comment-14185201 ] Timothy Potter commented on SOLR-6650: -- hmmm ... can you post the URL of the pull request here (or just post an updated patch to this ticket)? When I click on the 102 link above, it doesn't look like the latest code ... > Add optional slow request logging at WARN level > --- > > Key: SOLR-6650 > URL: https://issues.apache.org/jira/browse/SOLR-6650 > Project: Solr > Issue Type: Improvement >Reporter: Jessica Cheng Mallet >Assignee: Timothy Potter > Labels: logging > Fix For: 5.0 > > > At super high request rates, logging all the requests can become a bottleneck > and therefore INFO logging is often turned off. However, it is still useful > to be able to set a latency threshold above which a request is considered > "slow" and log that request at WARN level so we can easily identify slow > queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6650) Add optional slow request logging at WARN level
[ https://issues.apache.org/jira/browse/SOLR-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183804#comment-14183804 ] Jessica Cheng Mallet commented on SOLR-6650: Updated the PR to have this be disabled by default. > Add optional slow request logging at WARN level > --- > > Key: SOLR-6650 > URL: https://issues.apache.org/jira/browse/SOLR-6650 > Project: Solr > Issue Type: Improvement >Reporter: Jessica Cheng Mallet >Assignee: Timothy Potter > Labels: logging > Fix For: 5.0 > > > At super high request rates, logging all the requests can become a bottleneck > and therefore INFO logging is often turned off. However, it is still useful > to be able to set a latency threshold above which a request is considered > "slow" and log that request at WARN level so we can easily identify slow > queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6650) Add optional slow request logging at WARN level
[ https://issues.apache.org/jira/browse/SOLR-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183567#comment-14183567 ] Timothy Potter commented on SOLR-6650: -- FWIW - the original patch didn't have that problem in that it either logged as INFO if INFO was enabled for SolrCore's logger OR logged at WARN if the threshold was breached if SolrCore's logger was set to WARN ... re-opening the issue to pull in these additional changes > Add optional slow request logging at WARN level > --- > > Key: SOLR-6650 > URL: https://issues.apache.org/jira/browse/SOLR-6650 > Project: Solr > Issue Type: Improvement >Reporter: Jessica Cheng Mallet >Assignee: Timothy Potter > Labels: logging > Fix For: 5.0 > > > At super high request rates, logging all the requests can become a bottleneck > and therefore INFO logging is often turned off. However, it is still useful > to be able to set a latency threshold above which a request is considered > "slow" and log that request at WARN level so we can easily identify slow > queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6650) Add optional slow request logging at WARN level
[ https://issues.apache.org/jira/browse/SOLR-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183450#comment-14183450 ] Tomás Fernández Löbbe commented on SOLR-6650: - bq. It looks like this defaults to enabled with a threshold of 1 second. If that's the case, I don't think that's a good idea. It should default to disabled. +1 Specially now that the idea is to log WARN in addition to INFO. People that don't have this setting in the solrconfig (upgrading?) will start logging twice for many queries. > Add optional slow request logging at WARN level > --- > > Key: SOLR-6650 > URL: https://issues.apache.org/jira/browse/SOLR-6650 > Project: Solr > Issue Type: Improvement >Reporter: Jessica Cheng Mallet >Assignee: Timothy Potter > Labels: logging > Fix For: 5.0 > > > At super high request rates, logging all the requests can become a bottleneck > and therefore INFO logging is often turned off. However, it is still useful > to be able to set a latency threshold above which a request is considered > "slow" and log that request at WARN level so we can easily identify slow > queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6650) Add optional slow request logging at WARN level
[ https://issues.apache.org/jira/browse/SOLR-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183429#comment-14183429 ] Shawn Heisey commented on SOLR-6650: I like this idea. I can turn off INFO logging, set a threshold, and chances are good that whatever I need to look at is something that will be logged, but the file will not be clogged with every request. My look at the patch was very quick, so I have not noticed every detail. It looks like this defaults to enabled with a threshold of 1 second. If that's the case, I don't think that's a good idea. It should default to disabled. Hopefully it will log all queries if I set the threshold to zero. A negative number in the setting (or the setting not present) would be a good way to turn it off. Will this only log queries, or would it log all slow requests, including calls to /update? > Add optional slow request logging at WARN level > --- > > Key: SOLR-6650 > URL: https://issues.apache.org/jira/browse/SOLR-6650 > Project: Solr > Issue Type: Improvement >Reporter: Jessica Cheng Mallet >Assignee: Timothy Potter > Labels: logging > Fix For: 5.0 > > > At super high request rates, logging all the requests can become a bottleneck > and therefore INFO logging is often turned off. However, it is still useful > to be able to set a latency threshold above which a request is considered > "slow" and log that request at WARN level so we can easily identify slow > queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6650) Add optional slow request logging at WARN level
[ https://issues.apache.org/jira/browse/SOLR-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183395#comment-14183395 ] ASF GitHub Bot commented on SOLR-6650: -- GitHub user mewmewball opened a pull request: https://github.com/apache/lucene-solr/pull/102 SOLR-6650 - Add optional slow request logging at WARN level Based on discussion with Chris Hostetter, make the slow warn logging an if condition on its own rather than an else for the info logging. Also, add "slow: " prefix to the log message so it's easy to spot redundancy with info level. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mewmewball/lucene-solr trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/102.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #102 commit 8096b200187b81de78862ca71026a13d6a793650 Author: Jessica Cheng Date: 2014-10-23T23:07:31Z SOLR-6650 - Add optional slow request logging at WARN level commit c25993724e48343d8cc941cc0228312e9ff4f3ab Author: Jessica Cheng Date: 2014-10-23T23:08:25Z Merge branch 'trunk' of https://github.com/mewmewball/lucene-solr into trunk # By Jan Høydahl # Via Jan Høydahl * 'trunk' of https://github.com/mewmewball/lucene-solr: SOLR-6647: Bad error message when missing resource from ZK when parsing Schema commit 5c69624555b4f3f4aa21627efd57772dfa0a477c Author: Jessica Cheng Date: 2014-10-24T18:23:37Z Merge branch 'trunk' of https://github.com/apache/lucene-solr into trunk commit ba2a87b22dbc4355e663fb68a6dd4de16b42ff47 Author: Jessica Cheng Date: 2014-10-24T20:06:21Z SOLR-6650 - Add optional slow request logging at WARN level - Based on discussion with Chris Hostetter, make the slow warn logging an if condition on its own rather than an else for the info logging. Also, add "slow: " prefix to the log message so it's easy to spot redundancy with info level. > Add optional slow request logging at WARN level > --- > > Key: SOLR-6650 > URL: https://issues.apache.org/jira/browse/SOLR-6650 > Project: Solr > Issue Type: Improvement >Reporter: Jessica Cheng Mallet >Assignee: Timothy Potter > Labels: logging > Fix For: 5.0 > > > At super high request rates, logging all the requests can become a bottleneck > and therefore INFO logging is often turned off. However, it is still useful > to be able to set a latency threshold above which a request is considered > "slow" and log that request at WARN level so we can easily identify slow > queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6650) Add optional slow request logging at WARN level
[ https://issues.apache.org/jira/browse/SOLR-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183033#comment-14183033 ] ASF GitHub Bot commented on SOLR-6650: -- Github user asfgit closed the pull request at: https://github.com/apache/lucene-solr/pull/101 > Add optional slow request logging at WARN level > --- > > Key: SOLR-6650 > URL: https://issues.apache.org/jira/browse/SOLR-6650 > Project: Solr > Issue Type: Improvement >Reporter: Jessica Cheng Mallet >Assignee: Timothy Potter > Labels: logging > Fix For: 5.0 > > > At super high request rates, logging all the requests can become a bottleneck > and therefore INFO logging is often turned off. However, it is still useful > to be able to set a latency threshold above which a request is considered > "slow" and log that request at WARN level so we can easily identify slow > queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6650) Add optional slow request logging at WARN level
[ https://issues.apache.org/jira/browse/SOLR-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183007#comment-14183007 ] ASF subversion and git services commented on SOLR-6650: --- Commit 1634088 from [~thelabdude] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1634088 ] SOLR-6650: Add optional slow request logging at WARN level; this closes #101 > Add optional slow request logging at WARN level > --- > > Key: SOLR-6650 > URL: https://issues.apache.org/jira/browse/SOLR-6650 > Project: Solr > Issue Type: Improvement >Reporter: Jessica Cheng Mallet >Assignee: Timothy Potter > Labels: logging > > At super high request rates, logging all the requests can become a bottleneck > and therefore INFO logging is often turned off. However, it is still useful > to be able to set a latency threshold above which a request is considered > "slow" and log that request at WARN level so we can easily identify slow > queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6650) Add optional slow request logging at WARN level
[ https://issues.apache.org/jira/browse/SOLR-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183004#comment-14183004 ] ASF subversion and git services commented on SOLR-6650: --- Commit 1634086 from [~thelabdude] in branch 'dev/trunk' [ https://svn.apache.org/r1634086 ] SOLR-6650: Add optional slow request logging at WARN level; this closes #101 > Add optional slow request logging at WARN level > --- > > Key: SOLR-6650 > URL: https://issues.apache.org/jira/browse/SOLR-6650 > Project: Solr > Issue Type: Improvement >Reporter: Jessica Cheng Mallet >Assignee: Timothy Potter > Labels: logging > > At super high request rates, logging all the requests can become a bottleneck > and therefore INFO logging is often turned off. However, it is still useful > to be able to set a latency threshold above which a request is considered > "slow" and log that request at WARN level so we can easily identify slow > queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6650) Add optional slow request logging at WARN level
[ https://issues.apache.org/jira/browse/SOLR-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182901#comment-14182901 ] Timothy Potter commented on SOLR-6650: -- Just doing some basic testing and then will commit. > Add optional slow request logging at WARN level > --- > > Key: SOLR-6650 > URL: https://issues.apache.org/jira/browse/SOLR-6650 > Project: Solr > Issue Type: Improvement >Reporter: Jessica Cheng Mallet >Assignee: Timothy Potter > Labels: logging > > At super high request rates, logging all the requests can become a bottleneck > and therefore INFO logging is often turned off. However, it is still useful > to be able to set a latency threshold above which a request is considered > "slow" and log that request at WARN level so we can easily identify slow > queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6650) Add optional slow request logging at WARN level
[ https://issues.apache.org/jira/browse/SOLR-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182186#comment-14182186 ] Yonik Seeley commented on SOLR-6650: +1, great idea! > Add optional slow request logging at WARN level > --- > > Key: SOLR-6650 > URL: https://issues.apache.org/jira/browse/SOLR-6650 > Project: Solr > Issue Type: Improvement >Reporter: Jessica Cheng Mallet > Labels: logging > > At super high request rates, logging all the requests can become a bottleneck > and therefore INFO logging is often turned off. However, it is still useful > to be able to set a latency threshold above which a request is considered > "slow" and log that request at WARN level so we can easily identify slow > queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6650) Add optional slow request logging at WARN level
[ https://issues.apache.org/jira/browse/SOLR-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182148#comment-14182148 ] ASF GitHub Bot commented on SOLR-6650: -- GitHub user mewmewball opened a pull request: https://github.com/apache/lucene-solr/pull/101 SOLR-6650 - Add optional slow request logging at WARN level You can merge this pull request into a Git repository by running: $ git pull https://github.com/mewmewball/lucene-solr trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/101.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #101 commit 8096b200187b81de78862ca71026a13d6a793650 Author: Jessica Cheng Date: 2014-10-23T23:07:31Z SOLR-6650 - Add optional slow request logging at WARN level commit c25993724e48343d8cc941cc0228312e9ff4f3ab Author: Jessica Cheng Date: 2014-10-23T23:08:25Z Merge branch 'trunk' of https://github.com/mewmewball/lucene-solr into trunk # By Jan Høydahl # Via Jan Høydahl * 'trunk' of https://github.com/mewmewball/lucene-solr: SOLR-6647: Bad error message when missing resource from ZK when parsing Schema > Add optional slow request logging at WARN level > --- > > Key: SOLR-6650 > URL: https://issues.apache.org/jira/browse/SOLR-6650 > Project: Solr > Issue Type: Improvement >Reporter: Jessica Cheng Mallet > Labels: logging > > At super high request rates, logging all the requests can become a bottleneck > and therefore INFO logging is often turned off. However, it is still useful > to be able to set a latency threshold above which a request is considered > "slow" and log that request at WARN level so we can easily identify slow > queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
