[jira] [Commented] (SOLR-6876) Remove unused legacy scripts.conf
[ https://issues.apache.org/jira/browse/SOLR-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271113#comment-14271113 ] Alexandre Rafalovitch commented on SOLR-6876: - I think that whole section refers to the stuff that no longer ships with Solr. I don't know as of when the shipping it stopped. Remove unused legacy scripts.conf - Key: SOLR-6876 URL: https://issues.apache.org/jira/browse/SOLR-6876 Project: Solr Issue Type: Bug Affects Versions: 4.10.2, 5.0, Trunk Reporter: Alexandre Rafalovitch Assignee: Erick Erickson Priority: Minor Fix For: 5.0, Trunk Attachments: SOLR-6876.patch Some of the example collections include *scripts.conf* in the *conf* directory. It is not used by anything in the distribution and is somehow left over from the Solr 1.x legacy days. It should be possible to safe delete it to avoid confusing users trying to understand what different files actually do. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6876) Remove unused legacy scripts.conf
[ https://issues.apache.org/jira/browse/SOLR-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271636#comment-14271636 ] Hoss Man commented on SOLR-6876: bq. I think that whole section refers to the stuff that no longer ships with Solr. I don't know as of when the shipping it stopped. pruned now. Remove unused legacy scripts.conf - Key: SOLR-6876 URL: https://issues.apache.org/jira/browse/SOLR-6876 Project: Solr Issue Type: Bug Affects Versions: 4.10.2, 5.0, Trunk Reporter: Alexandre Rafalovitch Assignee: Erick Erickson Priority: Minor Fix For: 5.0, Trunk Attachments: SOLR-6876.patch Some of the example collections include *scripts.conf* in the *conf* directory. It is not used by anything in the distribution and is somehow left over from the Solr 1.x legacy days. It should be possible to safe delete it to avoid confusing users trying to understand what different files actually do. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6876) Remove unused legacy scripts.conf
[ https://issues.apache.org/jira/browse/SOLR-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270909#comment-14270909 ] Varun Thacker commented on SOLR-6876: - Hi [~erickerickson] , This change requires updating this ref guide page right?https://cwiki.apache.org/confluence/display/solr/Index+Replication#IndexReplication-TheSnapshotandDistributionProcess Remove unused legacy scripts.conf - Key: SOLR-6876 URL: https://issues.apache.org/jira/browse/SOLR-6876 Project: Solr Issue Type: Bug Affects Versions: 4.10.2, 5.0, Trunk Reporter: Alexandre Rafalovitch Assignee: Erick Erickson Priority: Minor Fix For: 5.0, Trunk Attachments: SOLR-6876.patch Some of the example collections include *scripts.conf* in the *conf* directory. It is not used by anything in the distribution and is somehow left over from the Solr 1.x legacy days. It should be possible to safe delete it to avoid confusing users trying to understand what different files actually do. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6876) Remove unused legacy scripts.conf
[ https://issues.apache.org/jira/browse/SOLR-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259709#comment-14259709 ] ASF subversion and git services commented on SOLR-6876: --- Commit 1648246 from [~erickoerickson] in branch 'dev/trunk' [ https://svn.apache.org/r1648246 ] SOLR-6876: Remove unused legacy scripts.conf Remove unused legacy scripts.conf - Key: SOLR-6876 URL: https://issues.apache.org/jira/browse/SOLR-6876 Project: Solr Issue Type: Bug Affects Versions: 4.10.2, 5.0, Trunk Reporter: Alexandre Rafalovitch Assignee: Erick Erickson Priority: Minor Attachments: SOLR-6876.patch Some of the example collections include *scripts.conf* in the *conf* directory. It is not used by anything in the distribution and is somehow left over from the Solr 1.x legacy days. It should be possible to safe delete it to avoid confusing users trying to understand what different files actually do. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6876) Remove unused legacy scripts.conf
[ https://issues.apache.org/jira/browse/SOLR-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259726#comment-14259726 ] ASF subversion and git services commented on SOLR-6876: --- Commit 1648252 from [~erickoerickson] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1648252 ] SOLR-6876: Remove unused legacy scripts.conf Remove unused legacy scripts.conf - Key: SOLR-6876 URL: https://issues.apache.org/jira/browse/SOLR-6876 Project: Solr Issue Type: Bug Affects Versions: 4.10.2, 5.0, Trunk Reporter: Alexandre Rafalovitch Assignee: Erick Erickson Priority: Minor Fix For: 5.0, Trunk Attachments: SOLR-6876.patch Some of the example collections include *scripts.conf* in the *conf* directory. It is not used by anything in the distribution and is somehow left over from the Solr 1.x legacy days. It should be possible to safe delete it to avoid confusing users trying to understand what different files actually do. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6876) Remove unused legacy scripts.conf
[ https://issues.apache.org/jira/browse/SOLR-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258466#comment-14258466 ] Erick Erickson commented on SOLR-6876: -- I think I'm going to close this one won't fix. As Koji points out, these support SnapPuller, which still ships with trunk. So they're still potentially useful. Although the note on the Wiki that these haven't been actively maintained since the 1.4 days kind of makes you wonder I'll give it a day or so for people to render different opinions, but otherwise I think they should stay. Remove unused legacy scripts.conf - Key: SOLR-6876 URL: https://issues.apache.org/jira/browse/SOLR-6876 Project: Solr Issue Type: Bug Affects Versions: 4.10.2, 5.0, Trunk Reporter: Alexandre Rafalovitch Assignee: Erick Erickson Priority: Minor Some of the example collections include *scripts.conf* in the *conf* directory. It is not used by anything in the distribution and is somehow left over from the Solr 1.x legacy days. It should be possible to safe delete it to avoid confusing users trying to understand what different files actually do. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6876) Remove unused legacy scripts.conf
[ https://issues.apache.org/jira/browse/SOLR-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258474#comment-14258474 ] Alexandre Rafalovitch commented on SOLR-6876: - I do not believe they ship with 5.0. I can't find them in the distribution. Only in the source. Or are these build-time artifacts? In which case I am not sure what the one in the configsets is doing given that it represents the latest core, not an actual one. Remove unused legacy scripts.conf - Key: SOLR-6876 URL: https://issues.apache.org/jira/browse/SOLR-6876 Project: Solr Issue Type: Bug Affects Versions: 4.10.2, 5.0, Trunk Reporter: Alexandre Rafalovitch Assignee: Erick Erickson Priority: Minor Some of the example collections include *scripts.conf* in the *conf* directory. It is not used by anything in the distribution and is somehow left over from the Solr 1.x legacy days. It should be possible to safe delete it to avoid confusing users trying to understand what different files actually do. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6876) Remove unused legacy scripts.conf
[ https://issues.apache.org/jira/browse/SOLR-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258522#comment-14258522 ] Erick Erickson commented on SOLR-6876: -- Well, the SnapPuller _class_ is still there in trunk. Therefore I assume that it's at least possible to use these configs (or a variant). The big warning on the Wiki is that the scripts aren't actively maintained, not that they're obsolete. OTOH, if people who know more about this than me think obfuscating snappuller is A Good Thing we can remove them, I'm kind of waiting for folks to either tell me I'm way off base or that it's OK to take them out. Remove unused legacy scripts.conf - Key: SOLR-6876 URL: https://issues.apache.org/jira/browse/SOLR-6876 Project: Solr Issue Type: Bug Affects Versions: 4.10.2, 5.0, Trunk Reporter: Alexandre Rafalovitch Assignee: Erick Erickson Priority: Minor Some of the example collections include *scripts.conf* in the *conf* directory. It is not used by anything in the distribution and is somehow left over from the Solr 1.x legacy days. It should be possible to safe delete it to avoid confusing users trying to understand what different files actually do. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6876) Remove unused legacy scripts.conf
[ https://issues.apache.org/jira/browse/SOLR-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258558#comment-14258558 ] Shalin Shekhar Mangar commented on SOLR-6876: - bq. Well, the SnapPuller class is still there in trunk. Therefore I assume that it's at least possible to use these configs (or a variant). The SnapPuller class in the code if for the Java based replication. It has no relation to the replication scripts or the scripts.conf files. I don't think we should keep shipping these scripts or these scripts.conf files. We can archive it somewhere on the wiki and nuke them from source. Remove unused legacy scripts.conf - Key: SOLR-6876 URL: https://issues.apache.org/jira/browse/SOLR-6876 Project: Solr Issue Type: Bug Affects Versions: 4.10.2, 5.0, Trunk Reporter: Alexandre Rafalovitch Assignee: Erick Erickson Priority: Minor Some of the example collections include *scripts.conf* in the *conf* directory. It is not used by anything in the distribution and is somehow left over from the Solr 1.x legacy days. It should be possible to safe delete it to avoid confusing users trying to understand what different files actually do. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6876) Remove unused legacy scripts.conf
[ https://issues.apache.org/jira/browse/SOLR-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258562#comment-14258562 ] Erick Erickson commented on SOLR-6876: -- Like I said, I'm kind of waiting for folks to either tell me I'm way off base or that it's OK to take them out. OK, they'll be gone today/tomorrow. Thanks! Remove unused legacy scripts.conf - Key: SOLR-6876 URL: https://issues.apache.org/jira/browse/SOLR-6876 Project: Solr Issue Type: Bug Affects Versions: 4.10.2, 5.0, Trunk Reporter: Alexandre Rafalovitch Assignee: Erick Erickson Priority: Minor Some of the example collections include *scripts.conf* in the *conf* directory. It is not used by anything in the distribution and is somehow left over from the Solr 1.x legacy days. It should be possible to safe delete it to avoid confusing users trying to understand what different files actually do. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6876) Remove unused legacy scripts.conf
[ https://issues.apache.org/jira/browse/SOLR-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255791#comment-14255791 ] Erick Erickson commented on SOLR-6876: -- Do we know for sure whether these should go away? I'm unfamiliar with the ins and outs of DIH that I wan to check... Remove unused legacy scripts.conf - Key: SOLR-6876 URL: https://issues.apache.org/jira/browse/SOLR-6876 Project: Solr Issue Type: Bug Affects Versions: 4.10.2, 5.0, Trunk Reporter: Alexandre Rafalovitch Priority: Minor Some of the example collections include *scripts.conf* in the *conf* directory. It is not used by anything in the distribution and is somehow left over from the Solr 1.x legacy days. It should be possible to safe delete it to avoid confusing users trying to understand what different files actually do. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6876) Remove unused legacy scripts.conf
[ https://issues.apache.org/jira/browse/SOLR-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255802#comment-14255802 ] Alexandre Rafalovitch commented on SOLR-6876: - They are not referenced by name by anything in the distribution. I did a grep search for them. And removing them passes all the test. And seem to be related to the ancient Solr 1.x replication that's also not shipped any more (as per discussion on the dev mailing list and the only place mentioned in the sources). I could not figure out any other way to confirm their usefulness. Remove unused legacy scripts.conf - Key: SOLR-6876 URL: https://issues.apache.org/jira/browse/SOLR-6876 Project: Solr Issue Type: Bug Affects Versions: 4.10.2, 5.0, Trunk Reporter: Alexandre Rafalovitch Assignee: Erick Erickson Priority: Minor Some of the example collections include *scripts.conf* in the *conf* directory. It is not used by anything in the distribution and is somehow left over from the Solr 1.x legacy days. It should be possible to safe delete it to avoid confusing users trying to understand what different files actually do. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6876) Remove unused legacy scripts.conf
[ https://issues.apache.org/jira/browse/SOLR-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255812#comment-14255812 ] Erick Erickson commented on SOLR-6876: -- Right, mostly I'm giving people with looonng memories a chance to chime in before I commit it in case there's some web page out there that references them, there's no guarantee that tests cover it. I fully expect you're right, I'll probably commit this tomorrow unless 1 people with long memories tell us that any of them are used or 2 people familiar with the code tell us that they're unnecessary Thanks! Remove unused legacy scripts.conf - Key: SOLR-6876 URL: https://issues.apache.org/jira/browse/SOLR-6876 Project: Solr Issue Type: Bug Affects Versions: 4.10.2, 5.0, Trunk Reporter: Alexandre Rafalovitch Assignee: Erick Erickson Priority: Minor Some of the example collections include *scripts.conf* in the *conf* directory. It is not used by anything in the distribution and is somehow left over from the Solr 1.x legacy days. It should be possible to safe delete it to avoid confusing users trying to understand what different files actually do. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6876) Remove unused legacy scripts.conf
[ https://issues.apache.org/jira/browse/SOLR-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256358#comment-14256358 ] Koji Sekiguchi commented on SOLR-6876: -- I think scripts.conf file is not for DIH, but it is for replication scripts. sold/scripts/scripts-util includes scripts.conf and scripts-util is included from many scripts in solr/scripts directory. I don't know Solr users in the world still use shell script based replication, except me. Remove unused legacy scripts.conf - Key: SOLR-6876 URL: https://issues.apache.org/jira/browse/SOLR-6876 Project: Solr Issue Type: Bug Affects Versions: 4.10.2, 5.0, Trunk Reporter: Alexandre Rafalovitch Assignee: Erick Erickson Priority: Minor Some of the example collections include *scripts.conf* in the *conf* directory. It is not used by anything in the distribution and is somehow left over from the Solr 1.x legacy days. It should be possible to safe delete it to avoid confusing users trying to understand what different files actually do. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6876) Remove unused legacy scripts.conf
[
https://issues.apache.org/jira/browse/SOLR-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255201#comment-14255201
]
Alexandre Rafalovitch commented on SOLR-6876:
-
Fix - delete the following files:
{quote}
solr/example/example-DIH/solr/db/conf/scripts.conf
solr/example/example-DIH/solr/mail/conf/scripts.conf
solr/example/example-DIH/solr/rss/conf/scripts.conf
solr/example/example-DIH/solr/solr/conf/scripts.conf
solr/server/solr/configsets/sample_techproducts_configs/conf/scripts.conf
{quote}
*ant test* passes with the files deleted.
Remove unused legacy scripts.conf
-
Key: SOLR-6876
URL: https://issues.apache.org/jira/browse/SOLR-6876
Project: Solr
Issue Type: Bug
Affects Versions: 4.10.2, 5.0, Trunk
Reporter: Alexandre Rafalovitch
Priority: Minor
Some of the example collections include *scripts.conf* in the *conf*
directory. It is not used by anything in the distribution and is somehow left
over from the Solr 1.x legacy days.
It should be possible to safe delete it to avoid confusing users trying to
understand what different files actually do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
