[jira] [Commented] (SOLR-6954) Considering changing SolrClient#shutdown to SolrClient#close.
[ https://issues.apache.org/jira/browse/SOLR-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295075#comment-14295075 ] ASF subversion and git services commented on SOLR-6954: --- Commit 1655263 from [~romseygeek] in branch 'dev/trunk' [ https://svn.apache.org/r1655263 ] SOLR-6954: SolrClient implements Closeable Considering changing SolrClient#shutdown to SolrClient#close. - Key: SOLR-6954 URL: https://issues.apache.org/jira/browse/SOLR-6954 Project: Solr Issue Type: Improvement Reporter: Mark Miller Fix For: 5.0, Trunk Attachments: SOLR-6954.patch, SOLR-6954.patch, SOLR-6954.patch SolrClient#shutdown is not as odd as SolrServer#shutdown, but as we want users to release these objects, close is more standard and if we implement Closeable, tools help point out leaks. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6954) Considering changing SolrClient#shutdown to SolrClient#close.
[ https://issues.apache.org/jira/browse/SOLR-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295094#comment-14295094 ] ASF subversion and git services commented on SOLR-6954: --- Commit 1655277 from [~romseygeek] in branch 'dev/trunk' [ https://svn.apache.org/r1655277 ] SOLR-6954: Remove deprecated SolrClient.shutdown() method from trunk Considering changing SolrClient#shutdown to SolrClient#close. - Key: SOLR-6954 URL: https://issues.apache.org/jira/browse/SOLR-6954 Project: Solr Issue Type: Improvement Reporter: Mark Miller Fix For: 5.0, Trunk Attachments: SOLR-6954.patch, SOLR-6954.patch, SOLR-6954.patch SolrClient#shutdown is not as odd as SolrServer#shutdown, but as we want users to release these objects, close is more standard and if we implement Closeable, tools help point out leaks. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6954) Considering changing SolrClient#shutdown to SolrClient#close.
[ https://issues.apache.org/jira/browse/SOLR-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295089#comment-14295089 ] ASF subversion and git services commented on SOLR-6954: --- Commit 1655273 from [~romseygeek] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1655273 ] SOLR-6954: SolrClient implements Closeable Considering changing SolrClient#shutdown to SolrClient#close. - Key: SOLR-6954 URL: https://issues.apache.org/jira/browse/SOLR-6954 Project: Solr Issue Type: Improvement Reporter: Mark Miller Fix For: 5.0, Trunk Attachments: SOLR-6954.patch, SOLR-6954.patch, SOLR-6954.patch SolrClient#shutdown is not as odd as SolrServer#shutdown, but as we want users to release these objects, close is more standard and if we implement Closeable, tools help point out leaks. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6954) Considering changing SolrClient#shutdown to SolrClient#close.
[ https://issues.apache.org/jira/browse/SOLR-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294197#comment-14294197 ] Alan Woodward commented on SOLR-6954: - I plan on committing this tomorrow. Considering changing SolrClient#shutdown to SolrClient#close. - Key: SOLR-6954 URL: https://issues.apache.org/jira/browse/SOLR-6954 Project: Solr Issue Type: Improvement Reporter: Mark Miller Fix For: 5.0, Trunk Attachments: SOLR-6954.patch, SOLR-6954.patch SolrClient#shutdown is not as odd as SolrServer#shutdown, but as we want users to release these objects, close is more standard and if we implement Closeable, tools help point out leaks. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6954) Considering changing SolrClient#shutdown to SolrClient#close.
[ https://issues.apache.org/jira/browse/SOLR-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14286322#comment-14286322 ] Tomás Fernández Löbbe commented on SOLR-6954: - I think it's better if close delegates in shutdown for now, that way if someone has extended shutdown their code would still work. Considering changing SolrClient#shutdown to SolrClient#close. - Key: SOLR-6954 URL: https://issues.apache.org/jira/browse/SOLR-6954 Project: Solr Issue Type: Improvement Reporter: Mark Miller Fix For: 5.0, Trunk Attachments: SOLR-6954.patch SolrClient#shutdown is not as odd as SolrServer#shutdown, but as we want users to release these objects, close is more standard and if we implement Closeable, tools help point out leaks. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
Re: [jira] [Commented] (SOLR-6954) Considering changing SolrClient#shutdown to SolrClient#close.
+1 on CC too. On Sat, Jan 10, 2015 at 3:41 PM Alan Woodward (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/SOLR-6954?page= com.atlassian.jira.plugin.system.issuetabpanels:comment- tabpanelfocusedCommentId=14272687#comment-14272687 ] Alan Woodward commented on SOLR-6954: - +1. I'd suggest we just make shutdown() delegate to close() and deprecate it. Might be worth doing the same thing for CoreContainer? Considering changing SolrClient#shutdown to SolrClient#close. - Key: SOLR-6954 URL: https://issues.apache.org/jira/browse/SOLR-6954 Project: Solr Issue Type: Improvement Reporter: Mark Miller Fix For: 5.0, Trunk SolrClient#shutdown is not as odd as SolrServer#shutdown, but as we want users to release these objects, close is more standard and if we implement Closeable, tools help point out leaks. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6954) Considering changing SolrClient#shutdown to SolrClient#close.
[ https://issues.apache.org/jira/browse/SOLR-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14272962#comment-14272962 ] Uwe Schindler commented on SOLR-6954: - +1, especially because of warnings in IDEs! :-) Considering changing SolrClient#shutdown to SolrClient#close. - Key: SOLR-6954 URL: https://issues.apache.org/jira/browse/SOLR-6954 Project: Solr Issue Type: Improvement Reporter: Mark Miller Fix For: 5.0, Trunk SolrClient#shutdown is not as odd as SolrServer#shutdown, but as we want users to release these objects, close is more standard and if we implement Closeable, tools help point out leaks. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6954) Considering changing SolrClient#shutdown to SolrClient#close.
[ https://issues.apache.org/jira/browse/SOLR-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14272566#comment-14272566 ] Mark Miller commented on SOLR-6954: --- Of course we can leave shutdown for now and deprecate if we want to allow a slow path. Considering changing SolrClient#shutdown to SolrClient#close. - Key: SOLR-6954 URL: https://issues.apache.org/jira/browse/SOLR-6954 Project: Solr Issue Type: Improvement Reporter: Mark Miller Fix For: 5.0, Trunk SolrClient#shutdown is not as odd as SolrServer#shutdown, but as we want users to release these objects, close is more standard and if we implement Closeable, tools help point out leaks. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6954) Considering changing SolrClient#shutdown to SolrClient#close.
[ https://issues.apache.org/jira/browse/SOLR-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14272687#comment-14272687 ] Alan Woodward commented on SOLR-6954: - +1. I'd suggest we just make shutdown() delegate to close() and deprecate it. Might be worth doing the same thing for CoreContainer? Considering changing SolrClient#shutdown to SolrClient#close. - Key: SOLR-6954 URL: https://issues.apache.org/jira/browse/SOLR-6954 Project: Solr Issue Type: Improvement Reporter: Mark Miller Fix For: 5.0, Trunk SolrClient#shutdown is not as odd as SolrServer#shutdown, but as we want users to release these objects, close is more standard and if we implement Closeable, tools help point out leaks. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
