[jira] [Commented] (SOLR-7336) Add State enum to Replica
[ https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14514550#comment-14514550 ] ASF subversion and git services commented on SOLR-7336: --- Commit 1676351 from hoss...@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1676351 ] preemptive cleanup of 'Upgrading' section for 5.2 (SOLR-7325, SOLR-7336, SOLR-4839 - merge r1676350) Add State enum to Replica - Key: SOLR-7336 URL: https://issues.apache.org/jira/browse/SOLR-7336 Project: Solr Issue Type: Improvement Components: SolrJ Reporter: Shai Erera Assignee: Shai Erera Fix For: Trunk, 5.2 Attachments: SOLR-7336.patch, SOLR-7336.patch, SOLR-7336.patch Following SOLR-7325, this issue adds a State enum to Replica. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7336) Add State enum to Replica
[ https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14514544#comment-14514544 ] ASF subversion and git services commented on SOLR-7336: --- Commit 1676350 from hoss...@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1676350 ] preemptive cleanup of 'Upgrading' section for 5.2 (SOLR-7325, SOLR-7336, SOLR-4839) Add State enum to Replica - Key: SOLR-7336 URL: https://issues.apache.org/jira/browse/SOLR-7336 Project: Solr Issue Type: Improvement Components: SolrJ Reporter: Shai Erera Assignee: Shai Erera Fix For: Trunk, 5.2 Attachments: SOLR-7336.patch, SOLR-7336.patch, SOLR-7336.patch Following SOLR-7325, this issue adds a State enum to Replica. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7336) Add State enum to Replica
[ https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14395596#comment-14395596 ] ASF subversion and git services commented on SOLR-7336: --- Commit 1671240 from [~shaie] in branch 'dev/trunk' [ https://svn.apache.org/r1671240 ] SOLR-7336: Add State enum to Replica Add State enum to Replica - Key: SOLR-7336 URL: https://issues.apache.org/jira/browse/SOLR-7336 Project: Solr Issue Type: Improvement Components: SolrJ Reporter: Shai Erera Assignee: Shai Erera Attachments: SOLR-7336.patch, SOLR-7336.patch, SOLR-7336.patch Following SOLR-7325, this issue adds a State enum to Replica. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7336) Add State enum to Replica
[ https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14395607#comment-14395607 ] ASF subversion and git services commented on SOLR-7336: --- Commit 1671246 from [~shaie] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1671246 ] SOLR-7336: Add State enum to Replica Add State enum to Replica - Key: SOLR-7336 URL: https://issues.apache.org/jira/browse/SOLR-7336 Project: Solr Issue Type: Improvement Components: SolrJ Reporter: Shai Erera Assignee: Shai Erera Attachments: SOLR-7336.patch, SOLR-7336.patch, SOLR-7336.patch Following SOLR-7325, this issue adds a State enum to Replica. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7336) Add State enum to Replica
[ https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14394580#comment-14394580 ] Mark Miller commented on SOLR-7336: --- Looks good to me. Add State enum to Replica - Key: SOLR-7336 URL: https://issues.apache.org/jira/browse/SOLR-7336 Project: Solr Issue Type: Improvement Components: SolrJ Reporter: Shai Erera Assignee: Shai Erera Attachments: SOLR-7336.patch, SOLR-7336.patch, SOLR-7336.patch Following SOLR-7325, this issue adds a State enum to Replica. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7336) Add State enum to Replica
[ https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14394044#comment-14394044 ] Shai Erera commented on SOLR-7336: -- [~markrmil...@gmail.com] if you have no objections, I will commit these changes. Add State enum to Replica - Key: SOLR-7336 URL: https://issues.apache.org/jira/browse/SOLR-7336 Project: Solr Issue Type: Improvement Components: SolrJ Reporter: Shai Erera Assignee: Shai Erera Attachments: SOLR-7336.patch, SOLR-7336.patch, SOLR-7336.patch Following SOLR-7325, this issue adds a State enum to Replica. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7336) Add State enum to Replica
[ https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392817#comment-14392817 ] Mark Miller commented on SOLR-7336: --- Notes on states: bq. ACTIVE The replica is ready to receive updates and queries. bq. DOWN Some of these names came before things were fully fleshed out :) DOWN is actually the first state before RECOVERING. I think tlog replay happens in DOWN, though that is a bit of a bug IMO. We should probably have a new state for it or something. A node in DOWN should be actively trying to move to RECOVERYING. bq. RECOVERING The node is recovering from the leader. This might involve peersync or full replication or finding out things are already in sync. bq. RECOVERY_FAILED RECOVERY attempts have not worked, something is not right. NOTE: This state doesn't matter if the node is not part of /live_nodes in zk - in that case the node is not part of the cluster and it's state should be discarded. Add State enum to Replica - Key: SOLR-7336 URL: https://issues.apache.org/jira/browse/SOLR-7336 Project: Solr Issue Type: Improvement Components: SolrJ Reporter: Shai Erera Assignee: Shai Erera Attachments: SOLR-7336.patch Following SOLR-7325, this issue adds a State enum to Replica. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7336) Add State enum to Replica
[ https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392811#comment-14392811 ] Mark Miller commented on SOLR-7336: --- SYNC is just cruft - part of some prototyping at the way start and never used. Add State enum to Replica - Key: SOLR-7336 URL: https://issues.apache.org/jira/browse/SOLR-7336 Project: Solr Issue Type: Improvement Components: SolrJ Reporter: Shai Erera Assignee: Shai Erera Attachments: SOLR-7336.patch Following SOLR-7325, this issue adds a State enum to Replica. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7336) Add State enum to Replica
[ https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392582#comment-14392582 ] Shai Erera commented on SOLR-7336: -- Forgot to mention that I also removed ZkStateReader.SYNC which seemed unused except by a test which waited on replicas to be active. But I don't think a replica is put in that state? Also, would appreciate if someone can review the documentation of the Replica.State values. Add State enum to Replica - Key: SOLR-7336 URL: https://issues.apache.org/jira/browse/SOLR-7336 Project: Solr Issue Type: Improvement Components: SolrJ Reporter: Shai Erera Assignee: Shai Erera Attachments: SOLR-7336.patch Following SOLR-7325, this issue adds a State enum to Replica. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7336) Add State enum to Replica
[
https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392910#comment-14392910
]
Mark Miller commented on SOLR-7336:
---
{quote}
+/**
+ * A replica can be in that state in two cases:
+ * ul
+ * liIt is truly down, i.e. hosted on a node that is no longer live./li
+ * liIt failed to acknowledge an update request from the leader and is
+ * catching up with the leader's transaction log./li
+ * /ul
{quote}
Neither of those statements are really currently correct though. It's as I say
above:
DOWN is the first state before RECOVERING. A node in DOWN should be actively
trying to move to RECOVERING.
The main reason for DOWN is so that leaders can see a replicas state change to
RECOVERING.
It doesn't mean it's truly down or hosted on a node that is no longer live, nor
does it necessarily imply an update failed from the leader.
Add State enum to Replica
-
Key: SOLR-7336
URL: https://issues.apache.org/jira/browse/SOLR-7336
Project: Solr
Issue Type: Improvement
Components: SolrJ
Reporter: Shai Erera
Assignee: Shai Erera
Attachments: SOLR-7336.patch, SOLR-7336.patch
Following SOLR-7325, this issue adds a State enum to Replica.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7336) Add State enum to Replica
[ https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392954#comment-14392954 ] Mark Miller commented on SOLR-7336: --- bq. We try and publish DOWN on shutdown Oh yeah, and I also think it was an attempt at taking nodes out of rotation on shutdown cleanly - just dropping and staying in ACTIVE in clusterstate.json can leave connections coming in during shutdown and this slows stuff down (there is a JIRA somewhere). CoreContainer#shutdown is actually too late to do this anyway though - it gets called too late. We need some explicit REST command or something to move to the DOWN state before we start container shutdown. Add State enum to Replica - Key: SOLR-7336 URL: https://issues.apache.org/jira/browse/SOLR-7336 Project: Solr Issue Type: Improvement Components: SolrJ Reporter: Shai Erera Assignee: Shai Erera Attachments: SOLR-7336.patch, SOLR-7336.patch Following SOLR-7325, this issue adds a State enum to Replica. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7336) Add State enum to Replica
[ https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392920#comment-14392920 ] Shai Erera commented on SOLR-7336: -- OK. I will update the documentation to what you put in quotes (and that only, correct?). But isn't a replica in DOWN, when the node it's on is also down? I know I saw that happening after shutting down Solr on a node. Add State enum to Replica - Key: SOLR-7336 URL: https://issues.apache.org/jira/browse/SOLR-7336 Project: Solr Issue Type: Improvement Components: SolrJ Reporter: Shai Erera Assignee: Shai Erera Attachments: SOLR-7336.patch, SOLR-7336.patch Following SOLR-7325, this issue adds a State enum to Replica. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7336) Add State enum to Replica
[ https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392923#comment-14392923 ] Mark Miller commented on SOLR-7336: --- bq. and is catching up with the leader's transaction log A DOWN node may or may not be catching up from it's *own* transaction log. Add State enum to Replica - Key: SOLR-7336 URL: https://issues.apache.org/jira/browse/SOLR-7336 Project: Solr Issue Type: Improvement Components: SolrJ Reporter: Shai Erera Assignee: Shai Erera Attachments: SOLR-7336.patch, SOLR-7336.patch Following SOLR-7325, this issue adds a State enum to Replica. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7336) Add State enum to Replica
[ https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392931#comment-14392931 ] Mark Miller commented on SOLR-7336: --- bq. But isn't a replica in DOWN, when the node it's on is also down? I know I saw that happening after shutting down Solr on a node. We try and publish DOWN on shutdown just because on startup we always want to see the progression DOWN, RECOVERING and this makes it more pronounced and because we just want to make a best effort to make the node not ACTIVE in clusterstate.json just because it does confuse users that you *have* to consult zk live_nodes to know the actual state. It's not really required, it came later, it's kind of a best effort thing. The key is, if a node is really shutdown, it's zk live node is gone. A zk live node being gone means ignore the state. You need both pieces of info - state is useless by itself. See the Solr Cloud admin UI. It won't show a node that is shutdown as DOWN. It's zk live node is gone, and so its marked as gray and gone. DOWN is the wrong name, but that's what it is. Add State enum to Replica - Key: SOLR-7336 URL: https://issues.apache.org/jira/browse/SOLR-7336 Project: Solr Issue Type: Improvement Components: SolrJ Reporter: Shai Erera Assignee: Shai Erera Attachments: SOLR-7336.patch, SOLR-7336.patch Following SOLR-7325, this issue adds a State enum to Replica. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7336) Add State enum to Replica
[ https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392894#comment-14392894 ] Shai Erera commented on SOLR-7336: -- bq. ACTIVE Changed. bq. RECOVERING Changed. bq. RECOVERY_FAILED Changed. bq. DOWN Left as is for now. When we change the semantics and logic, we should change the documentation too. Add State enum to Replica - Key: SOLR-7336 URL: https://issues.apache.org/jira/browse/SOLR-7336 Project: Solr Issue Type: Improvement Components: SolrJ Reporter: Shai Erera Assignee: Shai Erera Attachments: SOLR-7336.patch Following SOLR-7325, this issue adds a State enum to Replica. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
