[jira] [Commented] (SOLR-7655) Perf bug- DefaultSolrHighlighter.getSpanQueryScorer triggers MultiFields.getMergedFieldInfos
[ https://issues.apache.org/jira/browse/SOLR-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14580428#comment-14580428 ] Ere Maijala commented on SOLR-7655: --- Took me a while to get a build environment up, but results look very promising. My very unscientific benchmark shows that the highlighter may now be even a bit faster than in Solr 4.10.2 at least in some cases. Thanks for the great work, [~dsmiley]! Perf bug- DefaultSolrHighlighter.getSpanQueryScorer triggers MultiFields.getMergedFieldInfos Key: SOLR-7655 URL: https://issues.apache.org/jira/browse/SOLR-7655 Project: Solr Issue Type: Bug Components: highlighter Affects Versions: 5.0 Reporter: David Smiley Assignee: David Smiley Attachments: SOLR-7655.patch It appears grabbing the FieldInfos from the SlowCompositeReaderWrapper is slow. It isn't cached. The DefaultSolrHighligher in SOLR-6196 (v5.0) uses it to ascertain if there are payloads. Instead it can grab it from the Terms instance, which is cached. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7655) Perf bug- DefaultSolrHighlighter.getSpanQueryScorer triggers MultiFields.getMergedFieldInfos
[ https://issues.apache.org/jira/browse/SOLR-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14580499#comment-14580499 ] ASF subversion and git services commented on SOLR-7655: --- Commit 1684667 from [~dsmiley] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1684667 ] SOLR-7655: Speed up DefaultSolrHighlighter's check for the existence of payloads. Perf bug- DefaultSolrHighlighter.getSpanQueryScorer triggers MultiFields.getMergedFieldInfos Key: SOLR-7655 URL: https://issues.apache.org/jira/browse/SOLR-7655 Project: Solr Issue Type: Bug Components: highlighter Affects Versions: 5.0 Reporter: David Smiley Assignee: David Smiley Attachments: SOLR-7655.patch It appears grabbing the FieldInfos from the SlowCompositeReaderWrapper is slow. It isn't cached. The DefaultSolrHighligher in SOLR-6196 (v5.0) uses it to ascertain if there are payloads. Instead it can grab it from the Terms instance, which is cached. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7655) Perf bug- DefaultSolrHighlighter.getSpanQueryScorer triggers MultiFields.getMergedFieldInfos
[ https://issues.apache.org/jira/browse/SOLR-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14580502#comment-14580502 ] ASF subversion and git services commented on SOLR-7655: --- Commit 1684668 from [~dsmiley] in branch 'dev/branches/lucene_solr_5_2' [ https://svn.apache.org/r1684668 ] SOLR-7655: Speed up DefaultSolrHighlighter's check for the existence of payloads. Perf bug- DefaultSolrHighlighter.getSpanQueryScorer triggers MultiFields.getMergedFieldInfos Key: SOLR-7655 URL: https://issues.apache.org/jira/browse/SOLR-7655 Project: Solr Issue Type: Bug Components: highlighter Affects Versions: 5.0 Reporter: David Smiley Assignee: David Smiley Attachments: SOLR-7655.patch It appears grabbing the FieldInfos from the SlowCompositeReaderWrapper is slow. It isn't cached. The DefaultSolrHighligher in SOLR-6196 (v5.0) uses it to ascertain if there are payloads. Instead it can grab it from the Terms instance, which is cached. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7655) Perf bug- DefaultSolrHighlighter.getSpanQueryScorer triggers MultiFields.getMergedFieldInfos
[ https://issues.apache.org/jira/browse/SOLR-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14580494#comment-14580494 ] ASF subversion and git services commented on SOLR-7655: --- Commit 1684665 from [~dsmiley] in branch 'dev/trunk' [ https://svn.apache.org/r1684665 ] SOLR-7655: Speed up DefaultSolrHighlighter's check for the existence of payloads Perf bug- DefaultSolrHighlighter.getSpanQueryScorer triggers MultiFields.getMergedFieldInfos Key: SOLR-7655 URL: https://issues.apache.org/jira/browse/SOLR-7655 Project: Solr Issue Type: Bug Components: highlighter Affects Versions: 5.0 Reporter: David Smiley Assignee: David Smiley Attachments: SOLR-7655.patch It appears grabbing the FieldInfos from the SlowCompositeReaderWrapper is slow. It isn't cached. The DefaultSolrHighligher in SOLR-6196 (v5.0) uses it to ascertain if there are payloads. Instead it can grab it from the Terms instance, which is cached. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7655) Perf bug- DefaultSolrHighlighter.getSpanQueryScorer triggers MultiFields.getMergedFieldInfos
[ https://issues.apache.org/jira/browse/SOLR-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14580127#comment-14580127 ] Shalin Shekhar Mangar commented on SOLR-7655: - Looks good to me. I don't know if you're online but if not, I'll commit your patch in a couple of hours and create the RC. Perf bug- DefaultSolrHighlighter.getSpanQueryScorer triggers MultiFields.getMergedFieldInfos Key: SOLR-7655 URL: https://issues.apache.org/jira/browse/SOLR-7655 Project: Solr Issue Type: Bug Components: highlighter Affects Versions: 5.0 Reporter: David Smiley Assignee: David Smiley Attachments: SOLR-7655.patch It appears grabbing the FieldInfos from the SlowCompositeReaderWrapper is slow. It isn't cached. The DefaultSolrHighligher in SOLR-6196 (v5.0) uses it to ascertain if there are payloads. Instead it can grab it from the Terms instance, which is cached. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7655) Perf bug- DefaultSolrHighlighter.getSpanQueryScorer triggers MultiFields.getMergedFieldInfos
[
https://issues.apache.org/jira/browse/SOLR-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14579476#comment-14579476
]
David Smiley commented on SOLR-7655:
Suggested fix:
{code:java}
try {
scorer.setUsePayloads(request.getParams().getFieldBool(fieldName,
HighlightParams.PAYLOADS,
request.getSearcher().getLeafReader().fields().terms(fieldName).hasPayloads()));
// It'd be nice to know if payloads are on the tokenStream but the
presence of the attribute isn't a good
// indicator.
} catch (IOException e) {
throw new RuntimeException(e);
}
{code}
I'm going to try this now with Solr's tests, then post a patch.
Perf bug- DefaultSolrHighlighter.getSpanQueryScorer triggers
MultiFields.getMergedFieldInfos
Key: SOLR-7655
URL: https://issues.apache.org/jira/browse/SOLR-7655
Project: Solr
Issue Type: Bug
Components: highlighter
Affects Versions: 5.0
Reporter: David Smiley
Assignee: David Smiley
It appears grabbing the FieldInfos from the SlowCompositeReaderWrapper is
slow. It isn't cached. The DefaultSolrHighligher in SOLR-6196 (v5.0) uses
it to ascertain if there are payloads. Instead it can grab it from the Terms
instance, which is cached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7655) Perf bug- DefaultSolrHighlighter.getSpanQueryScorer triggers MultiFields.getMergedFieldInfos
[ https://issues.apache.org/jira/browse/SOLR-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14579478#comment-14579478 ] David Smiley commented on SOLR-7655: This was discovered via a commenter here: https://issues.apache.org/jira/browse/SOLR-5855?focusedCommentId=14578437page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14578437 (the purpose of that issue is unrelated to the discovery in the stack traces posted) Perf bug- DefaultSolrHighlighter.getSpanQueryScorer triggers MultiFields.getMergedFieldInfos Key: SOLR-7655 URL: https://issues.apache.org/jira/browse/SOLR-7655 Project: Solr Issue Type: Bug Components: highlighter Affects Versions: 5.0 Reporter: David Smiley Assignee: David Smiley It appears grabbing the FieldInfos from the SlowCompositeReaderWrapper is slow. It isn't cached. The DefaultSolrHighligher in SOLR-6196 (v5.0) uses it to ascertain if there are payloads. Instead it can grab it from the Terms instance, which is cached. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
