[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941316#comment-14941316 ] Mark Miller commented on SOLR-7746: --- FY on the CHANGES.txt entry for this one: {noformat} SOLR-7746: Ping requests stopped working with distrib=true in Solr 5.2.1. (Michael Sun) {noformat} It should read: {noformat} SOLR-7746: Ping requests stopped working with distrib=true in Solr 5.2.1. (Alexey Serba, Michael Sun via Greg Chanan) {noformat} Reporter always gets credit and if committer didn't really contribute we use the via credit. > Ping requests stopped working with distrib=true in Solr 5.2.1 > - > > Key: SOLR-7746 > URL: https://issues.apache.org/jira/browse/SOLR-7746 > Project: Solr > Issue Type: Bug > Components: SolrCloud >Affects Versions: 5.2.1 >Reporter: Alexey Serba >Assignee: Gregory Chanan > Fix For: Trunk, 5.4 > > Attachments: SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, > SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch > > > {noformat:title="steps to reproduce"} > # start 1 node SolrCloud cluster > sh> ./bin/solr -c -p > # create a test collection (we won’t use it, but I just want to it to load > solr configs to Zk) > ./bin/solr create_collection -c test -d sample_techproducts_configs -p > # create another test collection with 2 shards > curl > 'http://localhost:/solr/admin/collections?action=CREATE=test2=2=1=2=test' > # try distrib ping request > curl > 'http://localhost:/solr/test2/admin/ping?wt=json=true=true' > ... > "error":{ > "msg":"Ping query caused exception: Error from server at > http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the > PingRequestHandler recursively" > ... > {noformat} > {noformat:title="Exception"} > 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 > core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: > Cannot execute the PingRequestHandler recursively > at > org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) > at > org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) > at > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) > at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) > at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) > at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941394#comment-14941394 ] Gregory Chanan commented on SOLR-7746: -- Thanks Mark, both the "via" and reporter points make sense. Should I go back and update the CHANGES.txt? > Ping requests stopped working with distrib=true in Solr 5.2.1 > - > > Key: SOLR-7746 > URL: https://issues.apache.org/jira/browse/SOLR-7746 > Project: Solr > Issue Type: Bug > Components: SolrCloud >Affects Versions: 5.2.1 >Reporter: Alexey Serba >Assignee: Gregory Chanan > Fix For: Trunk, 5.4 > > Attachments: SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, > SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch > > > {noformat:title="steps to reproduce"} > # start 1 node SolrCloud cluster > sh> ./bin/solr -c -p > # create a test collection (we won’t use it, but I just want to it to load > solr configs to Zk) > ./bin/solr create_collection -c test -d sample_techproducts_configs -p > # create another test collection with 2 shards > curl > 'http://localhost:/solr/admin/collections?action=CREATE=test2=2=1=2=test' > # try distrib ping request > curl > 'http://localhost:/solr/test2/admin/ping?wt=json=true=true' > ... > "error":{ > "msg":"Ping query caused exception: Error from server at > http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the > PingRequestHandler recursively" > ... > {noformat} > {noformat:title="Exception"} > 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 > core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: > Cannot execute the PingRequestHandler recursively > at > org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) > at > org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) > at > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) > at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) > at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) > at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941458#comment-14941458 ] Mark Miller commented on SOLR-7746: --- Yeah, personally I think it's worth it for the reporter credit. > Ping requests stopped working with distrib=true in Solr 5.2.1 > - > > Key: SOLR-7746 > URL: https://issues.apache.org/jira/browse/SOLR-7746 > Project: Solr > Issue Type: Bug > Components: SolrCloud >Affects Versions: 5.2.1 >Reporter: Alexey Serba >Assignee: Gregory Chanan > Fix For: Trunk, 5.4 > > Attachments: SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, > SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch > > > {noformat:title="steps to reproduce"} > # start 1 node SolrCloud cluster > sh> ./bin/solr -c -p > # create a test collection (we won’t use it, but I just want to it to load > solr configs to Zk) > ./bin/solr create_collection -c test -d sample_techproducts_configs -p > # create another test collection with 2 shards > curl > 'http://localhost:/solr/admin/collections?action=CREATE=test2=2=1=2=test' > # try distrib ping request > curl > 'http://localhost:/solr/test2/admin/ping?wt=json=true=true' > ... > "error":{ > "msg":"Ping query caused exception: Error from server at > http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the > PingRequestHandler recursively" > ... > {noformat} > {noformat:title="Exception"} > 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 > core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: > Cannot execute the PingRequestHandler recursively > at > org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) > at > org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) > at > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) > at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) > at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) > at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941896#comment-14941896 ] ASF subversion and git services commented on SOLR-7746: --- Commit 1706499 from gcha...@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1706499 ] SOLR-7746: Update credit in CHANGES.txt > Ping requests stopped working with distrib=true in Solr 5.2.1 > - > > Key: SOLR-7746 > URL: https://issues.apache.org/jira/browse/SOLR-7746 > Project: Solr > Issue Type: Bug > Components: SolrCloud >Affects Versions: 5.2.1 >Reporter: Alexey Serba >Assignee: Gregory Chanan > Fix For: Trunk, 5.4 > > Attachments: SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, > SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch > > > {noformat:title="steps to reproduce"} > # start 1 node SolrCloud cluster > sh> ./bin/solr -c -p > # create a test collection (we won’t use it, but I just want to it to load > solr configs to Zk) > ./bin/solr create_collection -c test -d sample_techproducts_configs -p > # create another test collection with 2 shards > curl > 'http://localhost:/solr/admin/collections?action=CREATE=test2=2=1=2=test' > # try distrib ping request > curl > 'http://localhost:/solr/test2/admin/ping?wt=json=true=true' > ... > "error":{ > "msg":"Ping query caused exception: Error from server at > http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the > PingRequestHandler recursively" > ... > {noformat} > {noformat:title="Exception"} > 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 > core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: > Cannot execute the PingRequestHandler recursively > at > org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) > at > org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) > at > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) > at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) > at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) > at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941908#comment-14941908 ] ASF subversion and git services commented on SOLR-7746: --- Commit 1706502 from gcha...@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1706502 ] SOLR-7746: Update credit in CHANGES.txt > Ping requests stopped working with distrib=true in Solr 5.2.1 > - > > Key: SOLR-7746 > URL: https://issues.apache.org/jira/browse/SOLR-7746 > Project: Solr > Issue Type: Bug > Components: SolrCloud >Affects Versions: 5.2.1 >Reporter: Alexey Serba >Assignee: Gregory Chanan > Fix For: Trunk, 5.4 > > Attachments: SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, > SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch > > > {noformat:title="steps to reproduce"} > # start 1 node SolrCloud cluster > sh> ./bin/solr -c -p > # create a test collection (we won’t use it, but I just want to it to load > solr configs to Zk) > ./bin/solr create_collection -c test -d sample_techproducts_configs -p > # create another test collection with 2 shards > curl > 'http://localhost:/solr/admin/collections?action=CREATE=test2=2=1=2=test' > # try distrib ping request > curl > 'http://localhost:/solr/test2/admin/ping?wt=json=true=true' > ... > "error":{ > "msg":"Ping query caused exception: Error from server at > http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the > PingRequestHandler recursively" > ... > {noformat} > {noformat:title="Exception"} > 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 > core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: > Cannot execute the PingRequestHandler recursively > at > org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) > at > org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) > at > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) > at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) > at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) > at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741829#comment-14741829 ] ASF subversion and git services commented on SOLR-7746: --- Commit 1702581 from gcha...@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1702581 ] SOLR-7746: Ping requests stopped working with distrib=true in Solr 5.2.1 > Ping requests stopped working with distrib=true in Solr 5.2.1 > - > > Key: SOLR-7746 > URL: https://issues.apache.org/jira/browse/SOLR-7746 > Project: Solr > Issue Type: Bug > Components: SolrCloud >Affects Versions: 5.2.1 >Reporter: Alexey Serba >Assignee: Gregory Chanan > Attachments: SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, > SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch > > > {noformat:title="steps to reproduce"} > # start 1 node SolrCloud cluster > sh> ./bin/solr -c -p > # create a test collection (we won’t use it, but I just want to it to load > solr configs to Zk) > ./bin/solr create_collection -c test -d sample_techproducts_configs -p > # create another test collection with 2 shards > curl > 'http://localhost:/solr/admin/collections?action=CREATE=test2=2=1=2=test' > # try distrib ping request > curl > 'http://localhost:/solr/test2/admin/ping?wt=json=true=true' > ... > "error":{ > "msg":"Ping query caused exception: Error from server at > http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the > PingRequestHandler recursively" > ... > {noformat} > {noformat:title="Exception"} > 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 > core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: > Cannot execute the PingRequestHandler recursively > at > org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) > at > org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) > at > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) > at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) > at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) > at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741831#comment-14741831 ] ASF subversion and git services commented on SOLR-7746: --- Commit 1702582 from gcha...@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1702582 ] SOLR-7746: Ping requests stopped working with distrib=true in Solr 5.2.1 > Ping requests stopped working with distrib=true in Solr 5.2.1 > - > > Key: SOLR-7746 > URL: https://issues.apache.org/jira/browse/SOLR-7746 > Project: Solr > Issue Type: Bug > Components: SolrCloud >Affects Versions: 5.2.1 >Reporter: Alexey Serba >Assignee: Gregory Chanan > Attachments: SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, > SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch > > > {noformat:title="steps to reproduce"} > # start 1 node SolrCloud cluster > sh> ./bin/solr -c -p > # create a test collection (we won’t use it, but I just want to it to load > solr configs to Zk) > ./bin/solr create_collection -c test -d sample_techproducts_configs -p > # create another test collection with 2 shards > curl > 'http://localhost:/solr/admin/collections?action=CREATE=test2=2=1=2=test' > # try distrib ping request > curl > 'http://localhost:/solr/test2/admin/ping?wt=json=true=true' > ... > "error":{ > "msg":"Ping query caused exception: Error from server at > http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the > PingRequestHandler recursively" > ... > {noformat} > {noformat:title="Exception"} > 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 > core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: > Cannot execute the PingRequestHandler recursively > at > org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) > at > org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) > at > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) > at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) > at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) > at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731661#comment-14731661 ] Michael Sun commented on SOLR-7746: --- Thanks [~gchanan] for pointing it out. I updated the patch and uploaded it. > Ping requests stopped working with distrib=true in Solr 5.2.1 > - > > Key: SOLR-7746 > URL: https://issues.apache.org/jira/browse/SOLR-7746 > Project: Solr > Issue Type: Bug > Components: SolrCloud >Affects Versions: 5.2.1 >Reporter: Alexey Serba >Assignee: Gregory Chanan > Attachments: SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, > SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch > > > {noformat:title="steps to reproduce"} > # start 1 node SolrCloud cluster > sh> ./bin/solr -c -p > # create a test collection (we won’t use it, but I just want to it to load > solr configs to Zk) > ./bin/solr create_collection -c test -d sample_techproducts_configs -p > # create another test collection with 2 shards > curl > 'http://localhost:/solr/admin/collections?action=CREATE=test2=2=1=2=test' > # try distrib ping request > curl > 'http://localhost:/solr/test2/admin/ping?wt=json=true=true' > ... > "error":{ > "msg":"Ping query caused exception: Error from server at > http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the > PingRequestHandler recursively" > ... > {noformat} > {noformat:title="Exception"} > 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 > core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: > Cannot execute the PingRequestHandler recursively > at > org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) > at > org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) > at > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) > at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) > at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) > at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730038#comment-14730038 ] Gregory Chanan commented on SOLR-7746: -- Actually I found a problem with the test. It looks like {code} Builder jettyConfig = JettyConfig.builder(); {code} doesn't set up the JettyConfig properly for SSL tests. You need to use buildJettyConfig instead. Not sure if we can enforce that in tests automatically. > Ping requests stopped working with distrib=true in Solr 5.2.1 > - > > Key: SOLR-7746 > URL: https://issues.apache.org/jira/browse/SOLR-7746 > Project: Solr > Issue Type: Bug > Components: SolrCloud >Affects Versions: 5.2.1 >Reporter: Alexey Serba >Assignee: Gregory Chanan > Attachments: SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, > SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch > > > {noformat:title="steps to reproduce"} > # start 1 node SolrCloud cluster > sh> ./bin/solr -c -p > # create a test collection (we won’t use it, but I just want to it to load > solr configs to Zk) > ./bin/solr create_collection -c test -d sample_techproducts_configs -p > # create another test collection with 2 shards > curl > 'http://localhost:/solr/admin/collections?action=CREATE=test2=2=1=2=test' > # try distrib ping request > curl > 'http://localhost:/solr/test2/admin/ping?wt=json=true=true' > ... > "error":{ > "msg":"Ping query caused exception: Error from server at > http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the > PingRequestHandler recursively" > ... > {noformat} > {noformat:title="Exception"} > 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 > core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: > Cannot execute the PingRequestHandler recursively > at > org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) > at > org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) > at > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) > at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) > at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) > at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14726269#comment-14726269 ] Gregory Chanan commented on SOLR-7746: -- +1 lgtm. > Ping requests stopped working with distrib=true in Solr 5.2.1 > - > > Key: SOLR-7746 > URL: https://issues.apache.org/jira/browse/SOLR-7746 > Project: Solr > Issue Type: Bug > Components: SolrCloud >Affects Versions: 5.2.1 >Reporter: Alexey Serba > Attachments: SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, > SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch > > > {noformat:title="steps to reproduce"} > # start 1 node SolrCloud cluster > sh> ./bin/solr -c -p > # create a test collection (we won’t use it, but I just want to it to load > solr configs to Zk) > ./bin/solr create_collection -c test -d sample_techproducts_configs -p > # create another test collection with 2 shards > curl > 'http://localhost:/solr/admin/collections?action=CREATE=test2=2=1=2=test' > # try distrib ping request > curl > 'http://localhost:/solr/test2/admin/ping?wt=json=true=true' > ... > "error":{ > "msg":"Ping query caused exception: Error from server at > http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the > PingRequestHandler recursively" > ... > {noformat} > {noformat:title="Exception"} > 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 > core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: > Cannot execute the PingRequestHandler recursively > at > org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) > at > org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) > at > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) > at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) > at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) > at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723848#comment-14723848 ] Michael Sun commented on SOLR-7746: --- That makes sense. The updated patch is uploaded. Thanks [~gchanan] > Ping requests stopped working with distrib=true in Solr 5.2.1 > - > > Key: SOLR-7746 > URL: https://issues.apache.org/jira/browse/SOLR-7746 > Project: Solr > Issue Type: Bug > Components: SolrCloud >Affects Versions: 5.2.1 >Reporter: Alexey Serba > Attachments: SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, > SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch > > > {noformat:title="steps to reproduce"} > # start 1 node SolrCloud cluster > sh> ./bin/solr -c -p > # create a test collection (we won’t use it, but I just want to it to load > solr configs to Zk) > ./bin/solr create_collection -c test -d sample_techproducts_configs -p > # create another test collection with 2 shards > curl > 'http://localhost:/solr/admin/collections?action=CREATE=test2=2=1=2=test' > # try distrib ping request > curl > 'http://localhost:/solr/test2/admin/ping?wt=json=true=true' > ... > "error":{ > "msg":"Ping query caused exception: Error from server at > http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the > PingRequestHandler recursively" > ... > {noformat} > {noformat:title="Exception"} > 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 > core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: > Cannot execute the PingRequestHandler recursively > at > org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) > at > org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) > at > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) > at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) > at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) > at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) > at > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717605#comment-14717605 ] Michael Sun commented on SOLR-7746: --- Thanks [~gchanan] for your comments. The updated patch is uploaded. Ping requests stopped working with distrib=true in Solr 5.2.1 - Key: SOLR-7746 URL: https://issues.apache.org/jira/browse/SOLR-7746 Project: Solr Issue Type: Bug Components: SolrCloud Affects Versions: 5.2.1 Reporter: Alexey Serba Attachments: SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch {noformat:title=steps to reproduce} # start 1 node SolrCloud cluster sh ./bin/solr -c -p # create a test collection (we won’t use it, but I just want to it to load solr configs to Zk) ./bin/solr create_collection -c test -d sample_techproducts_configs -p # create another test collection with 2 shards curl 'http://localhost:/solr/admin/collections?action=CREATEname=test2numShards=2replicationFactor=1maxShardsPerNode=2collection.configName=test' # try distrib ping request curl 'http://localhost:/solr/test2/admin/ping?wt=jsondistrib=trueindent=true' ... error:{ msg:Ping query caused exception: Error from server at http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the PingRequestHandler recursively ... {noformat} {noformat:title=Exception} 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: Cannot execute the PingRequestHandler recursively at org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) at org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715804#comment-14715804 ] Gregory Chanan commented on SOLR-7746: -- 1. You should not modify TestMiniSolrCloudCluster. That's for testing whether the MiniSolrCloudCluster itself works. Write a test that uses the MiniSolrCloudCluster, there should be a number of examples. Or maybe you don't even need it -- can SolrPingTest satisfy what you need? 2. {code} + // Send distributed and non-distributed ping query + cloudSolrClient.setDefaultCollection(collectionName); + SolrPing req = new SolrPing(); + req.setDistrib(true); + SolrPingResponse rsp = req.process(cloudSolrClient, collectionName); + assertEquals(0, rsp.getStatus()); + + cloudSolrClient.setDefaultCollection(collectionName); + req = new SolrPing(); + req.setDistrib(false); + rsp = req.process(cloudSolrClient, collectionName); + assertEquals(0, rsp.getStatus()); {code} Most of this code is unnecessary, you set the default collection multiple times, you pass the collectionName even though it's set, you create a new request when it would just suffice to set distrib. 3. {code} + public SolrPing setDistrib(boolean distrib) { +params.add(distrib, distrib ? true : false); +return this; + } {code} You shouldn't modify SolrPing just to test it. Just extend getParams on SolrPing for your distrib example. 4. Can you just have a single one of these instead of putting it in each clause? {code} // Send an error or return + if( ex != null ) { +throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, +Ping query caused exception: +ex.getMessage(), ex ); + } +} else { {code} Ping requests stopped working with distrib=true in Solr 5.2.1 - Key: SOLR-7746 URL: https://issues.apache.org/jira/browse/SOLR-7746 Project: Solr Issue Type: Bug Components: SolrCloud Affects Versions: 5.2.1 Reporter: Alexey Serba Attachments: SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch {noformat:title=steps to reproduce} # start 1 node SolrCloud cluster sh ./bin/solr -c -p # create a test collection (we won’t use it, but I just want to it to load solr configs to Zk) ./bin/solr create_collection -c test -d sample_techproducts_configs -p # create another test collection with 2 shards curl 'http://localhost:/solr/admin/collections?action=CREATEname=test2numShards=2replicationFactor=1maxShardsPerNode=2collection.configName=test' # try distrib ping request curl 'http://localhost:/solr/test2/admin/ping?wt=jsondistrib=trueindent=true' ... error:{ msg:Ping query caused exception: Error from server at http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the PingRequestHandler recursively ... {noformat} {noformat:title=Exception} 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: Cannot execute the PingRequestHandler recursively at org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) at org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715882#comment-14715882 ] Gregory Chanan commented on SOLR-7746: -- I compared what happens in 5.1 vs your version of trunk for the commands listed in the description: 5.1: {noformat} curl 'http://localhost:8889/solr/test2/admin/ping?wt=jsondistrib=trueindent=true' { responseHeader:{ status:0, QTime:26, params:{ df:text, echoParams:all, indent:true, q:solrpingquery, distrib:true, wt:json, preferLocalShards:false, rows:10}}, status:OK} {noformat} Trunk: {noformat} curl 'http://localhost:8885/solr/test2/admin/ping?wt=jsondistrib=trueindent=true' { responseHeader:{ status:0, QTime:28, params:{ q:{!lucene}*:*, distrib:true, df:text, preferLocalShards:false, indent:true, echoParams:all, rows:10, wt:json}}, status:OK} {noformat} Looks good, the change in the q parameter looks like it's that way because the solrconfig.xml being used is different. Ping requests stopped working with distrib=true in Solr 5.2.1 - Key: SOLR-7746 URL: https://issues.apache.org/jira/browse/SOLR-7746 Project: Solr Issue Type: Bug Components: SolrCloud Affects Versions: 5.2.1 Reporter: Alexey Serba Attachments: SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch {noformat:title=steps to reproduce} # start 1 node SolrCloud cluster sh ./bin/solr -c -p # create a test collection (we won’t use it, but I just want to it to load solr configs to Zk) ./bin/solr create_collection -c test -d sample_techproducts_configs -p # create another test collection with 2 shards curl 'http://localhost:/solr/admin/collections?action=CREATEname=test2numShards=2replicationFactor=1maxShardsPerNode=2collection.configName=test' # try distrib ping request curl 'http://localhost:/solr/test2/admin/ping?wt=jsondistrib=trueindent=true' ... error:{ msg:Ping query caused exception: Error from server at http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the PingRequestHandler recursively ... {noformat} {noformat:title=Exception} 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: Cannot execute the PingRequestHandler recursively at org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) at org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712297#comment-14712297 ] Michael Sun commented on SOLR-7746: --- Attach patch with test. I tested that the test is gonna fail without change in PingRequestHandler. Also the code path in PingRequestHandler() is modified to separate the handling in case isShard is true or not to reduce if-else block. There is behavior change for PingRequestHandler in case isShard=true. In this case, it simply returns what the delegated handler returns. Javadoc is updated. Here is how new PingRequestHandler process ping request with distrib=true. This behavior change is required to aggregate results from shards (Step 7). 1. PingRequestHandler receives ping request with distrib=true. 2. Find the delegated handler, for example SearchHandler by default. 3. Call SearchHandler to handle request. 4. SearchHandler send requests to shards with distrib=false and isShard=true. 5. [Shard] PingHandler of each shard receives the request and delegate to SearchHandler. 6. [Shard] SearchHandler of shards process and return the result. 7. SearchHandler in Step3 aggregate the result of all shards. 8. Return the result to PingRequestHandler. 9. PingRequestHandler returns either success or HTTP Error code. Ping requests stopped working with distrib=true in Solr 5.2.1 - Key: SOLR-7746 URL: https://issues.apache.org/jira/browse/SOLR-7746 Project: Solr Issue Type: Bug Components: SolrCloud Affects Versions: 5.2.1 Reporter: Alexey Serba Attachments: SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch {noformat:title=steps to reproduce} # start 1 node SolrCloud cluster sh ./bin/solr -c -p # create a test collection (we won’t use it, but I just want to it to load solr configs to Zk) ./bin/solr create_collection -c test -d sample_techproducts_configs -p # create another test collection with 2 shards curl 'http://localhost:/solr/admin/collections?action=CREATEname=test2numShards=2replicationFactor=1maxShardsPerNode=2collection.configName=test' # try distrib ping request curl 'http://localhost:/solr/test2/admin/ping?wt=jsondistrib=trueindent=true' ... error:{ msg:Ping query caused exception: Error from server at http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the PingRequestHandler recursively ... {noformat} {noformat:title=Exception} 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: Cannot execute the PingRequestHandler recursively at org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) at org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14707039#comment-14707039 ] Michael Sun commented on SOLR-7746: --- Thanks [~gchanan] for reviewing. Here is my answers. 1. Will add space and other formatting. 2. qt parameter is no longer used at that point since delegation is completed. It doesn't matter if qt is removed or set to default handler. 3. The logic is correct for non-IS_SHARD use case and it adds OK status to rsp with the ! in last if condition. Ping requests stopped working with distrib=true in Solr 5.2.1 - Key: SOLR-7746 URL: https://issues.apache.org/jira/browse/SOLR-7746 Project: Solr Issue Type: Bug Components: SolrCloud Affects Versions: 5.2.1 Reporter: Alexey Serba Attachments: SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch {noformat:title=steps to reproduce} # start 1 node SolrCloud cluster sh ./bin/solr -c -p # create a test collection (we won’t use it, but I just want to it to load solr configs to Zk) ./bin/solr create_collection -c test -d sample_techproducts_configs -p # create another test collection with 2 shards curl 'http://localhost:/solr/admin/collections?action=CREATEname=test2numShards=2replicationFactor=1maxShardsPerNode=2collection.configName=test' # try distrib ping request curl 'http://localhost:/solr/test2/admin/ping?wt=jsondistrib=trueindent=true' ... error:{ msg:Ping query caused exception: Error from server at http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the PingRequestHandler recursively ... {noformat} {noformat:title=Exception} 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: Cannot execute the PingRequestHandler recursively at org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) at org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14707066#comment-14707066 ] Gregory Chanan commented on SOLR-7746: -- on #3, sorry I didn't write that correctly. Let me try to put it another way -- why not just simplify the code I listed above and get rid of the if/else handling. Does anything break if you do that? Also, it would be great to add a test to demonstrate the problem you are fixing so it doesn't show up again. Ideally the test should demonstrate IS_SHARD and non-IS_SHARD cases and the IS_SHARD test case should fail without your patch applied. Ping requests stopped working with distrib=true in Solr 5.2.1 - Key: SOLR-7746 URL: https://issues.apache.org/jira/browse/SOLR-7746 Project: Solr Issue Type: Bug Components: SolrCloud Affects Versions: 5.2.1 Reporter: Alexey Serba Attachments: SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch {noformat:title=steps to reproduce} # start 1 node SolrCloud cluster sh ./bin/solr -c -p # create a test collection (we won’t use it, but I just want to it to load solr configs to Zk) ./bin/solr create_collection -c test -d sample_techproducts_configs -p # create another test collection with 2 shards curl 'http://localhost:/solr/admin/collections?action=CREATEname=test2numShards=2replicationFactor=1maxShardsPerNode=2collection.configName=test' # try distrib ping request curl 'http://localhost:/solr/test2/admin/ping?wt=jsondistrib=trueindent=true' ... error:{ msg:Ping query caused exception: Error from server at http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the PingRequestHandler recursively ... {noformat} {noformat:title=Exception} 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: Cannot execute the PingRequestHandler recursively at org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) at org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706065#comment-14706065 ] Gregory Chanan commented on SOLR-7746: -- Looks good Michael, a few questions/comments: {code} (params.getBool(ShardParams.IS_SHARD,false)) {code} Convention is to put a space after ,. Also, are you using tabs? please remove them. {code} handler = core.getRequestHandler( null ); ModifiableSolrParams wparams = new ModifiableSolrParams(params); wparams.remove(CommonParams.QT); req.setParams(wparams); {code} Is it correct ot remove the QT or replace the QT with the default handler you are calling? {code} // In case it's a query for shard, return the result from delegated handler for distributed query to merge result if (params.getBool(ShardParams.IS_SHARD,false)) { core.execute(handler, req, rsp ); ex = rsp.getException(); } else { core.execute(handler, req, pingrsp ); ex = pingrsp.getException(); } ... if (!params.getBool(ShardParams.IS_SHARD,false)) { rsp.add( status, OK ); } {code} Is all the if-elsing necessary? What happens if you use pingrsp for whether IS_SHARD is true or not and then remove the if around the status check? What you have now doesn't look correct to me, the non-IS_SHARD case won't have OK status, right? Ping requests stopped working with distrib=true in Solr 5.2.1 - Key: SOLR-7746 URL: https://issues.apache.org/jira/browse/SOLR-7746 Project: Solr Issue Type: Bug Components: SolrCloud Affects Versions: 5.2.1 Reporter: Alexey Serba Attachments: SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch {noformat:title=steps to reproduce} # start 1 node SolrCloud cluster sh ./bin/solr -c -p # create a test collection (we won’t use it, but I just want to it to load solr configs to Zk) ./bin/solr create_collection -c test -d sample_techproducts_configs -p # create another test collection with 2 shards curl 'http://localhost:/solr/admin/collections?action=CREATEname=test2numShards=2replicationFactor=1maxShardsPerNode=2collection.configName=test' # try distrib ping request curl 'http://localhost:/solr/test2/admin/ping?wt=jsondistrib=trueindent=true' ... error:{ msg:Ping query caused exception: Error from server at http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the PingRequestHandler recursively ... {noformat} {noformat:title=Exception} 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: Cannot execute the PingRequestHandler recursively at org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) at org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705757#comment-14705757 ] Michael Sun commented on SOLR-7746: --- Upload the patch to handle sharded ping requests inside PingRequestHandler. There are two changes. 1. If the qt=/admin/ping for ping requests to shard, it delegates the request to the default handler, /select. 2. For ping requests to shard, PingRequestHandler returns what the delegated handler returns. Therefore the result can be aggregated later. (Originally PingRequestHandler removes most part from results that delegated handler returns. It works fine with non-distributed requests but can break the aggregation logic for distributed requests.) Ping requests stopped working with distrib=true in Solr 5.2.1 - Key: SOLR-7746 URL: https://issues.apache.org/jira/browse/SOLR-7746 Project: Solr Issue Type: Bug Components: SolrCloud Affects Versions: 5.2.1 Reporter: Alexey Serba Attachments: SOLR-7746.patch, SOLR-7746.patch, SOLR-7746.patch {noformat:title=steps to reproduce} # start 1 node SolrCloud cluster sh ./bin/solr -c -p # create a test collection (we won’t use it, but I just want to it to load solr configs to Zk) ./bin/solr create_collection -c test -d sample_techproducts_configs -p # create another test collection with 2 shards curl 'http://localhost:/solr/admin/collections?action=CREATEname=test2numShards=2replicationFactor=1maxShardsPerNode=2collection.configName=test' # try distrib ping request curl 'http://localhost:/solr/test2/admin/ping?wt=jsondistrib=trueindent=true' ... error:{ msg:Ping query caused exception: Error from server at http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the PingRequestHandler recursively ... {noformat} {noformat:title=Exception} 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: Cannot execute the PingRequestHandler recursively at org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) at org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14703885#comment-14703885 ] Michael Sun commented on SOLR-7746: --- Yeah, that makes sense. Thanks [~gchanan] for suggestion. Ping requests stopped working with distrib=true in Solr 5.2.1 - Key: SOLR-7746 URL: https://issues.apache.org/jira/browse/SOLR-7746 Project: Solr Issue Type: Bug Components: SolrCloud Affects Versions: 5.2.1 Reporter: Alexey Serba Attachments: SOLR-7746.patch {noformat:title=steps to reproduce} # start 1 node SolrCloud cluster sh ./bin/solr -c -p # create a test collection (we won’t use it, but I just want to it to load solr configs to Zk) ./bin/solr create_collection -c test -d sample_techproducts_configs -p # create another test collection with 2 shards curl 'http://localhost:/solr/admin/collections?action=CREATEname=test2numShards=2replicationFactor=1maxShardsPerNode=2collection.configName=test' # try distrib ping request curl 'http://localhost:/solr/test2/admin/ping?wt=jsondistrib=trueindent=true' ... error:{ msg:Ping query caused exception: Error from server at http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the PingRequestHandler recursively ... {noformat} {noformat:title=Exception} 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: Cannot execute the PingRequestHandler recursively at org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) at org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702234#comment-14702234 ] Gregory Chanan commented on SOLR-7746: -- Can we put the complexity in the PingRequestHandler instead of the SearchHandler? Localizing the complexity seems like the best long term approach here. Ping requests stopped working with distrib=true in Solr 5.2.1 - Key: SOLR-7746 URL: https://issues.apache.org/jira/browse/SOLR-7746 Project: Solr Issue Type: Bug Components: SolrCloud Affects Versions: 5.2.1 Reporter: Alexey Serba Attachments: SOLR-7746.patch {noformat:title=steps to reproduce} # start 1 node SolrCloud cluster sh ./bin/solr -c -p # create a test collection (we won’t use it, but I just want to it to load solr configs to Zk) ./bin/solr create_collection -c test -d sample_techproducts_configs -p # create another test collection with 2 shards curl 'http://localhost:/solr/admin/collections?action=CREATEname=test2numShards=2replicationFactor=1maxShardsPerNode=2collection.configName=test' # try distrib ping request curl 'http://localhost:/solr/test2/admin/ping?wt=jsondistrib=trueindent=true' ... error:{ msg:Ping query caused exception: Error from server at http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the PingRequestHandler recursively ... {noformat} {noformat:title=Exception} 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: Cannot execute the PingRequestHandler recursively at org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) at org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699905#comment-14699905 ] Michael Sun commented on SOLR-7746: --- Attach a fix. For the ping request particular, there is a requirement that qt parameter either be a meaningful handler or be null. The fix address this requirement when requests are sent to shards. Ping requests stopped working with distrib=true in Solr 5.2.1 - Key: SOLR-7746 URL: https://issues.apache.org/jira/browse/SOLR-7746 Project: Solr Issue Type: Bug Components: SolrCloud Affects Versions: 5.2.1 Reporter: Alexey Serba Attachments: SOLR-7746.patch {noformat:title=steps to reproduce} # start 1 node SolrCloud cluster sh ./bin/solr -c -p # create a test collection (we won’t use it, but I just want to it to load solr configs to Zk) ./bin/solr create_collection -c test -d sample_techproducts_configs -p # create another test collection with 2 shards curl 'http://localhost:/solr/admin/collections?action=CREATEname=test2numShards=2replicationFactor=1maxShardsPerNode=2collection.configName=test' # try distrib ping request curl 'http://localhost:/solr/test2/admin/ping?wt=jsondistrib=trueindent=true' ... error:{ msg:Ping query caused exception: Error from server at http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the PingRequestHandler recursively ... {noformat} {noformat:title=Exception} 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: Cannot execute the PingRequestHandler recursively at org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) at org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7746) Ping requests stopped working with distrib=true in Solr 5.2.1
[ https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697353#comment-14697353 ] Michael Sun commented on SOLR-7746: --- This issue can be reproduced in trunk build too. Ping requests stopped working with distrib=true in Solr 5.2.1 - Key: SOLR-7746 URL: https://issues.apache.org/jira/browse/SOLR-7746 Project: Solr Issue Type: Bug Components: SolrCloud Affects Versions: 5.2.1 Reporter: Alexey Serba {noformat:title=steps to reproduce} # start 1 node SolrCloud cluster sh ./bin/solr -c -p # create a test collection (we won’t use it, but I just want to it to load solr configs to Zk) ./bin/solr create_collection -c test -d sample_techproducts_configs -p # create another test collection with 2 shards curl 'http://localhost:/solr/admin/collections?action=CREATEname=test2numShards=2replicationFactor=1maxShardsPerNode=2collection.configName=test' # try distrib ping request curl 'http://localhost:/solr/test2/admin/ping?wt=jsondistrib=trueindent=true' ... error:{ msg:Ping query caused exception: Error from server at http://192.168.59.3:/solr/test2_shard2_replica1: Cannot execute the PingRequestHandler recursively ... {noformat} {noformat:title=Exception} 2116962 [qtp599601600-13] ERROR org.apache.solr.core.SolrCore [test2 shard2 core_node1 test2_shard2_replica1] – org.apache.solr.common.SolrException: Cannot execute the PingRequestHandler recursively at org.apache.solr.handler.PingRequestHandler.handlePing(PingRequestHandler.java:246) at org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:211) at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143) at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064) at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654) at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196) {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org