[jira] [Commented] (SOLR-7854) Remove ZkStateReader.updateClusterState(false)
[ https://issues.apache.org/jira/browse/SOLR-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651164#comment-14651164 ] Scott Blum commented on SOLR-7854: -- ty for landing Shalin :) Remove ZkStateReader.updateClusterState(false) -- Key: SOLR-7854 URL: https://issues.apache.org/jira/browse/SOLR-7854 Project: Solr Issue Type: Improvement Components: SolrCloud Affects Versions: 5.2.1 Reporter: Scott Blum Assignee: Shalin Shekhar Mangar Priority: Minor Labels: easyfix, newbie Fix For: 5.3, Trunk Attachments: SOLR-7854.patch Original Estimate: 2h Remaining Estimate: 2h `updateClusterState(false)` as far as I can tell has zero callers. It's super pointless anyway, because `updateClusterState(true)` is being used mostly from test code and in places where someone is trying to force a reload from ZK (for whatever reason). There's no point in asking for a deferred update when ZkStateReader is already going to keep itself in sync anyway. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7854) Remove ZkStateReader.updateClusterState(false)
[ https://issues.apache.org/jira/browse/SOLR-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14650175#comment-14650175 ] ASF subversion and git services commented on SOLR-7854: --- Commit 1693681 from sha...@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1693681 ] SOLR-7854: Remove unused ZkStateReader.updateClusterState(false) method Remove ZkStateReader.updateClusterState(false) -- Key: SOLR-7854 URL: https://issues.apache.org/jira/browse/SOLR-7854 Project: Solr Issue Type: Improvement Components: SolrCloud Affects Versions: 5.2.1 Reporter: Scott Blum Assignee: Shalin Shekhar Mangar Priority: Minor Labels: easyfix, newbie Attachments: SOLR-7854.patch Original Estimate: 2h Remaining Estimate: 2h `updateClusterState(false)` as far as I can tell has zero callers. It's super pointless anyway, because `updateClusterState(true)` is being used mostly from test code and in places where someone is trying to force a reload from ZK (for whatever reason). There's no point in asking for a deferred update when ZkStateReader is already going to keep itself in sync anyway. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7854) Remove ZkStateReader.updateClusterState(false)
[ https://issues.apache.org/jira/browse/SOLR-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14650336#comment-14650336 ] ASF subversion and git services commented on SOLR-7854: --- Commit 1693707 from sha...@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1693707 ] SOLR-7854: Remove unused ZkStateReader.updateClusterState(false) method Remove ZkStateReader.updateClusterState(false) -- Key: SOLR-7854 URL: https://issues.apache.org/jira/browse/SOLR-7854 Project: Solr Issue Type: Improvement Components: SolrCloud Affects Versions: 5.2.1 Reporter: Scott Blum Assignee: Shalin Shekhar Mangar Priority: Minor Labels: easyfix, newbie Attachments: SOLR-7854.patch Original Estimate: 2h Remaining Estimate: 2h `updateClusterState(false)` as far as I can tell has zero callers. It's super pointless anyway, because `updateClusterState(true)` is being used mostly from test code and in places where someone is trying to force a reload from ZK (for whatever reason). There's no point in asking for a deferred update when ZkStateReader is already going to keep itself in sync anyway. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7854) Remove ZkStateReader.updateClusterState(false)
[ https://issues.apache.org/jira/browse/SOLR-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14649644#comment-14649644 ] Mark Miller commented on SOLR-7854: --- updateClusterState(false) use to be used a lot to prevent silly rapid updates faster than was useful. Long ago, someone removed it's use but never cleaned it up fully. Remove ZkStateReader.updateClusterState(false) -- Key: SOLR-7854 URL: https://issues.apache.org/jira/browse/SOLR-7854 Project: Solr Issue Type: Improvement Components: SolrCloud Affects Versions: 5.2.1 Reporter: Scott Blum Priority: Minor Labels: easyfix, newbie Original Estimate: 2h Remaining Estimate: 2h `updateClusterState(false)` as far as I can tell has zero callers. It's super pointless anyway, because `updateClusterState(true)` is being used mostly from test code and in places where someone is trying to force a reload from ZK (for whatever reason). There's no point in asking for a deferred update when ZkStateReader is already going to keep itself in sync anyway. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
