[jira] [Commented] (SOLR-7968) Allow extending QueryComponent
[ https://issues.apache.org/jira/browse/SOLR-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127982#comment-15127982 ] ASF subversion and git services commented on SOLR-7968: --- Commit 4cdce3db77cde2506ac77dc9ced8c1f91ed9800f in lucene-solr's branch refs/heads/master-solr-8621 from [~dsmiley] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4cdce3d ] SOLR-7968: Make QueryComponent extensible > Allow extending QueryComponent > -- > > Key: SOLR-7968 > URL: https://issues.apache.org/jira/browse/SOLR-7968 > Project: Solr > Issue Type: Improvement > Components: SearchComponents - other >Affects Versions: 5.2.1 >Reporter: Markus Jelsma >Assignee: David Smiley >Priority: Minor > Fix For: 5.5 > > Attachments: SOLR-7968.patch, SOLR-7968.patch > > > QueryComponent is, after all this time, still not extendable. Overriding a > simple method is mostly impossible due to members being private or usage of > non-public classes. Copying all code to an external class is also not going > to work because of this. This patch finally allows overriding QueryComponent > methods such as createMainQuery and mergeIds. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7968) Allow extending QueryComponent
[ https://issues.apache.org/jira/browse/SOLR-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15125691#comment-15125691 ] ASF subversion and git services commented on SOLR-7968: --- Commit 4cdce3db77cde2506ac77dc9ced8c1f91ed9800f in lucene-solr's branch refs/heads/master from [~dsmiley] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4cdce3d ] SOLR-7968: Make QueryComponent extensible > Allow extending QueryComponent > -- > > Key: SOLR-7968 > URL: https://issues.apache.org/jira/browse/SOLR-7968 > Project: Solr > Issue Type: Improvement > Components: SearchComponents - other >Affects Versions: 5.2.1 >Reporter: Markus Jelsma >Assignee: David Smiley >Priority: Minor > Fix For: 5.5 > > Attachments: SOLR-7968.patch, SOLR-7968.patch > > > QueryComponent is, after all this time, still not extendable. Overriding a > simple method is mostly impossible due to members being private or usage of > non-public classes. Copying all code to an external class is also not going > to work because of this. This patch finally allows overriding QueryComponent > methods such as createMainQuery and mergeIds. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7968) Allow extending QueryComponent
[ https://issues.apache.org/jira/browse/SOLR-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15125697#comment-15125697 ] ASF subversion and git services commented on SOLR-7968: --- Commit ef2fda90b6f3aea131c83f3ca49b47abb00b920f in lucene-solr's branch refs/heads/branch_5x from [~dsmiley] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ef2fda9 ] SOLR-7968: Make QueryComponent extensible > Allow extending QueryComponent > -- > > Key: SOLR-7968 > URL: https://issues.apache.org/jira/browse/SOLR-7968 > Project: Solr > Issue Type: Improvement > Components: SearchComponents - other >Affects Versions: 5.2.1 >Reporter: Markus Jelsma >Assignee: David Smiley >Priority: Minor > Fix For: 5.5 > > Attachments: SOLR-7968.patch, SOLR-7968.patch > > > QueryComponent is, after all this time, still not extendable. Overriding a > simple method is mostly impossible due to members being private or usage of > non-public classes. Copying all code to an external class is also not going > to work because of this. This patch finally allows overriding QueryComponent > methods such as createMainQuery and mergeIds. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7968) Allow extending QueryComponent
[ https://issues.apache.org/jira/browse/SOLR-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117160#comment-15117160 ] Markus Jelsma commented on SOLR-7968: - Patch still applies to 5.4.1 source. > Allow extending QueryComponent > -- > > Key: SOLR-7968 > URL: https://issues.apache.org/jira/browse/SOLR-7968 > Project: Solr > Issue Type: Bug > Components: SearchComponents - other >Affects Versions: 5.2.1 >Reporter: Markus Jelsma > Fix For: 5.5 > > Attachments: SOLR-7968.patch, SOLR-7968.patch > > > QueryComponent is, after all this time, still not extendable. Overriding a > simple method is mostly impossible due to members being private or usage of > non-public classes. Copying all code to an external class is also not going > to work because of this. This patch finally allows overriding QueryComponent > methods such as createMainQuery and mergeIds. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7968) Allow extending QueryComponent
[ https://issues.apache.org/jira/browse/SOLR-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982567#comment-14982567 ] Markus Jelsma commented on SOLR-7968: - Hello - is this something that can make it into 5.4? It is so much easier to extend QueryComponent instead of copying it as a whole. > Allow extending QueryComponent > -- > > Key: SOLR-7968 > URL: https://issues.apache.org/jira/browse/SOLR-7968 > Project: Solr > Issue Type: Bug > Components: SearchComponents - other >Affects Versions: 5.2.1 >Reporter: Markus Jelsma > Fix For: 5.4 > > Attachments: SOLR-7968.patch > > > QueryComponent is, after all this time, still not extendable. Overriding a > simple method is mostly impossible due to members being private or usage of > non-public classes. Copying all code to an external class is also not going > to work because of this. This patch finally allows overriding QueryComponent > methods such as createMainQuery and mergeIds. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7968) Allow extending QueryComponent
[ https://issues.apache.org/jira/browse/SOLR-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727285#comment-14727285 ] Markus Jelsma commented on SOLR-7968: - Yes of course, i don't know why i marked it for 5.3.1 either. > Allow extending QueryComponent > -- > > Key: SOLR-7968 > URL: https://issues.apache.org/jira/browse/SOLR-7968 > Project: Solr > Issue Type: Bug > Components: SearchComponents - other >Affects Versions: 5.2.1 >Reporter: Markus Jelsma > Fix For: 5.4 > > Attachments: SOLR-7968.patch > > > QueryComponent is, after all this time, still not extendable. Overriding a > simple method is mostly impossible due to members being private or usage of > non-public classes. Copying all code to an external class is also not going > to work because of this. This patch finally allows overriding QueryComponent > methods such as createMainQuery and mergeIds. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7968) Allow extending QueryComponent
[ https://issues.apache.org/jira/browse/SOLR-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727258#comment-14727258 ] Noble Paul commented on SOLR-7968: -- Why is this marked for 5.3.1 ? looks like it's a new feature and not a bug > Allow extending QueryComponent > -- > > Key: SOLR-7968 > URL: https://issues.apache.org/jira/browse/SOLR-7968 > Project: Solr > Issue Type: Bug > Components: SearchComponents - other >Affects Versions: 5.2.1 >Reporter: Markus Jelsma > Fix For: 5.3.1 > > Attachments: SOLR-7968.patch > > > QueryComponent is, after all this time, still not extendable. Overriding a > simple method is mostly impossible due to members being private or usage of > non-public classes. Copying all code to an external class is also not going > to work because of this. This patch finally allows overriding QueryComponent > methods such as createMainQuery and mergeIds. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
