[jira] [Commented] (SOLR-8062) Solr should raise an exception if minRf is specified and not achieved for an update request
[
https://issues.apache.org/jira/browse/SOLR-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14995639#comment-14995639
]
Shai Erera commented on SOLR-8062:
--
I wanted to share a possible confusion on the user end, if we start throwing
exceptions.
Since Solr (and Lucene for that matter) is unable to rollback a specific update
request, I believe that's the reason why 'minRF' is used only as a hint, and
telling the user that the update request didn't achieve it. By not throwing the
exception, the user/client couldn't _think_ that the update request was
unsuccessful, and in fact, I believe that in many cases the update itself did
reach the failed replicas eventually.
If we start throwing an exception, I worry that users might think that the
update request was unsuccessful as a whole. If they care, they might re-issue
the request. But if they don't, then they might not realize that the update
*did* get through, and even reach the failed replicas eventually. This might
cause 'surprises' and inconsistency between what the user thinks is in the
index and what isn't.
I personally think that an exception is better than just a warning in the
response, but wanted to raise this potential confusion, in case others have an
opinion on it. Perhaps if we throw an explicit exception it will be easier to
note by users, i.e. {{UpdateNotFullyAppliedException}} or something like that.
It's not a total update failure, but it is some sort of failure cause we
weren't able to meet the client's requirements.
> Solr should raise an exception if minRf is specified and not achieved for an
> update request
> ---
>
> Key: SOLR-8062
> URL: https://issues.apache.org/jira/browse/SOLR-8062
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
>Reporter: Timothy Potter
>
> See discussion in SOLR-8034
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8062) Solr should raise an exception if minRf is specified and not achieved for an update request
[ https://issues.apache.org/jira/browse/SOLR-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14995655#comment-14995655 ] Mark Miller commented on SOLR-8062: --- We have to throw an exception because the request as designed could not be completed. Of course we wil document what that exception means. > Solr should raise an exception if minRf is specified and not achieved for an > update request > --- > > Key: SOLR-8062 > URL: https://issues.apache.org/jira/browse/SOLR-8062 > Project: Solr > Issue Type: Improvement > Components: SolrCloud >Reporter: Timothy Potter > > See discussion in SOLR-8034 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8062) Solr should raise an exception if minRf is specified and not achieved for an update request
[ https://issues.apache.org/jira/browse/SOLR-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14902914#comment-14902914 ] Anshum Gupta commented on SOLR-8062: I agree with this. Specially, considering that now LIR doesn't kick in if the minRF isn't achieved, this makes all the more sense. > Solr should raise an exception if minRf is specified and not achieved for an > update request > --- > > Key: SOLR-8062 > URL: https://issues.apache.org/jira/browse/SOLR-8062 > Project: Solr > Issue Type: Improvement > Components: SolrCloud >Reporter: Timothy Potter > > See discussion in SOLR-8034 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8062) Solr should raise an exception if minRf is specified and not achieved for an update request
[ https://issues.apache.org/jira/browse/SOLR-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14902569#comment-14902569 ] Mark Miller commented on SOLR-8062: --- For 6 we might even want to consider having this set by default to the number of replicas and let users scale back to less safety instead of the reverse. > Solr should raise an exception if minRf is specified and not achieved for an > update request > --- > > Key: SOLR-8062 > URL: https://issues.apache.org/jira/browse/SOLR-8062 > Project: Solr > Issue Type: Improvement > Components: SolrCloud >Reporter: Timothy Potter > > See discussion in SOLR-8034 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8062) Solr should raise an exception if minRf is specified and not achieved for an update request
[ https://issues.apache.org/jira/browse/SOLR-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790554#comment-14790554 ] Mark Miller commented on SOLR-8062: --- My feeling is, if you asked for a min rep and it was not achieved, the request failed. We should not just hint to the client, but disrupt its flow. If you are using a min rep param, presumably, this is the behavior you would want. > Solr should raise an exception if minRf is specified and not achieved for an > update request > --- > > Key: SOLR-8062 > URL: https://issues.apache.org/jira/browse/SOLR-8062 > Project: Solr > Issue Type: Improvement > Components: SolrCloud >Reporter: Timothy Potter > > See discussion in SOLR-8034 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
