[jira] [Commented] (SOLR-8191) CloudSolrStream close method NullPointerException
[ https://issues.apache.org/jira/browse/SOLR-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060895#comment-15060895 ] Joel Bernstein commented on SOLR-8191: -- Ok, this looks fine to me. > CloudSolrStream close method NullPointerException > - > > Key: SOLR-8191 > URL: https://issues.apache.org/jira/browse/SOLR-8191 > Project: Solr > Issue Type: Bug > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden > Attachments: SOLR-8191.patch > > > CloudSolrStream doesn't check if cloudSolrClient or solrStreams is null > yielding a NullPointerException in those cases when close() is called on it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8191) CloudSolrStream close method NullPointerException
[ https://issues.apache.org/jira/browse/SOLR-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060016#comment-15060016 ] Kevin Risden commented on SOLR-8191: [~gerlowskija] I hadn't looked for other places to do null-checks other than what was found by SOLR-8190. As you said there are probably other places that need hardening. > CloudSolrStream close method NullPointerException > - > > Key: SOLR-8191 > URL: https://issues.apache.org/jira/browse/SOLR-8191 > Project: Solr > Issue Type: Bug > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden > Attachments: SOLR-8191.patch > > > CloudSolrStream doesn't check if cloudSolrClient or solrStreams is null > yielding a NullPointerException in those cases when close() is called on it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8191) CloudSolrStream close method NullPointerException
[
https://issues.apache.org/jira/browse/SOLR-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15059213#comment-15059213
]
Jason Gerlowski commented on SOLR-8191:
---
The current patch still applies cleanly. Fixing this NPE might not be hugely
important, but this bug is blocking SOLR-8190, which would be a nice
improvement IMO. (Not a huge deal, but still a nice little tidbit).
Looking at {{CloudSolrStream}} a little closer though, it seems odd to perform
a null-check on {{close()}}, but not any of the other places that
{{cloudSolrClient}} is used. For instance, check out the protected
{{constructStreams()}} method, which is invoked on each call to {{open()}}.
Those are just my observations at a glance. I'm not very familiar with the
SolrJ code, so maybe this isn't actually an issue. Just wanted to mention it.
I'm going to tinker around with this more tonight to see if I can learn more.
> CloudSolrStream close method NullPointerException
> -
>
> Key: SOLR-8191
> URL: https://issues.apache.org/jira/browse/SOLR-8191
> Project: Solr
> Issue Type: Bug
> Components: SolrJ
>Affects Versions: Trunk
>Reporter: Kevin Risden
> Attachments: SOLR-8191.patch
>
>
> CloudSolrStream doesn't check if cloudSolrClient or solrStreams is null
> yielding a NullPointerException in those cases when close() is called on it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8191) CloudSolrStream close method NullPointerException
[
https://issues.apache.org/jira/browse/SOLR-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15059422#comment-15059422
]
Jason Gerlowski commented on SOLR-8191:
---
After a little more attention, I think it'd probably be safer to null-check in
{{constructStreams}} as well (see above). That said, I'm not sure if there was
a rationale for avoiding this so far. [~risdenk], was there a reason you hadn't
done this in your initial patch?
In any case, the patch does fix the NPE's exposed by closing the streams in the
Streaming tests, so in that respect it looks good to me.
Can someone with more familiarity with this part of the codebase (ideally
someone willing to consider merging this) take a look at this patch please
> CloudSolrStream close method NullPointerException
> -
>
> Key: SOLR-8191
> URL: https://issues.apache.org/jira/browse/SOLR-8191
> Project: Solr
> Issue Type: Bug
> Components: SolrJ
>Affects Versions: Trunk
>Reporter: Kevin Risden
> Attachments: SOLR-8191.patch
>
>
> CloudSolrStream doesn't check if cloudSolrClient or solrStreams is null
> yielding a NullPointerException in those cases when close() is called on it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8191) CloudSolrStream close method NullPointerException
[ https://issues.apache.org/jira/browse/SOLR-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15059442#comment-15059442 ] Joel Bernstein commented on SOLR-8191: -- Sure, I should have some time review this ticket and SOLR-8190 tomorrow. > CloudSolrStream close method NullPointerException > - > > Key: SOLR-8191 > URL: https://issues.apache.org/jira/browse/SOLR-8191 > Project: Solr > Issue Type: Bug > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden > Attachments: SOLR-8191.patch > > > CloudSolrStream doesn't check if cloudSolrClient or solrStreams is null > yielding a NullPointerException in those cases when close() is called on it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
