[jira] [Commented] (SOLR-8346) Upgrade Zookeeper to version 3.5.x
[ https://issues.apache.org/jira/browse/SOLR-8346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844918#comment-16844918 ] Erick Erickson commented on SOLR-8346: -- I'll have a patch up today. So far 1> everything compiles 2> precommit passes 3> three tests fail, I haven't looked closely at all yet. I'll take a brief look for obvious problems etc. There'll be several nocommits that I would _really_ appreciate people looking at. As before ZkTestServer is where some of the most worrisome changes are. Along the way I found a couple of overridden methods that are (apparently) never used, one of which is flagged as not overriding a superclass method even without these changes. > Upgrade Zookeeper to version 3.5.x > -- > > Key: SOLR-8346 > URL: https://issues.apache.org/jira/browse/SOLR-8346 > Project: Solr > Issue Type: Task > Components: SolrCloud >Reporter: Jan Høydahl >Priority: Major > Labels: security, zookeeper > Attachments: SOLR-8346.patch, SOLR_8346.patch > > > Investigate upgrading ZooKeeper to 3.5.x, once released. Primary motivation > for this is SSL support. --Currently a 3.5.4-beta is released (2018-05-17).-- > Version 3.5.5 was released 2019-05-20 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8346) Upgrade Zookeeper to version 3.5.x
[ https://issues.apache.org/jira/browse/SOLR-8346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813881#comment-16813881 ] Erick Erickson commented on SOLR-8346: -- This patch has a lot of mechanical changes and does _not_ incorporate any of the changes from the previous patch (frankly I didn't notice it when I started to be truthful). I did this against zookeeper 3.5.4-beta since 3.5.5 isn't out yet. Unless I'm missing something, there hasn't been a formal release of 3.5 at all so far... There are some nocommits, particularly in ZkTesServer. I don't particularly intend to pursue this, just checkpointing. Anyone who has a better grasp of how to integrate the previous patch and whether the changes in ZkTestServer make sense, please chime in. Apart from the nocommits I added back, precommit passes. These tests fail on a single run: [junit4] - org.apache.solr.cloud.OutOfBoxZkACLAndCredentialsProvidersTest.testOpenACLUnsafeAllover [junit4] - org.apache.solr.cloud.TestStressLiveNodes (suite) [junit4] - org.apache.solr.handler.admin.ZookeeperStatusHandlerTest.monitorZookeeper [junit4] - org.apache.solr.handler.TestSQLHandler (suite) > Upgrade Zookeeper to version 3.5.x > -- > > Key: SOLR-8346 > URL: https://issues.apache.org/jira/browse/SOLR-8346 > Project: Solr > Issue Type: Task > Components: SolrCloud >Reporter: Jan Høydahl >Priority: Major > Labels: security, zookeeper > Attachments: SOLR-8346.patch, SOLR_8346.patch > > > Investigate upgrading ZooKeeper to 3.5.x, once released. Primary motivation > for this is SSL support. Currently a 3.5.4-beta is released (2018-05-17). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8346) Upgrade Zookeeper to version 3.5.x
[ https://issues.apache.org/jira/browse/SOLR-8346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813643#comment-16813643 ] Erick Erickson commented on SOLR-8346: -- I'll take a quick whack at trying 3.5.4-beta, just to get a dimension on the problem. > Upgrade Zookeeper to version 3.5.x > -- > > Key: SOLR-8346 > URL: https://issues.apache.org/jira/browse/SOLR-8346 > Project: Solr > Issue Type: Task > Components: SolrCloud >Reporter: Jan Høydahl >Priority: Major > Labels: security, zookeeper > Attachments: SOLR_8346.patch > > > Investigate upgrading ZooKeeper to 3.5.x, once released. Primary motivation > for this is SSL support. Currently a 3.5.4-beta is released (2018-05-17). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8346) Upgrade Zookeeper to version 3.5.x
[ https://issues.apache.org/jira/browse/SOLR-8346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813467#comment-16813467 ] Jan Høydahl commented on SOLR-8346: --- v3.5.5 RC3 being voted upon now [https://lists.apache.org/thread.html/43daf77b7a60a0ed7773d7ec640738ddda65a4126b76c23a85b672c4@%3Cdev.zookeeper.apache.org%3E] :) Who wants to start working on the upgrade? > Upgrade Zookeeper to version 3.5.x > -- > > Key: SOLR-8346 > URL: https://issues.apache.org/jira/browse/SOLR-8346 > Project: Solr > Issue Type: Task > Components: SolrCloud >Reporter: Jan Høydahl >Priority: Major > Labels: security, zookeeper > Attachments: SOLR_8346.patch > > > Investigate upgrading ZooKeeper to 3.5.x, once released. Primary motivation > for this is SSL support. Currently a 3.5.4-beta is released (2018-05-17). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8346) Upgrade Zookeeper to version 3.5.x
[ https://issues.apache.org/jira/browse/SOLR-8346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797910#comment-16797910 ] Jan Høydahl commented on SOLR-8346: --- The ZK project is about to release v3.5.5 ([https://lists.apache.org/thread.html/febb768fd0312fd57f71c543ad3d757546f3630b39e2d81c785b3274@%3Cuser.zookeeper.apache.org%3E)] meaning we could move on with this. > Upgrade Zookeeper to version 3.5.x > -- > > Key: SOLR-8346 > URL: https://issues.apache.org/jira/browse/SOLR-8346 > Project: Solr > Issue Type: Task > Components: SolrCloud >Reporter: Jan Høydahl >Priority: Major > Labels: security, zookeeper > Attachments: SOLR_8346.patch > > > Investigate upgrading ZooKeeper to 3.5.x, once released. Primary motivation > for this is SSL support. Currently a 3.5.4-beta is released (2018-05-17). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8346) Upgrade Zookeeper to version 3.5.x
[ https://issues.apache.org/jira/browse/SOLR-8346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599647#comment-16599647 ] Shawn Heisey commented on SOLR-8346: And just as I clicked "Add" I read closer and saw that you were thinking of Jenkins testing. That probably DOES require a branch. Some Jenkins testing would be a good idea, since ZK is a VERY slow-moving beast. Which sends me on a tangent ... I wonder if maybe we can come up with annotations for tests that designate them as "Cloud" tests or "ZK" tests, so we can send a commandline option to ant that will signal it to only run those tests. > Upgrade Zookeeper to version 3.5.x > -- > > Key: SOLR-8346 > URL: https://issues.apache.org/jira/browse/SOLR-8346 > Project: Solr > Issue Type: Task > Components: SolrCloud >Reporter: Jan Høydahl >Priority: Major > Labels: security, zookeeper > Attachments: SOLR_8346.patch > > > Investigate upgrading ZooKeeper to 3.5.x, once released. Primary motivation > for this is SSL support. Currently a 3.5.3-beta is released (2017-04-17). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8346) Upgrade Zookeeper to version 3.5.x
[ https://issues.apache.org/jira/browse/SOLR-8346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599645#comment-16599645 ] Shawn Heisey commented on SOLR-8346: [~janhoy] I don't know that this change is big enough to need a separate branch. Whoever is planning to do the work should give the current 3.5 beta a spin and see whether code changes are required in order to achieve their goals and keep ZK functionality working. If they are, they can keep those changes in a local repository (or a patch uploaded here) and then complete the change once the stable version is released. > Upgrade Zookeeper to version 3.5.x > -- > > Key: SOLR-8346 > URL: https://issues.apache.org/jira/browse/SOLR-8346 > Project: Solr > Issue Type: Task > Components: SolrCloud >Reporter: Jan Høydahl >Priority: Major > Labels: security, zookeeper > Attachments: SOLR_8346.patch > > > Investigate upgrading ZooKeeper to 3.5.x, once released. Primary motivation > for this is SSL support. Currently a 3.5.3-beta is released (2017-04-17). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8346) Upgrade Zookeeper to version 3.5.x
[ https://issues.apache.org/jira/browse/SOLR-8346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404867#comment-16404867 ] Jan Høydahl commented on SOLR-8346: --- There seems to be some movement in the ZooKeeper camp towards a 3.5.4 release, although slowly. Do you guys want to wait for a stable release before starting the upgrade on the Solr side, or should we cut a feature branch for it right now off from master, setup some Jenkins on it and mature the whole ting to be ready? > Upgrade Zookeeper to version 3.5.x > -- > > Key: SOLR-8346 > URL: https://issues.apache.org/jira/browse/SOLR-8346 > Project: Solr > Issue Type: Task > Components: SolrCloud >Reporter: Jan Høydahl >Priority: Major > Labels: security, zookeeper > Attachments: SOLR_8346.patch > > > Investigate upgrading ZooKeeper to 3.5.x, once released. Primary motivation > for this is SSL support. Currently a 3.5.3-beta is released (2017-04-17). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
