[jira] [Commented] (SOLR-8580) Closing leaked Closeable resources
[ https://issues.apache.org/jira/browse/SOLR-8580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15539630#comment-15539630 ] Alexandre Rafalovitch commented on SOLR-8580: - Safe to close? There was an agreement to not go ahead with this patch. > Closing leaked Closeable resources > -- > > Key: SOLR-8580 > URL: https://issues.apache.org/jira/browse/SOLR-8580 > Project: Solr > Issue Type: Bug >Reporter: Ishan Chattopadhyaya >Priority: Trivial > Attachments: SOLR-8580.patch > > > # A ChannelFastInputStream in TransactionLog > # A ZkStateReader in ZooKeeperInspector -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8580) Closing leaked Closeable resources
[ https://issues.apache.org/jira/browse/SOLR-8580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15111504#comment-15111504 ] Mark Miller commented on SOLR-8580: --- bq. A ChannelFastInputStream in TransactionLog Hmm, I don't know that that is legit. If we close that, it closes the underlying channel, and I don't think that is what we are looking for there. > Closing leaked Closeable resources > -- > > Key: SOLR-8580 > URL: https://issues.apache.org/jira/browse/SOLR-8580 > Project: Solr > Issue Type: Bug >Reporter: Ishan Chattopadhyaya >Priority: Trivial > Attachments: SOLR-8580.patch > > > # A ChannelFastInputStream in TransactionLog > # A ZkStateReader in ZooKeeperInspector -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8580) Closing leaked Closeable resources
[ https://issues.apache.org/jira/browse/SOLR-8580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15111536#comment-15111536 ] Ishan Chattopadhyaya commented on SOLR-8580: Indeed, the underlying file channel would be closed. Since there are no tests around it, even I'm not sure now if this is safe. Lets leave it for now. :-) > Closing leaked Closeable resources > -- > > Key: SOLR-8580 > URL: https://issues.apache.org/jira/browse/SOLR-8580 > Project: Solr > Issue Type: Bug >Reporter: Ishan Chattopadhyaya >Priority: Trivial > Attachments: SOLR-8580.patch > > > # A ChannelFastInputStream in TransactionLog > # A ZkStateReader in ZooKeeperInspector -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
