[jira] [Commented] (SOLR-8648) Support selective clearing up of stored async collection API responses
[ https://issues.apache.org/jira/browse/SOLR-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330498#comment-15330498 ] Anshum Gupta commented on SOLR-8648: [~varunthacker] yes. I've removed this from both the places. > Support selective clearing up of stored async collection API responses > -- > > Key: SOLR-8648 > URL: https://issues.apache.org/jira/browse/SOLR-8648 > Project: Solr > Issue Type: New Feature >Reporter: Anshum Gupta >Assignee: Anshum Gupta > Fix For: 5.5, 6.0 > > Attachments: SOLR-8648.patch, SOLR-8648.patch, SOLR-8648.patch, > SOLR-8648.patch > > > The only way to clear up stored collection API responses right now is by > sending in '-1' as the request id in the REQUESTSTATUS call. It makes a lot > of sense to support selective deletion of stored responses so the ids could > be reused. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8648) Support selective clearing up of stored async collection API responses
[
https://issues.apache.org/jira/browse/SOLR-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329497#comment-15329497
]
Varun Thacker commented on SOLR-8648:
-
Hi Anshum,
In 6.x + we no longer support this {[action=REQUESTSTATUS=-1}} right?
I saw two references of that usage
https://cwiki.apache.org/confluence/display/solr/Collections+API#CollectionsAPI-RequestStatus
and
https://cwiki.apache.org/confluence/display/solr/Collections+API#CollectionsAPI-AsynchronousCalls
. We can safely remove that right?
> Support selective clearing up of stored async collection API responses
> --
>
> Key: SOLR-8648
> URL: https://issues.apache.org/jira/browse/SOLR-8648
> Project: Solr
> Issue Type: New Feature
>Reporter: Anshum Gupta
>Assignee: Anshum Gupta
> Fix For: 5.5, 6.0
>
> Attachments: SOLR-8648.patch, SOLR-8648.patch, SOLR-8648.patch,
> SOLR-8648.patch
>
>
> The only way to clear up stored collection API responses right now is by
> sending in '-1' as the request id in the REQUESTSTATUS call. It makes a lot
> of sense to support selective deletion of stored responses so the ids could
> be reused.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8648) Support selective clearing up of stored async collection API responses
[ https://issues.apache.org/jira/browse/SOLR-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15137666#comment-15137666 ] Shai Erera commented on SOLR-8648: -- Looks good [~anshumg]! +1 > Support selective clearing up of stored async collection API responses > -- > > Key: SOLR-8648 > URL: https://issues.apache.org/jira/browse/SOLR-8648 > Project: Solr > Issue Type: New Feature >Reporter: Anshum Gupta >Assignee: Anshum Gupta > Attachments: SOLR-8648.patch, SOLR-8648.patch, SOLR-8648.patch, > SOLR-8648.patch > > > The only way to clear up stored collection API responses right now is by > sending in '-1' as the request id in the REQUESTSTATUS call. It makes a lot > of sense to support selective deletion of stored responses so the ids could > be reused. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8648) Support selective clearing up of stored async collection API responses
[ https://issues.apache.org/jira/browse/SOLR-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15137672#comment-15137672 ] Anshum Gupta commented on SOLR-8648: Also, about the deprecation, I'll change the 5x commit to actually return a warning with the response body and also document it in the code. > Support selective clearing up of stored async collection API responses > -- > > Key: SOLR-8648 > URL: https://issues.apache.org/jira/browse/SOLR-8648 > Project: Solr > Issue Type: New Feature >Reporter: Anshum Gupta >Assignee: Anshum Gupta > Attachments: SOLR-8648.patch, SOLR-8648.patch, SOLR-8648.patch, > SOLR-8648.patch > > > The only way to clear up stored collection API responses right now is by > sending in '-1' as the request id in the REQUESTSTATUS call. It makes a lot > of sense to support selective deletion of stored responses so the ids could > be reused. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8648) Support selective clearing up of stored async collection API responses
[ https://issues.apache.org/jira/browse/SOLR-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15137707#comment-15137707 ] ASF subversion and git services commented on SOLR-8648: --- Commit 03d7f80b27031309f7156af3bafcb6ccea74f7c7 in lucene-solr's branch refs/heads/master from anshum [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=03d7f80 ] SOLR-8648: Support selective clearing up of stored async collection API responses via DELETESTATUS API > Support selective clearing up of stored async collection API responses > -- > > Key: SOLR-8648 > URL: https://issues.apache.org/jira/browse/SOLR-8648 > Project: Solr > Issue Type: New Feature >Reporter: Anshum Gupta >Assignee: Anshum Gupta > Attachments: SOLR-8648.patch, SOLR-8648.patch, SOLR-8648.patch, > SOLR-8648.patch > > > The only way to clear up stored collection API responses right now is by > sending in '-1' as the request id in the REQUESTSTATUS call. It makes a lot > of sense to support selective deletion of stored responses so the ids could > be reused. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8648) Support selective clearing up of stored async collection API responses
[
https://issues.apache.org/jira/browse/SOLR-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15137622#comment-15137622
]
Shai Erera commented on SOLR-8648:
--
Thanks [~anshumg], I've got few minor (style) comments:
{{OverseerTaskProcessor}}
* {{if(asyncId != null)}: can you add a space after the 'if'?
* Someplace else in the file: {{if(!runningMap.remove(asyncId))}} - also
missing space
{{DistributedMap.remove()}}
* I believe the javadocs won't render well as the \@return tag swallows
newlines. You can either use an {{}} element, or document it in text
instead of the tag.
{{CollectionsHandler}}
* {{public static final String FLUSH = "flush";}} is also defined in
CollectionAdminParams. Can we have just one definition?
* I don't see a deprecation/removal of {{requestId == -1}}. Do you intend to do
that separately?
* {{if (requestId != null && flush)}} "Both requestid or flush" should be "Both
requestid *and* flush"
* {{if (req.getParams().getBool(FLUSH, false))}} is redundant since you already
set it to {{flush}} above
* {{zkController.getOverseerFailureMap().remove(requestId);}} that's a mistake?
You already call remove inside the 'if'
{{DeleteStatusTest}}
* {{// Try deleting the same response again}} s/response/requestid/ ?
{{CoreAdminParams}}
* {{public static final String CLEANUP = "cleanup"}} I didn't get where it's
used in this patch?
> Support selective clearing up of stored async collection API responses
> --
>
> Key: SOLR-8648
> URL: https://issues.apache.org/jira/browse/SOLR-8648
> Project: Solr
> Issue Type: New Feature
>Reporter: Anshum Gupta
>Assignee: Anshum Gupta
> Attachments: SOLR-8648.patch, SOLR-8648.patch
>
>
> The only way to clear up stored collection API responses right now is by
> sending in '-1' as the request id in the REQUESTSTATUS call. It makes a lot
> of sense to support selective deletion of stored responses so the ids could
> be reused.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8648) Support selective clearing up of stored async collection API responses
[ https://issues.apache.org/jira/browse/SOLR-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15137922#comment-15137922 ] ASF subversion and git services commented on SOLR-8648: --- Commit 3892f7e7a3ef41ce335f5cbfedc62e74489b0dd4 in lucene-solr's branch refs/heads/branch_5x from anshum [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3892f7e ] SOLR-8648: Support selective clearing up of stored async collection API responses via DELETESTATUS API > Support selective clearing up of stored async collection API responses > -- > > Key: SOLR-8648 > URL: https://issues.apache.org/jira/browse/SOLR-8648 > Project: Solr > Issue Type: New Feature >Reporter: Anshum Gupta >Assignee: Anshum Gupta > Attachments: SOLR-8648.patch, SOLR-8648.patch, SOLR-8648.patch, > SOLR-8648.patch > > > The only way to clear up stored collection API responses right now is by > sending in '-1' as the request id in the REQUESTSTATUS call. It makes a lot > of sense to support selective deletion of stored responses so the ids could > be reused. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8648) Support selective clearing up of stored async collection API responses
[
https://issues.apache.org/jira/browse/SOLR-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135670#comment-15135670
]
Shai Erera commented on SOLR-8648:
--
bq. {{if(req.getParams().getBool("cleanup")) \{}}
* Can you add a space after the 'if'?
* Separately, would be nice if {{DistributedMap#remove()}} would return a
boolean/Object, you can avoid the {{.contains}} followed by {{.remove}} check
(which also means two accesses to ZK).
bq. {{.setCleanup(true).process(cloudClient);}}
If you're already doing the builder style (which I like), mind as well write
that as:
{code}
.setCleanup(true)
.process(cloudClient);
{code}
Some general comments:
* Can you also add a test which attempts to delete a non-existing requestId, as
well one which attempts to delete the same twice?
* How would the REST call look like?
{{/solr/admin/collections?action=REQUESTSTATUS=foo=true}}? I
thought that we want to add a {{DELETESTATUS}} specific action, in which case
you won't need to add a cleanup parameter?
* What about {{=-1=false}}? I mean, we obviously don't need
to support all options, but was just wondering what would the code do? If we
added a {{DELETESTATUS}} action, then we could deprecate {{requestId=-1}} at
all and remove in 6.0, in exchange for only the latter action. Also, V2-API
would be able to handle that with a {{DELETE /solr/admin/...}} vs {{GET
/solr/admin/...}}.
What do you think?
> Support selective clearing up of stored async collection API responses
> --
>
> Key: SOLR-8648
> URL: https://issues.apache.org/jira/browse/SOLR-8648
> Project: Solr
> Issue Type: New Feature
>Reporter: Anshum Gupta
>Assignee: Anshum Gupta
> Attachments: SOLR-8648.patch
>
>
> The only way to clear up stored collection API responses right now is by
> sending in '-1' as the request id in the REQUESTSTATUS call. It makes a lot
> of sense to support selective deletion of stored responses so the ids could
> be reused.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
