[jira] [Commented] (SOLR-8652) Implement Statement.setMaxRows()
[ https://issues.apache.org/jira/browse/SOLR-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136092#comment-15136092 ] Kevin Risden commented on SOLR-8652: How about wrapping the stream with a limit stream instead of the risky checking the SQL for the word limit? > Implement Statement.setMaxRows() > > > Key: SOLR-8652 > URL: https://issues.apache.org/jira/browse/SOLR-8652 > Project: Solr > Issue Type: New Feature >Affects Versions: 6.0 >Reporter: Joel Bernstein >Assignee: Joel Bernstein >Priority: Minor > Attachments: SOLR-8652.patch > > > This is used by DbVisualizer to limit the number of rows returned by the > query. The implementation will add a limit clause if one is not already > included in the query. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8652) Implement Statement.setMaxRows()
[ https://issues.apache.org/jira/browse/SOLR-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136095#comment-15136095 ] Joel Bernstein commented on SOLR-8652: -- The limit clause changes the underlying implementation. If it's not included Solr will stream the entire result set using the /export handler. This also ensures that people use the more permissive /select handler for simple selects, which will produce fewer errors. > Implement Statement.setMaxRows() > > > Key: SOLR-8652 > URL: https://issues.apache.org/jira/browse/SOLR-8652 > Project: Solr > Issue Type: New Feature >Affects Versions: 6.0 >Reporter: Joel Bernstein >Assignee: Joel Bernstein >Priority: Minor > Attachments: SOLR-8652.patch > > > This is used by DbVisualizer to limit the number of rows returned by the > query. The implementation will add a limit clause if one is not already > included in the query. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8652) Implement Statement.setMaxRows()
[ https://issues.apache.org/jira/browse/SOLR-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136102#comment-15136102 ] ASF subversion and git services commented on SOLR-8652: --- Commit ba20faa9557cdd56d6a696d702fb5a62d9d43f74 in lucene-solr's branch refs/heads/master from jbernste [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ba20faa ] SOLR-8652: Implement Statement.setMaxRows() > Implement Statement.setMaxRows() > > > Key: SOLR-8652 > URL: https://issues.apache.org/jira/browse/SOLR-8652 > Project: Solr > Issue Type: New Feature >Affects Versions: 6.0 >Reporter: Joel Bernstein >Assignee: Joel Bernstein >Priority: Minor > Attachments: SOLR-8652.patch > > > This is used by DbVisualizer to limit the number of rows returned by the > query. The implementation will add a limit clause if one is not already > included in the query. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8652) Implement Statement.setMaxRows()
[ https://issues.apache.org/jira/browse/SOLR-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136103#comment-15136103 ] ASF subversion and git services commented on SOLR-8652: --- Commit 75a81795b8c8370cc754b60801fc33cc020efb30 in lucene-solr's branch refs/heads/master from jbernste [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=75a8179 ] SOLR-8652: Check if second to last token is limit to test for limit clause > Implement Statement.setMaxRows() > > > Key: SOLR-8652 > URL: https://issues.apache.org/jira/browse/SOLR-8652 > Project: Solr > Issue Type: New Feature >Affects Versions: 6.0 >Reporter: Joel Bernstein >Assignee: Joel Bernstein >Priority: Minor > Attachments: SOLR-8652.patch > > > This is used by DbVisualizer to limit the number of rows returned by the > query. The implementation will add a limit clause if one is not already > included in the query. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8652) Implement Statement.setMaxRows()
[ https://issues.apache.org/jira/browse/SOLR-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136104#comment-15136104 ] ASF subversion and git services commented on SOLR-8652: --- Commit 3d47612b04dae27080a5960088aa5e7303f14874 in lucene-solr's branch refs/heads/master from jbernste [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3d47612 ] SOLR-8652: Lower case the limit clause > Implement Statement.setMaxRows() > > > Key: SOLR-8652 > URL: https://issues.apache.org/jira/browse/SOLR-8652 > Project: Solr > Issue Type: New Feature >Affects Versions: 6.0 >Reporter: Joel Bernstein >Assignee: Joel Bernstein >Priority: Minor > Attachments: SOLR-8652.patch > > > This is used by DbVisualizer to limit the number of rows returned by the > query. The implementation will add a limit clause if one is not already > included in the query. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8652) Implement Statement.setMaxRows()
[ https://issues.apache.org/jira/browse/SOLR-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136097#comment-15136097 ] Kevin Risden commented on SOLR-8652: My concern here is that there could be columns or collections that have the name limit. This would break the logic that just checks the limit word is in the SQL statement. > Implement Statement.setMaxRows() > > > Key: SOLR-8652 > URL: https://issues.apache.org/jira/browse/SOLR-8652 > Project: Solr > Issue Type: New Feature >Affects Versions: 6.0 >Reporter: Joel Bernstein >Assignee: Joel Bernstein >Priority: Minor > Attachments: SOLR-8652.patch > > > This is used by DbVisualizer to limit the number of rows returned by the > query. The implementation will add a limit clause if one is not already > included in the query. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8652) Implement Statement.setMaxRows()
[ https://issues.apache.org/jira/browse/SOLR-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136098#comment-15136098 ] Joel Bernstein commented on SOLR-8652: -- Good point. I'll split on whitespace and check the 2nd to last token. > Implement Statement.setMaxRows() > > > Key: SOLR-8652 > URL: https://issues.apache.org/jira/browse/SOLR-8652 > Project: Solr > Issue Type: New Feature >Affects Versions: 6.0 >Reporter: Joel Bernstein >Assignee: Joel Bernstein >Priority: Minor > Attachments: SOLR-8652.patch > > > This is used by DbVisualizer to limit the number of rows returned by the > query. The implementation will add a limit clause if one is not already > included in the query. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
