[jira] [Commented] (SOLR-8724) Upgrade Zookeeper to 3.4.8
[ https://issues.apache.org/jira/browse/SOLR-8724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185241#comment-15185241 ] Steve Rowe commented on SOLR-8724: -- I opened a ZooKeeper issue to report the race to them: ZOOKEEPER-2383. > Upgrade Zookeeper to 3.4.8 > -- > > Key: SOLR-8724 > URL: https://issues.apache.org/jira/browse/SOLR-8724 > Project: Solr > Issue Type: Bug >Reporter: Steve Rowe > Fix For: master > > Attachments: SOLR-8724.patch, SOLR-8724.patch, SOLR-8724.patch > > > Zookeeper 3.4.8 was released a few days ago - we should upgrade. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8724) Upgrade Zookeeper to 3.4.8
[ https://issues.apache.org/jira/browse/SOLR-8724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170245#comment-15170245 ] Steve Rowe commented on SOLR-8724: -- I'm getting the same errors when running the older patch too; previous success with the older patch was on my laptop, but seeing consistent failures on my server with more test concurrency. So the errors are unrelated to the parseProperties() implementation. Here's one (all 5 suites that fail have this pattern: in the process of a ZkTestServer starting up, it fails to register the connection in the platform MBean server): {noformat} [junit4] Suite: org.apache.solr.handler.TestSolrConfigHandlerConcurrent [junit4] 2> Creating dataDir: /home/sarowe/git/lucene-solr/solr/build/solr-core/test/J12/temp/solr.handler.TestSolrConfigHandlerConcurrent_ACC627484AE10FE0-001/init-core-data-001 [junit4] 2> 0INFO (SUITE-TestSolrConfigHandlerConcurrent-seed#[ACC627484AE10FE0]-worker) [] o.a.s.SolrTestCaseJ4 Randomized ssl (false) and clientAuth (false) [junit4] 2> 37 INFO (SUITE-TestSolrConfigHandlerConcurrent-seed#[ACC627484AE10FE0]-worker) [] o.a.s.BaseDistributedSearchTestCase Setting hostContext system property: / [junit4] 2> 107 INFO (TEST-TestSolrConfigHandlerConcurrent.test-seed#[ACC627484AE10FE0]) [] o.a.s.c.ZkTestServer STARTING ZK TEST SERVER [junit4] 2> 117 INFO (Thread-1) [] o.a.s.c.ZkTestServer client port:0.0.0.0/0.0.0.0:0 [junit4] 2> 117 INFO (Thread-1) [] o.a.s.c.ZkTestServer Starting server [junit4] 2> 215 INFO (TEST-TestSolrConfigHandlerConcurrent.test-seed#[ACC627484AE10FE0]) [] o.a.s.c.ZkTestServer start zk server on port:34020 [junit4] 2> 243 INFO (TEST-TestSolrConfigHandlerConcurrent.test-seed#[ACC627484AE10FE0]) [] o.a.s.c.c.SolrZkClient Using default ZkCredentialsProvider [junit4] 2> 298 INFO (TEST-TestSolrConfigHandlerConcurrent.test-seed#[ACC627484AE10FE0]) [] o.a.s.c.c.ConnectionManager Waiting for client to connect to ZooKeeper [junit4] 2> 334 ERROR (SyncThread:0) [] o.a.z.s.ZooKeeperCriticalThread Severe unrecoverable error, from thread : SyncThread:0 [junit4] 2> java.lang.AssertionError [junit4] 2>at org.apache.zookeeper.jmx.MBeanRegistry.register(MBeanRegistry.java:93) [junit4] 2>at org.apache.zookeeper.server.ServerCnxnFactory.registerConnection(ServerCnxnFactory.java:147) [junit4] 2>at org.apache.zookeeper.server.ZooKeeperServer.finishSessionInit(ZooKeeperServer.java:613) [junit4] 2>at org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:181) [junit4] 2>at org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:200) [junit4] 2>at org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:131) [junit4] 2> 45314 WARN (TEST-TestSolrConfigHandlerConcurrent.test-seed#[ACC627484AE10FE0]-SendThread(127.0.0.1:34020)) [] o.a.z.ClientCnxn Client session timed out, have not heard from server in 45007ms for sessionid 0x0 [junit4] 2> NOTE: download the large Jenkins line-docs file by running 'ant get-jenkins-line-docs' in the lucene directory. [junit4] 2> NOTE: reproduce with: ant test -Dtestcase=TestSolrConfigHandlerConcurrent -Dtests.method=test -Dtests.seed=ACC627484AE10FE0 -Dtests.slow=true -Dtests.linedocsfile=/home/jenkins/lucene-data/enwiki.random.lines.txt -Dtests.locale=de-LU -Dtests.timezone=Cuba -Dtests.asserts=true -Dtests.file.encoding=UTF-8 [junit4] ERROR 45.4s J12 | TestSolrConfigHandlerConcurrent.test <<< [junit4]> Throwable #1: org.apache.solr.common.SolrException: java.util.concurrent.TimeoutException: Could not connect to ZooKeeper 127.0.0.1:34020 within 45000 ms [junit4]>at __randomizedtesting.SeedInfo.seed([ACC627484AE10FE0:24921892E41D6218]:0) [junit4]>at org.apache.solr.common.cloud.SolrZkClient.(SolrZkClient.java:181) [junit4]>at org.apache.solr.common.cloud.SolrZkClient.(SolrZkClient.java:115) [junit4]>at org.apache.solr.common.cloud.SolrZkClient.(SolrZkClient.java:105) [junit4]>at org.apache.solr.cloud.AbstractZkTestCase.buildZooKeeper(AbstractZkTestCase.java:88) [junit4]>at org.apache.solr.cloud.AbstractZkTestCase.buildZooKeeper(AbstractZkTestCase.java:82) [junit4]>at org.apache.solr.cloud.AbstractDistribZkTestBase.distribSetUp(AbstractDistribZkTestBase.java:75) [junit4]>at org.apache.solr.cloud.AbstractFullDistribZkTestBase.distribSetUp(AbstractFullDistribZkTestBase.java:217) [junit4]>at org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsStatement.evaluate(BaseDistributedSearchTestCase.java:966) [junit4]>at
[jira] [Commented] (SOLR-8724) Upgrade Zookeeper to 3.4.8
[ https://issues.apache.org/jira/browse/SOLR-8724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170177#comment-15170177 ] Steve Rowe commented on SOLR-8724: -- Hmm, must've done something wrong in the latest patch, tests are failing with "TimeoutException: Could not connect to ZooKeeper 127.0.0.1: within 45000 ms". > Upgrade Zookeeper to 3.4.8 > -- > > Key: SOLR-8724 > URL: https://issues.apache.org/jira/browse/SOLR-8724 > Project: Solr > Issue Type: Bug >Reporter: Steve Rowe > Fix For: master > > Attachments: SOLR-8724.patch, SOLR-8724.patch, SOLR-8724.patch > > > Zookeeper 3.4.8 was released a few days ago - we should upgrade. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8724) Upgrade Zookeeper to 3.4.8
[ https://issues.apache.org/jira/browse/SOLR-8724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169717#comment-15169717 ] Mark Miller commented on SOLR-8724: --- +1, LGTM. bq. If it weren't for that last item, I'd advocate for getting rid of this patched parseProperties() and directly calling the superclass version, catching the ".../myid file is missing" IllegalArgumentException, and handling setting the server id in the catch block. Might not be a bad improvement - not ideal to have the MDC call, but also probably not very problematic. > Upgrade Zookeeper to 3.4.8 > -- > > Key: SOLR-8724 > URL: https://issues.apache.org/jira/browse/SOLR-8724 > Project: Solr > Issue Type: Bug >Reporter: Steve Rowe > Fix For: master > > Attachments: SOLR-8724.patch, SOLR-8724.patch > > > Zookeeper 3.4.8 was released a few days ago - we should upgrade. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8724) Upgrade Zookeeper to 3.4.8
[ https://issues.apache.org/jira/browse/SOLR-8724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169145#comment-15169145 ] Steve Rowe commented on SOLR-8724: -- If there are no objections I'll commit later today. > Upgrade Zookeeper to 3.4.8 > -- > > Key: SOLR-8724 > URL: https://issues.apache.org/jira/browse/SOLR-8724 > Project: Solr > Issue Type: Bug >Reporter: Steve Rowe > Fix For: master > > Attachments: SOLR-8724.patch, SOLR-8724.patch > > > Zookeeper 3.4.8 was released a few days ago - we should upgrade. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8724) Upgrade Zookeeper to 3.4.8
[ https://issues.apache.org/jira/browse/SOLR-8724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163792#comment-15163792 ] Steve Rowe commented on SOLR-8724: -- Forgot to mention: I checked for changed ZK dependencies between 3.4.6 and 3.4.8, and only the commons-collections dep changed, from v3.1 to v3.2.2. Solr already depends on v3.2.2. > Upgrade Zookeeper to 3.4.8 > -- > > Key: SOLR-8724 > URL: https://issues.apache.org/jira/browse/SOLR-8724 > Project: Solr > Issue Type: Bug >Reporter: Steve Rowe > Fix For: master > > Attachments: SOLR-8724.patch > > > Zookeeper 3.4.8 was released a few days ago - we should upgrade. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org