[jira] [Commented] (SOLR-9058) hashJoin does not work when "on" maps fields with "="
[ https://issues.apache.org/jira/browse/SOLR-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294323#comment-15294323 ] ASF subversion and git services commented on SOLR-9058: --- Commit fbf7d5446d3cdfda0c3906c274ac2c444b419a82 in lucene-solr's branch refs/heads/branch_6_0 from [~dpgove] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fbf7d54 ] SOLR-9058: Makes HashJoinStream and OuterHashJoinStream support different field names in the incoming streams, eg. fieldA=fieldB > hashJoin does not work when "on" maps fields with "=" > - > > Key: SOLR-9058 > URL: https://issues.apache.org/jira/browse/SOLR-9058 > Project: Solr > Issue Type: Bug >Affects Versions: 6.0 >Reporter: Stephan Osthold >Assignee: Dennis Gove >Priority: Minor > Fix For: 6.1, master (7.0) > > Attachments: SOLR-9058.patch > > > hashJoin does not work when "on" maps fields with "=" > eg. > hashJoin( > ... > on="field1=field2" > ) > See link for fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9058) hashJoin does not work when "on" maps fields with "="
[ https://issues.apache.org/jira/browse/SOLR-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281629#comment-15281629 ] Erick Erickson commented on SOLR-9058: -- I changed the fix versions to reflect the actual pushes. If you want it to go into 6.0.1, feel free to backport to 6_0 and update the fix versions Whether you want to backport depends, usually that's reserved for those bugs you consider critical to the release. And there's no guarantee at all that there will ever be a 6.0.1. Up to you > hashJoin does not work when "on" maps fields with "=" > - > > Key: SOLR-9058 > URL: https://issues.apache.org/jira/browse/SOLR-9058 > Project: Solr > Issue Type: Bug >Affects Versions: 6.0 >Reporter: Stephan Osthold >Assignee: Dennis Gove >Priority: Minor > Fix For: 6.1, master (7.0) > > Attachments: SOLR-9058.patch > > > hashJoin does not work when "on" maps fields with "=" > eg. > hashJoin( > ... > on="field1=field2" > ) > See link for fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9058) hashJoin does not work when "on" maps fields with "="
[ https://issues.apache.org/jira/browse/SOLR-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281499#comment-15281499 ] Joel Bernstein commented on SOLR-9058: -- Yes if it's in 6x it will be in 6.1. If you wanted to add this to 6.0.1 you'd have to back port to branch_6_0. > hashJoin does not work when "on" maps fields with "=" > - > > Key: SOLR-9058 > URL: https://issues.apache.org/jira/browse/SOLR-9058 > Project: Solr > Issue Type: Bug >Affects Versions: 6.0 >Reporter: Stephan Osthold >Assignee: Dennis Gove >Priority: Minor > Fix For: 6.0, 6.1 > > Attachments: SOLR-9058.patch > > > hashJoin does not work when "on" maps fields with "=" > eg. > hashJoin( > ... > on="field1=field2" > ) > See link for fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9058) hashJoin does not work when "on" maps fields with "="
[ https://issues.apache.org/jira/browse/SOLR-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281467#comment-15281467 ] Dennis Gove commented on SOLR-9058: --- Yeah, it can be. Have a question about the fix versions though. This has been committed to master and branch_6x. My understanding is that means it's going to hit 6.1. Is that right? Is there another branch I should backport it to? > hashJoin does not work when "on" maps fields with "=" > - > > Key: SOLR-9058 > URL: https://issues.apache.org/jira/browse/SOLR-9058 > Project: Solr > Issue Type: Bug >Affects Versions: 6.0 >Reporter: Stephan Osthold >Assignee: Dennis Gove >Priority: Minor > Fix For: 6.0, 6.1 > > Attachments: SOLR-9058.patch > > > hashJoin does not work when "on" maps fields with "=" > eg. > hashJoin( > ... > on="field1=field2" > ) > See link for fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9058) hashJoin does not work when "on" maps fields with "="
[ https://issues.apache.org/jira/browse/SOLR-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15280462#comment-15280462 ] Hoss Man commented on SOLR-9058: [~dpgove] - should this be resolved? > hashJoin does not work when "on" maps fields with "=" > - > > Key: SOLR-9058 > URL: https://issues.apache.org/jira/browse/SOLR-9058 > Project: Solr > Issue Type: Bug >Affects Versions: 6.0 >Reporter: Stephan Osthold >Assignee: Dennis Gove >Priority: Minor > Fix For: 6.0, 6.1 > > Attachments: SOLR-9058.patch > > > hashJoin does not work when "on" maps fields with "=" > eg. > hashJoin( > ... > on="field1=field2" > ) > See link for fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9058) hashJoin does not work when "on" maps fields with "="
[ https://issues.apache.org/jira/browse/SOLR-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273388#comment-15273388 ] ASF subversion and git services commented on SOLR-9058: --- Commit d95a91a9cca341d7633d339bf56b08ecd59d1c2a in lucene-solr's branch refs/heads/branch_6x from [~dpgove] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d95a91a ] SOLR-9058: Makes HashJoinStream and OuterHashJoinStream support different field names in the incoming streams, eg. fieldA=fieldB > hashJoin does not work when "on" maps fields with "=" > - > > Key: SOLR-9058 > URL: https://issues.apache.org/jira/browse/SOLR-9058 > Project: Solr > Issue Type: Bug >Reporter: Stephan Osthold >Assignee: Dennis Gove >Priority: Minor > Attachments: SOLR-9058.patch > > > hashJoin does not work when "on" maps fields with "=" > eg. > hashJoin( > ... > on="field1=field2" > ) > See link for fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9058) hashJoin does not work when "on" maps fields with "="
[ https://issues.apache.org/jira/browse/SOLR-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273386#comment-15273386 ] ASF subversion and git services commented on SOLR-9058: --- Commit c7929f8b851dd12d3ae1b9834058428394821790 in lucene-solr's branch refs/heads/master from [~dpgove] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c7929f8 ] SOLR-9058: Makes HashJoinStream and OuterHashJoinStream support different field names in the incoming streams, eg. fieldA=fieldB > hashJoin does not work when "on" maps fields with "=" > - > > Key: SOLR-9058 > URL: https://issues.apache.org/jira/browse/SOLR-9058 > Project: Solr > Issue Type: Bug >Reporter: Stephan Osthold >Assignee: Dennis Gove >Priority: Minor > Attachments: SOLR-9058.patch > > > hashJoin does not work when "on" maps fields with "=" > eg. > hashJoin( > ... > on="field1=field2" > ) > See link for fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9058) hashJoin does not work when "on" maps fields with "="
[ https://issues.apache.org/jira/browse/SOLR-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270373#comment-15270373 ] Stephan Osthold commented on SOLR-9058: --- OuterHashJoin inherits from HashJoin. I did the required changes and the tests pass, however I only did a very brief manual test. > hashJoin does not work when "on" maps fields with "=" > - > > Key: SOLR-9058 > URL: https://issues.apache.org/jira/browse/SOLR-9058 > Project: Solr > Issue Type: Bug >Reporter: Stephan Osthold >Assignee: Dennis Gove >Priority: Minor > > hashJoin does not work when "on" maps fields with "=" > eg. > hashJoin( > ... > on="field1=field2" > ) > See link for fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9058) hashJoin does not work when "on" maps fields with "="
[ https://issues.apache.org/jira/browse/SOLR-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270370#comment-15270370 ] Stephan Osthold commented on SOLR-9058: --- In regard to splitting only once, if you don't mind changing the parameters for the constructors, I'd do it like this: https://github.com/StephanOsthold/lucene-solr/commit/c0749f0aa6587d70db3bdbb2ad6a86d2901ed72f The lists are private, because I need to make sure they have the same size. > hashJoin does not work when "on" maps fields with "=" > - > > Key: SOLR-9058 > URL: https://issues.apache.org/jira/browse/SOLR-9058 > Project: Solr > Issue Type: Bug >Reporter: Stephan Osthold >Assignee: Dennis Gove >Priority: Minor > > hashJoin does not work when "on" maps fields with "=" > eg. > hashJoin( > ... > on="field1=field2" > ) > See link for fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9058) hashJoin does not work when "on" maps fields with "="
[ https://issues.apache.org/jira/browse/SOLR-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268744#comment-15268744 ] Dennis Gove commented on SOLR-9058: --- Note - need to check if this fix is also necessary for outerHash. I suspect it is. > hashJoin does not work when "on" maps fields with "=" > - > > Key: SOLR-9058 > URL: https://issues.apache.org/jira/browse/SOLR-9058 > Project: Solr > Issue Type: Bug >Reporter: Stephan Osthold >Assignee: Dennis Gove >Priority: Minor > > hashJoin does not work when "on" maps fields with "=" > eg. > hashJoin( > ... > on="field1=field2" > ) > See link for fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9058) hashJoin does not work when "on" maps fields with "="
[ https://issues.apache.org/jira/browse/SOLR-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268738#comment-15268738 ] Dennis Gove commented on SOLR-9058: --- I'll take this. I like the fix but want to see if there's an easy way to do the splitting once (during init) instead of on each read - we'll get slightly better performance with that. > hashJoin does not work when "on" maps fields with "=" > - > > Key: SOLR-9058 > URL: https://issues.apache.org/jira/browse/SOLR-9058 > Project: Solr > Issue Type: Bug >Reporter: Stephan Osthold >Priority: Minor > > hashJoin does not work when "on" maps fields with "=" > eg. > hashJoin( > ... > on="field1=field2" > ) > See link for fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9058) hashJoin does not work when "on" maps fields with "="
[ https://issues.apache.org/jira/browse/SOLR-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268694#comment-15268694 ] Joel Bernstein commented on SOLR-9058: -- [~dpgove], you want you to take this one? Or do you want me to take a look? > hashJoin does not work when "on" maps fields with "=" > - > > Key: SOLR-9058 > URL: https://issues.apache.org/jira/browse/SOLR-9058 > Project: Solr > Issue Type: Bug >Reporter: Stephan Osthold >Priority: Minor > > hashJoin does not work when "on" maps fields with "=" > eg. > hashJoin( > ... > on="field1=field2" > ) > See link for fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9058) hashJoin does not work when "on" maps fields with "="
[ https://issues.apache.org/jira/browse/SOLR-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268688#comment-15268688 ] Joel Bernstein commented on SOLR-9058: -- Thanks. I just checked and there isn't a test case for scenario. > hashJoin does not work when "on" maps fields with "=" > - > > Key: SOLR-9058 > URL: https://issues.apache.org/jira/browse/SOLR-9058 > Project: Solr > Issue Type: Bug >Reporter: Stephan Osthold >Priority: Minor > > hashJoin does not work when "on" maps fields with "=" > eg. > hashJoin( > ... > on="field1=field2" > ) > See link for fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
