[jira] [Commented] (SOLR-9216) Support collection.configName in MODIFYCOLLECTION request

2016-06-30 Thread Keith Laban (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357284#comment-15357284
 ] 

Keith Laban commented on SOLR-9216:
---

Never mind, I didn't realize you made a change to use it in some of the other 
classes 

> Support collection.configName in MODIFYCOLLECTION request
> -
>
> Key: SOLR-9216
> URL: https://issues.apache.org/jira/browse/SOLR-9216
> Project: Solr
>  Issue Type: Improvement
>Reporter: Keith Laban
>Assignee: Noble Paul
> Fix For: 6.2
>
> Attachments: SOLR-9216.patch, SOLR-9216.patch, SOLR-9216.patch
>
>
> MODIFYCOLLECTION should support updating the 
> {{/collections/}} value of "configName" in zookeeper



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-9216) Support collection.configName in MODIFYCOLLECTION request

2016-06-30 Thread Keith Laban (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357280#comment-15357280
 ] 

Keith Laban commented on SOLR-9216:
---

[~noble.paul] did you mean to commit that change to SolrParams?

> Support collection.configName in MODIFYCOLLECTION request
> -
>
> Key: SOLR-9216
> URL: https://issues.apache.org/jira/browse/SOLR-9216
> Project: Solr
>  Issue Type: Improvement
>Reporter: Keith Laban
>Assignee: Noble Paul
> Fix For: 6.2
>
> Attachments: SOLR-9216.patch, SOLR-9216.patch, SOLR-9216.patch
>
>
> MODIFYCOLLECTION should support updating the 
> {{/collections/}} value of "configName" in zookeeper



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-9216) Support collection.configName in MODIFYCOLLECTION request

2016-06-30 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356681#comment-15356681
 ] 

ASF subversion and git services commented on SOLR-9216:
---

Commit ce3ea76781c79b700a09a4c5fa36621af14016de in lucene-solr's branch 
refs/heads/branch_6x from [~noble.paul]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ce3ea76 ]

SOLR-9216: Support collection.configName in MODIFYCOLLECTION request


> Support collection.configName in MODIFYCOLLECTION request
> -
>
> Key: SOLR-9216
> URL: https://issues.apache.org/jira/browse/SOLR-9216
> Project: Solr
>  Issue Type: Improvement
>Reporter: Keith Laban
>Assignee: Noble Paul
> Attachments: SOLR-9216.patch, SOLR-9216.patch, SOLR-9216.patch
>
>
> MODIFYCOLLECTION should support updating the 
> {{/collections/}} value of "configName" in zookeeper



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-9216) Support collection.configName in MODIFYCOLLECTION request

2016-06-29 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356613#comment-15356613
 ] 

ASF subversion and git services commented on SOLR-9216:
---

Commit 1dc7480bcdfba1e9c854172e19e8cc6ba96144d2 in lucene-solr's branch 
refs/heads/master from [~noble.paul]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1dc7480 ]

SOLR-9216: Support collection.configName in MODIFYCOLLECTION request


> Support collection.configName in MODIFYCOLLECTION request
> -
>
> Key: SOLR-9216
> URL: https://issues.apache.org/jira/browse/SOLR-9216
> Project: Solr
>  Issue Type: Improvement
>Reporter: Keith Laban
>Assignee: Noble Paul
> Attachments: SOLR-9216.patch, SOLR-9216.patch, SOLR-9216.patch
>
>
> MODIFYCOLLECTION should support updating the 
> {{/collections/}} value of "configName" in zookeeper



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-9216) Support collection.configName in MODIFYCOLLECTION request

2016-06-29 Thread Keith Laban (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355784#comment-15355784
 ] 

Keith Laban commented on SOLR-9216:
---

removed changes from RulesTest and added an OverseerModifyCollectionTest with 
this testcase

> Support collection.configName in MODIFYCOLLECTION request
> -
>
> Key: SOLR-9216
> URL: https://issues.apache.org/jira/browse/SOLR-9216
> Project: Solr
>  Issue Type: Improvement
>Reporter: Keith Laban
>Assignee: Noble Paul
> Attachments: SOLR-9216.patch, SOLR-9216.patch
>
>
> MODIFYCOLLECTION should support updating the 
> {{/collections/}} value of "configName" in zookeeper



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-9216) Support collection.configName in MODIFYCOLLECTION request

2016-06-29 Thread Noble Paul (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355533#comment-15355533
 ] 

Noble Paul commented on SOLR-9216:
--

Yeah, the testcase is the problem. RulesTest is not the right place to do it. 
We should add it elsewhere


> Support collection.configName in MODIFYCOLLECTION request
> -
>
> Key: SOLR-9216
> URL: https://issues.apache.org/jira/browse/SOLR-9216
> Project: Solr
>  Issue Type: Improvement
>Reporter: Keith Laban
>Assignee: Noble Paul
> Attachments: SOLR-9216.patch
>
>
> MODIFYCOLLECTION should support updating the 
> {{/collections/}} value of "configName" in zookeeper



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-9216) Support collection.configName in MODIFYCOLLECTION request

2016-06-29 Thread Noble Paul (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355198#comment-15355198
 ] 

Noble Paul commented on SOLR-9216:
--

Sorry, lost track. I shall review it today

> Support collection.configName in MODIFYCOLLECTION request
> -
>
> Key: SOLR-9216
> URL: https://issues.apache.org/jira/browse/SOLR-9216
> Project: Solr
>  Issue Type: Improvement
>Reporter: Keith Laban
>Assignee: Noble Paul
> Attachments: SOLR-9216.patch
>
>
> MODIFYCOLLECTION should support updating the 
> {{/collections/}} value of "configName" in zookeeper



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-9216) Support collection.configName in MODIFYCOLLECTION request

2016-06-17 Thread Keith Laban (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336861#comment-15336861
 ] 

Keith Laban commented on SOLR-9216:
---

[~noble.paul] looks like you did the original work on MODIFYCOLLECTION. Would 
you mind taking a look?

I put the test into RulesTest, although I'm not sure this is the best place to 
put the test, it was the only spot I could find that this request was being 
tested. If you would like I can move it separate class. 

> Support collection.configName in MODIFYCOLLECTION request
> -
>
> Key: SOLR-9216
> URL: https://issues.apache.org/jira/browse/SOLR-9216
> Project: Solr
>  Issue Type: Improvement
>Reporter: Keith Laban
> Attachments: SOLR-9216.patch
>
>
> MODIFYCOLLECTION should support updating the 
> {{/collections/}} value of "configName" in zookeeper



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org