[jira] [Commented] (SOLR-9411) Better validation of dynamic field for Schema API
[ https://issues.apache.org/jira/browse/SOLR-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15527398#comment-15527398 ] Jan Høydahl commented on SOLR-9411: --- Good catch. Feel free to piggy-back on this issue and adjust title and CHANGES entry accordingly. > Better validation of dynamic field for Schema API > - > > Key: SOLR-9411 > URL: https://issues.apache.org/jira/browse/SOLR-9411 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Schema and Analysis >Reporter: Jan Høydahl >Assignee: Jan Høydahl > Fix For: 6.3, master (7.0) > > Attachments: SOLR-9411-part2.patch, SOLR-9411.patch, SOLR-9411.patch > > > Schema REST API needs better validation before doing changes. > * It should not be allowed to delete uniqueKey (also handled in SOLR-9349) > * When adding a dynamic field the API should test that it begins or ends with > {{*}}. Today the change succeeds, but you get errors later > These are two known cases. We should harden validation across the board for > all known schema requirements. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9411) Better validation of dynamic field for Schema API
[ https://issues.apache.org/jira/browse/SOLR-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525707#comment-15525707 ] ASF subversion and git services commented on SOLR-9411: --- Commit 53fcc7563c1010e34a8f0889968711816bcb89ff in lucene-solr's branch refs/heads/branch_6x from [~janhoy] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=53fcc75 ] SOLR-9411: Better validation of dynamic field for Schema API (cherry picked from commit 8046fe2) > Better validation of dynamic field for Schema API > - > > Key: SOLR-9411 > URL: https://issues.apache.org/jira/browse/SOLR-9411 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Schema and Analysis >Reporter: Jan Høydahl >Assignee: Jan Høydahl > Fix For: 6.3, master (7.0) > > Attachments: SOLR-9411.patch, SOLR-9411.patch > > > Schema REST API needs better validation before doing changes. > * It should not be allowed to delete uniqueKey (also handled in SOLR-9349) > * When adding a dynamic field the API should test that it begins or ends with > {{*}}. Today the change succeeds, but you get errors later > These are two known cases. We should harden validation across the board for > all known schema requirements. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9411) Better validation of dynamic field for Schema API
[ https://issues.apache.org/jira/browse/SOLR-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525687#comment-15525687 ] ASF subversion and git services commented on SOLR-9411: --- Commit 8046fe29e55e46df4d5093460825f64dabd4b7ba in lucene-solr's branch refs/heads/master from [~janhoy] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8046fe2 ] SOLR-9411: Better validation of dynamic field for Schema API > Better validation of dynamic field for Schema API > - > > Key: SOLR-9411 > URL: https://issues.apache.org/jira/browse/SOLR-9411 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Schema and Analysis >Reporter: Jan Høydahl >Assignee: Jan Høydahl > Fix For: 6.3, master (7.0) > > Attachments: SOLR-9411.patch, SOLR-9411.patch > > > Schema REST API needs better validation before doing changes. > * It should not be allowed to delete uniqueKey (also handled in SOLR-9349) > * When adding a dynamic field the API should test that it begins or ends with > {{*}}. Today the change succeeds, but you get errors later > These are two known cases. We should harden validation across the board for > all known schema requirements. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org