[jira] [Commented] (SOLR-9657) Create a new TemplateUpdateRequestProcessorFactory
[ https://issues.apache.org/jira/browse/SOLR-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15606278#comment-15606278 ] Alexandre Rafalovitch commented on SOLR-9657: - This matches commit 9d692cde53c25230d6db2663816f313cf356535b on the master that - for some reasons - did not link up with Jira. > Create a new TemplateUpdateRequestProcessorFactory > -- > > Key: SOLR-9657 > URL: https://issues.apache.org/jira/browse/SOLR-9657 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Fix For: 6.3, master (7.0) > > Attachments: SOLR-9657.patch > > > Unlike other URPs, this will operate on request parameters > example: > {code} > processor=Template&Template.field=fname:${somefield}some_string${someotherfield} > {code} > The actual name of the class is {{TemplateUpdateProcessorFactory}} and it is > possible to optionally drop the {{UpdateProcessorfactory}} part. The > {{Template.field}} specifies a field name as well as a template. The > {{Template.field}} parameter is multivalued , so , it is possible to add > multiple fields or a multivalued field with same name -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9657) Create a new TemplateUpdateRequestProcessorFactory
[ https://issues.apache.org/jira/browse/SOLR-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15606271#comment-15606271 ] ASF subversion and git services commented on SOLR-9657: --- Commit fdb4dd3b322a517ff7f9df2ef64001120e89854c in lucene-solr's branch refs/heads/branch_6x from [~arafalov] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fdb4dd3 ] SOLR-9657: Fixed Javadocs and added example > Create a new TemplateUpdateRequestProcessorFactory > -- > > Key: SOLR-9657 > URL: https://issues.apache.org/jira/browse/SOLR-9657 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Fix For: 6.3, master (7.0) > > Attachments: SOLR-9657.patch > > > Unlike other URPs, this will operate on request parameters > example: > {code} > processor=Template&Template.field=fname:${somefield}some_string${someotherfield} > {code} > The actual name of the class is {{TemplateUpdateProcessorFactory}} and it is > possible to optionally drop the {{UpdateProcessorfactory}} part. The > {{Template.field}} specifies a field name as well as a template. The > {{Template.field}} parameter is multivalued , so , it is possible to add > multiple fields or a multivalued field with same name -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9657) Create a new TemplateUpdateRequestProcessorFactory
[ https://issues.apache.org/jira/browse/SOLR-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15592065#comment-15592065 ] Alexandre Rafalovitch commented on SOLR-9657: - The Javadoc comment format is not correct for the class and does not build the description into the resulting Javadoc. Basically, you have to use the correct multi-line comment delimiters, as per [the rules|http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#format]. Or see the parent or any other class that have them. > Create a new TemplateUpdateRequestProcessorFactory > -- > > Key: SOLR-9657 > URL: https://issues.apache.org/jira/browse/SOLR-9657 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Fix For: 6.3, master (7.0) > > Attachments: SOLR-9657.patch > > > Unlike other URPs, this will operate on request parameters > example: > {code} > processor=Template&Template.field=fname:${somefield}some_string${someotherfield} > {code} > The actual name of the class is {{TemplateUpdateProcessorFactory}} and it is > possible to optionally drop the {{UpdateProcessorfactory}} part. The > {{Template.field}} specifies a field name as well as a template. The > {{Template.field}} parameter is multivalued , so , it is possible to add > multiple fields or a multivalued field with same name -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9657) Create a new TemplateUpdateRequestProcessorFactory
[ https://issues.apache.org/jira/browse/SOLR-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15591993#comment-15591993 ] ASF subversion and git services commented on SOLR-9657: --- Commit b1e2d02ec3e2d87bd406190f1600dccd679901f9 in lucene-solr's branch refs/heads/branch_6x from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b1e2d02 ] SOLR-9657: Use cache for templates > Create a new TemplateUpdateRequestProcessorFactory > -- > > Key: SOLR-9657 > URL: https://issues.apache.org/jira/browse/SOLR-9657 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9657.patch > > > Unlike other URPs, this will operate on request parameters > example: > {code} > processor=Template&Template.field=fname:${somefield}some_string${someotherfield} > {code} > The actual name of the class is {{TemplateUpdateProcessorFactory}} and it is > possible to optionally drop the {{UpdateProcessorfactory}} part. The > {{Template.field}} specifies a field name as well as a template. The > {{Template.field}} parameter is multivalued , so , it is possible to add > multiple fields or a multivalued field with same name -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9657) Create a new TemplateUpdateRequestProcessorFactory
[ https://issues.apache.org/jira/browse/SOLR-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15591979#comment-15591979 ] ASF subversion and git services commented on SOLR-9657: --- Commit 127bf9f772468cbc94478ad67d54652001b175e0 in lucene-solr's branch refs/heads/master from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=127bf9f ] SOLR-9657: Use cache for templates > Create a new TemplateUpdateRequestProcessorFactory > -- > > Key: SOLR-9657 > URL: https://issues.apache.org/jira/browse/SOLR-9657 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9657.patch > > > Unlike other URPs, this will operate on request parameters > example: > {code} > processor=Template&Template.field=fname:${somefield}some_string${someotherfield} > {code} > The actual name of the class is {{TemplateUpdateProcessorFactory}} and it is > possible to optionally drop the {{UpdateProcessorfactory}} part. The > {{Template.field}} specifies a field name as well as a template. The > {{Template.field}} parameter is multivalued , so , it is possible to add > multiple fields or a multivalued field with same name -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9657) Create a new TemplateUpdateRequestProcessorFactory
[ https://issues.apache.org/jira/browse/SOLR-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589703#comment-15589703 ] ASF subversion and git services commented on SOLR-9657: --- Commit 0ab908694ef503ea45b3a59ccd3707b54978fd5f in lucene-solr's branch refs/heads/branch_6x from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0ab9086 ] SOLR-9657: Addressing test failures > Create a new TemplateUpdateRequestProcessorFactory > -- > > Key: SOLR-9657 > URL: https://issues.apache.org/jira/browse/SOLR-9657 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9657.patch > > > Unlike other URPs, this will operate on request parameters > example: > {code} > processor=Template&Template.field=fname:${somefield}some_string${someotherfield} > {code} > The actual name of the class is {{TemplateUpdateProcessorFactory}} and it is > possible to optionally drop the {{UpdateProcessorfactory}} part. The > {{Template.field}} specifies a field name as well as a template. The > {{Template.field}} parameter is multivalued , so , it is possible to add > multiple fields or a multivalued field with same name -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9657) Create a new TemplateUpdateRequestProcessorFactory
[ https://issues.apache.org/jira/browse/SOLR-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589699#comment-15589699 ] ASF subversion and git services commented on SOLR-9657: --- Commit 6893595f340b748a9c5e5c3884704e71275deab4 in lucene-solr's branch refs/heads/master from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6893595 ] SOLR-9657: Addressing test failures > Create a new TemplateUpdateRequestProcessorFactory > -- > > Key: SOLR-9657 > URL: https://issues.apache.org/jira/browse/SOLR-9657 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9657.patch > > > Unlike other URPs, this will operate on request parameters > example: > {code} > processor=Template&Template.field=fname:${somefield}some_string${someotherfield} > {code} > The actual name of the class is {{TemplateUpdateProcessorFactory}} and it is > possible to optionally drop the {{UpdateProcessorfactory}} part. The > {{Template.field}} specifies a field name as well as a template. The > {{Template.field}} parameter is multivalued , so , it is possible to add > multiple fields or a multivalued field with same name -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9657) Create a new TemplateUpdateRequestProcessorFactory
[ https://issues.apache.org/jira/browse/SOLR-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589104#comment-15589104 ] Noble Paul commented on SOLR-9657: -- Possible. I'll debug it > Create a new TemplateUpdateRequestProcessorFactory > -- > > Key: SOLR-9657 > URL: https://issues.apache.org/jira/browse/SOLR-9657 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9657.patch > > > Unlike other URPs, this will operate on request parameters > example: > {code} > processor=Template&Template.field=fname:${somefield}some_string${someotherfield} > {code} > The actual name of the class is {{TemplateUpdateProcessorFactory}} and it is > possible to optionally drop the {{UpdateProcessorfactory}} part. The > {{Template.field}} specifies a field name as well as a template. The > {{Template.field}} parameter is multivalued , so , it is possible to add > multiple fields or a multivalued field with same name -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9657) Create a new TemplateUpdateRequestProcessorFactory
[ https://issues.apache.org/jira/browse/SOLR-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589063#comment-15589063 ] Alan Woodward commented on SOLR-9657: - I think this is causing test failures? https://jenkins.thetaphi.de/job/Lucene-Solr-6.x-Linux/1987/ > Create a new TemplateUpdateRequestProcessorFactory > -- > > Key: SOLR-9657 > URL: https://issues.apache.org/jira/browse/SOLR-9657 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9657.patch > > > Unlike other URPs, this will operate on request parameters > example: > {code} > processor=Template&Template.field=fname:${somefield}some_string${someotherfield} > {code} > The actual name of the class is {{TemplateUpdateProcessorFactory}} and it is > possible to optionally drop the {{UpdateProcessorfactory}} part. The > {{Template.field}} specifies a field name as well as a template. The > {{Template.field}} parameter is multivalued , so , it is possible to add > multiple fields or a multivalued field with same name -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9657) Create a new TemplateUpdateRequestProcessorFactory
[ https://issues.apache.org/jira/browse/SOLR-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588981#comment-15588981 ] Alexandre Rafalovitch commented on SOLR-9657: - The JIRA has not gone very far because it was hard to do (I just updated my own findings there). solr-start, based on similar principles is up and running, serving user needs and getting good views. And it is finding components that were missed both by Reference Guide AND Release Notes, exactly because it relies on shipped code alone. And, things like cross-reference to usage example, is not something that Reference Guide can maintain by hand with reasonable effort. The V2 API might be the magical unicorn when it actually lands, but - as my own comments there indicate - I could not make heads or tails out of it in a meanwhile. So, let's focus on reality, especially the reality for 6.x. As open-source Solr developers, we are combining 3 roles that are often separated in commercial organizations: Developers of new - blue-sky - features (master), maintainers and developers of the current features (6.x currently), and tech-support for whatever was already released (6.x.y, 5.x.y). Your suggested approach is about blue-sky which is great, but not sufficient. Let's just take care of these other aspects too, so other people don't have to. > Create a new TemplateUpdateRequestProcessorFactory > -- > > Key: SOLR-9657 > URL: https://issues.apache.org/jira/browse/SOLR-9657 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9657.patch > > > Unlike other URPs, this will operate on request parameters > example: > {code} > processor=Template&Template.field=fname:${somefield}some_string${someotherfield} > {code} > The actual name of the class is {{TemplateUpdateProcessorFactory}} and it is > possible to optionally drop the {{UpdateProcessorfactory}} part. The > {{Template.field}} specifies a field name as well as a template. The > {{Template.field}} parameter is multivalued , so , it is possible to add > multiple fields or a multivalued field with same name -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9657) Create a new TemplateUpdateRequestProcessorFactory
[ https://issues.apache.org/jira/browse/SOLR-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588945#comment-15588945 ] Noble Paul commented on SOLR-9657: -- That's going nowhere . In v2 api , we have documentation added to specification files. That's going to be the way forward > Create a new TemplateUpdateRequestProcessorFactory > -- > > Key: SOLR-9657 > URL: https://issues.apache.org/jira/browse/SOLR-9657 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9657.patch > > > Unlike other URPs, this will operate on request parameters > example: > {code} > processor=Template&Template.field=fname:${somefield}some_string${someotherfield} > {code} > The actual name of the class is {{TemplateUpdateProcessorFactory}} and it is > possible to optionally drop the {{UpdateProcessorfactory}} part. The > {{Template.field}} specifies a field name as well as a template. The > {{Template.field}} parameter is multivalued , so , it is possible to add > multiple fields or a multivalued field with same name -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9657) Create a new TemplateUpdateRequestProcessorFactory
[ https://issues.apache.org/jira/browse/SOLR-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588917#comment-15588917 ] Alexandre Rafalovitch commented on SOLR-9657: - Relying on Javadocs and other code-comments for multiple various things *is* a common practice out there. Including - as a feature request - for our own code (see SOLR-555 by [~hossman]). > Create a new TemplateUpdateRequestProcessorFactory > -- > > Key: SOLR-9657 > URL: https://issues.apache.org/jira/browse/SOLR-9657 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9657.patch > > > Unlike other URPs, this will operate on request parameters > example: > {code} > processor=Template&Template.field=fname:${somefield}some_string${someotherfield} > {code} > The actual name of the class is {{TemplateUpdateProcessorFactory}} and it is > possible to optionally drop the {{UpdateProcessorfactory}} part. The > {{Template.field}} specifies a field name as well as a template. The > {{Template.field}} parameter is multivalued , so , it is possible to add > multiple fields or a multivalued field with same name -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9657) Create a new TemplateUpdateRequestProcessorFactory
[ https://issues.apache.org/jira/browse/SOLR-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1558#comment-1558 ] Noble Paul commented on SOLR-9657: -- Relying on javadocs for ref guide is not a common practice. The purpose of javadocs is different . It makes little sense when a feature involves multiple source files. Javadocs must be used to communicate to fellow developers > Create a new TemplateUpdateRequestProcessorFactory > -- > > Key: SOLR-9657 > URL: https://issues.apache.org/jira/browse/SOLR-9657 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9657.patch > > > Unlike other URPs, this will operate on request parameters > example: > {code} > processor=Template&Template.field=fname:${somefield}some_string${someotherfield} > {code} > The actual name of the class is {{TemplateUpdateProcessorFactory}} and it is > possible to optionally drop the {{UpdateProcessorfactory}} part. The > {{Template.field}} specifies a field name as well as a template. The > {{Template.field}} parameter is multivalued , so , it is possible to add > multiple fields or a multivalued field with same name -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9657) Create a new TemplateUpdateRequestProcessorFactory
[ https://issues.apache.org/jira/browse/SOLR-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588868#comment-15588868 ] Alexandre Rafalovitch commented on SOLR-9657: - I absolutely think we need to have the Javadoc. I am biased of course, as that's what's used for generating http://www.solr-start.com/info/update-request-processors/ . But also, it is a way to keep the documentation with code, when the changes are made. And as to whether the documentation is required at all, I had to look at the patch to see what it actually does, the description of JIRA was not clear enough. Specifically *operate on request parameters" I read that perhaps something gets put back into parameter map. As an aside, once this is finished, we can probably resolve SOLR-9650 too. > Create a new TemplateUpdateRequestProcessorFactory > -- > > Key: SOLR-9657 > URL: https://issues.apache.org/jira/browse/SOLR-9657 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9657.patch > > > Unlike other URPs, this will operate on request parameters > example: > {code} > processor=Template&Template.field=fname:${somefield}some_string${someotherfield} > {code} > The actual name of the class is {{TemplateUpdateProcessorFactory}} and it is > possible to optionally drop the {{UpdateProcessorfactory}} part. The > {{Template.field}} specifies a field name as well as a template. The > {{Template.field}} parameter is multivalued , so , it is possible to add > multiple fields or a multivalued field with same name -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9657) Create a new TemplateUpdateRequestProcessorFactory
[ https://issues.apache.org/jira/browse/SOLR-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588626#comment-15588626 ] David Smiley commented on SOLR-9657: Fair point RE refguide. Nevertheless, IMO as a matter of universal good developer practices I think *every* top-level non-test class ought to have _at least one sentence said about it_, aimed at any other developer (whoever they may be) stumbling over it -- either via looking at the actual source, or via docs pop-up in their IDE. IMO it's a shame the Solr codebase has gotten to the point that so little has such a bare minimum. For this one I'll write it for you; feel free to edit: "Adds new fields to documents based on a template pattern specified via template.field request parameters (multi-valued)." [~arafalov] do you think this is at all useful? I know you work on adding docs to URPs 'n things. > Create a new TemplateUpdateRequestProcessorFactory > -- > > Key: SOLR-9657 > URL: https://issues.apache.org/jira/browse/SOLR-9657 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9657.patch > > > Unlike other URPs, this will operate on request parameters > example: > {code} > processor=Template&Template.field=fname:${somefield}some_string${someotherfield} > {code} > The actual name of the class is {{TemplateUpdateProcessorFactory}} and it is > possible to optionally drop the {{UpdateProcessorfactory}} part. The > {{Template.field}} specifies a field name as well as a template. The > {{Template.field}} parameter is multivalued , so , it is possible to add > multiple fields or a multivalued field with same name -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9657) Create a new TemplateUpdateRequestProcessorFactory
[ https://issues.apache.org/jira/browse/SOLR-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588598#comment-15588598 ] Noble Paul commented on SOLR-9657: -- Sorry about that [~dsmiley] , I should have responded to your comment and I missed it. I'm fine with adding javadocs. Just that it was not clear as to where you wanted it. Is it to help a user who would use this URP? How many users of Solr are java users and are likely to use javadocs. Most users rely on the the ref guide to learn how to use a component. Honestly, a one liner is not really useful. You really need a few examples at least to learn to use it. Is it to help the Solr developer? I agree with you. That being said . I'm not yet resolving this. There was a concern raised by Erik hatcher about the variable naming > Create a new TemplateUpdateRequestProcessorFactory > -- > > Key: SOLR-9657 > URL: https://issues.apache.org/jira/browse/SOLR-9657 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9657.patch > > > Unlike other URPs, this will operate on request parameters > example: > {code} > processor=Template&Template.field=fname:${somefield}some_string${someotherfield} > {code} > The actual name of the class is {{TemplateUpdateProcessorFactory}} and it is > possible to optionally drop the {{UpdateProcessorfactory}} part. The > {{Template.field}} specifies a field name as well as a template. The > {{Template.field}} parameter is multivalued , so , it is possible to add > multiple fields or a multivalued field with same name -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9657) Create a new TemplateUpdateRequestProcessorFactory
[ https://issues.apache.org/jira/browse/SOLR-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588547#comment-15588547 ] David Smiley commented on SOLR-9657: [~noble.paul] did you disagree with my feedback on adding at least a one-liner class javadoc? It feels rude to me to have simultaneously committed it without it and not responding. > Create a new TemplateUpdateRequestProcessorFactory > -- > > Key: SOLR-9657 > URL: https://issues.apache.org/jira/browse/SOLR-9657 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9657.patch > > > Unlike other URPs, this will operate on request parameters > example: > {code} > processor=Template&Template.field=fname:${somefield}some_string${someotherfield} > {code} > The actual name of the class is {{TemplateUpdateProcessorFactory}} and it is > possible to optionally drop the {{UpdateProcessorfactory}} part. The > {{Template.field}} specifies a field name as well as a template. The > {{Template.field}} parameter is multivalued , so , it is possible to add > multiple fields or a multivalued field with same name -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9657) Create a new TemplateUpdateRequestProcessorFactory
[ https://issues.apache.org/jira/browse/SOLR-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588486#comment-15588486 ] Noble Paul commented on SOLR-9657: -- bq. Is there DIH contrib dependency here? The code is moved from DIH to core so that the same code can be used in both places. So, the answer is No. > Create a new TemplateUpdateRequestProcessorFactory > -- > > Key: SOLR-9657 > URL: https://issues.apache.org/jira/browse/SOLR-9657 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9657.patch > > > Unlike other URPs, this will operate on request parameters > example: > {code} > processor=Template&Template.field=fname:${somefield}some_string${someotherfield} > {code} > The actual name of the class is {{TemplateUpdateProcessorFactory}} and it is > possible to optionally drop the {{UpdateProcessorfactory}} part. The > {{Template.field}} specifies a field name as well as a template. The > {{Template.field}} parameter is multivalued , so , it is possible to add > multiple fields or a multivalued field with same name -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9657) Create a new TemplateUpdateRequestProcessorFactory
[ https://issues.apache.org/jira/browse/SOLR-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588477#comment-15588477 ] ASF subversion and git services commented on SOLR-9657: --- Commit 2fc29c1cd5320322a434ca7f820b69d80536aa5a in lucene-solr's branch refs/heads/branch_6x from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2fc29c1 ] SOLR-9657: New TemplateUpdateProcessorFactory added > Create a new TemplateUpdateRequestProcessorFactory > -- > > Key: SOLR-9657 > URL: https://issues.apache.org/jira/browse/SOLR-9657 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9657.patch > > > Unlike other URPs, this will operate on request parameters > example: > {code} > processor=Template&Template.field=fname:${somefield}some_string${someotherfield} > {code} > The actual name of the class is {{TemplateUpdateProcessorFactory}} and it is > possible to optionally drop the {{UpdateProcessorfactory}} part. The > {{Template.field}} specifies a field name as well as a template. The > {{Template.field}} parameter is multivalued , so , it is possible to add > multiple fields or a multivalued field with same name -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9657) Create a new TemplateUpdateRequestProcessorFactory
[ https://issues.apache.org/jira/browse/SOLR-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588479#comment-15588479 ] ASF subversion and git services commented on SOLR-9657: --- Commit 180efba9b59190e6b44b1a2428e40617c52bb74c in lucene-solr's branch refs/heads/branch_6x from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=180efba ] SOLR-9657: New TemplateUpdateProcessorFactory added > Create a new TemplateUpdateRequestProcessorFactory > -- > > Key: SOLR-9657 > URL: https://issues.apache.org/jira/browse/SOLR-9657 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9657.patch > > > Unlike other URPs, this will operate on request parameters > example: > {code} > processor=Template&Template.field=fname:${somefield}some_string${someotherfield} > {code} > The actual name of the class is {{TemplateUpdateProcessorFactory}} and it is > possible to optionally drop the {{UpdateProcessorfactory}} part. The > {{Template.field}} specifies a field name as well as a template. The > {{Template.field}} parameter is multivalued , so , it is possible to add > multiple fields or a multivalued field with same name -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9657) Create a new TemplateUpdateRequestProcessorFactory
[ https://issues.apache.org/jira/browse/SOLR-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15587738#comment-15587738 ] ASF subversion and git services commented on SOLR-9657: --- Commit c2e031add3d5db2c4e89a5a92afd7bb8cc1f481f in lucene-solr's branch refs/heads/master from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c2e031a ] SOLR-9657: New TemplateUpdateProcessorFactory added > Create a new TemplateUpdateRequestProcessorFactory > -- > > Key: SOLR-9657 > URL: https://issues.apache.org/jira/browse/SOLR-9657 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-9657.patch > > > Unlike other URPs, this will operate on request parameters > example: > {code} > processor=Template&Template.field=fname:${somefield}some_string${someotherfield} > {code} > The actual name of the class is {{TemplateUpdateProcessorFactory}} and it is > possible to optionally drop the {{UpdateProcessorfactory}} part. The > {{Template.field}} specifies a field name as well as a template. The > {{Template.field}} parameter is multivalued , so , it is possible to add > multiple fields or a multivalued field with same name -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org