[jira] [Commented] (SOLR-9707) DeleteByQuery forward requests to down replicas and set it in LiR
[ https://issues.apache.org/jira/browse/SOLR-9707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746189#comment-15746189 ] ASF subversion and git services commented on SOLR-9707: --- Commit fecbbe081fd4a777f01517fdd8631e69797def38 in lucene-solr's branch refs/heads/feature/metrics from [~varunthacker] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fecbbe0 ] SOLR-9707: Don't forward DeleteByQuery requests to down replicas > DeleteByQuery forward requests to down replicas and set it in LiR > - > > Key: SOLR-9707 > URL: https://issues.apache.org/jira/browse/SOLR-9707 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: Jessica Cheng Mallet >Assignee: Varun Thacker > Labels: solrcloud > Fix For: 6.4 > > Attachments: SOLR-9707.diff, SOLR-9707.patch > > > DeleteByQuery, unlike other requests, does not filter out the down replicas. > Thus, the update is still forwarded to the down replica and fails, and the > leader then sets the replica in LiR. In a cluster where there are lots of > deleteByQuery requests, this can flood the /overseer/queue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9707) DeleteByQuery forward requests to down replicas and set it in LiR
[ https://issues.apache.org/jira/browse/SOLR-9707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743775#comment-15743775 ] Varun Thacker commented on SOLR-9707: - Thanks Jessica for catching this! > DeleteByQuery forward requests to down replicas and set it in LiR > - > > Key: SOLR-9707 > URL: https://issues.apache.org/jira/browse/SOLR-9707 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: Jessica Cheng Mallet >Assignee: Varun Thacker > Labels: solrcloud > Fix For: 6.4 > > Attachments: SOLR-9707.diff, SOLR-9707.patch > > > DeleteByQuery, unlike other requests, does not filter out the down replicas. > Thus, the update is still forwarded to the down replica and fails, and the > leader then sets the replica in LiR. In a cluster where there are lots of > deleteByQuery requests, this can flood the /overseer/queue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9707) DeleteByQuery forward requests to down replicas and set it in LiR
[ https://issues.apache.org/jira/browse/SOLR-9707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743773#comment-15743773 ] ASF subversion and git services commented on SOLR-9707: --- Commit a243f20973aad98f1961f48b197c90d2877704d4 in lucene-solr's branch refs/heads/branch_6x from [~varunthacker] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a243f20 ] SOLR-9707: Don't forward DeleteByQuery requests to down replicas > DeleteByQuery forward requests to down replicas and set it in LiR > - > > Key: SOLR-9707 > URL: https://issues.apache.org/jira/browse/SOLR-9707 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: Jessica Cheng Mallet >Assignee: Varun Thacker > Labels: solrcloud > Attachments: SOLR-9707.diff, SOLR-9707.patch > > > DeleteByQuery, unlike other requests, does not filter out the down replicas. > Thus, the update is still forwarded to the down replica and fails, and the > leader then sets the replica in LiR. In a cluster where there are lots of > deleteByQuery requests, this can flood the /overseer/queue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9707) DeleteByQuery forward requests to down replicas and set it in LiR
[ https://issues.apache.org/jira/browse/SOLR-9707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743771#comment-15743771 ] ASF subversion and git services commented on SOLR-9707: --- Commit fecbbe081fd4a777f01517fdd8631e69797def38 in lucene-solr's branch refs/heads/master from [~varunthacker] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fecbbe0 ] SOLR-9707: Don't forward DeleteByQuery requests to down replicas > DeleteByQuery forward requests to down replicas and set it in LiR > - > > Key: SOLR-9707 > URL: https://issues.apache.org/jira/browse/SOLR-9707 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: Jessica Cheng Mallet >Assignee: Varun Thacker > Labels: solrcloud > Attachments: SOLR-9707.diff, SOLR-9707.patch > > > DeleteByQuery, unlike other requests, does not filter out the down replicas. > Thus, the update is still forwarded to the down replica and fails, and the > leader then sets the replica in LiR. In a cluster where there are lots of > deleteByQuery requests, this can flood the /overseer/queue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9707) DeleteByQuery forward requests to down replicas and set it in LiR
[ https://issues.apache.org/jira/browse/SOLR-9707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743398#comment-15743398 ] Varun Thacker commented on SOLR-9707: - I'm going to run a couple of more rounds of tests and then commit the patch without the test case. > DeleteByQuery forward requests to down replicas and set it in LiR > - > > Key: SOLR-9707 > URL: https://issues.apache.org/jira/browse/SOLR-9707 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: Jessica Cheng Mallet >Assignee: Varun Thacker > Labels: solrcloud > Attachments: SOLR-9707.diff, SOLR-9707.patch > > > DeleteByQuery, unlike other requests, does not filter out the down replicas. > Thus, the update is still forwarded to the down replica and fails, and the > leader then sets the replica in LiR. In a cluster where there are lots of > deleteByQuery requests, this can flood the /overseer/queue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9707) DeleteByQuery forward requests to down replicas and set it in LiR
[ https://issues.apache.org/jira/browse/SOLR-9707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706307#comment-15706307 ] Varun Thacker commented on SOLR-9707: - Its still a good idea to filter out down replica before sending the update. There might be edge cases / bugs which could lead to a replica being in down state even on a live node. The tests pass with Jessica's original patch. [~markrmil...@gmail.com] or [~ysee...@gmail.com] any suggestions on how we can add a test case for this or is it just safe to commit the patch without an explicit test case for it? > DeleteByQuery forward requests to down replicas and set it in LiR > - > > Key: SOLR-9707 > URL: https://issues.apache.org/jira/browse/SOLR-9707 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: Jessica Cheng Mallet >Assignee: Varun Thacker > Labels: solrcloud > Attachments: SOLR-9707.diff, SOLR-9707.patch > > > DeleteByQuery, unlike other requests, does not filter out the down replicas. > Thus, the update is still forwarded to the down replica and fails, and the > leader then sets the replica in LiR. In a cluster where there are lots of > deleteByQuery requests, this can flood the /overseer/queue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9707) DeleteByQuery forward requests to down replicas and set it in LiR
[ https://issues.apache.org/jira/browse/SOLR-9707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667995#comment-15667995 ] Yonik Seeley commented on SOLR-9707: I don't think so... seems like it should follow the same procedure as any other update. > DeleteByQuery forward requests to down replicas and set it in LiR > - > > Key: SOLR-9707 > URL: https://issues.apache.org/jira/browse/SOLR-9707 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: Jessica Cheng Mallet >Assignee: Varun Thacker > Labels: solrcloud > Attachments: SOLR-9707.diff > > > DeleteByQuery, unlike other requests, does not filter out the down replicas. > Thus, the update is still forwarded to the down replica and fails, and the > leader then sets the replica in LiR. In a cluster where there are lots of > deleteByQuery requests, this can flood the /overseer/queue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9707) DeleteByQuery forward requests to down replicas and set it in LiR
[ https://issues.apache.org/jira/browse/SOLR-9707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667951#comment-15667951 ] Mark Miller commented on SOLR-9707: --- [~ysee...@gmail.com], any idea if that was on purpose to avoid a state race or something? > DeleteByQuery forward requests to down replicas and set it in LiR > - > > Key: SOLR-9707 > URL: https://issues.apache.org/jira/browse/SOLR-9707 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: Jessica Cheng Mallet >Assignee: Varun Thacker > Labels: solrcloud > Attachments: SOLR-9707.diff > > > DeleteByQuery, unlike other requests, does not filter out the down replicas. > Thus, the update is still forwarded to the down replica and fails, and the > leader then sets the replica in LiR. In a cluster where there are lots of > deleteByQuery requests, this can flood the /overseer/queue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
