[jira] [Commented] (SOLR-9886) Add ability to turn off/on caches
[ https://issues.apache.org/jira/browse/SOLR-9886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15814621#comment-15814621 ] ASF subversion and git services commented on SOLR-9886: --- Commit 39502a09eecbb52bf26bd52a4104ba59bca3900b in lucene-solr's branch refs/heads/branch_6x from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=39502a0 ] * SOLR-9886: Add a 'enable' flag to caches to enable/disable them > Add ability to turn off/on caches > -- > > Key: SOLR-9886 > URL: https://issues.apache.org/jira/browse/SOLR-9886 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Pushkar Raste >Assignee: Noble Paul >Priority: Minor > Attachments: EnableDisableCacheAttribute.patch, SOLR-9886.patch, > SOLR-9886.patch > > > There is no elegant way to turn off caches (filterCache, queryResultCache > etc) from the solrconfig. When I tried setting size and initialSize to zero, > it resulted in caches of size 2. Here is the code that overrides setting zero > sized cache. > https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/search/FastLRUCache.java#L61-L73 > Only way to disable cache right now is by removing cache configs from the > solrConfig, but we can simply provide an attribute to disable cache, so that > we can override it using a system property. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9886) Add ability to turn off/on caches
[ https://issues.apache.org/jira/browse/SOLR-9886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15814617#comment-15814617 ] Noble Paul commented on SOLR-9886: -- It should be OK > Add ability to turn off/on caches > -- > > Key: SOLR-9886 > URL: https://issues.apache.org/jira/browse/SOLR-9886 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Pushkar Raste >Assignee: Noble Paul >Priority: Minor > Attachments: EnableDisableCacheAttribute.patch, SOLR-9886.patch, > SOLR-9886.patch > > > There is no elegant way to turn off caches (filterCache, queryResultCache > etc) from the solrconfig. When I tried setting size and initialSize to zero, > it resulted in caches of size 2. Here is the code that overrides setting zero > sized cache. > https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/search/FastLRUCache.java#L61-L73 > Only way to disable cache right now is by removing cache configs from the > solrConfig, but we can simply provide an attribute to disable cache, so that > we can override it using a system property. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9886) Add ability to turn off/on caches
[ https://issues.apache.org/jira/browse/SOLR-9886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15814616#comment-15814616 ] ASF subversion and git services commented on SOLR-9886: --- Commit 2048b82443db548f76d584f9a95b5628c407edde in lucene-solr's branch refs/heads/master from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2048b82 ] * SOLR-9886: Add a 'enable' flag to caches to enable/disable them > Add ability to turn off/on caches > -- > > Key: SOLR-9886 > URL: https://issues.apache.org/jira/browse/SOLR-9886 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Pushkar Raste >Assignee: Noble Paul >Priority: Minor > Attachments: EnableDisableCacheAttribute.patch, SOLR-9886.patch, > SOLR-9886.patch > > > There is no elegant way to turn off caches (filterCache, queryResultCache > etc) from the solrconfig. When I tried setting size and initialSize to zero, > it resulted in caches of size 2. Here is the code that overrides setting zero > sized cache. > https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/search/FastLRUCache.java#L61-L73 > Only way to disable cache right now is by removing cache configs from the > solrConfig, but we can simply provide an attribute to disable cache, so that > we can override it using a system property. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9886) Add ability to turn off/on caches
[ https://issues.apache.org/jira/browse/SOLR-9886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15786323#comment-15786323 ] Pushkar Raste commented on SOLR-9886: - [~noble.paul] My only concern adding legend to {{EditableSolrConfigAttributes.json}} is, if we ever parse this file using a JSON parser, we will have to move legend to some other place. > Add ability to turn off/on caches > -- > > Key: SOLR-9886 > URL: https://issues.apache.org/jira/browse/SOLR-9886 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Pushkar Raste >Assignee: Noble Paul >Priority: Minor > Attachments: EnableDisableCacheAttribute.patch, SOLR-9886.patch, > SOLR-9886.patch > > > There is no elegant way to turn off caches (filterCache, queryResultCache > etc) from the solrconfig. When I tried setting size and initialSize to zero, > it resulted in caches of size 2. Here is the code that overrides setting zero > sized cache. > https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/search/FastLRUCache.java#L61-L73 > Only way to disable cache right now is by removing cache configs from the > solrConfig, but we can simply provide an attribute to disable cache, so that > we can override it using a system property. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9886) Add ability to turn off/on caches
[ https://issues.apache.org/jira/browse/SOLR-9886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15786306#comment-15786306 ] ASF GitHub Bot commented on SOLR-9886: -- GitHub user praste opened a pull request: https://github.com/apache/lucene-solr/pull/132 SOLR-9886 You can merge this pull request into a Git repository by running: $ git pull https://github.com/praste/lucene-solr CacheConfig Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/132.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #132 commit c5363f6dabb0a36cc41f174023eafdd443ed106f Author: Pushkar Raste Date: 2016-12-23T16:41:28Z Allow enable/disable cache commit b8daed32047475d0eee330374d8d4ed5f2820897 Author: Pushkar Raste Date: 2016-12-29T18:20:56Z Merge branch 'master' of https://github.com/apache/lucene-solr into CacheConfig commit e394b405b9e6fb0024c4b3a8747ec500dd5ba3d4 Author: Pushkar Raste Date: 2016-12-29T22:46:42Z Test case, bug fix, updated EdittableCofing.json commit 59484c080fc3e3e97bb5a443588c409e381e1340 Author: Pushkar Raste Date: 2016-12-29T22:47:37Z Adding missing files > Add ability to turn off/on caches > -- > > Key: SOLR-9886 > URL: https://issues.apache.org/jira/browse/SOLR-9886 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Pushkar Raste >Assignee: Noble Paul >Priority: Minor > Attachments: EnableDisableCacheAttribute.patch, SOLR-9886.patch > > > There is no elegant way to turn off caches (filterCache, queryResultCache > etc) from the solrconfig. When I tried setting size and initialSize to zero, > it resulted in caches of size 2. Here is the code that overrides setting zero > sized cache. > https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/search/FastLRUCache.java#L61-L73 > Only way to disable cache right now is by removing cache configs from the > solrConfig, but we can simply provide an attribute to disable cache, so that > we can override it using a system property. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9886) Add ability to turn off/on caches
[ https://issues.apache.org/jira/browse/SOLR-9886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15768331#comment-15768331 ] Pushkar Raste commented on SOLR-9886: - Check attached patch. I think we may to make changes to {{EditableSolrConfigAttributes.json}} as well. I don't understand mapping between the attribute names and associated numbers. > Add ability to turn off/on caches > -- > > Key: SOLR-9886 > URL: https://issues.apache.org/jira/browse/SOLR-9886 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Pushkar Raste >Priority: Minor > Attachments: EnableDisableCacheAttribute.patch > > > There is no elegant way to turn off caches (filterCache, queryResultCache > etc) from the solrconfig. When I tried setting size and initialSize to zero, > it resulted in caches of size 2. Here is the code that overrides setting zero > sized cache. > https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/search/FastLRUCache.java#L61-L73 > Only way to disable cache right now is by removing cache configs from the > solrConfig, but we can simply provide an attribute to disable cache, so that > we can override it using a system property. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org