[jira] [Commented] (SOLR-9910) Allow setting of additional jetty options in bin/solr and bin/solr.cmd
[
https://issues.apache.org/jira/browse/SOLR-9910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068129#comment-16068129
]
Mano Kovacs commented on SOLR-9910:
---
bq. So if you cannot count on it fully except at a moment in time, it's a
perhaps pretty flakey feature to build anything on.
Should we revert the patch?
> Allow setting of additional jetty options in bin/solr and bin/solr.cmd
> --
>
> Key: SOLR-9910
> URL: https://issues.apache.org/jira/browse/SOLR-9910
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Mano Kovacs
>Assignee: Mark Miller
> Fix For: master (7.0), 6.7
>
> Attachments: SOLR-9910.patch, SOLR-9910.patch
>
>
> Command line tools allow the option {{-a}} to add JVM options to start
> command. Proposing to add {{-j}} option to add additional config for jetty
> (the part after {{start.jar}}).
> Motivation: jetty can be configured with start.ini in server directory.
> Running multiple Solr instances, however, requires the configuration per
> instance that cannot share the start.ini with other instances.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9910) Allow setting of additional jetty options in bin/solr and bin/solr.cmd
[
https://issues.apache.org/jira/browse/SOLR-9910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063298#comment-16063298
]
Mark Miller commented on SOLR-9910:
---
bq. However, some custom configuration or debug feature is still only reachable
through jetty config.
Right, of course, but we don't really want to expose Jetty specific things
through Solr. So if there is something important we want to support, it's best
to try and do it in a more abstract way. In this case, I'm wondering if that is
something we actually want to support first class or if we should just say you
need a unique Solr folder for every instance.
If it's not something we care so much about supporting, it's fine to allow
unsupported things through some special unsupported config option - but the
tradeoff is anyone using that stuff cannot count on it in the future at all.
That's not always a very viable path depending on your use case. Even in a
point release, devs will be allowed to break this kind of support. So if you
cannot count on it fully except at a moment in time, it's a perhaps pretty
flakey feature to build anything on.
> Allow setting of additional jetty options in bin/solr and bin/solr.cmd
> --
>
> Key: SOLR-9910
> URL: https://issues.apache.org/jira/browse/SOLR-9910
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Mano Kovacs
>Assignee: Mark Miller
> Fix For: master (7.0), 6.7
>
> Attachments: SOLR-9910.patch, SOLR-9910.patch
>
>
> Command line tools allow the option {{-a}} to add JVM options to start
> command. Proposing to add {{-j}} option to add additional config for jetty
> (the part after {{start.jar}}).
> Motivation: jetty can be configured with start.ini in server directory.
> Running multiple Solr instances, however, requires the configuration per
> instance that cannot share the start.ini with other instances.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9910) Allow setting of additional jetty options in bin/solr and bin/solr.cmd
[
https://issues.apache.org/jira/browse/SOLR-9910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053706#comment-16053706
]
Mano Kovacs commented on SOLR-9910:
---
[~shalinmangar], thank you for the feedback.
bq. Mano Kovacs, the main motivation is to be able to run multiple Solr
instances from a single Solr server directory?
One of the original motivation was that. However, some custom configuration or
debug feature is still only reachable through jetty config.
bq. As you say, we could also just leave it as it is and document it as
internal and non back compat as well. That seems like the best option to me.
I'll prepare a doc change patch.
> Allow setting of additional jetty options in bin/solr and bin/solr.cmd
> --
>
> Key: SOLR-9910
> URL: https://issues.apache.org/jira/browse/SOLR-9910
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Mano Kovacs
>Assignee: Mark Miller
> Fix For: master (7.0), 6.7
>
> Attachments: SOLR-9910.patch, SOLR-9910.patch
>
>
> Command line tools allow the option {{-a}} to add JVM options to start
> command. Proposing to add {{-j}} option to add additional config for jetty
> (the part after {{start.jar}}).
> Motivation: jetty can be configured with start.ini in server directory.
> Running multiple Solr instances, however, requires the configuration per
> instance that cannot share the start.ini with other instances.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9910) Allow setting of additional jetty options in bin/solr and bin/solr.cmd
[
https://issues.apache.org/jira/browse/SOLR-9910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16052032#comment-16052032
]
Mark Miller commented on SOLR-9910:
---
Because we had a vote and now publish that Jetty is an implementation detail, I
don't think leakage will be able to tie anyone down. I'm sure other leakage
already exists to some extent, it's tough to generalise every little config
outside of Jetty for every feature.
It's a good point though. I had not considered that Jetty is leaking out of the
Solr startup script with this.
One option is to call it something like 'additional internal startup params' or
something indicative of that, and then document it as non backwards compatible
internal parameters. I'd worry that if we changed out Jetty, after an upgrade
some users may keep sending bad params to Netty or something.
As you say, we could also just leave it as it is and document it as internal
and non back compat as well. That seems like the best option to me.
[~manokovacs], the main motivation is to be able to run multiple Solr instances
from a single Solr server directory?
> Allow setting of additional jetty options in bin/solr and bin/solr.cmd
> --
>
> Key: SOLR-9910
> URL: https://issues.apache.org/jira/browse/SOLR-9910
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Mano Kovacs
>Assignee: Mark Miller
> Fix For: master (7.0), 6.7
>
> Attachments: SOLR-9910.patch, SOLR-9910.patch
>
>
> Command line tools allow the option {{-a}} to add JVM options to start
> command. Proposing to add {{-j}} option to add additional config for jetty
> (the part after {{start.jar}}).
> Motivation: jetty can be configured with start.ini in server directory.
> Running multiple Solr instances, however, requires the configuration per
> instance that cannot share the start.ini with other instances.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9910) Allow setting of additional jetty options in bin/solr and bin/solr.cmd
[
https://issues.apache.org/jira/browse/SOLR-9910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048734#comment-16048734
]
Shalin Shekhar Mangar commented on SOLR-9910:
-
Can we add another line to the usage docs of the {{-j}} parameter to say that
Solr does not support customization of jetty configs and such may break even in
minor or bug fix releases? I'd hate for us to be tied into back compat concerns
because of such hacks.
> Allow setting of additional jetty options in bin/solr and bin/solr.cmd
> --
>
> Key: SOLR-9910
> URL: https://issues.apache.org/jira/browse/SOLR-9910
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Mano Kovacs
>Assignee: Mark Miller
> Fix For: master (7.0), 6.7
>
> Attachments: SOLR-9910.patch, SOLR-9910.patch
>
>
> Command line tools allow the option {{-a}} to add JVM options to start
> command. Proposing to add {{-j}} option to add additional config for jetty
> (the part after {{start.jar}}).
> Motivation: jetty can be configured with start.ini in server directory.
> Running multiple Solr instances, however, requires the configuration per
> instance that cannot share the start.ini with other instances.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9910) Allow setting of additional jetty options in bin/solr and bin/solr.cmd
[
https://issues.apache.org/jira/browse/SOLR-9910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048597#comment-16048597
]
ASF subversion and git services commented on SOLR-9910:
---
Commit 9a0d9e83f69e9e10e18621f7bebe08db90b2f3d4 in lucene-solr's branch
refs/heads/jira/SOLR-10834 from [~mark.mil...@oblivion.ch]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9a0d9e8 ]
SOLR-9910: Add solr/solr.cmd parameter to append jetty parameters to the start
script.
> Allow setting of additional jetty options in bin/solr and bin/solr.cmd
> --
>
> Key: SOLR-9910
> URL: https://issues.apache.org/jira/browse/SOLR-9910
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Mano Kovacs
>Assignee: Mark Miller
> Fix For: master (7.0), 6.7
>
> Attachments: SOLR-9910.patch, SOLR-9910.patch
>
>
> Command line tools allow the option {{-a}} to add JVM options to start
> command. Proposing to add {{-j}} option to add additional config for jetty
> (the part after {{start.jar}}).
> Motivation: jetty can be configured with start.ini in server directory.
> Running multiple Solr instances, however, requires the configuration per
> instance that cannot share the start.ini with other instances.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9910) Allow setting of additional jetty options in bin/solr and bin/solr.cmd
[
https://issues.apache.org/jira/browse/SOLR-9910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048328#comment-16048328
]
ASF subversion and git services commented on SOLR-9910:
---
Commit 8730f2f375d95851ad957bc88c45936a65428dc9 in lucene-solr's branch
refs/heads/branch_6x from [~mark.mil...@oblivion.ch]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8730f2f ]
SOLR-9910: Add solr/solr.cmd parameter to append jetty parameters to the start
script.
> Allow setting of additional jetty options in bin/solr and bin/solr.cmd
> --
>
> Key: SOLR-9910
> URL: https://issues.apache.org/jira/browse/SOLR-9910
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Mano Kovacs
>Assignee: Mark Miller
> Fix For: master (7.0), 6.7
>
> Attachments: SOLR-9910.patch, SOLR-9910.patch
>
>
> Command line tools allow the option {{-a}} to add JVM options to start
> command. Proposing to add {{-j}} option to add additional config for jetty
> (the part after {{start.jar}}).
> Motivation: jetty can be configured with start.ini in server directory.
> Running multiple Solr instances, however, requires the configuration per
> instance that cannot share the start.ini with other instances.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9910) Allow setting of additional jetty options in bin/solr and bin/solr.cmd
[
https://issues.apache.org/jira/browse/SOLR-9910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048327#comment-16048327
]
ASF subversion and git services commented on SOLR-9910:
---
Commit 9a0d9e83f69e9e10e18621f7bebe08db90b2f3d4 in lucene-solr's branch
refs/heads/master from [~mark.mil...@oblivion.ch]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9a0d9e8 ]
SOLR-9910: Add solr/solr.cmd parameter to append jetty parameters to the start
script.
> Allow setting of additional jetty options in bin/solr and bin/solr.cmd
> --
>
> Key: SOLR-9910
> URL: https://issues.apache.org/jira/browse/SOLR-9910
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Mano Kovacs
>Assignee: Mark Miller
> Attachments: SOLR-9910.patch, SOLR-9910.patch
>
>
> Command line tools allow the option {{-a}} to add JVM options to start
> command. Proposing to add {{-j}} option to add additional config for jetty
> (the part after {{start.jar}}).
> Motivation: jetty can be configured with start.ini in server directory.
> Running multiple Solr instances, however, requires the configuration per
> instance that cannot share the start.ini with other instances.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9910) Allow setting of additional jetty options in bin/solr and bin/solr.cmd
[
https://issues.apache.org/jira/browse/SOLR-9910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041164#comment-16041164
]
Mark Miller commented on SOLR-9910:
---
Sorry, thought I had gotten to this but must have been a different one. I'll
get this in this week.
> Allow setting of additional jetty options in bin/solr and bin/solr.cmd
> --
>
> Key: SOLR-9910
> URL: https://issues.apache.org/jira/browse/SOLR-9910
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Mano Kovacs
>Assignee: Mark Miller
> Attachments: SOLR-9910.patch, SOLR-9910.patch
>
>
> Command line tools allow the option {{-a}} to add JVM options to start
> command. Proposing to add {{-j}} option to add additional config for jetty
> (the part after {{start.jar}}).
> Motivation: jetty can be configured with start.ini in server directory.
> Running multiple Solr instances, however, requires the configuration per
> instance that cannot share the start.ini with other instances.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9910) Allow setting of additional jetty options in bin/solr and bin/solr.cmd
[
https://issues.apache.org/jira/browse/SOLR-9910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008220#comment-16008220
]
Mano Kovacs commented on SOLR-9910:
---
[~markrmil...@gmail.com], is there anything I can do related to this jira?
> Allow setting of additional jetty options in bin/solr and bin/solr.cmd
> --
>
> Key: SOLR-9910
> URL: https://issues.apache.org/jira/browse/SOLR-9910
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Mano Kovacs
> Attachments: SOLR-9910.patch, SOLR-9910.patch
>
>
> Command line tools allow the option {{-a}} to add JVM options to start
> command. Proposing to add {{-j}} option to add additional config for jetty
> (the part after {{start.jar}}).
> Motivation: jetty can be configured with start.ini in server directory.
> Running multiple Solr instances, however, requires the configuration per
> instance that cannot share the start.ini with other instances.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9910) Allow setting of additional jetty options in bin/solr and bin/solr.cmd
[
https://issues.apache.org/jira/browse/SOLR-9910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968641#comment-15968641
]
Mark Miller commented on SOLR-9910:
---
Hey [~manokovacs], if you can update this patch to trunk I'll pop it in for you.
> Allow setting of additional jetty options in bin/solr and bin/solr.cmd
> --
>
> Key: SOLR-9910
> URL: https://issues.apache.org/jira/browse/SOLR-9910
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Mano Kovacs
> Attachments: SOLR-9910.patch
>
>
> Command line tools allow the option {{-a}} to add JVM options to start
> command. Proposing to add {{-j}} option to add additional config for jetty
> (the part after {{start.jar}}).
> Motivation: jetty can be configured with start.ini in server directory.
> Running multiple Solr instances, however, requires the configuration per
> instance that cannot share the start.ini with other instances.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
