David Smiley created LUCENE-6182: ------------------------------------ Summary: Spatial VisitorTemplate.visitScanned needn't be abstract Key: LUCENE-6182 URL: https://issues.apache.org/jira/browse/LUCENE-6182 Project: Lucene - Core Issue Type: Improvement Components: modules/spatial Reporter: David Smiley Assignee: David Smiley Priority: Minor Fix For: 5.x
visitScanned can be implemented, allowing subclasses to specialize if desired. {code:java} protected void visitScanned(Cell cell) throws IOException { if (queryShape.relate(cell.getShape()).intersects()) { if (cell.isLeaf()) { visitLeaf(cell); } else { visit(cell); } } } {code} Then I can remove Intersect's impl, and remove the one prefix-tree faceting. Additionally, I noticed collectDocs(FixBitSet) can be improved to take BitSet and call bitSet.or(docsEnum) -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org