[jira] [Issue Comment Deleted] (SOLR-12798) Structural changes in SolrJ since version 7.0.0 have effectively disabled multipart post
[
https://issues.apache.org/jira/browse/SOLR-12798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul updated SOLR-12798:
--
Comment: was deleted
(was: | (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
9s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 2m 15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 2m 15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 2m 15s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 6m
55s{color} | {color:green} solrj in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 16m 33s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12798 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12941838/SOLR-12798.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 964cc88 |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | 1.8.0_172 |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/194/testReport/ |
| modules | C: solr/solrj U: solr/solrj |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/194/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
)
> Structural changes in SolrJ since version 7.0.0 have effectively disabled
> multipart post
>
>
> Key: SOLR-12798
> URL: https://issues.apache.org/jira/browse/SOLR-12798
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrJ
>Affects Versions: 7.4
>Reporter: Karl Wright
>Assignee: Karl Wright
>Priority: Major
> Attachments: HOT Balloon Trip_Ultra HD.jpg,
> SOLR-12798-approach.patch, SOLR-12798-reproducer.patch,
> SOLR-12798-workaround.patch, SOLR-12798.patch, SOLR-12798.patch, no params in
> url.png, solr-update-request.txt
>
>
> Project ManifoldCF uses SolrJ to post documents to Solr. When upgrading from
> SolrJ 7.0.x to SolrJ 7.4, we encountered significant structural changes to
> SolrJ's HttpSolrClient class that seemingly disable any use of multipart
> post. This is critical because ManifoldCF's documents often contain metadata
> in excess of 4K that therefore cannot be stuffed into a URL.
> The changes in question seem to have been performed by Paul Noble on
> 10/31/2017, with the introduction of the RequestWriter mechanism. Basically,
> if a request has a RequestWriter, it is used exclusively to write the
> request, and that overrides the stream mechanism completely. I haven't
> chased it back to a specific ticket.
> ManifoldCF's usage of SolrJ involves the creation of
> ContentStreamUpdateRequests for all posts meant for Solr Cell, and the
> creation of UpdateRequests for posts not meant for Solr Cell (as well as for
> delete and commit requests). For our release cycle that is taking place
> right now, we're shipping a modified version of HttpSolrClient that ignores
> the RequestWriter when dealing with ContentStreamUpdateRequests. We
> apparently cannot use multipart for all requests because on the Solr side we
> get "pfountz Should not get here!" errors on the Solr side when we do, which
> generate HTTP error code 500 responses. That should
[jira] [Issue Comment Deleted] (SOLR-12798) Structural changes in SolrJ since version 7.0.0 have effectively disabled multipart post
[
https://issues.apache.org/jira/browse/SOLR-12798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul updated SOLR-12798:
--
Comment: was deleted
(was: | (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
39s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 20m 41s{color}
| {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 4m 57s{color}
| {color:red} solrj in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 30m 59s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.schema.TestManagedSchemaAPI |
| | solr.handler.TestRestoreCore |
| | solr.cloud.LeaderFailureAfterFreshStartTest |
| | solr.TestHighlightDedupGrouping |
| | solr.cloud.TestCloudRecovery |
| | solr.cloud.autoscaling.IndexSizeTriggerTest |
| | solr.cloud.TestPullReplicaErrorHandling |
| | solr.cloud.TriLevelCompositeIdRoutingTest |
| | solr.cloud.api.collections.CustomCollectionTest |
| | solr.handler.component.DistributedFacetPivotSmallTest |
| | solr.schema.TestCloudSchemaless |
| | solr.cloud.autoscaling.MetricTriggerIntegrationTest |
| | solr.core.TestDynamicURP |
| | solr.search.MergeStrategyTest |
| | solr.handler.component.DistributedFacetPivotWhiteBoxTest |
| | solr.cloud.ZkFailoverTest |
| | solr.util.TestSolrCLIRunExample |
| | solr.cloud.TestCloudPseudoReturnFields |
| | solr.cloud.cdcr.CdcrWithNodesRestartsTest |
| | solr.handler.component.DistributedDebugComponentTest |
| | solr.cloud.LIRRollingUpdatesTest |
| | solr.response.transform.TestSubQueryTransformerDistrib |
| | solr.schema.TestBinaryField |
| | solr.handler.component.DistributedFacetPivotLargeTest |
| | solr.cloud.TestDownShardTolerantSearch |
| | solr.cloud.MoveReplicaHDFSFailoverTest |
| | solr.handler.admin.CoreAdminHandlerTest |
| | solr.cloud.api.collections.TestCollectionAPI |
| | solr.TestDistributedMissingSort |
| | solr.cloud.BasicDistributedZk2Test |
| | solr.cloud.TestShortCircuitedRequests |
| | solr.cloud.SolrCloudExampleTest |
| | solr.core.OpenCloseCoreStressTest |
| | solr.core.TestDynamicLoading |
| | solr.cloud.LeaderTragicEventTest |
| | solr.cloud.MigrateRouteKeyTest |
| | solr.handler.component.DistributedExpandComponentTest |
| | solr.TestTolerantSearch |
| | solr.handler.component.TestDistributedStatsComponentCardinality |
| | solr.security.BasicAuthIntegrationTest |
| | solr.handler.TestReplicationHandlerBackup |
| | solr.cloud.TestCloudSearcherWarming |
| | solr.cloud.TestCloudPivotFacet |
| | solr.cloud.RecoveryZkTest |
| | solr.security.hadoop.TestSolrCloudWithHadoopAuthPlugin |
| | solr.handler.component.DistributedFacetPivotLongTailTest |
| | solr.cloud.MissingSegmentRecoveryTest |
| | solr.search.join.TestCloudNestedDocsSort |
| | solr.DistributedIntervalFacetingTest |
| | solr.cloud.TestCryptoKeys |
| | solr.core.BlobRepositoryCloudTest |
| | solr.cloud.DistribDocExpirationUpdateProcessorTest |
| | solr.cloud.TestTolerantUpdateProcessorCloud |
| | solr.search.stats.TestDefaultStatsCache |
| | solr.cloud.cdcr.CdcrVersionReplicationTest |
| | solr.update.SolrIndexSplitterTest |
| | solr.cloud.TestPullReplica |
| | solr.request.TestRemoteStreaming |
| | solr.cloud.TestLeaderElectionWithEmptyReplica |
| | solr.cloud.autoscaling.SystemLogListenerTest |
| | solr.metrics.reporters.solr.SolrCloudReportersTest |
| |
[jira] [Issue Comment Deleted] (SOLR-12798) Structural changes in SolrJ since version 7.0.0 have effectively disabled multipart post
[ https://issues.apache.org/jira/browse/SOLR-12798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Wright updated SOLR-12798: --- Comment: was deleted (was: Thinking about this: I think the fix might well be to add a decent implementation of getContentStreams() to BinaryRequestWriter, and then prioritizing the use of content streams in HttpSolrClient when useMultipart is true. That would fix the basic problem, if it doesn't introduce other ones. For the ManifoldCF project's immediate release concerns, I'd have to create a ModifiedUpdateRequest class and a ModifiedBinaryRequestWriter class, if they're not locked down anyway, and use ModifiedUpdateRequest instead of UpdateRequest whenever I need to add SolrInputDocuments. I'll check out whether this would work. That makes some six SolrJ classes that ManifoldCF needs to override, however, just to get multipart post to work properly. I think it's time to make multipart post a first-class citizen for SolrJ, no? ) > Structural changes in SolrJ since version 7.0.0 have effectively disabled > multipart post > > > Key: SOLR-12798 > URL: https://issues.apache.org/jira/browse/SOLR-12798 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrJ >Affects Versions: 7.4 >Reporter: Karl Wright >Priority: Major > > Project ManifoldCF uses SolrJ to post documents to Solr. When upgrading from > SolrJ 7.0.x to SolrJ 7.4, we encountered significant structural changes to > SolrJ's HttpSolrClient class that seemingly disable any use of multipart > post. This is critical because ManifoldCF's documents often contain metadata > in excess of 4K that therefore cannot be stuffed into a URL. > The changes in question seem to have been performed by Paul Noble on > 10/31/2017, with the introduction of the RequestWriter mechanism. Basically, > if a request has a RequestWriter, it is used exclusively to write the > request, and that overrides the stream mechanism completely. I haven't > chased it back to a specific ticket. > ManifoldCF's usage of SolrJ involves the creation of > ContentStreamUpdateRequests for all posts meant for Solr Cell, and the > creation of UpdateRequests for posts not meant for Solr Cell (as well as for > delete and commit requests). For our release cycle that is taking place > right now, we're shipping a modified version of HttpSolrClient that ignores > the RequestWriter when dealing with ContentStreamUpdateRequests. We > apparently cannot use multipart for all requests because on the Solr side we > get "pfountz Should not get here!" errors on the Solr side when we do, which > generate HTTP error code 500 responses. That should not happen either, in my > opinion. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Issue Comment Deleted] (SOLR-12798) Structural changes in SolrJ since version 7.0.0 have effectively disabled multipart post
[
https://issues.apache.org/jira/browse/SOLR-12798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Wright updated SOLR-12798:
---
Comment: was deleted
(was: We're researching the actual issue that is blocking release. It seems
that deleting documents using a Solr Cloud installation may not be working; for
each document, we're seeing a 400 error with the following message:
{code}
Error from server at http://localhost:8983/solr/FileShare_shard1_replica_n1:
missing content stream: Error from server at
http://localhost:8983/solr/FileShare_shard1_replica_n1: missing content stream
{code}
Furthermore, after checking the Solr index, none of the documents have been
removed.
This is obviously severe and we're trying now to confirm that this happens
without our modifications to HttpSolrClient.
)
> Structural changes in SolrJ since version 7.0.0 have effectively disabled
> multipart post
>
>
> Key: SOLR-12798
> URL: https://issues.apache.org/jira/browse/SOLR-12798
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrJ
>Affects Versions: 7.4
>Reporter: Karl Wright
>Priority: Major
>
> Project ManifoldCF uses SolrJ to post documents to Solr. When upgrading from
> SolrJ 7.0.x to SolrJ 7.4, we encountered significant structural changes to
> SolrJ's HttpSolrClient class that seemingly disable any use of multipart
> post. This is critical because ManifoldCF's documents often contain metadata
> in excess of 4K that therefore cannot be stuffed into a URL.
> The changes in question seem to have been performed by Paul Noble on
> 10/31/2017, with the introduction of the RequestWriter mechanism. Basically,
> if a request has a RequestWriter, it is used exclusively to write the
> request, and that overrides the stream mechanism completely. I haven't
> chased it back to a specific ticket.
> ManifoldCF's usage of SolrJ involves the creation of
> ContentStreamUpdateRequests for all posts meant for Solr Cell, and the
> creation of UpdateRequests for posts not meant for Solr Cell (as well as for
> delete and commit requests). For our release cycle that is taking place
> right now, we're shipping a modified version of HttpSolrClient that ignores
> the RequestWriter when dealing with ContentStreamUpdateRequests. We
> apparently cannot use multipart for all requests because on the Solr side we
> get "pfountz Should not get here!" errors on the Solr side when we do, which
> generate HTTP error code 500 responses. That should not happen either, in my
> opinion.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
