[jira] [Updated] (LUCENE-4423) DocumentStoredFieldVisitor.binaryField ignores offset and length
[
https://issues.apache.org/jira/browse/LUCENE-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-4423:
-
Attachment: LUCENE-4423.patch
This patch should fix the issue, although I am not sure whether it should be
the responsability of the {{StoredFieldVisitor}} or of the
{{StoredFieldsReader}} to make sure that the byte[] is a copy (this patch
assumes it it the responsability of {{StoredFieldVisitor}}).
Moreover, do you think this issue should be a blocker for {{4.0}}?
> DocumentStoredFieldVisitor.binaryField ignores offset and length
>
>
> Key: LUCENE-4423
> URL: https://issues.apache.org/jira/browse/LUCENE-4423
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/store
>Reporter: Adrien Grand
> Attachments: LUCENE-4423.patch
>
>
> This is no problem with SimpleText and Lucene40 since in their cases, offset
> is always 0 and length the length of the byte[] array, but it might break
> with custom codecs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-4423) DocumentStoredFieldVisitor.binaryField ignores offset and length
[ https://issues.apache.org/jira/browse/LUCENE-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-4423: - Attachment: LUCENE-4423.patch Minimal patch that leaves the responsability to make the copy on the codec side. I created LUCENE-4425 to address the documentation issue. > DocumentStoredFieldVisitor.binaryField ignores offset and length > > > Key: LUCENE-4423 > URL: https://issues.apache.org/jira/browse/LUCENE-4423 > Project: Lucene - Core > Issue Type: Bug > Components: core/store >Reporter: Adrien Grand > Attachments: LUCENE-4423.patch, LUCENE-4423.patch > > > This is no problem with SimpleText and Lucene40 since in their cases, offset > is always 0 and length the length of the byte[] array, but it might break > with custom codecs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
