[jira] [Updated] (LUCENE-4585) Spatial RecursivePrefixTreeFilter has some bugs with indexing non-point shapes

2012-12-06 Thread David Smiley (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Smiley updated LUCENE-4585:
-

Fix Version/s: 5.0
   4.1

 Spatial RecursivePrefixTreeFilter has some bugs with indexing non-point shapes
 --

 Key: LUCENE-4585
 URL: https://issues.apache.org/jira/browse/LUCENE-4585
 Project: Lucene - Core
  Issue Type: Bug
  Components: modules/spatial
Affects Versions: 4.0
Reporter: David Smiley
Assignee: David Smiley
 Fix For: 4.1, 5.0

 Attachments: LUCENE-4585_PrefixTree_bugs.patch, 
 LUCENE-4585_PrefixTree_bugs.patch


 RecursivePrefixTreeFilter has some bugs that can occur when searching indexed 
 shapes.  One bug is an unpositioned termsEnum.  It through an exception in 
 testing; I'm not sure what its effects would be in production.  The other 
 couple bugs are hard to describe here but were rare to occur in extensive 
 testing. The effects were probably a slim chance of matching an indexed shape 
 near the query shape. And SpatialPrefixTree does not support an indexed shape 
 that covers the entire globe.
 These bugs were discovered during development of tests for RPTF LUCENE-4419 
 which I will submit shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (LUCENE-4585) Spatial RecursivePrefixTreeFilter has some bugs with indexing non-point shapes

2012-12-04 Thread David Smiley (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Smiley updated LUCENE-4585:
-

Attachment: LUCENE-4585_PrefixTree_bugs.patch

The attached patch resolves the aforementioned problems.

However note that when a point is indexed, the final full-length token is not 
indexed with a trailing leaf '+' byte variant; it was before.  The up-side is 
that we save one token per indexed point (~1/12th savings if 11 maxLevels).  
The semantics of that '+' are intended to be that the entire grid cell 
represents an indexed shape for matching, so compare the rectangle for it with 
the query shape.  But for points, it should be the center point of the cell, so 
no '+'.

If a user doesn't re-index, then an indexed point is 1/2 the smallest grid cell 
closer to a query shape and as such might match when it didn't before.  Quite 
minor I think but worth mentioning.

 Spatial RecursivePrefixTreeFilter has some bugs with indexing non-point shapes
 --

 Key: LUCENE-4585
 URL: https://issues.apache.org/jira/browse/LUCENE-4585
 Project: Lucene - Core
  Issue Type: Bug
  Components: modules/spatial
Affects Versions: 4.0
Reporter: David Smiley
 Attachments: LUCENE-4585_PrefixTree_bugs.patch


 RecursivePrefixTreeFilter has some bugs that can occur when searching indexed 
 shapes.  One bug is an unpositioned termsEnum.  It through an exception in 
 testing; I'm not sure what its effects would be in production.  The other 
 couple bugs are hard to describe here but were rare to occur in extensive 
 testing. The effects were probably a slim chance of matching an indexed shape 
 near the query shape. And SpatialPrefixTree does not support an indexed shape 
 that covers the entire globe.
 These bugs were discovered during development of tests for RPTF LUCENE-4419 
 which I will submit shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (LUCENE-4585) Spatial RecursivePrefixTreeFilter has some bugs with indexing non-point shapes

2012-12-04 Thread David Smiley (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Smiley updated LUCENE-4585:
-

Attachment: LUCENE-4585_PrefixTree_bugs.patch

Updated patch with the correct set of files.

 Spatial RecursivePrefixTreeFilter has some bugs with indexing non-point shapes
 --

 Key: LUCENE-4585
 URL: https://issues.apache.org/jira/browse/LUCENE-4585
 Project: Lucene - Core
  Issue Type: Bug
  Components: modules/spatial
Affects Versions: 4.0
Reporter: David Smiley
 Attachments: LUCENE-4585_PrefixTree_bugs.patch, 
 LUCENE-4585_PrefixTree_bugs.patch


 RecursivePrefixTreeFilter has some bugs that can occur when searching indexed 
 shapes.  One bug is an unpositioned termsEnum.  It through an exception in 
 testing; I'm not sure what its effects would be in production.  The other 
 couple bugs are hard to describe here but were rare to occur in extensive 
 testing. The effects were probably a slim chance of matching an indexed shape 
 near the query shape. And SpatialPrefixTree does not support an indexed shape 
 that covers the entire globe.
 These bugs were discovered during development of tests for RPTF LUCENE-4419 
 which I will submit shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org