[jira] [Updated] (LUCENE-4586) Change default ResultMode of FacetRequest to PER_NODE_IN_TREE

2012-12-04 Thread Shai Erera (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shai Erera updated LUCENE-4586:
---

Attachment: LUCENE-4586.patch

Same patch, but moved the CHANGES entry under a "Changes in Runtime Behavior" 
section

> Change default ResultMode of FacetRequest to PER_NODE_IN_TREE
> -
>
> Key: LUCENE-4586
> URL: https://issues.apache.org/jira/browse/LUCENE-4586
> Project: Lucene - Core
>  Issue Type: Improvement
>  Components: modules/facet
>Reporter: Shai Erera
>Assignee: Shai Erera
>Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: LUCENE-4586.patch, LUCENE-4586.patch
>
>
> Today the default ResultMode is GLOBAL_FLAT, but it should be 
> PER_NODE_IN_TREE. ResultMode is being used whenever you set the depth of 
> FacetRequest to greater than 1. The difference between the two is:
> * PER_NODE_IN_TREE would then compute the top-K categories recursively, for 
> every top category at every level (up to depth). The results are returned in 
> a tree structure as well. For instance:
> {noformat}
> Date
>   2010
> March
> February
>   2011
> April
> May
> {noformat}
> * GLOBAL_FLAT computes the top categories among all the nodes up to depth, 
> and returns a flat list of categories.
> GLOBAL_FLAT is faster to compute than PER_NODE_IN_TREE (it just computes 
> top-K among N total categories), however I think that it's less intuitive, 
> and therefore should not be used as a default. In fact, I think this is kind 
> of an expert usage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (LUCENE-4586) Change default ResultMode of FacetRequest to PER_NODE_IN_TREE

2012-12-04 Thread Shai Erera (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shai Erera updated LUCENE-4586:
---

Attachment: LUCENE-4586.patch

Patch changes the default ResultMode to PER_NODE_IN_TREE. That uncovered a 
potential bug in TopKInEachNodeHandler where it didn't resolve ties on facet 
values by ordinal -- this lead to inconsistent ordering of facet results 
(discovered by SamplingWrapperTest).

I had to fix some tests that relied on GLOBAL_FLAT mode for results 
verification (it's easier to verify results in that mode).

Added a CHANGES entry under back-compat changes.

All tests pass (tried many iterations).

> Change default ResultMode of FacetRequest to PER_NODE_IN_TREE
> -
>
> Key: LUCENE-4586
> URL: https://issues.apache.org/jira/browse/LUCENE-4586
> Project: Lucene - Core
>  Issue Type: Improvement
>  Components: modules/facet
>Reporter: Shai Erera
>Assignee: Shai Erera
>Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: LUCENE-4586.patch
>
>
> Today the default ResultMode is GLOBAL_FLAT, but it should be 
> PER_NODE_IN_TREE. ResultMode is being used whenever you set the depth of 
> FacetRequest to greater than 1. The difference between the two is:
> * PER_NODE_IN_TREE would then compute the top-K categories recursively, for 
> every top category at every level (up to depth). The results are returned in 
> a tree structure as well. For instance:
> {noformat}
> Date
>   2010
> March
> February
>   2011
> April
> May
> {noformat}
> * GLOBAL_FLAT computes the top categories among all the nodes up to depth, 
> and returns a flat list of categories.
> GLOBAL_FLAT is faster to compute than PER_NODE_IN_TREE (it just computes 
> top-K among N total categories), however I think that it's less intuitive, 
> and therefore should not be used as a default. In fact, I think this is kind 
> of an expert usage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org