[jira] [Updated] (LUCENE-5628) SpecialOperations.getFiniteStrings should not recurse
[ https://issues.apache.org/jira/browse/LUCENE-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-5628: --- Fix Version/s: 4.8.1 SpecialOperations.getFiniteStrings should not recurse - Key: LUCENE-5628 URL: https://issues.apache.org/jira/browse/LUCENE-5628 Project: Lucene - Core Issue Type: Bug Reporter: Michael McCandless Assignee: Michael McCandless Fix For: 4.8.1, 4.9, 5.0 Attachments: LUCENE-5628.patch, LUCENE-5628.patch, LUCENE-5628.patch, LUCENE-5628.patch Today it consumes one Java stack frame per transition, which when used by AnalyzingSuggester is per character in each token. This can lead to stack overflows if you have a long suggestion. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-5628) SpecialOperations.getFiniteStrings should not recurse
[ https://issues.apache.org/jira/browse/LUCENE-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-5628: --- Attachment: LUCENE-5628.patch New patch, just adding some comments and removing the nocommit. I think it's ready ... I plan to commit soon. SpecialOperations.getFiniteStrings should not recurse - Key: LUCENE-5628 URL: https://issues.apache.org/jira/browse/LUCENE-5628 Project: Lucene - Core Issue Type: Bug Reporter: Michael McCandless Assignee: Michael McCandless Fix For: 4.9, 5.0 Attachments: LUCENE-5628.patch, LUCENE-5628.patch, LUCENE-5628.patch, LUCENE-5628.patch Today it consumes one Java stack frame per transition, which when used by AnalyzingSuggester is per character in each token. This can lead to stack overflows if you have a long suggestion. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-5628) SpecialOperations.getFiniteStrings should not recurse
[ https://issues.apache.org/jira/browse/LUCENE-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-5628: --- Attachment: LUCENE-5628.patch New patch. SpecialOperations.getFiniteStrings should not recurse - Key: LUCENE-5628 URL: https://issues.apache.org/jira/browse/LUCENE-5628 Project: Lucene - Core Issue Type: Bug Reporter: Michael McCandless Assignee: Michael McCandless Fix For: 4.9, 5.0 Attachments: LUCENE-5628.patch, LUCENE-5628.patch Today it consumes one Java stack frame per transition, which when used by AnalyzingSuggester is per character in each token. This can lead to stack overflows if you have a long suggestion. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-5628) SpecialOperations.getFiniteStrings should not recurse
[ https://issues.apache.org/jira/browse/LUCENE-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-5628: --- Attachment: LUCENE-5628.patch New patch, with some simplification: I moved all the hairy logic about next label/transition into the PathNode. I think this helps. I put a nocommit to use Stack instead of PathNode[] ... this would be simpler (push/pop instead of .get/.remove) ... the only backside is it would mean new Java object on each push vs now where it re-uses. SpecialOperations.getFiniteStrings should not recurse - Key: LUCENE-5628 URL: https://issues.apache.org/jira/browse/LUCENE-5628 Project: Lucene - Core Issue Type: Bug Reporter: Michael McCandless Assignee: Michael McCandless Fix For: 4.9, 5.0 Attachments: LUCENE-5628.patch, LUCENE-5628.patch, LUCENE-5628.patch Today it consumes one Java stack frame per transition, which when used by AnalyzingSuggester is per character in each token. This can lead to stack overflows if you have a long suggestion. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-5628) SpecialOperations.getFiniteStrings should not recurse
[ https://issues.apache.org/jira/browse/LUCENE-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-5628: --- Attachment: LUCENE-5628.patch Patch. The method is more hairy than before ... but I think it's working. I added some more tests for getFiniteStrings. SpecialOperations.getFiniteStrings should not recurse - Key: LUCENE-5628 URL: https://issues.apache.org/jira/browse/LUCENE-5628 Project: Lucene - Core Issue Type: Bug Reporter: Michael McCandless Assignee: Michael McCandless Fix For: 4.9, 5.0 Attachments: LUCENE-5628.patch Today it consumes one Java stack frame per transition, which when used by AnalyzingSuggester is per character in each token. This can lead to stack overflows if you have a long suggestion. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
