[jira] [Updated] (LUCENE-6845) Merge Spans and SpanScorer
[ https://issues.apache.org/jira/browse/LUCENE-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-6845: -- Attachment: LUCENE-6845_norenames.patch Ah, I see what you mean now. I've changed the patch to be as least invasive as I can make it - SpanScorer is merged into Spans, rather than the other way around, and SpanWeight.getSpans() stays the same. > Merge Spans and SpanScorer > -- > > Key: LUCENE-6845 > URL: https://issues.apache.org/jira/browse/LUCENE-6845 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: Trunk, 5.4 > > Attachments: LUCENE-6845.patch, LUCENE-6845_norenames.patch, > LUCENE-6845_norenames.patch, LUCENE-6845_norenames.patch.txt > > > SpanScorer and Spans currently share the burden of scoring span queries, with > SpanScorer delegating to Spans for most operations. Spans is essentially a > Scorer, just with the ability to iterate through positions as well, and no > SimScorer to use for scoring. This seems overly complicated. We should > merge the two classes into one. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6845) Merge Spans and SpanScorer
[ https://issues.apache.org/jira/browse/LUCENE-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-6845: -- Attachment: LUCENE-6845_norenames.patch.txt Updated patch, with ScoringWrapperSpans. I also renamed SpanWeight.getSpanScorer() to SpanWeight.spanScorer(), by analogy with scorer() and bulkScorer(). All tests and precommit pass. > Merge Spans and SpanScorer > -- > > Key: LUCENE-6845 > URL: https://issues.apache.org/jira/browse/LUCENE-6845 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: Trunk, 5.4 > > Attachments: LUCENE-6845.patch, LUCENE-6845_norenames.patch, > LUCENE-6845_norenames.patch.txt > > > SpanScorer and Spans currently share the burden of scoring span queries, with > SpanScorer delegating to Spans for most operations. Spans is essentially a > Scorer, just with the ability to iterate through positions as well, and no > SimScorer to use for scoring. This seems overly complicated. We should > merge the two classes into one. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6845) Merge Spans and SpanScorer
[ https://issues.apache.org/jira/browse/LUCENE-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-6845: -- Attachment: LUCENE-6845_norenames.patch Patch without the renames, which should make changes easier to see. I don't think there's anything in here that needs to wait for 6.0? People creating their own Spans implementations are highly-expert users, and shouldn't have a problem with changing things to extend SpanScorer instead. > Merge Spans and SpanScorer > -- > > Key: LUCENE-6845 > URL: https://issues.apache.org/jira/browse/LUCENE-6845 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: Trunk, 5.4 > > Attachments: LUCENE-6845.patch, LUCENE-6845_norenames.patch > > > SpanScorer and Spans currently share the burden of scoring span queries, with > SpanScorer delegating to Spans for most operations. Spans is essentially a > Scorer, just with the ability to iterate through positions as well, and no > SimScorer to use for scoring. This seems overly complicated. We should > merge the two classes into one. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6845) Merge Spans and SpanScorer
[ https://issues.apache.org/jira/browse/LUCENE-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-6845: -- Attachment: LUCENE-6845.patch Patch. Spans is merged entirely into SpanScorer, various classes get renamed, and SpanWeight.getSpans() becomes SpanWeight.getSpanScorer(). The only slightly messy part concerns how to pass SimScorers around, as SpanScorer now takes one in its constructor. Span tests pass, but I still need to run the whole test suite, so health warnings apply. > Merge Spans and SpanScorer > -- > > Key: LUCENE-6845 > URL: https://issues.apache.org/jira/browse/LUCENE-6845 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: Trunk, 5.4 > > Attachments: LUCENE-6845.patch > > > SpanScorer and Spans currently share the burden of scoring span queries, with > SpanScorer delegating to Spans for most operations. Spans is essentially a > Scorer, just with the ability to iterate through positions as well, and no > SimScorer to use for scoring. This seems overly complicated. We should > merge the two classes into one. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
